Reviewed-by: Eric Dong
-Original Message-
From: Ni, Ray
Sent: Wednesday, May 12, 2021 12:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek ; Kumar,
Rahul1
Subject: [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation
5-level paging can be enabled on CPU
Agree this fix. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Walon Li
> 发送时间: 2021年5月13日 10:49
> 收件人: devel@edk2.groups.io
> 抄送: walon...@hpe.com; nickle.w...@hpe.com; dandan...@intel.com;
> gaolim...@byosoft.com.cn
> 主题: [PATCH] MdeModulePkg/PlatformDriOverrideDxe: Fix overflow
> condition
Code mistake, VariableIndex is smaller normally than buffer+buffersize
so should not break loop.
Signed-off-by:Walon Li
---
.../Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The Flush parameter is used to provide a hint whether the specified range
is Mmio address. Now that we have a dedicated helper to clear the
memory encryption mask for the Mmio address range, its safe to remove the
Flush parameter from
From: Tom Lendacky
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275
Version 2 of GHCB introduces NAE for creating AP when SEV-SNP is enabled
in the guest VM. See the GHCB specification, Table 5 "List of Supported
Non-Automatic Events" and sections 4.1.9 and 4.3.2, for further details.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The PVALIDATE instruction validates or rescinds validation of a guest
page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS
bits OF, ZF, AF, PF and SF are set based on this return code. If the
instruction completed
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The Page State Change NAE exit will be used by the SEV-SNP guest to
request a page state change using the GHCB protocol. See the GHCB
spec section 4.1.6 and 2.3.1 for more detail on the structure
definitions.
Cc: James Bottomley
Cc: Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask
for the Mmio address range.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Cc: Erdem
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The MemEncryptSevClearMmioPageEncMask() helper can be used for clearing
the memory encryption mask for the Mmio region.
The MemEncryptSevClearMmioPageEncMask() is a simplified version of
MemEncryptSevClearPageEncMask() -- it does not flush
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Version 2 of GHCB introduces advertisement of features that are supported
by the hypervisor. See the GHCB spec section 2.2 for an additional details.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask
for the Mmio address range.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Cc: Erdem
From: Tom Lendacky
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
The RMPADJUST instruction will be used by the SEV-SNP guest to modify the
RMP permissions for a guest page. See AMD APM volume 3 for further
details.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Use the MemEncryptSevClearMmioPageEncMask() to clear memory encryption mask
for the Mmio and NonExistent address range.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo
This series is taken from the SNP RFC. This series defines the GHCBv2
macros and NAE events. Additionally, it also introduces a helper to
clear the page encryption mask from the Mmio region.
The series is based on the commit:
5531fd48ded1 BaseTools: Add support for version 3 of FMP Image Header
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Version 2 of the GHCB spec introduces several new SNP-specific NAEs.
Unfortunately, the names for those NAEs break the alignment. Add some
white spaces so that the SNP support patches do not break the alignment.
Cc: James Bottomley
Cc: Min
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
An SEV-SNP guest is required to perform the GHCB GPA registration. See
the GHCB specification for further details.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Define the SEV-SNP MSR bits.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Laszlo Ersek
Cc: Erdem Aktas
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Reviewed-by:
On 5/11/21 12:45 PM, Brijesh Singh wrote:
> On 5/11/21 6:55 AM, Laszlo Ersek wrote:
>> I don't fully understand the updates in this patch:
>>
>> On 05/07/21 22:38, Brijesh Singh wrote:
>>> BZ:
>>>
The changes are upstreamed by commit-id :
https://github.com/tianocore/edk2-test/commit/2821093d6f2b3521c453834f0657cf07c0908155
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75075): https://edk2.groups.io/g/devel/message/75075
Mute
Hi Grant,
There is already a repo like this in tianocore:
https://github.com/tianocore/edk2-edkrepo-manifest
It is focused on manifests used by the edkrepo tool:
https://github.com/tianocore/edk2-edkrepo
Nate and Ashley are the maintainers. They can help you with using
On Wed, 12 May 2021 at 00:37, Jeremy Linton wrote:
>
> The genet is capable of addressing the entire memory space
> on the RPI4. Lets allow it to dma into those regions.
> This solves intermittent issues with grub/etc being able
> to communicate when the 3G limit is lifted on 8G boards.
>
>
Would it be possible to get a new repo under the github.com/tianocore
project? I've got a repo manifest that I've been using for building the
SCT, and is now being used by quite a few people. However it is
currently hosted under my personal area here:
On Wed, 12 May 2021 at 13:19, Pete Batard wrote:
>
> Two minor notes below:
>
> On 2021.05.11 23:41, Jeremy Linton wrote:
> > The newer BCM2711 SoC's don't have a DMA constraint on the emmc2
> > controller. So we don't need to do the 1G translation. Lets
> > allow the AML to detect the SoC
Two minor notes below:
On 2021.05.11 23:41, Jeremy Linton wrote:
The newer BCM2711 SoC's don't have a DMA constraint on the emmc2
controller. So we don't need to do the 1G translation. Lets
allow the AML to detect the SoC revision and return a different
_DMA resource.
Signed-off-by: Jeremy
On 2021.05.11 23:41, Jeremy Linton wrote:
Now that we are doing SoC detection and adjusting the DMA
window it should be safe to turn DMA on by default.
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 4 ++--
Platform/RaspberryPi/RPi4/RPi4.dsc
For anyone having this issue,the below patch detects the error in PciHostBridge
aperture, from 9elements github repository:
https://github.com/9elements/edk2-1/commit/6be829a631e3e0e7f6043c88cfef33f9a0588298
also available in system76 repo: https://github.com/system76/edk2.git
commit
Hi Etienn,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/05/2021 08:53 AM, Etienne Carriere wrote:
Use (UINTN) cast to cast physical or virtual address values to the
pointer size before casting from/to a pointer value.
Cc:
Hi Etienn,
Thank you for this patch.
Please find my feedback inline marked [SAMI] .
With those fixed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/05/2021 08:53 AM, Etienne Carriere wrote:
Build PlatformStandaloneMmRpmb for ARM architecture (32bit arm machine).
The generated
Hi Etienne,
I have some minor suggestion marked inline as [SAMI].
With that addressed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/05/2021 08:53 AM, Etienne Carriere wrote:
Add SMCCC function IDs for RPMB read/write service on 32bit architectures.
Define generic
Hi Etienne,
Thank you for this patch.
I would have prefered this patch split in 3 parts (for SgiPkg, Socionext
and Platform/StandaloneMm). In either case the changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/05/2021 08:53 AM, Etienne Carriere wrote:
Hello Sami,
Thanks for the comments.
I'll address them in v2 if this series.
Regards,
Etienne
On Tue, 11 May 2021 at 21:18, Sami Mujawar wrote:
>
> Hi Etienne,
>
> Thank you for this patch.
>
> I am getting build errors in VariableMmDependency.inf when building for
> ARM. Not sure if you are
Looks good to me. I'm just curious if we would run into a similar problem with
using Print() in MdePkg\Library\UefiLib\UefiLibPrint.c or ShellPrintEx() in
ShellPkg\Library\UefiShellLib\UefiShellLib.c. If not, we may need to improve
SctPrint().
Reviewed-by: Sunny Wang
-Original
Looks good to me. I'm just curious if we would run into a similar problem with
using Print() in MdePkg\Library\UefiLib\UefiLibPrint.c or ShellPrintEx() in
ShellPkg\Library\UefiShellLib\UefiShellLib.c. If not, we may need to improve
SctPrint().
Reviewed-by: Sunny Wang
-Original
Thanks for checking my comment, Heinrich.
I was thinking that this may be a mistake made in the very beginning because
there may be no possibility to have a negative value in the members (like
MaxMode) in SIMPLE_TEXT_OUTPUT_MODE structure. However, you made a good point
about the compatibility
On Sun, May 9, 2021 at 10:40 PM, Samer El-Haj-Mahmoud wrote:
>
> Reviewed-by: Samer El-Haj-Mahmoud
Upstreamed by commit-id :
https://github.com/tianocore/edk2-test/commit/3c9b20bee2d8610b9a88acb5ae7f9255b0140a67
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
Hi Sunny,
Do you have any further comments on this change?
If not, can we upstream the change?
With Warm Regards,
Edhay
> -Original Message-
> From: Heinrich Schuchardt
> Sent: 10 May 2021 16:00
> To: Sunny Wang ; devel@edk2.groups.io
> Cc: Eric Jin ; G Edhaya Chandran
> ; Barton
36 matches
Mail list logo
