[edk2-devel] [edk2-platforms][PATCH v2 6/6] Platform/StandaloneMm: build StandaloneMmRpmb for 32bit architectures

2021-05-16 Thread Etienne Carriere
Build PlatformStandaloneMmRpmb for ARM architecture (32bit arm machine). The generated image targets an execution environment similar to AArch64 StMM secure partition in OP-TEE but in 32bit mode. GCC flag -fno-stack-protector added. The stack protection code bring GOT dependencies we prefer avoid

[edk2-devel] [edk2-platforms][PATCH v2 5/6] Drivers/OpTee: address cast build warning issue in 32b mode

2021-05-16 Thread Etienne Carriere
Use (UINTN) cast to cast physical or virtual address values to the pointer size before casting from/to a pointer value. Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Signed-off-by: Etienne Carriere --- No change since v1 ---

[edk2-devel] [edk2-platforms][PATCH v2 4/6] Drivers/OpTee: Add Aarch32 SVC IDs for 32bit Arm targets

2021-05-16 Thread Etienne Carriere
Add SMCCC function IDs for RPMB read/write service on 32bit architectures. Define generic SP_SVC_RPMB_READ/SP_SVC_RPMB_WRITE IDs for native target architecture (32b or 64b). Changes OpTeeRpmbFvb.c to use architecture agnostic macro ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ for 32b and 64b support. Cc:

[edk2-devel] [edk2-platforms][PATCH v2 3/6] Platform/StandaloneMm: sync with edk2 StandaloneMmCpu path change

2021-05-16 Thread Etienne Carriere
Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [edk2-platforms][PATCH v2 2/6] Platform/Socionext/DeveloperBox: sync with edk2 StandaloneMmCpu path change

2021-05-16 Thread Etienne Carriere
Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [edk2-platforms][PATCH v2 1/6] Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change

2021-05-16 Thread Etienne Carriere
Synchronize with edk2 package where StandaloneMmCpu component has moved from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf Cc: Ard Biesheuvel Cc: Ilias Apalodimas Cc: Leif Lindholm Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH v2 5/5] StandaloneMmPkg: build for 32bit arm machines

2021-05-16 Thread Etienne Carriere
This change allows to build StandaloneMmPkg components for 32bit Arm StandaloneMm firmware. This change mainly moves AArch64/ source files to Arm/ side directory for several components: StandaloneMmCpu, StandaloneMmCoreEntryPoint and StandaloneMmMemLib. The source file is built for both 32b and

[edk2-devel] [PATCH v2 4/5] StandaloneMmPkg: fix pointer/int casts against 32bit architectures

2021-05-16 Thread Etienne Carriere
Use intermediate (UINTN) cast when casting int from/to pointer. This is needed as UINT64 values cast from/to 32bit pointer for 32bit architectures. Cc: Achin Gupta Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Leif Lindholm Cc: Sami Mujawar Cc: Sughosh Ganu Signed-off-by: Etienne Carriere --- No

[edk2-devel] [PATCH v2 3/5] GenFv: Arm: support images entered in Thumb mode

2021-05-16 Thread Etienne Carriere
Change GenFv for Arm architecture to generate a specific jump instruction as image entry instruction, when the target entry label is assembled with Thumb instruction set. This is possible since SecCoreEntryAddress value fetched from the PE32 has its LSBit set when the entry instruction executes in

[edk2-devel] [PATCH v2 1/5] ArmPkg/IndustryStandard: 32b/64b agnostic FF-A, Mm SVC and Std SMC IDs

2021-05-16 Thread Etienne Carriere
Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit function IDs as per SMCCC specification. Defines also generic ARM SVC identifier macros to wrap 32bit or 64bit identifiers upon target built architecture. Cc: Achin Gupta Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sughosh Ganu

[edk2-devel] [PATCH v2 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

2021-05-16 Thread Etienne Carriere
Changes in ArmPkg to prepare building StandaloneMm firmware for 32bit Arm architectures. Adds MmCommunicationDxe driver and ArmMmuPeiLib and ArmmmuStandaloneMmLib libraries to the list of the standard components build for ArmPkg on when ARM architectures. Changes path of source file

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-16 Thread Laszlo Ersek
On 05/14/21 22:28, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3324 > > The SEV-ES stacks currently share a page with the reset code and data. > Separate the SEV-ES stacks from the reset vector code and data to avoid > possible stack overflows from overwriting the

[edk2-devel] [PATCH v3] IntelFsp2Pkg: YAML script bug fix

2021-05-16 Thread Tung Lun
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3395 This patch fixes the issue observed during BSF file to YAML file conversion. It also addresses the issue during multibyte array data conversion check, for example the data representation of 0x instead of 0xFF, 0xFF would be thrown

Re: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: Add DTCPP_FLAGS for GCC5 RISCV64 toolchain

2021-05-16 Thread Bob Feng
Create a PR for this patch. https://github.com/tianocore/edk2/pull/1649 Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Sunday, May 16, 2021 4:06 PM To: 'Chang, Abner (HPS SW/FW Technologist)' ; 'Schaefer, Daniel' ; devel@edk2.groups.io Cc: Feng,

[edk2-devel] [PATCH v2] IntelFsp2Pkg: YAML script bug fix

2021-05-16 Thread Tung Lun
This patch fixes the issue observed during BSF file to YAML file conversion. It also addresses the issue during multibyte array data conversion check, for example the data representation of 0x instead of 0xFF, 0xFF would be thrown exception "Array size is not proper" without this patch. Cc:

Re: [edk2-devel] [PATCH v2 13/13] OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter

2021-05-16 Thread Laszlo Ersek
On 05/13/21 01:46, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The Flush parameter is used to provide a hint whether the specified range > is Mmio address. Now that we have a dedicated helper to clear the > memory encryption mask for the Mmio address range,

Re: [edk2-devel] [PATCH v2 09/13] OvmfPkg/BaseMemEncryptSevLib: introduce MemEncryptSevClearMmioPageEncMask()

2021-05-16 Thread Laszlo Ersek
On 05/13/21 01:46, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MemEncryptSevClearMmioPageEncMask() helper can be used for clearing > the memory encryption mask for the Mmio region. > > The MemEncryptSevClearMmioPageEncMask() is a simplified version of >

Re: [edk2-devel] [PATCH v2 08/13] MdePkg/BaseLib: add support for RMPADJUST instruction

2021-05-16 Thread Laszlo Ersek
On 05/13/21 01:46, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The RMPADJUST instruction will be used by the SEV-SNP guest to modify the > RMP permissions for a guest page. See AMD APM volume 3 for further > details. > > Cc: James

Re: [edk2-devel] [PATCH 1/1] BaseTools/Brotli: Fix compressed data loss issue

2021-05-16 Thread Bob Feng
Created a PR for this patch. https://github.com/tianocore/edk2/pull/1648 Thanks, Bob From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Friday, May 14, 2021 3:58 PM To: Chen, Christine ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Brotli: Fix compressed data loss

Re: [edk2-devel] [PATCH v2 07/13] MdePkg/BaseLib: add support for PVALIDATE instruction

2021-05-16 Thread Laszlo Ersek
On 05/13/21 01:46, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The PVALIDATE instruction validates or rescinds validation of a guest > page RMP entry. Upon completion, a return code is stored in EAX, rFLAGS > bits OF, ZF, AF, PF and SF are set based on this

Re: [edk2-devel] [PATCH v2 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

2021-05-16 Thread Laszlo Ersek
Patches v2 01-05 look good to me, thanks for the updates. Now on to this one: On 05/13/21 01:46, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 (1) The "3D" seems like a typo in the bug ticket URL. (This crept into v2 somehow; v1 didn't

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Fix various typos

2021-05-16 Thread Wu, Hao A
Pushed via: PR: https://github.com/tianocore/edk2/pull/1647 Commit: https://github.com/tianocore/edk2/commit/e0cb5e1814a67bb12dd476a72d1698350633bcbb Best Regards, Hao Wu > -Original Message- > From: Wu, Hao A > Sent: Thursday, May 6, 2021 7:46 AM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/PciBusDxe: Fix possible uninitialized use

2021-05-16 Thread Ni, Ray
How about below fix? I think it might be simpler to understand and doesn't introduce unnecessary logic to handle impossible case: if (ResizableBarOp == PciResizableBarMax) { Bit = HighBitSet64(Capabilities); } else { ASSERT (ResizableBarOp == PciResizableBarMin); Bit =

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-16 Thread Marvin Häuser
Am 16.05.2021 um 03:17 schrieb Laszlo Ersek: On 05/14/21 17:44, Marvin Häuser wrote: On 14.05.21 17:23, Lendacky, Thomas wrote: On 5/14/21 10:04 AM, Marvin Häuser wrote: +  // Check to be sure that the "allocate below" behavior hasn't changed. +  // This will also catch a failed

[edk2-devel] [edk2-platforms][PATCH V2 08/11] Platform/Sgi: Add SMBIOS Type16 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 16 table (Physical Memory Array) describes a collection of memory devices that operate together to form a memory address. It includes information about number of devices, total memory installed, error correction mechanism used and other related information. Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH V2 10/11] Platform/Sgi: Add SMBIOS Type19 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 19 table (Memory Array Mapped Addr) that includes information about the address mapping for a Physical Memory Array. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 +

[edk2-devel] [edk2-platforms][PATCH V2 11/11] Platform/Sgi: Add SMBIOS Type32 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 32 table (System Boot Information) that includes information about the System Boot Status. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 + Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h

[edk2-devel] [edk2-platforms][PATCH V2 09/11] Platform/Sgi: Add SMBIOS Type17 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 17 table (Memory Device) that includes the specification of each installed memory device such as size of each device, bank locator, memory device type, and other related information. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V2 00/11] Add SMBIOS tables for Arm's Reference Design platforms

2021-05-16 Thread Pranav Madhu
SMBIOS provides basic hardware and firmware configuration information through table-driven data structure. This patch series adds SMBIOS support for Arm's SGI/RD platforms. The first patch in this series defines platform-id values for the RD-N2 platform library header. The second patch add

[edk2-devel] [edk2-platforms][PATCH V2 02/11] Platform/Sgi: Add GetProductId API for SGI/RD Platforms

2021-05-16 Thread Pranav Madhu
Add GetProductId API for SGI/RD Platform. The API returns a product id in integer format based on the platform description data. The product id is required for other drivers such as SMBIOS. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 21 +

[edk2-devel] [edk2-platforms][PATCH V2 05/11] Platform/Sgi: Add SMBIOS Type3 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 3 table (System Enclosure) that includes information about manufacturer, type, serial number and other information related to system enclosure. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 +

[edk2-devel] [edk2-platforms][PATCH V2 04/11] Platform/Sgi: Add SMBIOS Type1 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 1 table (System Information) that includes information about manufacturer, product name, version, serial number and other information related to the system identification. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf

[edk2-devel] [edk2-platforms][PATCH V2 01/11] Platform/Sgi: Define RD-N2 platform id values

2021-05-16 Thread Pranav Madhu
Add RD-N2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[edk2-devel] [edk2-platforms][PATCH V2 07/11] Platform/Sgi: Add SMBIOS Type7 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 7 table (Cache Information) that includes information about cache levels implemented, cache configuration, ways of associativity and other information related to cache memory installed. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V2 06/11] Platform/Sgi: Add SMBIOS Type4 Table

2021-05-16 Thread Pranav Madhu
Add the SMBIOS type 4 table (Processor Information) that includes information about manufacture, family, processor id, maximum operating frequency, and other information related to the processor. Signed-off-by: Pranav Madhu --- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc

[edk2-devel] [edk2-platforms][PATCH V2 03/11] Platform/Sgi: Add Initial SMBIOS support

2021-05-16 Thread Pranav Madhu
SMBIOS provides basic hardware and firmware configuration information through table-driven data structure. This patch adds SMBIOS driver support that allows for installation of multiple SMBIOS types. Also add SMBIOS Type0 (BIOS Information) table, that include information about BIOS vendor name,

[edk2-devel] Updated Event: TianoCore Bug Triage - APAC / NAMO #cal-invite

2021-05-16 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

[edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail

2021-05-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Garrett Kirkendall > 发送时间: 2021年5月14日 23:02 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen ; Garrett > Kirkendall > 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail > > When build.by POSTBUILD

[edk2-devel] 回复: [PATCH v1 1/1] BaseTools: Add DTCPP_FLAGS for GCC5 RISCV64 toolchain

2021-05-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Chang, Abner (HPS SW/FW Technologist) > 发送时间: 2021年5月14日 14:55 > 收件人: Schaefer, Daniel ; devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen > 主题: RE: [PATCH v1 1/1] BaseTools: Add DTCPP_FLAGS for GCC5 RISCV64 > toolchain > >