Re: [edk2-devel] [PATCH v3] IntelFsp2Pkg: YAML script bug fix

Pushed: 1fbf5e30ae8eb725f4e10984f7b0a208f78abbd0 Thanks, Chasel > -Original Message- > From: Loo, Tung Lun > Sent: Monday, May 17, 2021 12:04 PM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Subject: [PATCH v3

Re: 回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

On 5/18/21 9:04 AM, gaoliming wrote: > Daniel: > Seemly, this API is missing in BaseLib for RiscV64 arch. How do you detect > this issue? What do you mean it's missing? Yes MemoryFence() for RiscV64 is missing currently, that's why I'm adding it here. Maybe you mean that it's not currently use

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, 18 May 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAM

Re: [edk2-devel] [edk2-platforms PATCH] Platform/ARM: Update Readme.md

Hi Rebecca, Thank you for your patch. It functionally looks good however I noticed one small grammatical error to fix, noted below. Reviewed-by: Chris Jones Thanks, Chris > > The repo with the Visual Studio support no longer exists. > fiptool from the prebuilt_tools repo doesn't work due to

回复: [edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 05/18/2021 6:30pm-7:30pm #cal-reminder

Few new issue is submitted this week. Let’s cancel the meeting this week. 3394 EDK2 Code unassig...@tianocore.org UNCO Add APIs for CPU physical address mask calculation Fri 20

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 05/18/2021 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 18 May 2021, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTUyZTg2NjgtNDhlNS00ODVlLTllYTUtYzg1OTNjNjdiZjFh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4e

回复: [edk2-devel] [PATCH v1 1/1] Add MemoryFence implementation for RiscV64

Daniel: Seemly, this API is missing in BaseLib for RiscV64 arch. How do you detect this issue? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Daniel > Schaefer > 发送时间: 2021年5月16日 2:13 > 收件人: devel@edk2.groups.io > 抄送: Abner Chang ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu

回复: [edk2-devel] [PATCH v1 3/3] CryptoPkg/BaseCryptLib: Fix possible uninitialized use

Sergei: Yes. GCC49 is LTO disable GCC tool chain. GCC5 is LTO enable tool chain. They both work on the different GCC version, such as gcc5, gcc6.. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90844 mentions -ffat-lto-objects option that can trig the warning with LTO option. Do you try it? I

回复: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3

Rebecca: This change supports python2 & python3 both. So, I think this is a good fix. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2021年5月17日 21:29 > 收件人: devel@edk2.groups.io; Andrew Fish ; Ray Ni > > 主题: Re: [edk2-devel] [PATCH]

[edk2-devel] Google Summer of Code (GSoC) 2021 Projects Announced!

Hi Everyone, Google has announced this year's Summer of Code students. TianoCore is mentoring 7 students this year, which is more than 3 times larger than our previous high of 2 students! The list of projects is available here: https://summerofcode.withgoogle.com/organizations/6376892141142016/

Re: [edk2-devel] [PATCH v2 05/13] MdePkg/Register/Amd: define GHCB macro for the Page State Change

I verified that the values align with the GHCB spec publication: #56421 Revision: 2.00 Reviewed-by: Erdem Aktas On Wed, May 12, 2021 at 4:46 PM Brijesh Singh wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The Page State Change NAE exit will be used by the SEV-SNP guest t

Re: [edk2-devel] [PATCH v2 04/13] MdePkg/Register/Amd: define GHCB macro for Register GPA structure

I verified that the values align with the GHCB spec publication: #56421 Revision: 2.00 Just one question: is there any reason why GHCB_* defines are decimal while the SVM_EXIT_* are all in hexadecimal? Does EDK2 have any preference? Reviewed-by: Erdem Aktas -Erdem On Wed, May 12, 2021 at 4:46

Re: [edk2-devel] [PATCH v2 03/13] MdePkg/Register/Amd: define GHCB macros for hypervisor feature detection

I verified that the values align with the GHCB spec publication: #56421 Revision: 2.00 Reviewed-by: Erdem Aktas -Erdem On Wed, May 12, 2021 at 4:46 PM Brijesh Singh wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of GHCB introduces advertisement of features th

Re: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/PciBusDxe: Fix possible uninitialized use

If the function gets invalid value for the `ResizableBarOp` parameter and asserts are disabled, `Bit` can be used uninitialized. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Sergei Dmitrouk --- Notes: v2: - simplify if-statement to avoid unused branches MdeModulePkg/Bus/Pc

Re: [edk2-devel] [edk2-non-osi] [PATCH] ElkhartlakeSiliconBinPkg: Add EHL microcode

Couple of comments: 1. Please fix the file description of MicrocodeUpdates.inf and make sure it reflects the contents of the file. 2. Since this is a new file, start with year 2021. -Sai -Original Message- From: Lim, Jin Jhu Sent: Thursday, May 06, 2021 2:11 AM To: devel@edk2.groups.io

Re: [edk2-devel] [edk2-platforms][PATCH V2 11/11] Platform/Sgi: Add SMBIOS Type32 Table

Hi Pranav, Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 32 table (System Boot Information) that includes information about t

Re: [edk2-devel] [edk2-platforms][PATCH V2 08/11] Platform/Sgi: Add SMBIOS Type16 Table

Hi Pranav, Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 16 table (Physical Memory Array) describes a collection of memory de

Re: [edk2-devel] [edk2-platforms][PATCH V2 10/11] Platform/Sgi: Add SMBIOS Type19 Table

Hi Pranav, Please find my comments inline marked [SAMI]. Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 19 table (Memory Array

Re: [edk2-devel] [edk2-platforms][PATCH V2 06/11] Platform/Sgi: Add SMBIOS Type4 Table

Hi Pranav, Please find my comments inline marked [SAMI]. Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 4 table (Processor In

Re: [edk2-devel] [edk2-platforms][PATCH V2 09/11] Platform/Sgi: Add SMBIOS Type17 Table

Hi Pranav, Please find my comments inline marked [SAMI]. Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 17 table (Memory Devic

Re: [edk2-devel] [edk2-platforms][PATCH V2 03/11] Platform/Sgi: Add Initial SMBIOS support

Hi Pranav, Please find my comments inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: SMBIOS provides basic hardware and firmware configuration information through table-driven data structure. This patch a

Re: [edk2-devel] [edk2-platforms][PATCH V2 07/11] Platform/Sgi: Add SMBIOS Type7 Table

Hi Pranav, Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 7 table (Cache Information) that includes information about cache le

Re: [edk2-devel] [edk2-platforms][PATCH V2 05/11] Platform/Sgi: Add SMBIOS Type3 Table

Hi Pranav, Please find my comments inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 3 table (System Enclosure) that includes information about manufacturer, type, serial number and ot

Re: [edk2-devel] [edk2-platforms][PATCH V2 04/11] Platform/Sgi: Add SMBIOS Type1 Table

Hi Pranav, Please find my comments inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add the SMBIOS type 1 table (System Information) that includes information about manufacturer, product name, version, s

Re: [edk2-devel] [edk2-platforms][PATCH V2 02/11] Platform/Sgi: Add GetProductId API for SGI/RD Platforms

Hi Pranav, Please find my feedback inline marked [SAMI]. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add GetProductId API for SGI/RD Platform. The API returns a product id in integer format based on the platform descript

Re: [edk2-devel] [edk2-platforms][PATCH V2 01/11] Platform/Sgi: Define RD-N2 platform id values

Hi Pranav, Thank you for this patch. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: Add RD-N2 platform identification values including the part number and configuration number. This information will be used in popula

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

On 5/16/21 11:22 PM, Laszlo Ersek wrote: > On 05/14/21 22:28, Lendacky, Thomas wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3324&data=04%7C01%7Cthomas.lendacky%40amd.com%7C8142daa079b04c0b3b5508d918eb6417%7C3dd8961f

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/6] Platform/ARM/SgiPkg: sync with edk2 StandaloneMmCpu path change

On 5/17/21 11:20 AM, Etienne Carriere wrote: > Synchronize with edk2 package where StandaloneMmCpu component has > moved > from > StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > Cc: Ard Biesheuvel > Cc: Ili

Re: [edk2-devel] [PATCH v2 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

On 5/16/21 10:08 PM, Laszlo Ersek wrote: > Patches v2 01-05 look good to me, thanks for the updates. Now on to this > one: > > On 05/13/21 01:46, Brijesh Singh wrote: >> From: Tom Lendacky >> >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fsho

Re: [edk2-devel] [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer

On Fri, May 14, 2021 at 12:49 PM Laszlo Ersek wrote: > > For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar > from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg" > section. > > Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role, > remove "Ar

Re: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3

Could someone review this please? Thanks. Rebecca Cran On 5/9/21 1:26 PM, Rebecca Cran wrote: The version of lldb shipping with macOS Big Sur is lldb-1205.0.27.3, and it uses python3. Update lldbefi.py to work with it, including removing the unused 'commands' import and fixing the print stateme

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

Andrew, could you review this please? Thanks. Rebecca Cran On 5/9/21 1:18 PM, Rebecca Cran wrote: The existing instructions no longer work on macOS Big Sur and Xcode 12.5. Update them to include for example using lldb instead of gdb, installing XQuartz, and using modern names such as macOS inst

Re: [edk2-devel] [edk2-platforms][PATCH v2 6/6] Platform/StandaloneMm: build StandaloneMmRpmb for 32bit architectures

On Mon, May 17, 2021 at 07:50:47AM +0200, Etienne Carriere wrote: > Build PlatformStandaloneMmRpmb for ARM architecture (32bit arm machine). > The generated image targets an execution environment similar to AArch64 > StMM secure partition in OP-TEE but in 32bit mode. > > GCC flag -fno-stack-protec

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/6] Drivers/OpTee: address cast build warning issue in 32b mode

On Mon, May 17, 2021 at 07:50:46AM +0200, Etienne Carriere wrote: > Use (UINTN) cast to cast physical or virtual address values to the > pointer size before casting from/to a pointer value. > > Cc: Ard Biesheuvel > Cc: Ilias Apalodimas > Cc: Leif Lindholm > Cc: Sami Mujawar > Signed-off-by: Et

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/6] Drivers/OpTee: Add Aarch32 SVC IDs for 32bit Arm targets

On Mon, May 17, 2021 at 07:50:45AM +0200, Etienne Carriere wrote: > Add SMCCC function IDs for RPMB read/write service on 32bit architectures. > Define generic SP_SVC_RPMB_READ/SP_SVC_RPMB_WRITE IDs for native target > architecture (32b or 64b). > > Changes OpTeeRpmbFvb.c to use architecture agnos

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/6] Platform/StandaloneMm: sync with edk2 StandaloneMmCpu path change

On Mon, May 17, 2021 at 07:50:44AM +0200, Etienne Carriere wrote: > Synchronize with edk2 package where StandaloneMmCpu component has moved > from StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf > to StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf > > Cc: Ard Bieshe

Re: [edk2-devel] [PATCH v3 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

On Mon, 17 May 2021 at 10:49, Yao, Jiewen wrote: > > Hi Ard > Can it be resolved in patch - > https://edk2.groups.io/g/devel/message/75135?p=,,,20,0,0,0::Created,,cryptopkg,20,2,0,82822574 > ? > That looks like the same issue, yes. > I really hope to improve CI to catch this earlier... > Yes,

Re: [edk2-devel] [PATCH v3 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

Hi Ard Can it be resolved in patch - https://edk2.groups.io/g/devel/message/75135?p=,,,20,0,0,0::Created,,cryptopkg,20,2,0,82822574 ? I really hope to improve CI to catch this earlier... Hi Jian Would you please merge this ASAP? > -Original Message- > From: devel@edk2.groups.io On B

Re: [edk2-devel] [PATCH v3 1/1] CryptoPkg: BaseCryptLib: Add RSA PSS verify support

On Tue, 4 May 2021 at 19:54, Agrawal, Sachin wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3314 > > This patch uses Openssl's EVP API's to perform RSASSA-PSS verification > of a binary blob. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > > Signed-off

Re: [edk2-devel] [PATCH v2 3/5] GenFv: Arm: support images entered in Thumb mode

On Mon, 17 May 2021 at 09:48, gaoliming wrote: > > Etienne: > Thanks for your reminder. I try VS compiler and meet with the compiler > error on this line. > > Here, does if ((SecCoreEntryAddress & 1) != 0) mean the lowest bit of this > address is 1? Yes it does. > > Thanks > Liming > > --

回复: [edk2-devel] [PATCH v2 3/5] GenFv: Arm: support images entered in Thumb mode

Etienne: Thanks for your reminder. I try VS compiler and meet with the compiler error on this line. Here, does if ((SecCoreEntryAddress & 1) != 0) mean the lowest bit of this address is 1? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Etienne > Carriere > 发送时间: 2021年5月17日

[edk2-devel] [PATCH v3 4/5] StandaloneMmPkg: fix pointer/int casts against 32bit architectures

Use intermediate (UINTN) cast when casting int from/to pointer. This is needed as UINT64 values cast from/to 32bit pointer for 32bit architectures. Cc: Achin Gupta Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Leif Lindholm Cc: Sami Mujawar Cc: Sughosh Ganu Signed-off-by: Etienne Carriere --- No ch

[edk2-devel] [PATCH v3 5/5] StandaloneMmPkg: build for 32bit arm machines

This change allows to build StandaloneMmPkg components for 32bit Arm StandaloneMm firmware. This change mainly moves AArch64/ source files to Arm/ side directory for several components: StandaloneMmCpu, StandaloneMmCoreEntryPoint and StandaloneMmMemLib. The source file is built for both 32b and 6

[edk2-devel] [PATCH v3 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

Changes in ArmPkg to prepare building StandaloneMm firmware for 32bit Arm architectures. Adds MmCommunicationDxe driver and ArmMmuPeiLib and ArmmmuStandaloneMmLib libraries to the list of the standard components build for ArmPkg on when ARM architectures. Changes path of source file AArch64/ArmMm

[edk2-devel] [PATCH v3 3/5] GenFv: Arm: support images entered in Thumb mode

Change GenFv for Arm architecture to generate a specific jump instruction as image entry instruction, when the target entry label is assembled with Thumb instruction set. This is possible since SecCoreEntryAddress value fetched from the PE32 has its LSBit set when the entry instruction executes in

[edk2-devel] [PATCH v3 1/5] ArmPkg/IndustryStandard: 32b/64b agnostic FF-A, Mm SVC and Std SMC IDs

Defines ARM_SVC_ID_FFA_* and ARM_SVC_ID_SP_* identifiers for 32bit function IDs as per SMCCC specification. Defines also generic ARM SVC identifier macros to wrap 32bit or 64bit identifiers upon target built architecture. Cc: Achin Gupta Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sughosh Ganu Si

回复: [edk2-devel] [PATCH v2 06/13] MdePkg/Register/Amd: define GHCB macros for SNP AP creation

Laszlo: Thanks for your detail review. I have no comments for the changes in this patch set. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Laszlo Ersek > 发送时间: 2021年5月17日 11:09 > 收件人: devel@edk2.groups.io; brijesh.si...@amd.com > 抄送: Tom Lendacky ; Jame

Re: [edk2-devel] [PATCH v2 3/5] GenFv: Arm: support images entered in Thumb mode

On Mon, 17 May 2021 at 09:24, gaoliming wrote: > > Acked-by: Liming Gao > > > -邮件原件- > > 发件人: Etienne Carriere > > 发送时间: 2021年5月17日 13:49 > > 收件人: devel@edk2.groups.io > > 抄送: Achin Gupta ; Ard Biesheuvel > > ; Jiewen Yao ; Leif > > Lindholm ; Sami Mujawar ; > > Sughosh Ganu ; Etienne Ca

[edk2-devel] 回复: [PATCH v2 3/5] GenFv: Arm: support images entered in Thumb mode

Acked-by: Liming Gao > -邮件原件- > 发件人: Etienne Carriere > 发送时间: 2021年5月17日 13:49 > 收件人: devel@edk2.groups.io > 抄送: Achin Gupta ; Ard Biesheuvel > ; Jiewen Yao ; Leif > Lindholm ; Sami Mujawar ; > Sughosh Ganu ; Etienne Carriere > ; Bob Feng ; Liming > Gao > 主题: [PATCH v2 3/5] GenFv: Arm: