Re: [External] 回复: [edk2-devel] A plea for help

On 05/20/21 19:56, Fowler, Eric (Mondo International, LLC) via groups.io wrote: > UEFI spelunking can be a lonely art. It doesn't have to be; please consider checking out the following resources: central git repo: https://github.com/tianocore/edk2/ wiki: https://github.com/tianocore/

Re: [edk2-devel] [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

On 05/21/21 22:43, Bret Barkelew via groups.io wrote: > Reviewed-by: Bret Barkelew > bret.barke...@microsoft.com > Thanks! > I don’t regret making it ERROR at first because now no one can claim to have > not been warned when the interface drops, I agree tha

Re: 回复: [edk2-devel] [EXTERNAL] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

On 05/22/21 03:23, gaoliming wrote: > Reviewed-by: Liming Gao > > > > I am ok to merge this patch for stable tag 202105. Thanks, Liming! Laszlo > > > > Thanks > > Liming > > 发件人: devel@edk2.groups.io 代表 Bret Barkelew via > groups.io > 发送时间: 2021年5月22日 4:43 > 收件人: Laszlo Ersek ; edk2-

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

On 05/21/21 20:28, Rebecca Cran wrote: > Could someone review this please? I submitted it almost 2 weeks ago. I've been aware of it, but I've not once launched (or even seen) Xcode, so I can't verify the patch. One thing by which you could help Andrew review the patch is: pushing the patched wiki

Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

On 05/21/21 12:49, Joey Gouly wrote: >> From: Joey Gouly >> Sent: 09 March 2021 16:45 >> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 >   > Hi, > > A little ping on this. Can someone take a look? > > There was a similar patch here, that addressed the same issue > h

Re: [edk2-devel] [PATCH V2] BaseTools: Add -ffat-lto-objects option in GCC5 tool chain

On 05/21/21 07:49, gaoliming wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3403 > > Now, some uninitialized warning can't be detected on GCC5 tool chain, but > can be detected on GCC49 tool chain. Edk2 CI only covers GCC5 tool chain. > So, the merged code may impact GCC49 build. >

Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

On Sun, 23 May 2021 at 10:55, Laszlo Ersek wrote: > > On 05/21/21 12:49, Joey Gouly wrote: > >> From: Joey Gouly > >> Sent: 09 March 2021 16:45 > >> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 > > > > Hi, > > > > A little ping on this. Can someone take a look? > > >

[edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 2017 adds support for 16550-compatible Serial Port Subtype with parameters defined in Generic Address Structure (GAS) [1] Reflect that in the EDK2 headers. [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup

Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

On 05/23/21 11:03, Ard Biesheuvel wrote: > On Sun, 23 May 2021 at 10:55, Laszlo Ersek wrote: >> >> On 05/21/21 12:49, Joey Gouly wrote: From: Joey Gouly Sent: 09 March 2021 16:45 Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 >>> >>> Hi, >>> >>> A little

Re: [edk2-devel] [edk2-stable202105 PATCH] MdeModulePkg/VariableLock: downgrade compatibility warnings to DEBUG_WARN

On 05/21/21 22:40, Laszlo Ersek wrote: > Commit a18a9bde36d2 ("MdeModulePkg/Variable/RuntimeDxe: Restore Variable > Lock Protocol behavior", 2020-12-15), for bug 3111, added two such sets of > debug messages that: > > (a) are relevant for developers, > > (b) yet should not necessarily poke end-us

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

On 5/23/2021 2:51 AM, Laszlo Ersek wrote: On 05/21/21 20:28, Rebecca Cran wrote: Could someone review this please? I submitted it almost 2 weeks ago. I've been aware of it, but I've not once launched (or even seen) Xcode, so I can't verify the patch. One thing by which you could help Andrew r

[edk2-devel] [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 MdeLibs.dsc.inc was added for some basic/default library instances provided by MdePkg and RegisterFilterLibNull Library was also added into it as the first version of MdeLibs.dsc.inc. So update platform dsc to consume MdeLibs.dsc.inc for Re

Re: [edk2-devel] [tianocore.github.io.wiki PATCH 1/1] Xcode.md: Update instructions to work on modern macOS and Xcode versions

I’ll take a look . I need to grab a blank system and give it a try. > On May 23, 2021, at 9:12 AM, Rebecca Cran wrote: > > On 5/23/2021 2:51 AM, Laszlo Ersek wrote: > >>> On 05/21/21 20:28, Rebecca Cran wrote: >>> Could someone review this please? I submitted it almost 2 weeks ago. >> I've been

[edk2-devel] [PATCH v1] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace

From: IanX Kuo (a) C:\Users\\AppData\Local\Program\Python\Python38 (b) C:\Python38 (c) C:\Program Files\Python38 Issue only happens on (a) and (c). (a) happen on have whitespace. Ex: Tony Chen (c) happen on "Program Files" have whitespace. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: IanX

[edk2-devel] [PATCH v2] MinPlatformPkg/Fsp: Rebase fail when python tools path exist whitespace

From: IanX Kuo (a) C:\Users\\AppData\Local\Program\Python\Python38 (b) C:\Python38 (c) C:\Program Files\Python38 Issue only happens on (a) and (c). (a) happen on have whitespace. Ex: Tony Chen (c) happen on "Program Files" have whitespace. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: IanX

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

Looks good, Marcin. However, it looks like something wrong with the line-ending. Could you check if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could you use it? I expect this tool can catch the line-ending problem. Best

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

Hi Sunny, pon., 24 maj 2021 o 04:09 Sunny Wang napisał(a): > > Looks good, Marcin. > However, it looks like something wrong with the line-ending. Could you check > if your line-ending setting is CR/LF? Did you use > /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could

Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

Add Liming's new email. Hi Marcin, There seems no LF (0A). 1. From the patch I got below in this email, several lines got merged into one line. > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART > 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC

[edk2-devel] [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

GetWakeupTime should return full time information, including the daylight/timezone. Make use of the existing non-volatile variables for that purpose. Moreover add an error checking of possibly invalid parameters. This partially fixes FWTS and SCT Set/GetWakeupTime tests on Marvell platforms. Signe

[edk2-devel] [edk2-platforms PATCH 0/6] Marvell ACS fixes

Hi, This series addresses a couple of issues found during ACS3.0 test suit runs. The SMBIOS Type17 table extension and RTC fixes/improvements. Moreover the SPCR console subtype is switched to a different value and Cn913xDb ACPI tables are fixed, so that to achieve proper Windows 10 PE boot. More

[edk2-devel] [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's

The CN9131 variant's SSDT comprised UID's, whose values overlapped the ones used in the main DSDT file. Fix that. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Silicon/Marvell/

[edk2-devel] [edk2-platforms PATCH 1/6] Marvell/Drivers: SmbiosPlatformDxe: Align Type17 to SMBIOS v3.2

This patch adds missing entries required for SMBIOS v3.2 compliance of the Type17 table. On the occasion improve Type4 table contents. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 39 ++-- 1 file changed, 35 insertions(+), 4 de

[edk2-devel] [edk2-platforms PATCH 2/6] Marvell: Armada7k8k/OcteonTx: Fix RT debug prints

Resolution of the DebugLib for the DXE_RUNTIME_DRIVER library class was limited to non-RELEASE builds. This caused crashes during FWTS in case the RT attempted to use UART. Fix that by allowing to use DxeRuntimeDebugLibSerialPort in all kind of builds. Signed-off-by: Marcin Wojtas --- Silicon/Ma

[edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8k/OcteonTx: Switch SPCR UART subtype to 0x1

DBG2 ACPI table description [1] specifies three subtypes related to 16550 UART: 0x0 - 16550 compatible 0x1 - 16550 subset 0x12 - 16550 compatible with parameters defined in Generic Address Structure (GAS) It turned out however, that the Windows OS treats 0x0 subtype as legacy x86 UART with

[edk2-devel] [edk2-platforms PATCH 6/6] Marvell: RealTimeClockLib: Rework LibGetWakeupTime/LibSetWakeupTime

Apply multiple fixes to the Marvell RealTimeClockLib wakeup library callbacks. LibGetWakeupTime: * Add input parameters validation * Fix 'Pending' value check LibSetWakeupTime: * Allow disabling the wakeup timer regardless the input 'Time' value * Use more generic 'Time' value verification, which

[edk2-devel] [edk2-platforms PATCH 5/6] Marvell: RealTimeClockLib: Fix daylight and timezone handling

The Marvell implementation of the RealTimeClockLib was unnecessarily overriding the daylight and timezone values, which are handled by non-volatile variables in the generic code. Fix that. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 3

Re: [edk2-devel] [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

Looks good to me. Good catch! Reviewed-by: Sunny Wang By the way, just FYI, I still run into the same problem (line-ending problem) with Windows Outlook and EDK2 email archive https://edk2.groups.io/g/devel/topic/patch/83043513?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83043513. Moreover