Re: [edk2-devel] [Patch V3 7/9] MdeModulePkg: Add new structure for the Universal Payload ACPI Table Info Hob

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Wang, Jian J ; Wu, > Hao A > Subject: [Patch V3 7/9] MdeModulePkg: Add new structure for the Universal > Payload ACPI Table Info Hob > >

Re: [edk2-devel] [Patch V3 8/9] MdeModulePkg/ACPI: Install ACPI table from HOB.

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Liming Gao > ; Ni, Ray > Subject: [Patch V3 8/9] MdeModulePkg/ACPI: Install ACPI table from HOB. > > V1: > If HOB contains APCI

Re: [edk2-devel] [Patch V3 5/9] MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Zeng, Star ; Gao, > Zhichao ; Patrick Rudolph > > Subject: [Patch V3 5/9] MdeModulePkg/Universal/SmbiosDxe: Scan for > existing

Re: [edk2-devel] [Patch V3 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Wang, Jian J ; Wu, Hao > A > Subject: [Patch V3 2/9] MdeModulePkg: Add new structure for the PCI Root > Bridge Info Hob > > Cc: Michael D

Re: [edk2-devel] [Patch V3 4/9] MdeModulePkg: Add new structure for the Universal Payload SMBios Table Info Hob

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Wang, Jian J ; Wu, Hao > A > Subject: [Patch V3 4/9] MdeModulePkg: Add new structure for the Universal > Payload SMBios Table Info Hob > >

Re: [edk2-devel] [Patch V3 1/9] MdeModulePkg: Add Universal Payload general defination header file

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Liu, Zhiguang > Sent: Friday, June 4, 2021 5:42 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Wang, Jian J ; Wu, Hao > A > Subject: [Patch V3 1/9] MdeModulePkg: Add Universal Payload general > defination header file

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/08/2021 #cal-reminder

2021-06-07 Thread gaoliming
The following issues will be discussed in this week Bug Triage meeting. 3399 EDK2 Code sami.muja...@arm.com UNCO ArmGicLib.c is rife with bad assignments for AARCH64 Fri 07:24

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

2021-06-07 Thread Ni, Ray
Marvin, Comments below. > > +EFI_STATUS > > +ProcessRelocation32 ( > > + IN Elf32_Rela*Rela, > > + IN UINT32RelaSize, > > + IN UINT32RelaEntrySize, > > + IN UINT32RelaType, > > + IN INTN Delta, > > + IN

[edk2-devel] [Patch] Document: Add PCD_DYNAMIC_AS_DYNAMICEX to DSC defines section

2021-06-07 Thread Bob Feng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 DynamicEx Pcd supports binary module build well. It's helpful to add a new build option for build tool to convert all Dynamic Pcd to DynamicEx Pcd. Add a new key word in defines section for this function. Signed-off-by: Bob Feng Cc:

[edk2-devel] [Patch V2] BaseTools: Enable the flag to treat dynamic pcd as dynamicEx

2021-06-07 Thread Bob Feng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 In order to support binary build, build tool add a flag to convert type of Dynamic Pcd to DynamicEx Pcd User can append -D PCD_DYNAMIC_AS_DYNAMICEX to build command to enable this function. Also, user can add "PCD_DYNAMIC_AS_DYNAMICEX =

[edk2-devel] [Patch] BaseTools: Enable the flag to treat dynamic pcd as dynamicEx

2021-06-07 Thread Bob Feng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 In order to support binary build, build tool add a flag to convert type of Dynamic Pcd to DynamicEx Pcd User can append -D PCD_DYNAMIC_AS_DYNAMICEX to build command to enable this function. Also, user can add "PCD_DYNAMIC_AS_DYNAMICEX =

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

2021-06-07 Thread Ni, Ray
Marvin, thank you very much for reviewing the detailed logics. Are you ok that I will send a separate patch based on this PayloadLoaderPeim? I think that will be more convenient for both of us for further review and discussion. I will reply your comments in next mail. -=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/08/2021 #cal-reminder

2021-06-07 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data

2021-06-07 Thread gaoliming
Laszlo: Thanks for your reminder. When I merge this change, I add the regression commit info in the commit message. This change is merged at ddb3fdbef30de5a2946f9bd51060e8d5b1987aef. Thanks Liming > -邮件原件- > 发件人: Laszlo Ersek > 发送时间: 2021年6月7日 23:19 > 收件人: devel@edk2.groups.io;

回复: [edk2-devel] [PATCH RFC v3 22/22] MdePkg/GHCB: increase the GHCB protocol max version

2021-06-07 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Laszlo Ersek > 发送时间: 2021年6月3日 21:09 > 收件人: devel@edk2.groups.io > 抄送: brijesh.si...@amd.com; James Bottomley ; Min > Xu ; Jiewen Yao ; Tom > Lendacky ; Jordan Justen > ; Erdem Aktas ; Eric > Dong ; Ray Ni ; Rahul Kumar > ;

Re: [edk2-devel] [edk2-platforms][PATCH v2 32/32] AmpereAltraPkg,JadePkg: Support LinuxBoot DSC/FDF build for Jade platform

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:24 +0700, Nhi Pham wrote: > Adds DSC and FDF files to support the LinuxBoot build. Some PEI/DXE > drivers are not added into the target build as they are not required for > booting to the LinuxBoot Shell. > > Please note that we MUST have the LinuxBoot binary in the

Re: [edk2-devel] [edk2-platforms][PATCH v2 31/32] Platform/Ampere: Introduce the LinuxBootPkg

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:23 +0700, Nhi Pham wrote: > LinuxBoot is a firmware that replaces specific firmware functionality > like the UEFI DXE phase with a Linux kernel and runtime. At the end of > the DXE phase, UEFI will hand over the control to the LinuxBoot kernel. > > This package

Re: [edk2-devel] [edk2-platforms][PATCH v2 30/32] AmpereSiliconPkg: Implement PlatformBootManagerLib for LinuxBoot

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:22 +0700, Nhi Pham wrote: > The PlatformBootManagerLib library derived from > ArmPkg/Library/PlatformBootManagerLib. > > This implementation registers only a common GUID for LinuxBoot Payload > ("D834A5AD-459C-4AED-B0D0-8CBCB28838D7") as a active boot option. This >

Re: [edk2-devel] [edk2-platforms][PATCH v2 29/32] JadePkg: Recover boot options when NVRAM cleared

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:21 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Due to recent changes in EDK2, system without a valid boot options list > in NVRAM will enter Platform Recovery mode. As ReadyToBoot event is not > triggered in this mode, services like ACPI and PCIe won't be able to

Re: [edk2-devel] [edk2-platforms][PATCH v2 28/32] AmpereAltraPkg: Add configuration screen for Pcie Devices

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:20 +0700, Nhi Pham wrote: > From: Vu Nguyen > > This screen provide menu options to configure Max Payload and Max Read > Request size for each PCIe device under Root Port. PCIe devices which > attach to external switch are not supported yet. > > Cc: Thang Nguyen >

Re: [edk2-devel] [PATCH v2 3/3] PeiCore: Remove assertion when failing to load PE image

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: Ni, Ray > Sent: Thursday, June 3, 2021 2:23 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Liming Gao > Subject: [PATCH v2 3/3] PeiCore: Remove assertion when failing to load PE > image > > EFI_PEI_LOAD_FILE_PPI is invoked by

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload

2021-06-07 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Thursday, June 3, 2021 2:23 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Ma, > Maurice ; Dong, Guo > Subject: [edk2-devel] [PATCH v2 1/3]

Re: [edk2-devel] [edk2-platforms][PATCH v2 27/32] AmpereAltraPkg: Add configuration screen for Watchdog timer

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:19 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provide menu options to configure Secure Watchdog and Non-Secure Watchdog > timer. Please give more description. Configure how? > By default, the values of these options are 5 minutes. > > Cc: Thang Nguyen > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v2 26/32] AmpereAltraPkg: Add configuration screen for RAS

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:18 +0700, Nhi Pham wrote: > From: Quan Nguyen > > This supports user to enable/disable RAS components running the system > firmware such as HEST, BERT,... > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v2 25/32] AmpereAltraPkg: Add configuration screen for ACPI

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:17 +0700, Nhi Pham wrote: > This supports: > * Enable/Disable APEI Support > * Enable/Disable CPPC Support > * Enable/Disable LPI support > * Enable/Disable Max Performance Mode > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v2 24/32] AmpereAltraPkg: Add configuration screen for CPU

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:16 +0700, Nhi Pham wrote: > From: Vu Nguyen > > This screen only supports to configure the SubNUMA mode currently. And what sort of info does it display? / Leif > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D

Re: [edk2-devel] [edk2-platforms][PATCH v2 23/32] AmpereAltraPkg: Add configuration screen for memory

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:15 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provide memory screen with below info: > * Memory total capacity > * Memory RAS and Performance Configuration > * Per DIMM Information > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm >

Re: [edk2-devel] [edk2-platforms][PATCH v2 22/32] AmpereAltraPkg: Add platform info screen

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:14 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provide screen menu with basic platform information include: > * Platform name > * SCP firmware info > * System bus clock frequency. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v2 21/32] AmpereAltraPkg: Add DebugInfoPei module

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:13 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Helps to show various system information like CPU info and Board Setting > values to UART console during boot process. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D

Re: [edk2-devel] [edk2-platforms][PATCH v2 20/32] JadePkg: Add SMBIOS tables support

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:12 +0700, Nhi Pham wrote: > From: Quan Nguyen > > This supports various SMBIOS tables type 0, 1, 2, 3, 4, 7, 8, 9, 11, > 13, 16, 17, 19, 24 and 32. > > SMBIOS Type 1, 2 and 3 are hardcoded as Host-BMC communication is not > supported yet. And, this module does not

Re: [edk2-devel] [edk2-platforms][PATCH v2 18/32] JadePkg: Add ASpeed GOP driver

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:10 +0700, Nhi Pham wrote: > This wires up the pre-built binary placed in the edk2-non-osi > repository for PCIe VGA Controller support. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [edk2-platforms][PATCH v2 17/32] JadePkg: Enable PCIe-related libraries and device drivers

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:09 +0700, Nhi Pham wrote: > From: Vu Nguyen > > This change also enables the support for SCSI, NVMe, USB keyboard, and > USB storage devices. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ard Biesheuvel

Re: [edk2-devel] [edk2-platforms][PATCH v2 15/32] JadePkg: Add PcieBoardLib library instance

2021-06-07 Thread Leif Lindholm
On Wed, May 26, 2021 at 17:07:07 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provides basic features like: > * Screen menu to change bifurcation setting of each Root Complex. Note > that we can only change the option for Root Complex which doesn't have > default value in the BoardSetting. >

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

2021-06-07 Thread Marvin Häuser
Good day everyone, Sorry that I comment with insufficient review, I am a bit low on time. However I have been working with the PE code in EDK II code for a while and thought I could share some comments based on my experiences with it. I tried to mainly outline the kind of issues, my picks are

Re: [edk2-devel] VirtIO sound device in qemu?

2021-06-07 Thread Leif Lindholm
On Mon, Jun 07, 2021 at 17:16:00 +0200, Laszlo Ersek wrote: > On 06/07/21 13:40, Michael Brown wrote: > > On 07/06/2021 05:41, Ethin Probst wrote: > >> For my audio output protocol (I wonder if we should abbreviate it as > >> AOP?) I need to get access to VirtIO devices in PCIe configuration > >>

Re: [edk2-devel] [PATCH v2 0/3] Add PayloadLoaderPeim which can load ELF payload

2021-06-07 Thread Guo Dong
Reviewed-by: Guo Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, June 2, 2021 11:23 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/3] Add PayloadLoaderPeim which can load > ELF payload > > v2: > > Separate the patch

Re: [edk2-devel] VirtIO sound device in qemu?

2021-06-07 Thread Ethin Probst
Yeah, I was talking about presenting a virtio-sound device to the guest. On 6/7/21, Laszlo Ersek wrote: > On 06/07/21 13:40, Michael Brown wrote: >> On 07/06/2021 05:41, Ethin Probst wrote: >>> For my audio output protocol (I wonder if we should abbreviate it as >>> AOP?) I need to get access to

Re: [edk2-devel] [PATCH v2] OvmfPkg/README: Fix typo in README

2021-06-07 Thread Laszlo Ersek
On 06/05/21 19:17, KAAIRA GUPTA wrote: > Fix typographical error in the OvmfPkg/README by correcting the 'an' > mistyped as 'and'. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: mikub...@linux.microsoft.com > Cc: ray...@intel.com > Signed-off-by: Kaaira Gupta > --- >

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Brijesh Singh via groups.io
On 6/7/21 7:48 AM, Laszlo Ersek wrote: > On 06/07/21 14:26, Laszlo Ersek wrote: >> On 05/27/21 01:11, Brijesh Singh wrote: >>> BZ: >>>

[edk2-devel] [edk2-libc PATCH 1/1] Update LibC to use safe string functions

2021-06-07 Thread Rebecca Cran
The insecure string functions such as StrCpy were removed a while ago, breaking the StdLib build. Migrate StdLib/LibC to the safe string versions. Signed-off-by: Rebecca Cran --- StdLib/LibC/StdLib/Environs.c | 11 ++- StdLib/LibC/StdLib/realpath.c | 5 +++--

[edk2-devel] [edk2-platforms][PATCH v2 4/4] MinPlatformPkg/TpmPlatformHierarchyLib: Add disable support

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411 Adds a new PCD (PcdRandomizePlatformHierarchy) to MinPlatformPkg.dec that allows a platform integrator to choose whether to randomize or disable the TPM platform hierarchy. The current behavior to randomize the

[edk2-devel] [edk2-platforms][PATCH v2 3/4] MinPlatformPkg/Tcg2PlatformPei: Use TpmPlatformHierarchyLib

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki Eliminates code duplication in the module with TpmPlatformHierarchyLib. Pre-existing behavior of randomzing the TPM platform auth is retained by calling the implementation of ConfigureTpmPlatformHierarchy() in TpmPlatformHierarchyLib. Cc: Chasel Chiu Cc: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH v2 2/4] MinPlatformPkg/TpmPlatformHierarchyLib: Add PEI support

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki Expands the TpmPlatformHierarchyLib instance in MinPlatformPkg to support PEIM in addition to DXE_DRIVER. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add TPM platform hier disable support

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411 This patch series adds support in TpmPlatformHierarchyLib to either randomize the platform auth (current behavior) or disable the platform auth (new behavior) based on a new PCD introduced to MinPlatformPkg:

[edk2-devel] [edk2-platforms][PATCH v2 1/4] MinPlatformPkg: Add TpmPlatformHierarchyLib to Components in DSC

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki Adds TpmPlatformHierarchyLib to the [Components] section in MinPlatformPkg.dsc so it is always built in the package build. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki ---

[edk2-devel] [PATCH v1 1/1] MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy

2021-06-07 Thread kenlautner3
From: Ken Lautner Changed BdsEntry.c to use Variable Policy instead of Variable Lock as Variable Lock will be Deprecated eventually Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Kenneth Lautner --- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 4 +++-

[edk2-devel] [PATCH v1 0/1] *** Update BdsEntry.c to Variable Policy ***

2021-06-07 Thread kenlautner3
From: Ken Lautner *** Changes BdsEntry.c from Variable Lock to Variable Policy as Variable Lock is deprecated and won't be around in the future*** https://github.com/kenlautner/edk2/tree/deprecated_fix Cc: Jian J Wang Cc: Hao A Wu Cc: Zhichao Gao Cc: Ray Ni Ken Lautner (1):

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Brijesh Singh via groups.io
On 6/7/21 7:26 AM, Laszlo Ersek wrote: > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: >>

Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Fix regression issue to convert the image to ACPI data

2021-06-07 Thread Laszlo Ersek
On 06/05/21 03:18, gaoliming wrote: > With GCC49 tool chain, aslc file is compiled into elf image. > But, its text section has no CODE attribute. So, it can't be detected > by new GenFw tool.For this type file. its text section is not required. > Its data section will be converted to acpi table. >

Re: [edk2-devel] VirtIO sound device in qemu?

2021-06-07 Thread Laszlo Ersek
On 06/07/21 13:40, Michael Brown wrote: > On 07/06/2021 05:41, Ethin Probst wrote: >> For my audio output protocol (I wonder if we should abbreviate it as >> AOP?) I need to get access to VirtIO devices in PCIe configuration >> space. However, I can't seem to find a way of telling QEMU to use this

Re: [edk2-devel] [PATCH v4 3/3] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-06-07 Thread Mario Bălănică
Looks good to me. Thanks for working on this! --Mario În lun., 7 iun. 2021 la 10:54, Sunny Wang a scris: > This change is based on edk2-platforms-raspberrypi-pl011-bth-noflow.diff > in https://github.com/worproject/RPi-Bluetooth-Testing/ with the > modifications and additional changes below

Re: [edk2-devel] [PATCH v3 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-06-07 Thread Mario Bălănică
This version of MiniComm will work without vcredist (compiled with /MT): https://drive.google.com/file/d/1v04RHUEIqlhrg2TUU_d_G4Z6lbZ1l44g/view?usp=sharing --Mario În lun., 7 iun. 2021 la 11:31, Sunny Wang a scris: > Thanks for all the valuable comments, Mario. I learned a lot from your >

[edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC

2021-06-07 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033 Adds several libraries and modules to the MinPlatformPkg build that are currently missing. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki ---

Re: [edk2-rfc] [edk2-devel] RFC: design review for TDVF in OVMF

2021-06-07 Thread Laszlo Ersek
On 06/06/21 14:49, Xu, Min M wrote: > On June 6, 2021 7:30 PM, Michael Brown Wrote: >> On 06/06/2021 03:03, Min Xu wrote: (11) "Page table should support both 4-level and 5-level page table" As a general development strategy, I would suggest building TDX support in small,

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-07 Thread Brijesh Singh via groups.io
Hi Laszlo, On 6/7/21 6:54 AM, Laszlo Ersek wrote: > Hi Brijesh, > > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: >>

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-07 Thread Laszlo Ersek
On 06/06/21 15:21, Dov Murik wrote: > > > On 04/06/2021 14:26, Laszlo Ersek wrote: >> On 06/04/21 12:30, Dov Murik wrote: >> >>> So I argue to keep the existing approach with two separate areas: >>> existing one for injected secrets, and new one for a table of approved >>> hashes (filled by QEMU

Re: [edk2-devel] [PATCH RFC v3 03/22] OvmfPkg/MemEncryptSevLib: extend the workarea to include SNP enabled field

2021-06-07 Thread Brijesh Singh via groups.io
Hi Laszlo, On 6/7/21 6:20 AM, Laszlo Ersek via groups.io wrote: > On 06/04/21 16:15, Laszlo Ersek wrote: >> On 05/27/21 01:10, Brijesh Singh wrote: >>> BZ: >>>

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Laszlo Ersek
On 06/07/21 14:26, Laszlo Ersek wrote: > On 05/27/21 01:11, Brijesh Singh wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 >> >> When AMD SEV is enabled in the guest VM, a hypervisor need to insert a >> secrets page. > > For pure SEV? > >> >> When SEV-SNP is enabled, the secrets

Re: [edk2-devel] [PATCH RFC v3 05/22] OvmfPkg: reserve Secrets page in MEMFD

2021-06-07 Thread Laszlo Ersek
On 05/27/21 01:11, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > When AMD SEV is enabled in the guest VM, a hypervisor need to insert a > secrets page. For pure SEV? > > When SEV-SNP is enabled, the secrets page contains the VM platform > communication

Re: [edk2-devel] [RESEND PATCH RFC v3 00/22] Add AMD Secure Nested Paging (SEV-SNP) support

2021-06-07 Thread Laszlo Ersek
On 06/04/21 15:09, Laszlo Ersek wrote: > On 06/04/21 13:50, Brijesh Singh wrote: >> The main issue is I typed wrong branch name in the cover letter. The >> branch name should be "sev-snp-rfc-3" and not "sev-snp-rfc-2". I >> apologies for it :(. Ray asked the branch name and I replied him with >>

Re: [edk2-devel] [PATCH RFC v3 04/22] OvmfPkg/MemEncryptSevLib: extend Es Workarea to include hv features

2021-06-07 Thread Laszlo Ersek
Hi Brijesh, On 05/27/21 01:11, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The GHCB Version 2 introduces advertisement of features that are supported > by the hypervisor. The features value is saved in the SevEs workarea. Save > the value in the PCD for the

Re: [edk2-devel] VirtIO sound device in qemu?

2021-06-07 Thread Michael Brown
On 07/06/2021 05:41, Ethin Probst wrote: For my audio output protocol (I wonder if we should abbreviate it as AOP?) I need to get access to VirtIO devices in PCIe configuration space. However, I can't seem to find a way of telling QEMU to use this device for audio output. Is there something I

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Readme.md: Refer users to the Arm GNU-A Downloads page for toolchains

2021-06-07 Thread Sami Mujawar
Pushed as 6e92566d2e61..7bf73ecc3c47 Thanks. Regards, Sami Mujawar On 03/06/2021 11:34 AM, Leif Lindholm wrote: Reviewed-by: Leif Lindholm -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76123):

Re: [edk2-devel] [PATCH RFC v3 03/22] OvmfPkg/MemEncryptSevLib: extend the workarea to include SNP enabled field

2021-06-07 Thread Laszlo Ersek
On 06/04/21 16:15, Laszlo Ersek wrote: > On 05/27/21 01:10, Brijesh Singh wrote: >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 >> >> Extend the workarea to include the SEV-SNP enabled fields. This will be set >> when SEV-SNP is active in the guest VM. >> >> Cc: James Bottomley >> Cc:

Re: [edk2-devel] [PATCH] Platform/ARM/Morello: Correct the private resources in PPTT

2021-06-07 Thread christopher . jones
Hi Chandni, I have built and verified this patch and it looks good to me. Reviewed-by: Chris Jones < christopher. jones @arm.com> Thanks, Chris -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76121):

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload

2021-06-07 Thread Ni, Ray
Hao, Can you give a R-b for this patch and the other one that changes PeiCore? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76120): https://edk2.groups.io/g/devel/message/76120 Mute This Topic: https://groups.io/mt/83277975/21656 Group

Re: [edk2-devel] [PATCH v3 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-06-07 Thread Sunny Wang
Thanks for all the valuable comments, Mario. I learned a lot from your comments. I just sent v4 for addressing your comments. By the way, for samples/MinComm at develop · ms-iot/samples (github.com) 1. I successfully build it. However,

[edk2-devel] [PATCH v4 3/3] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-06-07 Thread Sunny Wang
This change is based on edk2-platforms-raspberrypi-pl011-bth-noflow.diff in https://github.com/worproject/RPi-Bluetooth-Testing/ with the modifications and additional changes below for enabling Bluetooth and serial port (Mini UART) in Windows IOT. - Remove RPIQ connection for BT_ON/OFF in

[edk2-devel] [PATCH v4 2/3] Silicon/Broadcom/Bcm283x: Clean up GpioPinSet function

2021-06-07 Thread Sunny Wang
Make the changes below for making it clearer. - Rename GpioPinSet() to GpioPinConfigure() - Rename parameter Val to Config and change its type to BOOLEAN Cc: Samer El-Haj-Mahmoud Cc: Sami Mujawar Cc: Jeremy Linton Cc: Pete Batard Cc: Ard Biesheuvel Cc: Mario Bălănică Signed-off-by:

[edk2-devel] [PATCH v4 1/3] Platform/RaspberryPi: Dynamically build UARTs info in ACPI

2021-06-07 Thread Sunny Wang
Changes: 1. Add code to ConfigDxe driver and AcpiTables module to dynamically build either Mini UART or PL011 UART info in ACPI. This also fixes the issue discussed in https://github.com/pftf/RPi4/issues/118. 2. Cleanup by moving duplicate Debug Port 2 table related defines and

[edk2-devel] [PATCH v4 0/3] Dynamically build UARTs info in ACPI

2021-06-07 Thread Sunny Wang
In v4: Address comments given by Mario on v3. In v3: Address comments given by Jeremy, Mario, and Pete on v2. In v2: Address comments given by Pete on v1. Dynamically build UARTs info in ACPI so that it can match the UART related settings defined in config.txt Cc: Samer El-Haj-Mahmoud Cc: Sami

Re: [edk2-devel] [PATCH v2 0/6] Secure Boot default keys

2021-06-07 Thread Grzegorz Bernacki
Hi Min M, I tested it with Ovmf. I will try other compiler and provide you logs soon. thanks, greg pt., 4 cze 2021 o 10:17 Xu, Min M napisał(a): > > Grzegorz > Have you built this feature with different tool chains, such as > VS2017/VS2019/GCC5? And test it in IA32/X64/AARCH64? > Would you