Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Keep read only alloc section as text section when convert ELF

Reviewed-by: Bob Feng -Original Message- From: Liming Gao Sent: Wednesday, June 9, 2021 6:06 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Ni, Ray Subject: [PATCH 1/1] BaseTools GenFw: Keep read only alloc section as text section when convert ELF This is the fix of the regression iss

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/15/2021 #cal-reminder

Hi, all The following issues will be discussed in this week TianoCore Bug Triage meeting. 3458 EDK2 Code unassig...@tianocore.org UNCO Add support IORT Rev E.b specification updates

Re: [edk2-devel] [PATCH 0/4] Prepare bhyve's OVMF for GPU-Passthrough

Hi Corvin, GPU-Passthrough for bhyve requires a few patches to work properly. These patches will allow GPU-Passthrough for bhyve. It will work for dedicated AMD GPUs and integrated Intel GPUs. I have no issue with adding USB support or fixing the PCI32 base: that either codifies existing beh

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

On Mon, Jun 14, 2021 at 11:55 PM Leif Lindholm wrote: > > Hi Marcin, > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > Hi, > > > > The MDIO ACPI binding has been established and merged to the > > Linux tree, > > Congratulations! :) > > Is FreeBSD expected to follow suit? > > > h

Re: [edk2-devel] [PATCH] MdeModulePkg: Fix device path when the boot manager menu is from different FV

> -Original Message- > From: Liu, Zhiguang > Sent: Wednesday, June 9, 2021 5:37 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Zhichao ; Ni, Ray > Subject: [PATCH] MdeModulePkg: Fix device path when the boot manager > menu is from different FV > > REF: https://bugz

Re: [edk2-devel] [RESEND PATCH v2] BaseTools: Add support for RISCV GOT/PLT relocations

Great commit message, thanks Sunil! Maintainers, please take a look and let us know if there's any other concern. This patch lets us build the RISC-V platforms using modern toolchains that are provided directly by the distributions, rather than building your own from source. Thanks, Daniel _

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/15/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-devel] [PATCH v3 3/8] SecurityPkg: Create include file for default key content.

Hi I am not sure why we hardcode 3 items for each. Can we move this fdf to platform pkg, instead of security pkg ? Thank you Yao Jiewen > -Original Message- > From: Grzegorz Bernacki > Sent: Monday, June 14, 2021 5:43 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...

Re: [edk2-devel] [Patch V2] BaseTools: Enable the flag to treat dynamic pcd as dynamicEx

Add Mike Turner for review. -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Tuesday, June 8, 2021 10:50 AM To: devel@edk2.groups.io Cc: Liming Gao ; Chen, Christine ; Kinney, Michael D ; Desimone, Nathaniel L Subject: [edk2-devel] [Patch V2] BaseTools: Enable

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Update Salt length requirement for RSA-PSS scheme.

Reviewed-by: Jiewen Yao > -Original Message- > From: Agrawal, Sachin > Sent: Monday, June 14, 2021 11:31 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin > Subject: [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Update Salt length > requirement for

Re: [edk2-devel] [PATCH v1 3/5] MdeModulePkg: MemoryProfileInfo: Updated MessageLength calculation

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Saturday, June 12, 2021 5:30 AM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH v1 3/5] MdeModulePkg: MemoryProfileInfo: > Updated MessageLength calculation > > Hi

Re: [edk2-devel] [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs

Hi Marcin, On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > Hi, > > The MDIO ACPI binding has been established and merged to the > Linux tree, Congratulations! :) Is FreeBSD expected to follow suit? > hence it is now possible to update the ACPI > description of the platforms that

Re: [edk2-devel] [PATCH V1 4/4] Platform/NXP/LS1046aFrwyPkg: Add OEM specific DSDT generator

On Fri, Jun 11, 2021 at 21:22:00 +0530, Vikas Singh wrote: > This patch adds platform specific DSDT generator > and Clk dsdt properties for LS1046AFRWY platform. > > Signed-off-by: Vikas Singh > --- > Platform/NXP/LS1046aFrwyPkg/AcpiTablesInclude/Dsdt/Clk.asl > | 60 +

Re: [edk2-devel] [PATCH V1 3/4] Platform/NXP/LS1046aFrwyPkg: Extend Dynamic ACPI support

On Fri, Jun 11, 2021 at 21:21:59 +0530, Vikas Singh wrote: > This patch set extends Configuration Manager (CM) and > its services to leverage the Dynamic ACPI support for > NXP's LS1046aFrwy platform. This patch does not touch ConfigurationManager. Please describe what this patch does. My guess i

Re: [edk2-devel] [PATCH V1 2/4] Silicon/NXP: Add support of SVR handling for LS1046FRWY

On Fri, Jun 11, 2021 at 21:21:58 +0530, Vikas Singh wrote: > This change set intend to add a generic method to get Does it intend to add, or does it add? / Leif > access to SoC's Silicon Version Register (SVR) and its > handling for LS1046aFrwy platform. > > Signed-off-by: Vikas Singh > --

Re: [edk2-devel] [PATCH V1 1/4] Platform/NXP: Add generic log in CM to print SoC version

On Fri, Jun 11, 2021 at 21:21:57 +0530, Vikas Singh wrote: > Summary - > 1.Configuration Manager(CM) is a common implementation > and should not evaluate the SoC version using macro's > However CM must directly consume SoC ver string from > platfrom who is extending CM services for ACPI table

[edk2-devel] [PATCH v2 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmCache.h

Many of the cache definitions in ArmLibPrivate.h are being used outside of ArmLib, in Universal/Smbios. Move them into ArmCache.h to make them public, and remove the include of ArmLibPrivate.h from files in Universal/Smbios. Signed-off-by: Rebecca Cran --- ArmPkg/Include/IndustryStandard/ArmCach

Re: [edk2-devel] [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment

Hi Ard, Sorry for the confusion and thanks for providing the r-b tag. This should be fixed in v2 patches: https://edk2.groups.io/g/devel/message/76479 Regards, Kun On 06/12/2021 01:22, Ard Biesheuvel wrote: On Sat, 12 Jun 2021 at 05:44, Kun Qin wrote: From: Sean Brogan REF: https://bug

[edk2-devel] [PATCH v2 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 Spellcheck was not covering all specified files due to CSpell v5 and Node v10 incompatibility of current CI pipeline configuration. This change updates ExtendedWords for ArmPkg with valid acronyms to avoid potential spel

[edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 Per update from Cspell tool, the minimal requirement of Cspell 5.x regarding Node is 12 and above. This has caused multple Cspell failures during CI build validation: "Failed to process "**.c" TypeError: text.matchAll(...) is not a function

[edk2-devel] [PATCH v2 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 Spellcheck was not covering all specified files due to CSpell v5 and Node v10 incompatibility of current CI pipeline configuration. This change switches the spellcheck for ArmPlatformPkg to AuditOnly to avoid potentially

[edk2-devel] [PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 This change fixed a misspelling that was not caught by spell check. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Sean Brogan Signed-off-by: Kun Qin Revi

[edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76419 v2 patches mainly focus on feedback for reviewed commits in v1 patches, including: a. Adding "Reviewed-by" tags for applicable patches; b.

[edk2-devel] [PATCH 1/4] OvmfPkg/Bhyve: enable bus enumeration

Neccessary for GPU Passthrough of dedicated AMD GPUs. For Linux guests, AMD GPUs require that their PCI ROM is processed by UEFI. Enable bus enumeration to process the PCI ROM of all devices. Signed-off-by: Corvin Köhne --- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 de

[edk2-devel] [PATCH 2/4] Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"

This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c. Revert this commit to enable bus enumeration properly. Signed-off-by: Corvin Köhne --- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX6

[edk2-devel] [PATCH 0/4] Prepare bhyve's OVMF for GPU-Passthrough

Hi, GPU-Passthrough for bhyve requires a few patches to work properly. These patches will allow GPU-Passthrough for bhyve. It will work for dedicated AMD GPUs and integrated Intel GPUs. Best Regards, Corvin Corvin Köhne (4): OvmfPkg/Bhyve: enable bus enumeration Revert "OvmfPkg/Bhyve: co

[edk2-devel] [PATCH 4/4] OvmfPkg/Bhyve: use static PCI32Base address

It's neccessary to allocate a Graphics Stolen Memory area to enable GPU-Passthrough for integrated Intel GPUs. Therefore, use a new memory layout with a static Pci32Baseaddress. Old layout: [..., lowmemlimit] RAM [lowmemlimit, 0xE000 ] PCI Space New layout: [..

[edk2-devel] [PATCH 3/4] OvmfPkg/Bhyve: add USB support

An USB driver is required to use a keyboard or mouse while installing an OS or while in a bootloader menu like grub when using GPU + USB Passthrough. Signed-off-by: Corvin Köhne --- OvmfPkg/Bhyve/BhyveX64.dsc | 11 +++ OvmfPkg/Bhyve/BhyveX64.fdf | 10 ++ 2 files changed, 21 inse

Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes

Attached V2 patch after typo correction. Thanks Gopi From: Rebecca Cran Sent: Sunday, June 13, 2021 9:34 AM To: devel@edk2.groups.io; Thotala, Gopi Subject: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes There’s a typo of ‘persistent’ in: // Optane DC Presistent

[edk2-devel] [PATCH v1 0/1] CryptoPkg: Update Salt length requirement for RSA-PSS scheme.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3455 This patch enforces salt length to be equal to digest length for RSA PSS encoding scheme. https://github.com/sagraw2/edk2/tree/pss_salt_len Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Sachin Agrawal (1): CryptoPkg

[edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Update Salt length requirement for RSA-PSS scheme.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3455 Enforce salt length to be equal to digest length for RSA-PSS encoding scheme. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Sachin Agrawal --- CryptoPkg/Library/BaseCryptLib/Pk/CryptRsaPss.c

Re: [edk2-devel] [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h

On Fri, 11 Jun 2021 at 00:44, Rebecca Cran wrote: > > On 6/10/21 9:04 AM, Ard Biesheuvel wrote: > > On Tue, 8 Jun 2021 at 15:54, Rebecca Cran wrote: > >> Many of the cache definitions in ArmLibPrivate.h are being used outside > >> of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make th

Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] Platform/Sgi: Cleanup build options for StandaloneMM context

On 6/11/21 4:04 PM, Pranav Madhu via groups.io wrote: > From: Omkar Anand Kulkarni > > The Arm reference design platforms support only AArch64 mode for > StandaloneMM execution context. So cleanup the existing build options > specified for StandaloneMM. > > Signed-off-by: Omkar Anand Kulkarni

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Sgi: update _OSC control method to control LPI and CPPC

On 6/11/21 4:04 PM, Pranav Madhu via groups.io wrote: > Define and use the global macro LPI_EN and CPPC_EN to enable low power > idle and CPPC support for reference design platforms. Update platform > wide _OSC control method to enable/disable low power idle and CPPC > support based on pcd PcdOs

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/5] Platform/Sgi: Add GED support

On 6/11/21 4:04 PM, Pranav Madhu via groups.io wrote: > Add ACPI Generic Event Device (GED) support for Arm's reference design > platforms. The SP804 dual-timer interrupt is used as the event source > for GED. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/SgiPlatform.dec

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] Platform/Sgi: Enable PrimeCell GPIO

On 6/11/21 4:04 PM, Pranav Madhu via groups.io wrote: > The HW-Reduced ACPI model has specific requirements for GPIO > controllers. Arm's reference design Platforms has PrimeCell GPIO > (PL061) integrated in the RoS subsystem to provide GPIO support. Add > GPIO device entry and also add GPIO sign

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM system, and confirmed the issue got fixed by this patch. Without this fix, the result would be 18 tests, and 4 Errors. CreateEvent_Func: [FAILED] Passes... 14 Warnings. 0 Errors... 4 Wit

Re: [edk2-devel] [PATCH v2 0/6] Secure Boot default keys

Hi Min M, Please find log from tests of OvmfX64 built with VS2019 at: https://drive.google.com/file/d/18w7s6GxIz3aeId22xABMib7I3JX7G9X1/view?usp=sharing thanks, greg pon., 7 cze 2021 o 09:29 Grzegorz Bernacki napisał(a): > > Hi Min M, > > I tested it with Ovmf. I will try other compiler and pro

[edk2-devel] [PATCH v3 8/8] MdeModulePkg: Use SecureBootVariableLib in PlatformVarCleanupLib.

This commits removes CreateTimeBasedPayload() function from PlatformVarCleanupLib and uses exactly the same function from SecureBootVariableLib. Signed-off-by: Grzegorz Bernacki --- MdeModulePkg/Library/PlatformVarCleanupLib/PlatformVarCleanupLib.inf | 2 + MdeModulePkg/Library/PlatformVarClean

[edk2-devel] [PATCH v3 5/8] SecurityPkg: Add EnrollFromDefaultKeys application.

This application allows user to force key enrollment from Secure Boot default variables. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.inf | 47 + SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c | 109 +

[edk2-devel] [PATCH v3 7/8] SecurityPkg: Add option to reset secure boot keys.

This commit add option which allows reset content of Secure Boot keys and databases to default variables. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 --- SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/Secure

[edk2-devel] [PATCH v3 6/8] SecurityPkg: Add new modules to Security package.

This commits adds modules related to initialization and usage of default Secure Boot key variables to SecurityPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 --- SecurityPkg/SecurityPkg.dec | 14 ++ Se

[edk2-devel] [PATCH v3 4/8] SecurityPkg: Add SecureBootDefaultKeysDxe driver

This driver initializes default Secure Boot keys and databases based on keys embedded in flash. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi --- SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDe

[edk2-devel] [edk2-platforms PATCH v3 2/2] Platform/RaspberryPi: Enable default Secure Boot variables initialization

This commit allows to initialize Secure Boot default key and databases from data embedded in firmware binary. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 --- Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ Platform/Ras

[edk2-devel] [PATCH v3 3/8] SecurityPkg: Create include file for default key content.

This commits add file which can be included by platform Flash Description File. It allows to specify certificate files, which will be embedded into binary file. The content of these files can be used to initialize Secure Boot default keys and databases. Signed-off-by: Grzegorz Bernacki --- Secur

[edk2-devel] [PATCH v3 0/8] Secure Boot default keys

This patchset adds support for initialization of default Secure Boot variables based on keys content embedded in flash binary. This feature is active only if Secure Boot is enabled and DEFAULT_KEY is defined. The patchset consist also application to enroll keys from default variables and secure boo

[edk2-devel] [PATCH v3 2/8] Platforms: add SecureBootVariableLib class resolution

Update platform files to add SecureBootVariableLib for each platform which uses SecureBootConfigDxe. Signed-off-by: Grzegorz Bernacki --- ArmVirtPkg/ArmVirtQemu.dsc | 3 +++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 3 +++ EmulatorPkg/EmulatorPkg.dsc | 1 + OvmfPkg/Bhyve/BhyveX64.dsc

[edk2-devel] [PATCH v3 1/8] SecurityPkg: Create library for setting Secure Boot variables.

This commits add library, which consist functions related creation/removal Secure Boot variables. Some of the functions was moved from SecureBootConfigImpl.c file. Signed-off-by: Grzegorz Bernacki --- SecurityPkg/SecurityPkg.dsc | 1 + Securit

[edk2-devel] [edk2-platforms PATCH v3 1/2] Platforms: add SecureBootVariableLib class resolution

SecureBootConfigDxe needs this library after change in edk2: SecurityPkg: Create library for setting Secure Boot variables. Signed-off-by: Grzegorz Bernacki --- Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 + Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc

Re: 回复: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

On 10/06/2021 12:15, gaoliming wrote: > Dov: > Can you submit one BZ for this new feature? I will add it into edk2 202108 > stable tag planning. Submitted: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 I'll add the BZ link to future versions of the patch series. Thanks, -Dov > > Th