[edk2-devel] [PATCH v3 0/3] Add PayloadLoaderPeim which can load ELF payload

v3: Change PLD_ to UNIVERSAL_PAYLOAD_ based on Mike's comments. v2: Separate the patch set from the patch that adds CLANGDWARF toolchain. Add missing function header commments. Change DEBUG_ERROR to DEBUG_INFO for information debug message. Ray Ni (3): MdeModulePkg/UniversalPayload

Re: [edk2-devel] [PATCH 1/1] BaseTools GenFw: Keep read only alloc section as text section when convert ELF

Hi Liming, There are some warning reported from PatchCheck.py, would you update the commit message? Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Tuesday, June 15, 2021 2:49 PM To: Liming Gao ; devel@edk2.groups.io Cc: Ni, Ray Subject: Re: [edk2

[edk2-devel] SIMPLE_TEXT_OUTPUT_PROTOCOL and Video Resolution

Hello, I've found that most implementation of UEFI don't automatically change the resolution when setting the mode with STOP (Simple Text Output Protocol) . You can use GOP to change it after the mode but that causes other problems. For example, using surface pro 7 in this case, with 4K screen.

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

Hi Guo, The PciHostBridgeDxe expects the PCI Aperature and MMCONF to be marked as EfiMemoryMappedIO, however as the bootloader provides an e820 compatible memory map, it's actually marked as EfiReservedMemoryType. The PciHostBridgeDxe asserts on this incorrect memory type. This is what the patch tr

[edk2-devel] [edk2][PATCH V1 1/1] ArmPkg: introduce FF-A interface support in MM_COMMUNICATE

From: Aditya Angadi With the introduction of Firmware Framework for Arm platforms (FF-A), normal world and secure world endpoints can use FF-A interface for communication with each other. In this patch, FFA_MSG_SEND_DIRECT_REQ and FFA_VERSION interfaces are introduced. This change adds an option

Re: [edk2-devel] [Patch] StandaloneMmPkg: Fixed communicating from TF-A failed issue

On 6/10/21 6:44 AM, Ming Huang via groups.io wrote: > On 6/9/21 3:10 PM, Ard Biesheuvel wrote: > > On Tue, 8 Jun 2021 at 16:21, Ming Huang > wrote: > >> > >> TF-A: TrustedFirmware-a > >> SPM: Secure Partition Manager(MM) > >> > >> For AArch64, when SPM enable in TF-A, TF-A may communicate to MM >

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Yeah, that is a typo. The result with 13 passes was got from testing with this fix. Thanks for catching this, Barton. Best Regards, Sunny Wang -Original Message- From: Gao Jie Sent: Wednesday, June 16, 2021 9:15 AM To: devel@edk2.groups.io; Sunny Wang ; Samer El-Haj-Mahmoud ; 'Heinrich

Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Thanks Kun, I am a little concerned on whether there will be other missing cases that are not covered by this patch series. I am also wondering is there any detection can be made to warn the cases that code modification should be made after this structure update. Otherwise, it will be the burde

回复: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

Hi Sunny, I believe the result with 13 passes should be tested *with* this fix, right? I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch upstreamed soon. Thanks Barton -邮件原件- 发件人: devel@edk2.groups.io 代表 Sunny Wang 发送时间: 2021年6月14日 17:53 收件人: Samer El-Haj-Mahmoud

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/15/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

回复: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Universal Payload

Thank Patrick for verifying. I will add your Tested-by tag for this patch series. Thanks Zhiguang 发件人: Patrick Rudolph 发送时间: 2021年6月15日 20:00 收件人: devel@edk2.groups.io ; Liu, Zhiguang 抄送: gaoliming 主题: Re: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Un

Re: [edk2-devel] [PATCH v3 6/8] SecurityPkg: Add new modules to Security package.

Good catch, Jeremiah! Thank you! From: devel@edk2.groups.io On Behalf Of Jeremiah Cox via groups.io Sent: Wednesday, June 16, 2021 2:55 AM To: Grzegorz Bernacki ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v3 6/8] SecurityPkg: Add new modules to Security package. "dbt" and "dbx" are

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add TPM platform hier disable support

Thank you, Michael. Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, June 16, 2021 4:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao ; > Dong, Eric ; Yao, Jiewen ; > Jerem

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

One final comment, PurleyOpenBoardPkg/Override/edk2/MdeModulePkg/Bus/Pci/PciBusDxe seems a little excessive, I think you can do PurleyOpenBoardPkg/Override/MdeModulePkg/Bus/Pci/PciBusDxe and everyone will understand what it is. Thanks, Nate -Original Message- From: devel@edk2.groups.i

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

Could you provide more info on the issues in fixed by this patch? There is a UEFI payload patch (under code review) to support the bootloader to provide a HOB on the PCI resources, this way the UEFI payload doesn't need collect resources again by parsing all the PCI devices. Not sure if that pa

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

Also, uefi_2500_800.efi should not be added directly inside of PurleyOpenBoardPkg. You will need to move that to edk2-non-osi. I'm not sure exactly which driver that is, but I have a suspicion that it might make sense to add it to ASpeedGopBinPkg. Thanks, Nate -Original Message- From:

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Support for TiogaPass Platform and Override generic PciBus Driver with

Hi Manic, I looked over all of your changes. The code itself looks good. However, there is an issue with the copyright headers that you have placed on the top of many of the files included here. It appears that you added the following: /** @file Copyright (c) 2018, Intel Corporation. All right

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add TPM platform hier disable support

It's been a week and I haven't seen any feedback. Please review when possible. Thanks, Michael On 6/7/2021 12:05 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411 This patch series adds support in TpmPlatformHierarchyLib to either rando

Re: [edk2-devel] [PATCH v1 1/5] EDK2 Code First: PI Specification: EFI_MM_COMMUNICATE_HEADER Update

Hi Hao, Sorry that I missed comments for this patch earlier. You are correct. I only inspected SmmLockBoxPeiLib. The PEI instance handled mode switch with ```OFFSET_OF ``` function. But DXE instance still have a few use cases that will be impacted. I will update this read me file and add a c

Re: [edk2-devel] [PATCH v3 6/8] SecurityPkg: Add new modules to Security package.

"dbt" and "dbx" are swapped in the comments?  Look for groups of 3 underscores ("___") below... + ## GUID used to specify section with default ___dbt___ content + gDefault___dbx___FileGuid = { 0x5740766a, 0x718e, 0x4dc0, { 0x99, 0x35, 0xc3, 0x6f, 0x7d, 0x3f, 0x88, 0x4f } } + + ## GUID used to sp

[edk2-devel] [PATCH v1 0/1] ArmPlatformPkg/Scripts: Create add-symbol-file commands from UEFI console

cmd_load_symbols.py can only load symbols from a firmware volume. Add the possibility to use UEFI console output to calculate dll load address and send add-symbol-file commands directly to ArmDS debugger Public branch: https://github.com/artkopotev/edk2/commits/fix_armds_debug_script Cc: Leif Li

[edk2-devel] [PATCH v1 1/1] ArmPlatformPkg/Scripts: Create add-symbol-file commands from UEFI console

cmd_load_symbols.py can only load symbols from FV. Add the possibility to use UEFI console output to calculate dll load address and send add-symbol-file commands directly to ArmDS debugger dll load address can't be used directly from UEFI output, see comment in DebugPeCoffExtraActionLib: "This may

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

Hey Ray, Sure, thanks a lot for taking the time. I will need a bit longer to get to it, sorry. :) Best regards, Marvin On 15.06.21 16:36, Ni, Ray wrote: Marvin, I have sent out https://edk2.groups.io/g/devel/message/76429 to address your feedbacks. Can I merge the 3 patches first? (we ca

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

Thanks for the review. Updated patch has been sent here: https://edk2.groups.io/g/devel/message/76553. Please let me know if any other feedbacks. Regards, Kun On 06/15/2021 09:20, Bret Barkelew wrote: Reviewed-by: Bret Barkelew - Bret *From: *Sean Brogan *Sent

[edk2-devel] [PATCH v2 0/1] SpellCheck plugin inspects fewer files when run on Linux

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/76427 v2 patch change includes feedback for v1 series: a. Adding "Reviewed-by" tags; b. Adding "Signed-Off-by" tags for myself; Patch v2 branch

[edk2-devel] [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. This change adds additional quotes to defer expansion in order to bring parity in cspell result. Cc: Sean Brogan Cc: Bret Barkelew C

Re: [edk2-devel] [edk2-platforms][PATCH v2 29/32] JadePkg: Recover boot options when NVRAM cleared

On 6/8/21 06:46, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:21 +0700, Nhi Pham wrote: From: Vu Nguyen Due to recent changes in EDK2, system without a valid boot options list in NVRAM will enter Platform Recovery mode. As ReadyToBoot event is not triggered in this mode, services like AC

Re: [edk2-devel] [edk2-platforms][PATCH v2 20/32] JadePkg: Add SMBIOS tables support

On 6/8/21 06:00, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:12 +0700, Nhi Pham wrote: From: Quan Nguyen This supports various SMBIOS tables type 0, 1, 2, 3, 4, 7, 8, 9, 11, 13, 16, 17, 19, 24 and 32. SMBIOS Type 1, 2 and 3 are hardcoded as Host-BMC communication is not supported yet.

Re: [edk2-devel] [edk2-platforms][PATCH v2 21/32] AmpereAltraPkg: Add DebugInfoPei module

On 6/8/21 06:08, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:13 +0700, Nhi Pham wrote: From: Vu Nguyen Helps to show various system information like CPU info and Board Setting values to UART console during boot process. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm

Re: [edk2-devel] [edk2-platforms][PATCH v2 15/32] JadePkg: Add PcieBoardLib library instance

Hi Leif, Thanks for reviewing. Will address all your comments from this patch. Best regards, Nhi On 6/8/21 05:45, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:07 +0700, Nhi Pham wrote: From: Vu Nguyen Provides basic features like: * Screen menu to change bifurcation setting of each Ro

Re: [edk2-devel] [edk2-platforms][PATCH v2 09/32] AmpereAltraPkg: Support non-volatile variables

On 6/5/21 06:36, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:01 +0700, Nhi Pham wrote: From: Vu Nguyen Non-volatile variables now can be stored on flash. MM communication protocol is used to access storage on flash. Included in this change are: * FlashPei module is used to compare save

Re: [edk2-devel] [edk2-platforms][PATCH v2 08/32] AmpereAltraPkg: Add BootProgress support

On 6/5/21 06:27, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:07:00 +0700, Nhi Pham wrote: From: Quan Nguyen BootProgress will send 32-bit UEFI Status Code via doorbell to report its progress status. Currently support reporting Progress Status Code and Error Status Code only. Other types of

Re: [edk2-devel] [edk2-platforms][PATCH v2 07/32] JadePkg: Implement RealTimeClockLib for PCF85063

On 6/5/21 06:26, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:06:59 +0700, Nhi Pham wrote: From: Vu Nguyen This library adds the support for retrieving and updating system datetime over real RTC PCF85063 device on Mt. Jade platform instead of using virtual RTC. Cc: Thang Nguyen Cc: Chuong

Re: [edk2-devel] [edk2-platforms][PATCH v2 05/32] AmpereAltraPkg: Add DwI2cLib library

On 6/5/21 06:21, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:06:57 +0700, Nhi Pham wrote: From: Vu Nguyen The DwI2cLib library provides basic functions to control the I2C controller on Ampere Altra processor. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Michael

Re: [edk2-devel] [edk2-platforms][PATCH v2 04/32] AmperePlatformPkg: Add FailSafe and WDT support

Hi Leif, On 6/5/21 06:12, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:06:56 +0700, Nhi Pham wrote: The FailSafeDxe driver reverts the system's configuration to known good values if the system fails to boot up multiple times. It also implements the Watchdog Timer Architectural Protocol to re

Re: [edk2-devel] [edk2-platforms][PATCH v2 01/32] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

Hi Leif, On 6/5/21 06:04, Leif Lindholm wrote: On Wed, May 26, 2021 at 17:06:52 +0700, Nhi Pham wrote: From: Vu Nguyen This commit adds the support for Ampere’s Altra processor-based Mt. Jade platform that provides up to 160 processor cores in a dual socket configuration. The essential module

Re: [edk2-devel] [PATCH v3 3/8] SecurityPkg: Create include file for default key content.

Maybe use the MinPlatformPkg for Intel (like what Jiewen recommended) and ArmPlatformPkg for Arm? At least this reduced the per-platform duplication for every platform. But it may not cover all architectures/platform families (e.g. AMD, RISC-V?) > -Original Message- > From: devel@edk2.

[edk2-devel] [PATCH v1 6/8] DynamicTablesPkg: IORT set reference to interrupt array if present

The IORT generator is populating the reference field for Context and PMU interrupts even if their count is zero. Update the IORT generator to set the references only if the interrupt count is not 0. Also add checks to ensure a valid reference token has been provided. Signed-off-by: Sami Mujawar

[edk2-devel] [PATCH v1 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.b

Bugzilla: 3458 - Add support IORT Rev E.b specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.b, Feb 2021 (https://developer.arm.com/documentation/den0049/) introduces the following updates, collectively

[edk2-devel] [PATCH v1 5/8] DynamicTablesPkg: IORT set reference to Id array only if present

The IORT table generator is setting up a reference to ID array for nodes even when the ID Mapping count is zero. This is not an issue as an OS would only access the ID Reference if the ID mapping count is not zero. However, it would be good to set the reference to ID array to zero when the ID Mapp

[edk2-devel] [PATCH v1 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment

Some field names in the IORT table parser were longer than the OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of the output print alignment. Therefore, abbreviate the field names. Signed-off-by: Sami Mujawar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.

[edk2-devel] [PATCH v1 2/8] MdePkg: IORT header update for IORT Rev E.b spec

Bugzilla: 3458 - Add support IORT Rev E.b specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.b, Feb 2021 (https://developer.arm.com/documentation/den0049/) introduces the following updates, collectively

[edk2-devel] [PATCH v1 4/8] ShellPkg: Acpiview: IORT parser update for IORT Rev E.b spec

Bugzilla: 3458 - Add support IORT Rev E.b specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.b, Feb 2021 (https://developer.arm.com/documentation/den0049/) introduces the following updates, collectively

[edk2-devel] [PATCH v1 0/8] IORT Rev E.b specification updates

Bugzilla: 3458 - Add support IORT Rev E.b specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table (IORT) specification has been updated to rev E.b. The following updates are introduced including the errata to rev E and E.a: - increments the IO

[edk2-devel] [PATCH v1 8/8] DynamicTablesPkg: IORT generator updates for Rev E.b spec

Bugzilla: 3458 - Add support IORT Rev E.b specification updates (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) The IO Remapping Table, Platform Design Document, Revision E.b, Feb 2021 (https://developer.arm.com/documentation/den0049/) introduces the following updates, collectively

[edk2-devel] [PATCH v1 1/8] MdePkg: Fix IORT header file include guard

According to section 5.3.5, EDK II C Coding Standards Specification (https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification) the header file guard names must not be prefixed with underscores as they are reserved for compiler implementation. Therefore, fix the header file include guar

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

Reviewed-by: Bret Barkelew - Bret From: Sean Brogan Sent: Tuesday, June 15, 2021 9:00 AM To: devel@edk2.groups.io; kuqi...@gmail.com Cc: Sean Brogan; Bret Barkelew

Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

Pierre, Yes we noticed this the other day. Bugzilla here: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 A patch is on the list https://edk2.groups.io/g/devel/message/76428 it implemented your second option. The good news is this doesn't change the outcome of overall CI because the Windo

Re: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Defer path expansion in cspell parameters

Please update the signed-off-by to include yours. Reviewed-by: Sean Brogan Thanks Sean On 6/11/2021 10:04 PM, Kun Qin wrote: From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3454 On Linux the shell expands the wildcard paths and causes multiple files to be missed. Thi

Re: [edk2-devel] [edk2-platforms][PATCH v2 16/32] AmpereAltraPkg: Add PciHostBridge driver

On 6/9/21 12:29, Ard Biesheuvel wrote: On Wed, 26 May 2021 at 12:12, Nhi Pham wrote: From: Vu Nguyen The roles of this driver: * Consume PcieCoreLib to initialize all enable PCIe controllers. * Produce neccessary protocols like RootBridgeIo an ResourceAllocation which will be used later by

Re: [edk2-devel] [edk2-non-osi][PATCH 1/1] Platform/RaspberryPi: Update TF-A to v2.5

Acked-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Pete > Batard via groups.io > Sent: Tuesday, June 15, 2021 11:27 AM > To: devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; l...@nuviainc.com > Subject: [edk2-devel] [edk2-non-osi][PATCH 1/1

[edk2-devel] [edk2-non-osi][PATCH 1/1] Platform/RaspberryPi: Update TF-A to v2.5

This is a run-of-the-mill update of the TF-A binaries used by the Raspberry Pi 3 and Raspberry Pi 4 platforms, based on the recently released TF-A 2.5. These binaries were built in an open and verifiable manner through a GitHub Actions build script (https://github.com/pftf/pitf). It should be not

[edk2-devel] [PATCH RESEND v1 1/2] ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg

From: Sami Mujawar PCIe support has been added to Kvmtool Virtual Machine Manager. The PCI host bridge utility lib is used to retrieve information about the Root Bridges in a platform. Therefore, add an instance of PciHostBridgeUtilityLib as this is required to enable PCIe support for Kvmtool fir

[edk2-devel] [PATCH RESEND v1 0/2] ArmVirtPkg: Enable PCIe support for Kvmtool

From: Pierre Gondois PCIe support has been added to the Kvmtool virtual machine manager. Therefore, add a PciHostBridgeUtilityLib and enable PCIe support for Kvmtool firmware. The patches were re-send as the devel@edk2.groups.io was not included. The patches can be seen at: https://github.com/

[edk2-devel] [PATCH RESEND v1 2/2] ArmVirtPkg: Enable PCIe support for Kvmtool

From: Sami Mujawar PCIe support has been added to the Kvmtool virtual machine manager. Therefore, enable PCIe support for Kvmtool firmware. Signed-off-by: Sami Mujawar Signed-off-by: Pierre Gondois --- ArmVirtPkg/ArmVirtKvmTool.dsc | 35 +-- ArmVirtPkg/ArmVirtK

Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload

Marvin, I have sent out https://edk2.groups.io/g/devel/message/76429 to address your feedbacks. Can I merge the 3 patches first? (we can continue discussing the more-checks patch.) Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Thursday, J

Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure

Hi Kun and Sean, As a follow-up to your patch-set, it seems that the spell checker does not currently run as expected. It only runs on files that are 'one level deep' in each package. I.e.: This was taken from Build/CI_BUILDLOG.txt from the TARGET_ARM_ARMPLATFORM artifact at https://dev.azure.c

Re: [edk2-devel] [PATCH v3 3/8] SecurityPkg: Create include file for default key content.

I don’t think it is a good idea to put it to security pkg, because it is a platform configuration. If the goal is to create one include file, you can put it to other common platform pkg, such as https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Include/Fdf T

Re: [edk2-devel] [PATCH v3 3/8] SecurityPkg: Create include file for default key content.

Hi, Adding edk-devel group back in the loop... I removed it by mistake. greg wt., 15 cze 2021 o 14:16 Grzegorz Bernacki napisał(a): > > It was the original design, but it was changed when RFC was reviewed. > Please see: > https://edk2.groups.io/g/rfc/topic/edk2_devel_rfc_secure/82139806 > > I t

[edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Improve bootloader memrange parsing

Currently several DXE crash due to invalid memory resource settings. coreboot and slimbootloader provide an e820 compatible memory map, which doesn't work well with EDK2 as the e820 spec is missing MMIO regions. In e820 'reserved' could either mean "DRAM used by boot firmware" or "MMIO in use and n

Re: [edk2-devel] [Patch V4 0/9] Create multiple Hobs for Universal Payload

Tested the patch series on Intel Coffee Lake Platform using latest coreboot master. Everything seems to work fine. Thanks Patrick On Thu, Jun 10, 2021 at 11:48 AM Zhiguang Liu wrote: > > Liming, > > Bugzilla is created at https://bugzilla.tianocore.org/show_bug.cgi?id=3447 > > Thanks > Zhiguang

Re: [edk2-devel] [Patch V5 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob

Yes. Please help to keep my R-b tag. Thanks. Best Regards, Hao Wu From: Liu, Zhiguang Sent: Tuesday, June 15, 2021 5:16 PM To: devel@edk2.groups.io; Liu, Zhiguang ; Wu, Hao A Subject: 回复: [edk2-devel] [Patch V5 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob Hi Hao, Fo

回复: [edk2-devel] [Patch V5 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob

Hi Hao, For this patch, can I keep your reviewed-by? I just added ExceptionList in MdeModulePkg\MdeModulePkg.ci.yaml, to avoid CI failure. Thanks Zhiguang 发件人: devel@edk2.groups.io 代表 Zhiguang Liu 发送时间: 2021年6月15日 17:12 收件人: devel@edk2.groups.io 抄送: Kinney,

[edk2-devel] [Patch V5 9/9] UefiPayloadPkg: Create gUniversalPayloadAcpiTableGuid Hob

>From SysTableInfo Hob, get ACPI table address, and create gUniversalPayloadAcpiTableGuid Hob to store it. Remove directly adding ACPI table to ConfigurationTable. Dxe ACPI driver will parse it and install ACPI table from Guid Hob. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni Review

[edk2-devel] [Patch V5 8/9] MdeModulePkg/ACPI: Install ACPI table from HOB.

If HOB contains APCI table information, entry point of AcpiTableDxe.inf should parse the APCI table from HOB, and install these tables. We assume the whole ACPI table (starting with EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER) is contained by a single gEfiAcpiTableGuid HOB. If error happens when

[edk2-devel] [Patch V5 7/9] MdeModulePkg: Add new structure for the Universal Payload ACPI Table Hob

Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/AcpiTable.h | 30 ++ MdeModulePkg/MdeModulePkg.dec | 3 +++ 2 files changed, 33 inser

[edk2-devel] [Patch V5 6/9] UefiPayloadPkg: Create gUniversalPayloadSmbiosTableGuid Hob

>From SysTableInfo Hob, get Smbios table address, and create gUniversalPayloadSmbiosTableGuid Hob to store it. Remove directly adding smbios table to ConfigurationTable. Dxe module SmbiosDxe will parse it and install smbios table from it. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Reviewed-by

[edk2-devel] [Patch V5 5/9] MdeModulePkg/Universal/SmbiosDxe: Scan for existing tables

The default EfiSmbiosProtocol operates on an empty SMBIOS table. The SMBIOS tables are provided by the bootloader on UefiPayloadPkg. Scan for existing tables in SmbiosDxe and load them if they seem valid. This fixes the settings menu not showing any hardware information, instead only "0 MB RAM" was

[edk2-devel] [Patch V5 3/9] UefiPayloadPkg: UefiPayload retrieve PCI root bridge from Guid Hob

UefiPayload parse gUniversalPayloadPciRootBridgeInfoGuid Guid Hob to retrieve PCI root bridges information. gUniversalPayloadPciRootBridgeInfoGuid Guid Hob should be created by Bootloader. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Reviewed-by: Guo Dong Signed-off-by: Zhiguang Liu --- Uefi

[edk2-devel] [Patch V5 1/9] MdeModulePkg: Add Universal Payload general definition header file

Add Universal Payload general definition header file according to Universal Payload's documentation as below: https://universalpayload.github.io/documentation/ Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg

[edk2-devel] [Patch V5 0/9] Create multiple Hobs for Universal Payload

V1: This patch set is based on Universal Payload on https://universalpayload.github.io/documentation/payload-interfaces/index.html This patch set introduce one general header, three different hob types and how Universal Payload consume these hobs. V2: Move all the header files and Guid define to

[edk2-devel] [Patch V5 4/9] MdeModulePkg: Add new structure for the Universal Payload SMBios Table Hob

Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePkg/Include/UniversalPayload/SmbiosTable.h | 30 ++ MdeModulePkg/MdeModulePkg.dec | 6 ++ 2 files changed, 3

[edk2-devel] [Patch V5 2/9] MdeModulePkg: Add new structure for the PCI Root Bridge Info Hob

V5: Add ExceptionList in MdeModulePkg\MdeModulePkg.ci.yaml, to avoid open CI issue, because UID and HID are terms which are already used in current source code. Cc: Michael D Kinney Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Reviewed-by: Hao A Wu Signed-off-by: Zhiguang Liu --- MdeModulePk

Re: [edk2-devel] [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter.

Acked-by: Jian J Wang > -Original Message- > From: Kuo, Scottie > Sent: Tuesday, June 01, 2021 5:26 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Wang, Jian J > > Cc: Zhang, Qi1 ; Kumar, Rahul1 > ; Chu, Maggie > Subject: RE: [PATCH] SecurityPkg: TcgStorageOpalLib: Initialize > Supporte

回复: 回复: [edk2-devel] [PATCH v1 1/1] Pytool: SpellCheck: Fix incorrect file mask across package matrices

Create PR https://github.com/tianocore/edk2/pull/1713 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Kun Qin > 发送时间: 2021年6月12日 11:50 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Sean Brogan' ; 'Bret Barkelew' > ; 'Michael D Kinney' > > 主题: Re: 回复: [edk2-devel] [PATCH v1 1/1] Py