Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

Change pushed: 8cb431b46a0888a8ee8e442dc3ea50d7de79e473 107af998afe1a34c7b6aff5240abd9918e51b073 Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 2:33 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao >

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

Sounds good. -Original Message- From: Chiu, Chasel Sent: Thursday, July 08, 2021 11:32 PM To: Chaganty, Rangasai V ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Liming Gao ; Oram, Isaac W Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Hi Sa

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

Hi Sai, We will fix the build failure first and macro naming convention will be checked separately later. Thanks, Chasel > -Original Message- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Li

Re: [edk2-devel] [edk2-platforms PATCH 1/4] SolidRun/Armada80x0McBin: Add ACPI MDIO description

Tested-by: Grzegorz Bernacki regards, greg niedz., 13 cze 2021 o 20:17 Marcin Wojtas napisał(a): > > As the MDIO ACPI binding in DSDT is now established, > add description for the SMI and XSMI controllers, along > with the 10G and 1G PHYs. > > Signed-off-by: Marcin Wojtas > --- > Silicon/Mar

Re: [edk2-devel] [edk2-platforms PATCH 2/4] Marvell/Cn913xDb: Add ACPI MDIO description

Tested-by: Grzegorz Bernacki regards, greg niedz., 13 cze 2021 o 20:17 Marcin Wojtas napisał(a): > > As the MDIO ACPI binding in DSDT is now established, > add description for the SMI controller, along with the 1G PHYs. > Add also a missing 'managed' property to the 10G ports. > > Signed-off-by

Re: [edk2-devel] [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py

Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Thursday, July 8, 2021 11:49 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py Mergify adds merge com

回复: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

Reviewed-by: Liming Gao 发件人: devel@edk2.groups.io 代表 Michael D Kinney 发送时间: 2021年7月8日 10:40 收件人: Bret Barkelew ; devel@edk2.groups.io; Kinney, Michael D 抄送: Liming Gao ; Liu, Zhiguang 主题: Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

回复: [edk2-devel] [Patch 0/3] Mergify Enhancements

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年7月8日 11:49 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Liming Gao ; > Bob Feng ; Yuwei Chen > 主题: [edk2-devel] [Patch 0/3] Mergify Enhancements > > * Removed FINISHED a

[edk2-devel] [PATCH] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Cc: Ard Biesheuvel cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Cc: Jim Fehlig Signed-off-by: Gary Lin --- OvmfPkg/OvmfXen.dsc | 1 + OvmfPkg/OvmfX

Re: [edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.

Reviewed-by: Sai Chaganty -Original Message- From: Chiu, Chasel Sent: Thursday, July 08, 2021 7:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Liming Gao ; Oram, Isaac W Subject: [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail t

Re: [edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

In ServerManagment.h, please make sure the newly added macros and structure names are EFI/PI spec defined. If they are not, please remove "EFI_" prefix from the names. With that: Reviewed-by: Sai Chaganty -Original Message- From: Chiu, Chasel Sent: Thursday, July 08, 2021 7:41 AM To:

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 07/08/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 07/08/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-devel] [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines

Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Friday, July 9, 2021 3:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines * Update GetMaintainer.

回复: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2021年7月9日 1:57 > 收件人: Laszlo Ersek > 抄送: edk2-devel-groups-io ; Andrew Fish > ; Ard Biesheuvel ; Eric Dong > ; Jordan Justen ; Michael > D Kinney ; Philippe Mathieu-Daudé > ; Rahul Kumar ; Ray Ni > ; S

Re: [edk2-devel] [Patch V2 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings

Reviewed-by: Bob Feng -Original Message- From: Kinney, Michael D Sent: Friday, July 9, 2021 3:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [Patch V2 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings Cc: Bob Feng Cc: Liming Gao Cc: Y

回复: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes

Reviewed-by: Liming Gao 发件人: devel@edk2.groups.io 代表 Thotala, Gopi 发送时间: 2021年7月8日 23:35 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Rebecca Cran' 主题: Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes Liming, No platform changes required for this.

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC

Pushed as: https://github.com/tianocore/edk2-platforms/commit/35c8ba10fe00db810f83730b23b1538daa75efa7 Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 8, 2021 3:44 PM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, Michael D > > Cc: Chiu, C

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg: Add missing components to DSC

Michael, Reviewed-by: Michael D Kinney This has been waiting for a while, so I will go ahead and push. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Thursday, June 17, 2021 4:34 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone,

Re: [edk2-devel] Possible [BUG] PeiCore: HOBs after cache-as-RAM teardown

Hi Benjamin, Based on what you've described, I'll try to provide my best guess as to what is happening without actually debugging it. Ultimately, I will need to submit a patch to update PeiSerialPortLibSpiFlash. Are you're aware, gPchSpiPpiGuid is installed in Silicon/Intel/KabylakeSiliconPk

Re: [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt

Hi Sean, Maintainers.txt is a standard file format defined by TianoCore. Format is in file header. The intent is for the file format to be consumable by tools and developers. I reviewed CODEOWERS feature. It has limitations that do not match the EDK II development process. Mike > -Origi

Re: [edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt

Is Maintainers.txt a standard file used by standard tools or just a custom file for the GetMaintainer.py script? There is a similar idea used by github (and maybe others) called CODEOWNERS. See https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository

[edk2-devel] [Patch V2 0/3] Add GitHub IDs to Maintainers.txt

New in V2 = * Maintainers.txt updates * Remove content after email address from standard output * Fix --lookup compatibility with '\' path separators. Update GetMaintainer.py to allow a GitHub ID after the email address for maintainers and reviewers and update Maitainers.txt with GitHub ID

[edk2-devel] [Patch V2 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings

Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 380 ++--- 1 file changed, 190 insertions(+), 190 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py inde

[edk2-devel] [Patch V2 3/3] Maintainers.txt: Add GitHub IDs

Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- Maintainers.txt | 282 1 file changed, 139 insertions(+), 143 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index f4e4c72d0628..575a80be5e89 10

[edk2-devel] [Patch V2 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines

* Update GetMaintainer.py to support an optional GitHub ID at the end of maintainer and reviewer lines. * Remove contents after email address from standard output * Fix minor issue in --lookup to convert file path separators from '\' to '/' to be compatible with regular expression file matchi

Re: [edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: Enable default Secure Boot variables initialization

Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Grzegorz Bernacki > Sent: Tuesday, June 1, 2021 9:12 AM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; m...@semihalf.com; upstr...@semihalf.com; > jiewen

Re: [edk2-devel] [edk2-platforms PATCH v2 2/2] Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"

Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Grzegorz Bernacki > Sent: Tuesday, July 6, 2021 6:45 AM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; m...@semihalf.com; upstr...@semihalf.com; > p...@a

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

On Thu, Jul 08, 2021 at 09:09:16 +0200, Laszlo Ersek wrote: > I'm relinquishing all my roles listed in "Maintainers.txt", for personal > reasons. > > My email address remains functional. > > To my understanding, my employer is working to assign others engineers to > the edk2 project (at their di

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

Reviewed-by: Andrew Fish > On Jul 8, 2021, at 9:40 AM, Michael D Kinney > wrote: > > Reviewed-by: Michael D Kinney > > >> -Original Message- >> From: Laszlo Ersek >> Sent: Thursday, July 8, 2021 12:09 AM >> To: edk2-devel-groups-io >> Cc: Andrew Fish ; Ard Biesheuvel >> ; Dong, E

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

I shall pour out a cup of bits in your honor! Your diligence will be missed. - Bret From: Michael D Kinney via groups.io Sent: Thursday, July 8, 2021 9:42 AM To: Laszlo Ersek; edk2-devel-groups-io

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

Reviewed-by: Michael D Kinney > -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 8, 2021 12:09 AM > To: edk2-devel-groups-io > Cc: Andrew Fish ; Ard Biesheuvel > ; Dong, Eric ; Justen, > Jordan L ; Leif Lindholm ; > Kinney, Michael D ; > Philippe Mathieu-Daudé ; Kumar,

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 07/08/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 07/08/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT TZNAME:

Re: [edk2-devel] [PATCH] MdePkg/Include: Smbios Specification 3.4.0 changes

Liming, No platform changes required for this. Commit message is highlighted with the changes. Attached the V3 patch here. Thanks Gopi From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Sunday, June 20, 2021 6:11 PM To: Thotala, Gopi ; devel@edk2.groups.io; 'Rebecca Cran' Subject: 回复:

Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

Hi Ben, Yes. That was an oversight when I update to the latest version of Maintainers.txt. I will send a V2. Mike > -Original Message- > From: You, Benjamin > Sent: Thursday, July 8, 2021 1:39 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Andrew Fish ; Laszlo Ersek ; Leif >

Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

> -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 8, 2021 12:47 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Andrew Fish ; Leif Lindholm > Subject: Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs > > Hi Mike, > > On 07/08/21 05:46, Michael D Kinney

[edk2-devel] [edk2-platforms: PATCH 0/2] Fail to build Intel/AdvancedFeaturePkg.

AdvancedFeaturePkg building failure caused by IpmiFeaturePkg code. This patch series fixed the issue. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu Chasel Chiu (2): IpmiFeaturePkg: Fail to build this package. AdvancedFeaturePkg: Fail to build

[edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +-- 1 file change

[edk2-devel] [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + Fe

[edk2-devel] [PATCH v5 4/4] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

From: Ashish Kalra Check for SEV live migration feature support, if detected setup a new UEFI enviroment variable to indicate OVMF support for SEV live migration. The new runtime UEFI environment variable is set via the notification function registered for the EFI_END_OF_DXE_EVENT_GROUP_GUID eve

[edk2-devel] [PATCH v5 3/4] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

From: Ashish Kalra Mark the SEC GHCB page (that is mapped as unencrypted in ResetVector code) in the hypervisor page status tracking. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- OvmfPkg/PlatformPei/AmdSev.c | 9 + 1 file changed, 9 insertion

[edk2-devel] [PATCH v5 2/4] OvmfPkg/VmgExitLib: Add support for hypercalls with SEV-ES.

From: Ashish Kalra Make the VC handler hypercall aware by adding support to compare the hypercall number and add the additional register values used by hypercall in the GHCB. Also mark the SEC GHCB page (that is mapped as unencrypted in ResetVector code) in the hypervisor guest page status track

[edk2-devel] [PATCH v5 1/4] OvmfPkg/BaseMemEncryptLib: Support to issue unencrypted hypercall

From: Ashish Kalra By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the unencrypted pages. The information will be used during guest li

[edk2-devel] [PATCH v5 0/4] SEV Live Migration support for OVMF.

From: Ashish Kalra BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3467 By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the unencr

[edk2-devel] [PATCH] IntelSiliconPkg/Include/IndustryStandard: Add IgdOpRegion30.h to support IGD Opregion spec version 3.0

From: Digant H Solanki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are obsoleted in MBOX3. Sign

Re: [edk2-devel] [PATCH v4 2/3] Acpi: Install Acpi tables for Cloud hypervisor

Merged as 4c051c2c65a8..0e3b6bd0ee75 Thanks. Regards, Sami Mujawar On 07/07/2021, 02:43, "Jianyong Wu" wrote: Hi Sami, Thanks for your rework on my patch. I tried the change and it works well. You can do what you like on the patch set. Thanks Jianyong > -Original

Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

Hi Mike, On > -R: Benjamin You and > +M: Benjamin You [BenjaminYou] Could you please change "M" to "R"? I am no longer a maintainer for UEFIPayload package. Thanks! - ben > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Thursday, July 8, 202

Re: [edk2-devel] [edk2-platforms PATCH v2 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

See below comments. > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Grzegorz Bernacki > Sent: Tuesday, July 6, 2021 6:45 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.co

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

See below comments. > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Grzegorz Bernacki > Sent: Tuesday, July 6, 2021 6:45 PM > To: devel@edk2.groups.io > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- > mahm...@arm.com; sunny.w...@arm.com; m...@semihalf.co

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

On 7/8/21 9:09 AM, Laszlo Ersek wrote: > I'm relinquishing all my roles listed in "Maintainers.txt", for personal > reasons. > > My email address remains functional. > > To my understanding, my employer is working to assign others engineers to > the edk2 project (at their discretion). > > Cc: A

Re: [edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

Hi Mike, On 07/08/21 05:46, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 286 > 1 file changed, 143 insertions(+), 143 deletions(-) > > diff --git

[edk2-devel] [PATCH] Maintainers.txt: remove Laszlo Ersek's entries

I'm relinquishing all my roles listed in "Maintainers.txt", for personal reasons. My email address remains functional. To my understanding, my employer is working to assign others engineers to the edk2 project (at their discretion). Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Eric Dong Cc: Jordan