Re: [edk2-devel] [edk2-platforms PATCH v5 0/2] Add BootDiscoveryPolicyUiLib

2021-08-02 Thread Ard Biesheuvel
On Mon, 2 Aug 2021 at 14:18, Grzegorz Bernacki wrote: > > This patchset extends Boot Maintenance Menu and allows to select > Boot Discovery Policy. Raspberry Pi platforms uses the variable to > connect specified class of devices on boot. This patchset also > removes efdc159e which has similar

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Wu, Hao A
Thanks all, Patch merged via: PR - https://github.com/tianocore/edk2/pull/1858 Commit - https://github.com/tianocore/edk2/commit/2b47aaecef38b9440a65809cbdaf9d97029f4eeb Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunny > Wang > Sent: Tuesday,

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Gao, Zhichao
No. Please keep my 'R-b' for v5. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, August 3, 2021 8:01 AM > To: devel@edk2.groups.io; g...@semihalf.com; Gao, Zhichao > ; sunny.w...@arm.com > Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer.El-Haj- >

[edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

2021-08-02 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

[edk2-devel] [PATCH V4 2/3] OvmfPkg/Sec: Update the check logic in SevEsIsEnabled

2021-08-02 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero. It is correct when SevEsWorkArea is only used by SEV. After Intel TDX is enabled in Ovmf, the SevEsWorkArea is shared by TDX and SEV. (This is to avoid the waist of

[edk2-devel] [PATCH V4 1/3] OvmfPkg: Add Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-08-02 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx Virtual Firmware (TDVF) includes one Firmware Volume (FV) known as the Boot Firmware Volume (BFV). The FV format is defined in the UEFI Platform Initialization (PI) spec. BFV includes all TDVF components required during boot. TDVF also

[edk2-devel] [PATCH V4 0/3] Add Intel TDX support in OvmfPkg/ResetVector

2021-08-02 Thread Min Xu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

[edk2-devel] [edk2-platforms][PATCH v5 02/46] WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Removes extra IntelSiliconPkg.dec entry in PeiPolicyUpdateLib.inf. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Sai Chaganty ---

[edk2-devel] [edk2-platforms][PATCH v5 27/46] MinPlatformPkg: Remove SpiFvbService modules

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 SpiFvbServiceSmm and SpiFvbServiceStandaloneMm have moved to IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH v5 03/46] CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 gEfiMemoryTypeInformationGuid is used in PeiSaPolicyUpdatePreMem.c but not in the [Guids] section in PeiPolicyUpdateLib.inf. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc:

[edk2-devel] [edk2-platforms][PATCH v5 26/46] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the boards in the package to use SpiFvbServicesSmm from IntelSiliconPkg since the MinPlatformPkg driver was moved there. Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH v5 04/46] IntelSiliconPkg: Add BIOS area base address and size PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries and modules in IntelSiliconPkg to be able to use this PCD.

[edk2-devel] [edk2-platforms][PATCH v5 08/46] IntelSiliconPkg: Add SpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the SpiFlashCommonLib interface to IntelSiliconPkg. The initial library instance added in this change is the NULL instance. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate

[edk2-devel] [edk2-platforms][PATCH v5 13/46] SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Agyeman Prince Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone ---

[edk2-devel] [edk2-platforms][PATCH v5 12/46] KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller Signed-off-by: Michael Kubacki Reviewed-by: Nate

[edk2-devel] [edk2-platforms][PATCH v5 07/46] IntelSiliconPkg: Add PCH SPI Protocol

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 These SPI Protocol definitions are intended to serve as the single definitions for Intel platform and silicon packages. 1. gPchSpiProtocolGuid 2. gPchSmmSpiProtocolGuid Cc: Ray Ni Cc: Rangasai V Chaganty

[edk2-devel] [edk2-platforms][PATCH v5 14/46] TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki Reviewed-by: Nate

[edk2-devel] [edk2-platforms][PATCH v5 37/46] SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 gEfiSmmSpiProtocolGuid is now declared in IntelSiliconPkg.dec. This change updates Ich10Pkg to remove the protocol declaration in the package and update libraries and modules to use the protocol from IntelSiliconPkg.

[edk2-devel] [edk2-platforms][PATCH v5 38/46] TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The following PPI and Protocols have moved to IntelSiliconPkg. The remaining definitions in TigerlakeSiliconPkg are removed and libs/ modules that need to reference IntelSiliconPkg are updated. 1. gPchSpiProtocolGuid

[edk2-devel] [edk2-platforms][PATCH v5 35/46] CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The following PPI and Protocols have moved to IntelSiliconPkg. The remaining definitions in CoffeelakeSiliconPkg are removed and libs/ modules that need to reference IntelSiliconPkg are updated. 1.

[edk2-devel] [edk2-platforms][PATCH v5 25/46] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the boards in the package to use SpiFvbServicesSmm from IntelSiliconPkg since the MinPlatformPkg driver was moved there. Cc: Nate DeSimone Cc: Chasel

[edk2-devel] [edk2-platforms][PATCH v5 34/46] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This library now uses gPchSpiPpiGuid from IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Chasel Chiu ---

[edk2-devel] [edk2-platforms][PATCH v5 29/46] KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The library has been consolidated with instances in other Intel silicon packages as a single instance in IntelSiliconPkg Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH v5 40/46] IntelSiliconPkg: Identify flash regions by GUID

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the SPI protocol to identify flash regions by GUID instead of fixed values defined in an enum. Packages consuming IntelSiliconPkg are able to associate a given GUID with their chosen values based on their SPI

[edk2-devel] [edk2-platforms][PATCH v5 19/46] TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Removes the PCDs from SiPkg.dec since they are defined in IntelSiliconPkg.dec. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone ---

[edk2-devel] [edk2-platforms][PATCH v5 24/46] WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates WhiskeylakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-platforms][PATCH v5 41/46] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the library to identify flash regions by GUID and internally map the GUID entries to values specific to CoffeelakeSiliconPkg. Cc: Chasel Chiu Cc: Rangasai V Chaganty Cc: Nate DeSimone Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH v5 33/46] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the header file to PurleyOpenBoardPkg since it was removed from MinPlatformPkg. Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Michael Kubacki ---

[edk2-devel] [edk2-platforms][PATCH v5 42/46] KabylakeSiliconPkg: Identify flash regions by GUID

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the code to identify flash regions by GUID and internally map the GUID entries to values specific to KabylakeSiliconPkg. Cc: Chasel Chiu Cc: Rangasai V Chaganty Cc: Nate DeSimone Signed-off-by: Michael

[edk2-devel] [edk2-platforms][PATCH v5 20/46] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates CometlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika

[edk2-devel] [edk2-platforms][PATCH v5 28/46] CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The library has been consolidated with instances in other Intel silicon packages as a single instance in IntelSiliconPkg. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu

[edk2-devel] [edk2-platforms][PATCH v5 45/46] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the library to identify flash regions by GUID and internally map the GUID entries to values specific to SimicsIch10Pkg. Cc: Agyeman Prince Cc: Nate DeSimone Signed-off-by: Michael Kubacki Reviewed-by: Nate

[edk2-devel] [edk2-platforms][PATCH v5 46/46] TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates the library to identify flash regions by GUID and internally map the GUID entries to values specific to TigerlakeSiliconPkg. Cc: Rangasai V Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael

[edk2-devel] [edk2-platforms][PATCH v5 09/46] IntelSiliconPkg: Add SmmSpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the SMM instance of SpiFlashCommonLib. The code is based on refactoring existing library instances into a consolidated version with no functional impact. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH v5 36/46] KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The following PPI and Protocols have moved to IntelSiliconPkg. The remaining definitions in KabylakeSiliconPkg are removed and libs modules that need to reference IntelSiliconPkg are updated. 1. gPchSpiProtocolGuid

[edk2-devel] [edk2-platforms][PATCH v5 17/46] KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH v5 39/46] IntelSiliconPkg: Add flash region GUIDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This change identifies flash regions by GUID instead of fixed values since the flash region identifiers are now defined in IntelSiliconPkg and different boards may want to associate a flash region identifier with a

[edk2-devel] [edk2-platforms][PATCH v5 44/46] KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortlibSpiFlash to build

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This library is part of KabylakeOpenBoardPkg but is currently not built anywhere. This change adds the library to the KabylakeRvp3 build to ensure it can always build properly if not linked elsewhere. Cc: Chasel Chiu

[edk2-devel] [edk2-platforms][PATCH v5 31/46] TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The library has been consolidated with instances in other Intel silicon packages as a single instance in IntelSiliconPkg Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki Reviewed-by:

[edk2-devel] [edk2-platforms][PATCH v5 01/46] CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Removes extra IntelSiliconPkg.dec entry in PeiPolicyUpdateLib.inf. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-platforms][PATCH v5 21/46] KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates KabylakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller Signed-off-by:

[edk2-devel] [edk2-platforms][PATCH v5 22/46] SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates SimicsOpenBoardPkg to use the SmmSpiFlashCommonLib instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Agyeman Prince Signed-off-by: Michael Kubacki Reviewed-by: Nate

[edk2-devel] [edk2-platforms][PATCH v5 18/46] SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. The previous PCDs are removed from Ich10Pkg.dec. Cc: Agyeman Prince Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-platforms][PATCH v5 16/46] CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the PCDs are declared in IntelSiliconPkg.dec. The previous PCDs are removed from CoffeelakeSiliconPkg.dec. Cc: Chasel Chiu Cc: Sai Chaganty

[edk2-devel] [edk2-platforms][PATCH v5 05/46] IntelSiliconPkg: Add microcode FV PCDs

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the following PCDs to IntelSiliconPkg.dec to consolidate the PCD to a single silicon declaration file. This allows libraries modules in IntelSiliconPkg to be able to use this PCD.

[edk2-devel] [edk2-platforms][PATCH v5 06/46] IntelSiliconPkg: Add PCH SPI PPI

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This SPI PPI definition is intended to serve as the single definition for Intel platform and silicon packages. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone

[edk2-devel] [edk2-platforms][PATCH v5 30/46] SimicsIch10Pkg: Remove SmmSpiFlashCommonLib

2021-08-02 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 The library has been consolidated with instances in other Intel silicon packages as a single instance in IntelSiliconPkg Cc: Agyeman Prince Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone ---

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Sunny Wang
Ditto. v5 looks good to me as well, so keep my 'R-b' for v5. Thanks for helping on this, Hao. :) Best Regards, Sunny Wang -Original Message- From: Gao, Zhichao Sent: Tuesday, August 3, 2021 10:25 AM To: Wu, Hao A ; devel@edk2.groups.io; g...@semihalf.com; Sunny Wang Cc:

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/03/2021 #cal-reminder

2021-08-02 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-08-02 Thread Wu, Hao A
Sorry Zhichao and Ray, Could you help to review this patch? Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: Caden Kline > Sent: Friday, July 30, 2021 10:45 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Zhichao ; Ni, Ray > Subject: [PATCH

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Wu, Hao A
Thanks Greg, the new patch pass all the merging tests: https://github.com/tianocore/edk2/pull/1858. Hello Zhichao and Sunny Wang, Do you have comments for this new version of the patch? If not, I will keep your 'R-b' tags from V4. Thanks in advance. Best Regards, Hao Wu > -Original

Re: [edk2-devel] [edk2-discuss] State of the `edk2-libc` project

2021-08-02 Thread Rebecca Cran
By the lack of replies, I suspect we should bring it up as a topic of discussion in the Community Meeting next week. -- Rebecca Cran On 7/14/21 1:43 PM, Rebecca Cran wrote: I submitted a patch to fix it several weeks ago, but it never got committed. Rebecca Cran On Jul 14, 2021, at 11:36

Re: [edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

2021-08-02 Thread Andrew Fish via groups.io
> On Aug 1, 2021, at 7:35 PM, Ni, Ray wrote: > > I also vote "using HOB passing policy". This design helps the new > bootloader/payload architecture. > > EDKII library class design was a good design which mimics C++ class to > provide same interface for: > 1. different phases (PEI, DXE,

Re: [edk2-devel] [edk2-platforms][PATCH v4 00/41] Consolidate SpiFlashCommonLib instances

2021-08-02 Thread Michael Kubacki
Hi Nate, Does BoardMtOlympus in edk2-platforms/master build for you? It looks like some additional microcode patches were added and the microcode FV was not expanded. Generating MICROCODE_FV FV Return Value = 2 GenFv: ERROR 3000: Invalid the required fv image size 0x22460 exceeds

Re: [edk2-devel] ArmVirt and Self-Updating Code

2021-08-02 Thread Andrew Fish via groups.io
> On Aug 1, 2021, at 2:40 PM, Marvin Häuser wrote: > > 01.08.2021 18:33:47 Ard Biesheuvel : > >> On Sat, 31 Jul 2021 at 21:08, Marvin Häuser wrote: >>> On 23.07.21 16:34, Ard Biesheuvel wrote: On Fri, 23 Jul 2021 at 16:27, Marvin Häuser wrote: > On 23.07.21 16:09, Ard Biesheuvel

Re: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8kPciHostBridgeLib: Remove ECAM base limitation

2021-08-02 Thread Marcin Wojtas
Hi Ard, pon., 2 sie 2021 o 10:43 Ard Biesheuvel napisał(a): > > On Mon, 2 Aug 2021 at 07:01, Marcin Wojtas wrote: > > > > On CN913x-based platforms it is possible to have up to 9 PCIE > > root complexes. In such case it may be necessary to configure > > more configuration spaces with smaller

Re: [edk2-devel] [PATCH v2 1/4] ArmPlatformPkg: Allow dynamic generation of HEST ACPI table

2021-08-02 Thread Sami Mujawar
Hi Omkar, Please find my response marked inline as [SAMI]. Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Introduce the HEST table generation protocol that allows platforms to build the table with multiple error source descriptors and install the table. The

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

2021-08-02 Thread Sami Mujawar
Hi Omkar, Thank you for this patch series and for the clear explaination below. The explaination below is very useful for anyone who is trying to understand the code. Since the cover letter will not be part of the patch commit messages, would it be possible to include this explanation: 1.

[edk2-devel] [PATCH v6 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Check for SEV live migration feature support, if detected setup a new UEFI enviroment variable to indicate OVMF support for SEV live migration. The new runtime UEFI environment variable is set via the notification function registered for the EFI_END_OF_DXE_EVENT_GROUP_GUID

[edk2-devel] [PATCH v6 5/6] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Mark the SEC GHCB page (that is mapped as unencrypted in ResetVector code) in the hypervisor's guest page encryption state tracking. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- OvmfPkg/PlatformPei/AmdSev.c | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v6 4/6] OvmfPkg/VmgExitLib: Encryption state change hypercall support in VC handler

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Make the #VC handler aware of the page encryption state change hypercall by adding support to check KVM_HC_MAP_GPA_RANGE hypercall and add the additional register values used by hypercall in the GHCB. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra ---

[edk2-devel] [PATCH v6 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Invoke the hypercall API to notify hypervisor when the page's encryption state changes. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Brijesh Singh Signed-off-by: Ashish Kalra --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c | 20

[edk2-devel] [PATCH v6 2/6] OvmfPkg/BaseMemEncryptLib: Hypercall API for page encryption state change

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Add API to issue hypercall on page encryption state change. By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the

[edk2-devel] [PATCH v6 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra Add support to check if we are running inside KVM HVM and KVM HVM supports SEV Live Migration feature. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- OvmfPkg/Include/Library/MemEncryptSevLib.h| 27 ++

[edk2-devel] [PATCH v6 0/6] SEV Live Migration support for OVMF.

2021-08-02 Thread Ashish Kalra via groups.io
From: Ashish Kalra BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3467 By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the

[edk2-devel] [edk2-platforms PATCH v5 2/2] Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"

2021-08-02 Thread Grzegorz Bernacki
This reverts commit efdc159ef7c9f15581a0f63d755a1530ff475156. This commit is not longer required as Boot Discovery Policy has been implemented for RPi. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RaspberryPi.dec

[edk2-devel] [edk2-platforms PATCH v5 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

2021-08-02 Thread Grzegorz Bernacki
This commit modify platform boot to check the value of BootDiscoveryPolicy variable and use BootPolicyManager Protocol to connect devices specified by the variable. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RPi4/RPi4.dsc

[edk2-devel] [PATCH v5 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Grzegorz Bernacki
This library extends Boot Maintenance Menu and allows to select Boot Discovery Policy. When choice is made BootDiscoveryPolicy variable is set. Platform code can use this variable to decide which class of device shall be connected. Signed-off-by: Grzegorz Bernacki Reviewed-by: Zhichao Gao ---

[edk2-devel] [edk2-platforms PATCH v5 0/2] Add BootDiscoveryPolicyUiLib

2021-08-02 Thread Grzegorz Bernacki
This patchset extends Boot Maintenance Menu and allows to select Boot Discovery Policy. Raspberry Pi platforms uses the variable to connect specified class of devices on boot. This patchset also removes efdc159e which has similar functionality. Discussion on design can be found at:

[edk2-devel] [PATCH v8 11/11] SecurityPkg: Add option to reset secure boot keys.

2021-08-02 Thread Grzegorz Bernacki
This commit add option which allows reset content of Secure Boot keys and databases to default variables. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 ---

[edk2-devel] [PATCH v8 10/11] SecurityPkg: Add new modules to Security package.

2021-08-02 Thread Grzegorz Bernacki
This commits adds modules and dependencies related to initialization and usage of default Secure Boot key variables to SecurityPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi 4 ---

[edk2-devel] [PATCH v8 09/11] SecurityPkg: Add EnrollFromDefaultKeys application.

2021-08-02 Thread Grzegorz Bernacki
This application allows user to force key enrollment from Secure Boot default variables. Signed-off-by: Grzegorz Bernacki Reviewed-by: Jiewen Yao Reviewed-by: Sunny Wang --- SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.inf | 48

[edk2-devel] [PATCH v8 08/11] SecurityPkg: Add SecureBootDefaultKeysDxe driver

2021-08-02 Thread Grzegorz Bernacki
This driver initializes default Secure Boot keys and databases based on keys embedded in flash. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Pete Batard Tested-by: Pete Batard on Raspberry Pi Reviewed-by: Jiewen Yao ---

[edk2-devel] [PATCH v8 07/11] ArmPlatformPkg: Create include file for default key content.

2021-08-02 Thread Grzegorz Bernacki
This commits add file which can be included by platform Flash Description File. It allows to specify certificate files, which will be embedded into binary file. The content of these files can be used to initialize Secure Boot default keys and databases. Signed-off-by: Grzegorz Bernacki

[edk2-devel] [PATCH v8 06/11] SecurityPkg: Remove duplicated functions from SecureBootConfigDxe.

2021-08-02 Thread Grzegorz Bernacki
This commit removes functions which were added to SecureBootVariableLib. It also adds dependecy on that library. Signed-off-by: Grzegorz Bernacki Reviewed-by: Jiewen Yao eviewed-by: Sunny Wang --- SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf | 2 +

[edk2-devel] [PATCH v8 05/11] EmulatorPkg: add SecureBootVariableLib class resolution

2021-08-02 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for EmulatorPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang

[edk2-devel] [PATCH v8 04/11] OvmfPkg: add SecureBootVariableLib class resolution

2021-08-02 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for OvmfPkg. Signed-off-by: Grzegorz Bernacki Reviewed-by: Laszlo Ersek

[edk2-devel] [PATCH v8 03/11] ArmVirtPkg: add SecureBootVariableLib class resolution

2021-08-02 Thread Grzegorz Bernacki
The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for ArmVirtPkg platform. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny

[edk2-devel] [PATCH v8 02/11] SecurityPkg: Create library for enrolling Secure Boot variables.

2021-08-02 Thread Grzegorz Bernacki
This commits add library, which consist functions to enrolll Secure Boot keys and initialize Secure Boot default variables. Some of the functions was moved from SecureBootConfigImpl.c file. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao ---

[edk2-devel] [PATCH v8 01/11] SecurityPkg: Create SecureBootVariableLib.

2021-08-02 Thread Grzegorz Bernacki
This commits add library, which consist helper functions related to creation/removal Secure Boot variables. Some of the functions was moved from SecureBootConfigImpl.c file. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang Reviewed-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec

[edk2-devel] [PATCH v8 00/11] Secure Boot default keys

2021-08-02 Thread Grzegorz Bernacki
This patchset adds support for initialization of default Secure Boot variables based on keys content embedded in flash binary. This feature is active only if Secure Boot is enabled and DEFAULT_KEY is defined. The patchset consist also application to enroll keys from default variables and secure

Re: [edk2-devel] [edk2-platforms PATCH 3/6] Marvell: Armada7k8kPciHostBridgeLib: Remove ECAM base limitation

2021-08-02 Thread Ard Biesheuvel
On Mon, 2 Aug 2021 at 07:01, Marcin Wojtas wrote: > > On CN913x-based platforms it is possible to have up to 9 PCIE > root complexes. In such case it may be necessary to configure > more configuration spaces with smaller bus count, so that > to fit the memory layout constraints. For that purpose

Re: [edk2-devel] 回复: [PATCH v7 00/11] Secure Boot default keys

2021-08-02 Thread Ard Biesheuvel
On Mon, 2 Aug 2021 at 09:27, Grzegorz Bernacki wrote: > > Hi, > > I took the template for function header from: > https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming > (5.7.1.10) > It is incorrect? Where I can found the correct one? > I run CI test

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array

2021-08-02 Thread Jason Lou
Hi Ray, According to the definitions in SDM, the value of "Core" core type(40H) is larger than that of "Atom" core type(20H), if array is sorted by core type value from largest to smallest, “Core” CPU cache info can be placed before "Atom" CPU cache info in the CpuCacheInfo array. No matter

Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

2021-08-02 Thread Grzegorz Bernacki
Hi, Sure, I will send a new version of the patches soon. thanks, greg pon., 2 sie 2021 o 07:22 Wu, Hao A napisał(a): > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Wu, Hao > > A > > Sent: Monday, August 2, 2021 12:36 PM > > To: Sunny Wang ; Gao, Zhichao > > ;

Re: [edk2-devel] 回复: [PATCH v7 00/11] Secure Boot default keys

2021-08-02 Thread Grzegorz Bernacki
Hi, I took the template for function header from: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/57_c_programming (5.7.1.10) It is incorrect? Where I can found the correct one? I run CI test locally and it did not show that kind of errors. Anyway, I will send

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuCacheInfoLib: Sort CpuCacheInfo array

2021-08-02 Thread Ni, Ray
+ Get CpuCacheInfo data array. The data array is sorted by CPU package ID from smallest to largest, + by core type from largest to smallest and by cache level from smallest to largest. Why is core type sorted from largest to smallest but the other twos are sorted from smallest to largest?