This patch doesn't change the default behavior.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Zhiguang Liu
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
2 files changed, 6 insertions(+)
diff --git a/UefiPayloadPkg/UefiPay
Change the default value of the below PCDs to diable some legacy feature.
gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE
gUefiCpuPkgTokenSpaceGuid.PcdCpuNumberOfReservedVariableMtrrs|0
Cc: Guo Dong
Cc: Ray N
Define some PCDs as DynamicEX PCD to be used as global variable.
Because PcdUartDefaultBaudRate is defined as DynamicEX, remove the code
to set it in platformlib. That code was actually redundant.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Zhiguang Liu
---
UefiPa
Add the three PCDs as fixed at build PCD:
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxSizeNonPopulateCapsule
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister
gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister
The default value is defined as Macro, so it can be passed in at build
command.
Cc: Guo D
For Qemu sbsa-ref platforms,to enable detection of GICv3 Interrupt
Translation Service capability in the ACPI MADT,the GIC ITS structure
is created with the relevant values for each of its fields.The
existing MADT functionality is extended to include GIC ITS structure
presence as well.
Cc: Leif Li
Define new pcd setting for specifying the base address of GICv3
Interrupt Translation Service.For Qemu sbsa-ref platforms,this
enables the detection of GIC ITS capability within the GIC ITS
structure of ACPI MADT.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Graeme Gregory
Signed-off-by: Shashi Mal
This patchset implements ACPI MADT functionality extension to include
the GICv3 ITS functionality. This enables devices to use message
signalled LPI interrupts in addition to SPIs,PPIs supported on ARM
SBSA reference qemu platforms.
Shashi Mallela (2):
Platform/Qemu/SbsaQemu/SbsaQemu.dsc: defin
Hi Ray,
I think for now it will not cause any issue when standalone mm is launched.
As the functionality of collecting StandaloneMm performance data itself is
missing in Edk2.
So, it's ok to remove the related logic in FirmwarePerformanceStandaloneMm.inf
now.
But later if we want to collect th
Reviewed-by: Chasel Chiu
Tested-by: Benjamin Doron
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, August 3, 2021 10:39 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH v5 43/46]
> KabylakeOpenBoar
Reviewed-by: Chasel Chiu
Tested-by: Benjamin Doron
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, August 3, 2021 10:39 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH v5 44/46]
> KabylakeOpenBoar
Reviewed-by: Chasel Chiu
Tested-by: Benjamin Doron
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, August 3, 2021 11:01 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH v5 43/46]
> KabylakeOpenBoar
Reviewed-by: Chasel Chiu
Tested-by: Benjamin Doron
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, August 3, 2021 11:01 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: [edk2-platforms][PATCH v5 43/46]
> KabylakeOpenBoa
Hi Kun,
Thank you for the information.
Yes, the idea is to centralize the SMM performance report collection job to
SmmCorePerformanceLib, and DxeCorePerformanceLib could communicate with
SmmCorePerformanceLib for all SMM performance data rather than through
FirmwarePerformance**Mm driver.
But
1. I see lots of coding style changes in the patch. Can you please separate
these changes that don't impact functionality in a standalone patch?
> +CpuIdMapPtr->AcpiProcessorId =
> ((UINT32)ProcessorInfoBuffer.Location.Package * (UINT32)mNumberOfCpus * 2) +
> Index;
2. Per ACPI spec, t
It looks like a good topic to discuss in TianoCore Open Design meeting😊
Question to Dandan's proposal: Does it cause any conflict (or help) when
standalone mm is launched from PEI?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kun Qin
> Sent: Friday, August
Thanks for the feedback, I addressed it in a v2 series:
https://edk2.groups.io/g/devel/message/78767
Regards,
Michael
On 8/5/2021 7:14 PM, Nate DeSimone wrote:
Hi Michael,
Here is a summary of my feedback:
1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have a
Z
From: Michael Kubacki
Makes the OutTable parameter in DumpAcpiRsdt() and DumpAcpiXsdt()
optional since the pointer passed can be NULL if the Signature
pointer is also NULL.
Can fix a potential failure in TestPointCheckAcpi().
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Si
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521
The current logic depends on a particular order in which the
descriptors for three or more regions are placed in the array to
perform proper adjacency checking. When three or more regions are
all adjacent, but neighbor
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520
TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index
to skip the test. It should use byte 6 instead of byte 5.
Also defines a macro "TEST_POINT_INDEX_BYTE6_SMM" for the byte index
6 value.
Cc: Chasel Ch
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518
Per the protocol definition, the caller must allocate the input
structure and set the size field. TestPointCheckTcgTrustedBoot()
does not do this which can result in an EFI_BUFFER_TOO_SMALL error.
Cc: Chasel Chiu
Cc:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531
The MessageLength field of EFI_MM_COMMUNICATE_HEADER as defined in
MdePkg/Include/Protocol/MmCommunication.h was updated to a fixed
size as opposed to UINTN to avoid ambiguity between different
caller enviornments.
Th
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521
This patch series groups together several bug fixe
Thanks for your update. Reviewed-by: Liming Gao
If no other comments, I will merge this patch set for 202108 stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chris Jones
> 发送时间: 2021年8月6日 0:25
> 收件人: devel@edk2.groups.io
> 抄送: Sami Mujawar ; Akanksha Jain
> ; Ben Adder
Hi Michael,
I have not tried actually. Now that TiogaPass has been merged upstream we have
not been focusing on Mt. Olympus. I believe the original code was pair
programmed by Mallik and Jiewen and neither of them seem to be interested in
continuing maintenance of it. We are planning on depreca
Caden,
Please make sure you test this patch thoroughly. With that...
Reviewed-by: Nate DeSimone
Thanks!
Nate
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Caden
> Kline
> Sent: Thursday, July 29, 2021 7:45 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
>
Reviewed-by: Nate DeSimone
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Thursday, August 5, 2021 7:57 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [edk2-devel] [edk2-platform
Reviewed-by: Nate DeSimone
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Thursday, August 5, 2021 7:57 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [edk2-devel] [edk2-platform
Reviewed-by: Nate DeSimone
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, August 5, 2021 7:57 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1 1/5]
> MinPlatformPkg/Te
Hi Michael,
Comments are inline.
Thanks,
Nate
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, August 5, 2021 7:57 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1 2/5]
Hi Michael,
Here is a summary of my feedback:
1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have
a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability)) before
setting the size.
2. Patch 3/5: SmmTestPointCheckLib.c: line 112 - I think we should have
Hi Michael,
Comments are inline.
Thanks,
Nate
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, August 5, 2021 7:57 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Liming Gao
> ; Dong, Eric
> Subject: [edk2-platforms][PATCH v1 3/5]
Hi Mike,
Thanks for the helpful pointers. I'll consider everything for V2,
which I'll submit as soon as possible (hopefully tomorrow).
RE: Code style. I'll re-run ECC and try to solve the issues. One thing
though: Is it possible to make an exception for the naming of
ext4-specific struct members?
Hi Dandan,
Thanks for letting me know. I added Bret and Sean to the thread for
broader view in our scope.
But currently our StandaloneMm Core does not report performance data to
FirmwarePerformanceStandaloneMm module.
Is the idea to centralize the performance report collection job to
SmmCo
Hi Tung Lun,
Is this patch still needed or was it superseded by
https://edk2.groups.io/g/devel/message/75168 ?
Thanks,
Nate
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tung Lun
Sent: Thursday, April 1, 2021 7:32 PM
To: devel@edk2.groups.io
Cc: Loo, Tung Lun
Subject: [ed
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
While build the initial page table, the SetCr3ForPageTables64 checks
whether SEV-ES is enabled. If so, clear the page encryption mask from the
GHCB page. Move the logic to clear the page encryption mask in the
AmdSev.asm.
Cc: James Bottomley
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Update the SEV support to switch to using the newer work area format.
Cc: James Bottomley
Cc: Min Xu
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Jordan Justen
Cc: Ard Biesheuvel
Cc: Erdem Aktas
Signed-off-by: Brijesh Singh
---
OvmfPkg/Reset
Based on the discussion on the mailing list, we agreed that instead
of wasting extra page in the MEMFD, we can reuse the SevEsWorkArea
buffer for the TDX. To avoid any confusion, lets introduce a OvmfWorkArea
that will contains 32 bytes of header followed by the actual workarea.
While at it, move
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
Both the TDX and SEV support needs to reserve a page in MEMFD as a work
area. The page will contain meta data specific to the guest type.
Currently, the SEV-ES support reserves a page in MEMFD
(PcdSevEsWorkArea) for the work area. This page c
Pushed: https://github.com/tianocore/edk2-platforms/commit/d6794cc
-Original Message-
From: devel@edk2.groups.io On Behalf Of Nate DeSimone
Sent: Thursday, August 5, 2021 11:28 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W ; Liming Gao
; KARPAGAVINAYAGAM, MANICKAVASAKAM
Subject: [edk2-
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate DeSimone
> Sent: Thursday, August 5, 2021 11:28 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Liming Gao
> ; KARPAGAVINAYAGAM, MANICKAVASAKAM
>
> Subject: [edk2-devel] [edk2-pl
Hi Pedro,
1) Ext4Pkg/Ext4Dxe/Ext4Dxe.inf:
* To be consistent with other drivers, BASE_NAME should be changed from Ext4
to Ext4Dxe.
* For proper dependency checking in incremental builds, please add the .h
files to the [Sources] section
Ext4Disk.h
Ext4Dxe.h
2) There are a num
Building the IpmiFeaturePkg standalone
(not as part of a platform build) currently
fails because the IpmiPlatformHookLib was added
but the reference to the NULL implementation of
that LibraryClass was miseed.
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Manickavasakam Karpagavinayagam
S
Linux, for the time being has refused to support the Arm
standard SMCCC for PCIe configuration. Instead they
want to continue to maintain per device "quirks".
As the RPI isn't really ECAM this is a bit more
involved because the MADT can't really describe
the root port+config registers situation. F
Linux has been refusing to use the generic SMC
PCIe config method, so we need to add a bit of additional
linux specific information to support a new rpi4 quirk.
This patch depends on the general XHCI/PCIe SMC set.
Jeremy Linton (1):
Platform/RaspberryPi: Add linux quirk support
Platform/Raspb
From: Michael Kubacki
Removes an unnecessary library dependency.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael Kubacki
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.h | 1 -
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatfor
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534
Updates the code to be compatible with a recent Firmware Test Suite
(FWTS) fix that improves adherence to the ACPI Specification.
Relevant FWTS commit:
https://git.launchpad.net/fwts/commit/?
id=4ad3e374bf98931c84adcf
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
Updates InitializeHeader() to fill in the CreatorId and
CreatorRevision values from PCDs instead of being hardcoded to zero.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael Ku
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
Updates the table to use the standard MdeModulePkg PCD
PcdAcpiDefaultOemRevision to set the OEM revision in WSMT.
This allows board packages to easily configure the OEM
revision value.
Cc: Chasel Chiu
Cc: Nate DeSim
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3532
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3533
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3534
This patch series groups together several bug fixes and
improvements to AcpiPlatform.
Note that the follo
The CM4 has an actual pcie slot, so we need to move the linkup
check to the configuration probe logic. Further the device
restriction logic needs to be relaxed to support downstream
PCIe switches.
Suggested-by: René Treffer
Signed-off-by: Jeremy Linton
---
.../Bcm2711PciHostBridgeLibConstructor
Since we plan on toggling between XHCI and PCI the PCI
root needs to be in its own SSDT. This is all thats needed
of UEFI. The SMC conduit is provided directly to the running
OS. When the OS detects this PCIe port, on a machine without
a MADT it attempts to connect to the SMC conduit. The RPi
defin
The CM4 has a number of carrier boards with PCIe
slots. With the PCIe changes in place its quite
possible to setup a NVMe root device. Lets allow
people to boot from it.
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/RPi4/RPi4.dsc | 5 +
Platform/RaspberryPi/RPi4/RPi4.fdf | 5 +
2
Arm has standardized a PCI SMC conduit that can be used
to access the PCI config space in a standardized way. This
functionality doesn't yet exist in many OS/Distro's. Lets
add another advanced config item that allows the user
to toggle between presenting the XHCI on the base RPi4
as a platform dev
Lets prepare to switch between XHCI and PCI by moving
the XHCI definition into its own SSDT. That way we can
select it based on the menu settings.
Signed-off-by: Jeremy Linton
---
Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 1 +
Platform/RaspberryPi/AcpiTables/Dsdt.asl | 3 -
A new Arm standard DEN0115A specifies how
platforms that don't have standard ECAM can
use the firmware to handle config read/write
operations. This is mostly implemented in TFA
but UEFI needs to assure that there is a
description of the root complex in the ACPI
namespace.
This set adds that descri
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Fix a coding style issue raised by EccCheck. This issue (error code
7008) has been fixed by moving a nested union out of its structure.
Also add Acpi64.h to the "IgnoreFiles" list to stop the CI flagging
naming errors present pr
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.59, Section 5.2.27.1 & Section 5.2.27.4
- Mantis ID 1991 (https://mantis.uefi.org/mantis/view.php?id=1991)
Signed-off-by: Ch
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.137, Table 5.140, Table 5.141
- Mantis ID 2138 (https://mantis.uefi.org/mantis/view.php?id=2138)
Signed-off-by: Chris Jones
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.26.1.1
- Mantis ID 2111 (https://mantis.uefi.org/mantis/view.php?id=2111)
Signed-off-by: Chris Jones
---
MdePkg/Includ
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.21, Section 5.2.12.19
- Mantis ID 2087 (https://mantis.uefi.org/mantis/view.php?id=2087)
Signed-off-by: Chris Jones
---
Md
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.24, Table 5.100 & Section 5.2.24.2
- Mantis ID 2126 (https://mantis.uefi.org/mantis/view.php?id=2126)
Signed-off-by: Chr
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5, Section 5.2.30
- Mantis ID 2094 (https://mantis.uefi.org/mantis/view.php?id=2094)
Signed-off-by: Chris Jones
---
MdePkg
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
This patch introduces a header file for the ACPI specification version
6.4. Currently it is based on the Acpi63.h header file however makes
six changes:
1. Replace all occurences of "6_3"/"6.3" with "6_4/6.4".
2. Remove the trai
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 14.1.7, Section 14.4
- Mantis ID 2010 (https://mantis.uefi.org/mantis/view.php?id=2010)
Signed-off-by: Chris Jones
---
Mde
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.21.12
- Mantis ID 1975 (https://mantis.uefi.org/mantis/view.php?id=1975)
Signed-off-by: Chris Jones
---
MdePkg/Include
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Section 5.2.25.2 System Physical Address (SPA)
Range Structure, Table 5.109
- Mantis ID 1988 (https://mantis.uefi.org/mantis/view.p
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5-9
- Mantis ID 2105 (https://mantis.uefi.org/mantis/view.php?id=2105)
Signed-off-by: Chris Jones
---
MdePkg/Include/Industr
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
Make changes to ACPI 6.4 header according to the latest specification:
- ACPI 6.4 January 2021, Table 5.5
- Mantis ID 2133 (https://mantis.uefi.org/mantis/view.php?id=2133)
Signed-off-by: Chris Jones
---
MdePkg/Include/Industr
Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
This patch series introduces a header file for the latest version of the
ACPI 6.4 specification, January 2021. This header contains all updates
to the ACPI specification in addition to addressing a few small errors
from the previ
Hi Pedro,
There is a build failure when building the Ext4Pkg.dsc file for a missing
RegisterFilerLib mapping.
The correct fix for this issue is to add the following !include statement to
the DSC file after the
the [Defines] section.
!include MdePkg/MdeLibs.dsc.inc
With this one change, the X6
Hi Pedro,
When I run BaseTools/Scripts/Patchcheck.py on this patch series, I see the
following issues:
Checking git commit: 5f0db07586
Ext4Pkg: Add Ext4Dxe driver.
The commit message format passed all checks.
Code format is not valid:
* EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
Good day everyone,
Staging branch available at:
https://github.com/tianocore/edk2-staging/tree/2021-gsoc-secure-loader
As part of an internship at ISP RAS, my colleague Vitaly and I developed
a replacement for the current EDK II PE/COFF loader with the help of
formal methods. The reason for
Ah, sorry, I did not realize that you are using that in FDF.
If we have to define the PcdOvmfWorkAreaHeaderSize, then I would suggest:
1) Add detail comment in the PCD definition - it must be same as sizeof(Header).
2) Add ASSERT in the code to ensure PcdOvmfWorkAreaHeaderSize is same as
sizeof(H
From: Michael Kubacki
Makes the OutTable parameter in DumpAcpiRsdt() and DumpAcpiXsdt()
optional since the pointer passed can be NULL if the Signature
pointer is also NULL.
Can fix a potential failure in TestPointCheckAcpi().
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Si
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521
The current logic depends on a particular order in which the
descriptors for three or more regions are placed in the array to
perform proper adjacency checking. When three or more regions are
all adjacent, but neighbor
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520
TestPointSmmEndOfDxeSmrrFunctional() uses the incorrect byte index
to skip the test. It should use byte 6 instead of byte 5.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael Ku
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518
Per the protocol definition, the caller must allocate the input
structure and set the size field. TestPointCheckTcgTrustedBoot()
does not do this which can result in an EFI_BUFFER_TOO_SMALL error.
Cc: Chasel Chiu
Cc:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531
The MessageLength field of EFI_MM_COMMUNICATE_HEADER as defined in
MdePkg/Include/Protocol/MmCommunication.h was updated to a fixed
size as opposed to UINTN to avoid ambiguity between different
caller enviornments.
Th
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521
This patch series groups together several bug fixe
Hi Jiewen,
On 8/4/21 9:18 PM, Yao, Jiewen wrote:
HI Brijesh
Thanks for the startup. Feedback below:
1) I don't think we need a PCD to indicate the header.
gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaHeaderSize|4|UINT32|0x51
Instead, if we define a HEADER structure, we can use sizeof() natural
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20201011T015911Z
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZNAME:CST
TZOFFSETFROM
Hi Kun,
I plan to make some change for FirmwarePerformanceSmm.inf, may also update the
behavior of FirmwarePerformanceStandaloneMm.inf as they are sharing codes now.
And I saw you are the submitter of this driver. Could you help clarify
following questions ? Thanks in advance.
1. Do you hav
Hi Jiewen,
Thanks for the quick feedback. I will make the recommended change and
send the updated patch. I was under assumption that union will be done
when Min adds the SGX support because that's when we start reusing the
WorkArea for SEV and TDX. But I guess its good idea for me to do it now
so
On Thu, Aug 05, 2021 at 05:17:15AM +, Yao, Jiewen wrote:
> Hi
> I have some questions:
>
> 1) May I know what is the usage of this UEFI variable -
> SevLiveMigrationEnabled?
> I only see it is created, but I do not see how it is consumed.
Yes, it is created by UEFI but consumed by the (gues
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Je
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365
BIOS cannot find correct AcpiProcId in mApicIdMap because of
there is no suitable map, that causes ACPI_BIOS_ERROR.
Remove mApicIdMap for determing AcpiProcId, uses normal
countings instead.
Signed-off-by: JackX Lin
Cc: Chasel Chiu
Cc: Je
86 matches
Mail list logo
