Re: [edk2-devel] [PATCH v3 2/7] MdePkg: MmCommunication: Introduce EFI_MM_COMMUNICATE_HEADER_V3 to MdePkg

Can you kindly explain why you choose to define the definitions in PiMultiPhase.h instead of MmCommunication.h? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kun Qin > Sent: Tuesday, August 17, 2021 1:08 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D

[edk2-devel] [PATCH v3 7/7] MdeModulePkg: PiSmmIpl: Update MessageLength calculation for MmCommunicate

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change added support of installing `EFI_MM_COMMUNICATION3_PROTOCOL`. MmCommunicate v3 routine that calculates message length is also updated to remove ambiguity in contrast to

[edk2-devel] [PATCH v3 6/7] StandaloneMmPkg: StandaloneMmCore: Parsing new MM communicate header

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 MM communicate protocols are expanded with EFI_MM_COMMUNICATE_HEADER_V3 structure that cooperates with updated field types and flexible array. The PiSmmCore implementation is updated

[edk2-devel] [PATCH v3 4/7] MdePkg: MmCommunication: Introduce EFI_PEI_MM_COMMUNICATION3_PPI to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change introduces a new definition for MM communicate PPI v3. This PPI will be installed under a new GUID in contrast to exisiting EFI_PEI_MM_COMMUNICATION_PPI. Data

[edk2-devel] [PATCH v3 3/7] MdePkg: MmCommunication: Introduce EFI_MM_COMMUNICATION3_PROTOCOL to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change introduces a new definition for MM communicate protocol v3. This protocol will be installed under a new GUID in contrast to exisiting EFI_MM_COMMUNICATION_PROTOCOL. Data

[edk2-devel] [PATCH v3 5/7] MdeModulePkg: PiSmmCore: Added parser of new MM communicate header

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 MM communicate protocols are expanded with EFI_MM_COMMUNICATE_HEADER_V3 structure that cooperates with updated field types and flexible array. The PiSmmCore implementation is updated

[edk2-devel] [PATCH v3 2/7] MdePkg: MmCommunication: Introduce EFI_MM_COMMUNICATE_HEADER_V3 to MdePkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3398 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change introduces a new definition for MM communicate header structure, intending to provide better portability between different architectures (IA32 & X64) and adapt to flexible

[edk2-devel] [PATCH v3 1/7] EDK2 Code First: PI Specification: New communicate header and interfaces

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Andrew

[edk2-devel] [PATCH v3 0/7] New MM Communicate header and interfaces

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3430 This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/77017 Since the submission of previous patch series, there were suggestions made to change the entire existing MM communicate header in order

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, August 17, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/17/2021 #cal-reminder

Few new issues are submitted this week. Let’s cancel the meeting. 3549 EDK2 Code unassig...@tianocore.org UNCO VS2017 build tool compiler flags in StdLib.inc needs to be aligned with the VS2015 compiler flags to ignore certain

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/17/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

I don't have better names. Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin Häuser > Sent: Monday, August 16, 2021 9:10 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang > ; Vitaly Cheptsov >

Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

On Monday, August 16, 2021 5:43 PM, Gerd Hoffmann wrote: > > +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm > > Any specific reason why you code up your own instead of using the existing > cpuid functions in BaseLib ? Actually there is no specific reason. I am not sure if AsmCpuid is a

[edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

The default value for CpuConfigLibPreMemConfig->PeciC10Reset should be 1 so that Peci Reset on C10 exit is disabled. Other bug fixes in KabylakeSiliconPkg\Cpu\Library\PeiCpuPolicyLibPreMem\PeiCpuPolicyLib.c 1. PCI configuration space can only be read 32-bits at a time. Converted MmioRead64

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

It shouldn’t be because if it were then it would be impossible to access MCHBAR from 32-bit mode… but fair point. I’ve added an error check for that case, please see patch v2. Thanks, Nate From: devel@edk2.groups.io On Behalf Of Benjamin Doron Sent: Monday, August 16, 2021 10:16 AM To:

[edk2-devel] [PATCH] Platform/RaspberryPi: Always use non translating DMA in DT mode

One of the many issues with the PCIe on this platform is its inbound DMA is either constrained to the lower 3G, or on later SoC's a translation can be used. That translation was problematic with some of the OS's expected to boot on this platform. So, across the board a 3G DMA limit is enforced

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

The edk2 branch was created here: https://github.com/makubacki/edk2/tree/uncrustify_poc_2 We have a Project Mu fork with custom changes to the Uncrustify tool to help comply with EDK II formatting here: https://dev.azure.com/projectmu/_git/Uncrustify The latest information about the status

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

Hey Rebecca, I think even Uncrustify has issues with the EDK II indentation style. You might want to check the UEFI Talkbox Discord server, I had a brief chat with Michael about it there. I don't think realistically any tool supports EDK II's indentation style however, so I'd propose it is

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

cc devel@ . On 8/16/21 1:33 PM, Rebecca Cran wrote: I noticed a message on Twitter about an idea of using Uncrustify for EDK2 instead of the ECC tool, and came across

Re: [edk2-devel] [Patch v3 0/3] Ext4Pkg: Add Ext4Pkg

Hi Mike, I've sent out v4, which should address those two small issues. Best regards, Pedro On Mon, 16 Aug 2021 at 17:11, Kinney, Michael D wrote: > > Hi Pedro, > > Thank you for addressing all the feedback. > > 1) The Ext4Dxe.dsc does not build due to a missing RegisterFilterLib. >

[edk2-devel] [Patch v4 3/3] Ext4Pkg: Add .DSC file.

This file is required to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dsc | 70 1 file changed, 70 insertions(+) create mode 100644 Features/Ext4Pkg/Ext4Pkg.dsc diff

[edk2-devel] [Patch v4 0/3] Ext4Pkg: Add Ext4Pkg

This patch-set adds Ext4Pkg, a package designed to hold various drivers and utilities related to the EXT4 filesystem. Right now, it holds a single read-only UEFI EXT4 driver (Ext4Dxe), which consumes the DISK_IO, BLOCK_IO and DISK_IO2 protocols and produce EFI_FILE_PROTOCOL and

[edk2-devel] [Patch v4 1/3] Ext4Pkg: Add Ext4Pkg.dec and Ext4Pkg.uni.

These files are needed to build Ext4Pkg. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bret Barkelew Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dec | 17 + Features/Ext4Pkg/Ext4Pkg.uni | 14 ++ 2 files changed, 31 insertions(+) create mode 100644

[edk2-devel] Предложение

Здравствуйте. Вас интересует продвижения сайта? Напишите мне в Skype пожалуйста WhatsApp/Viber владельца сайта и передайте мое предложение. Мой Skype для быстрой связи: mayboroda_aleks Преимущества при сотрудничестве со мной: 1. Увеличение конверсии Вашего сайта в 2-3 раза и более. 2. Увеличение

[edk2-devel] Предложение

Здравствуйте. Вас интересует продвижения сайта? Напишите мне в Skype пожалуйста WhatsApp/Viber владельца сайта и передайте мое предложение. Мой Skype для быстрой связи: mayboroda_aleks Преимущества при сотрудничестве со мной: 1. Увеличение конверсии Вашего сайта в 2-3 раза и более. 2. Увеличение

Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure

On 8/15/21 7:34 PM, Gary Lin (HPS OE-Linux TDC) wrote: On Fri, Aug 13, 2021 at 09:55:48AM +, Yao, Jiewen wrote: HI Gary Hi Jiewen, Several comment: 1) According to our process, we need a Bugzilla. Would you please file it? Okay, will create a bugzilla entry to track the issue. 2) I

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

The MCH BAR field is the 38:15 bit range. Are the higher bits guaranteed to be clear, so that a 32 bit read is sufficient? Best regards, Benjamin On Mon, Aug 16, 2021 at 11:53 AM Michael Kubacki < mikub...@linux.microsoft.com> wrote: > Reviewed-by: Michael Kubacki > > On 8/16/2021 12:02 AM,

Re: [edk2-devel] SecCore evacuation in PeiCore?

Hi Marvin, Your understanding of SecMigrationPei is correct. It is not ideal as it's an unfamiliar pattern that could give the false impression that it is a universal SEC migration solution, which it is not. But if platforms understand that any additional data published in SecCore must be

Re: [edk2-devel] [Patch v3 0/3] Ext4Pkg: Add Ext4Pkg

Hi Pedro, Thank you for addressing all the feedback. 1) The Ext4Dxe.dsc does not build due to a missing RegisterFilterLib. mapping. Looks like the update to add the following line to Ext4Dxe.dsc after the [Defines] section is missing in this latest patch series: !include

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

On 8/16/21 3:35 PM, Yao, Jiewen wrote: > Hi Greg > Can we define MACRO to replace 1 or 2? That is very confusing. > > For example, > #define VIRT_IO_DEVICE_VERSION_0_95 1 > #define VIRT_IO_DEVICE_VERSION_1_00 2 Good idea. > > Thank you > Yao Jiewen -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

Reviewed-by: Michael Kubacki On 8/16/2021 12:02 AM, Nate DeSimone wrote: The default value for CpuConfigLibPreMemConfig->PeciC10Reset should be 1 so that Peci Reset on C10 exit is disabled. Other bug fixes in KabylakeSiliconPkg\Cpu\Library\PeiCpuPolicyLibPreMem\PeiCpuPolicyLib.c 1. PCI

Re: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Platform/Intel: Early hook-up Acer Aspire VN7-572G

Reviewed-by: Michael Kubacki On 8/13/2021 8:24 PM, Benjamin Doron wrote: Note that the SKU IDs do not represent register values, they were chosen somewhat arbitrarily. We perform the mapping ourselves, so the definitions can be changed. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files

Reviewed-by: Michael Kubacki On 8/13/2021 8:24 PM, Benjamin Doron wrote: This makes diffing the follow-up board changes in these files easier. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Benjamin Doron ---

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands

Reviewed-by: Michael Kubacki On 8/13/2021 8:24 PM, Benjamin Doron wrote: Add EC read (0x80) and write (0x81) commands, as defined by ACPI. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Benjamin Doron --- Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h

[edk2-devel] [PATCH v1 2/2] ShellPkg: Update Acpiview GTDT parser to ACPI 6.4

Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) Update the Acpiview GTDT parser to use Acpi64.h and as such rename all occurences of "SBSA Generic Watchdog" to "Arm Generic Watchdog". Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: Rename SBSA generic watchdog

Buzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) As part of the updates to ACPI 6.4 the "SBSA Generic Watchdog" was renamed to the "Arm Generic Watchdog". This patch implements that change by updating the GTDT generator to use Acpi64.h and renames any occurence of "SBSA Generic

[edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) This patch series updates the Acpiview GTDT parser and DynamicTables GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h which requires the "SBSA Generic Watchdog" structure to be renamed to the "Arm Generic

Re: [edk2-devel] [PATCH v2 0/3] reuse the SevEsWork area

Hi Min, I was giving sometime for other reviewers to comment. I will respin v3 this week with Tom's feedback addressed. thanks On 8/14/21 10:00 PM, Xu, Min M wrote: Hi, Brijesh May I know is there some progress of this patch set? I noticed some comments have been given to the patch-set.

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

HI Gerd I apologize for the mistake on name. I should call you Gerd, not Greg. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Monday, August 16, 2021 9:36 PM > To: devel@edk2.groups.io; kra...@redhat.com > Cc: Philippe

Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

Hi Greg Can we define MACRO to replace 1 or 2? That is very confusing. For example, #define VIRT_IO_DEVICE_VERSION_0_95 1 #define VIRT_IO_DEVICE_VERSION_1_00 2 Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, August

Re: [edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as Reviewer to ArmVirtPkg and OvmfPkg

Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, August 16, 2021 3:18 PM > To: devel@edk2.groups.io > Cc: Gerd Hoffmann > Subject: [edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as Reviewer to > ArmVirtPkg and

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

Hey Ray, On 16/08/2021 11:42, Ni, Ray wrote: Marvin, So lucky to have you in the edk2 project looking into these fundamentals! Thank you. :) + #define ALIGNOF(TYPE) OFFSET_OF (struct { CHAR8 C; TYPE A; }, A) 1. Does struct{} inside a macro conform to C standard? How is the compatibility

[edk2-devel] [edk2-platforms: PATCH V8] Platform/Intel: Correct CPU APIC IDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3365 BIOS cannot find correct AcpiProcId in mApicIdMap because of there is no suitable map, that causes ACPI_BIOS_ERROR. Remove mApicIdMap for determing AcpiProcId, uses normal countings instead. Signed-off-by: JackX Lin Cc: Chasel Chiu Cc:

[edk2-devel] [PATCH 1/1] Maintainers: Add kraxel as Reviewer to ArmVirtPkg and OvmfPkg

Signed-off-by: Gerd Hoffmann --- Maintainers.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 2e2d4d1b7f77..694994b4bfae 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -145,6 +145,7 @@ W:

[edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

Add support for virtio 1.0 to the mmio transport. virtio 0.9.5 uses page size, page frame number and a fixed layout for the ring. virtio 1.0 uses the physical addresses for base address, used bits and available bits instead. The ring layout is not changed, so a 0.9.5 compatible layout is used

[edk2-devel] [PATCH v2 4/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 feature bit handling

virtio 1.0 has 64 feature bits instead of 32. Signed-off-by: Gerd Hoffmann --- .../VirtioMmioDeviceFunctions.c | 28 +++ 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c

[edk2-devel] [PATCH v2 3/4] OvmfPkg/VirtioMmioDeviceLib: Add default QueueNum for virtio 1.0

Use QueueNumMax as QueueNum default for drivers which do not explicitly call VIRTIO_DEVICE_PROTOCOL->SetQueueSize(). Signed-off-by: Gerd Hoffmann --- .../Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + .../VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 12 +++- 2 files

[edk2-devel] [PATCH v2 0/4] add support for virtio-mmio 1.0

This little series adds virtio 1.0 support for the virtio-mmio transport. For the mmio transport the difference between 0.9.5 and 1.0 is rather small (when compared to the pci transport), it is just a bunch of new registers for the changed virtio queue initialization. So the patch series is

[edk2-devel] [PATCH v2 1/4] OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines

Add defines for the config space offsets for virtio 1.0 mmio transport. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/Include/IndustryStandard/Virtio10.h | 12 1 file changed, 12 insertions(+) diff --git a/OvmfPkg/Include/IndustryStandard/Virtio10.h

Re: [edk2-devel] [PATCH V4 3/3] OvmfPkg/ResetVector: Enable Intel TDX in ResetVector of Ovmf

Hi, > This patch need to be broken into multiple sub patches for the easy to > review and keeping the code bisectable. The first thing we need to do is > introduce the new CCWorkArea concept and update the existing Sev support to > use the new CCWorkArea. Fully agree. Also moving around code

[edk2-devel] [edk2-platforms PATCH v2] ArmPkg: Enable boot discovery policy for ARM package.

This commit adds code which check BootDiscoveryPolicy variable and calls Boot Policy Manager Protocol to connect device specified by the variable. To enable that mechanism for platform EfiMdeModulePkgTokenSpaceGuid.PcdBootDiscoveryPolicy PCD must be added to DSC file and BootDiscoveryPolicyUiLib

Re: [edk2-devel] [PATCH 05/23] MdePkg: Add TdxProbeLib to probe Intel Tdx

> +++ b/MdePkg/Library/TdxProbeLib/X64/TdProbe.nasm Any specific reason why you code up your own instead of using the existing cpuid functions in BaseLib ? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79347):

Re: [edk2-devel] [PATCH v2 4/7] ArmPkg/DefaultExceptionHandlerLib: Check DebugImageInfoTable type safely

On Mon, 9 Aug 2021 at 23:19, Marvin Häuser wrote: > > On 09/08/2021 14:40, Marvin Häuser wrote: > > On 09/08/2021 13:55, Ard Biesheuvel wrote: > >> On Mon, 9 Aug 2021 at 11:51, Marvin Häuser wrote: > >>> C does not allow casting to or dereferencing incompatible pointer > >>> types. Use the

Re: [edk2-devel] 回复: [PATCH v5 2/5] ArmPkg: prepare 32bit ARM build of StandaloneMmPkg

Hi Liming, Apologies, I was on vacation last week. Hi Ard, Thank you for taking care of this. Regards, Sami Mujawar On 11/08/2021, 02:52, "gaoliming" wrote: Etienne: Thanks for your update. This version should pass CI. Sami: Can you help review the updated patch? So,

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

Marvin, So lucky to have you in the edk2 project looking into these fundamentals! + #define ALIGNOF(TYPE) OFFSET_OF (struct { CHAR8 C; TYPE A; }, A) 1. Does struct{} inside a macro conform to C standard? How is the compatibility with different compilers? +#define IS_POW2(Value) ((Value) !=

[edk2-devel] 回复: [edk2-stable202108] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field

Ard: Now, we enter into Hard Feature Freeze phase until edk2-stable202108 tag is created at 2021-08-27. In this phase, the bug fix is still allowed to be merged. This patch is a clear bug fix. I am OK to merge it for this stable tag. I suggest we wait for 1 day to collect the feedback

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, August 16, 2021 12:03 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Benjamin Doron > ; Michael Kubacki > > Subject: [edk2-platforms] [PATCH V1]

Re: [edk2-devel] [PATCH v2 0/2] rpi: Fix PXE issues with grub

On Wed, 12 May 2021 at 00:37, Jeremy Linton wrote: > > When PXE booting with grub the network link > isn't given a chance to resume so grub's transmit > calls fail. This results in failed boots. Similarly > the DMA range for the adapter isn't right since it > doesn't have a 32-bit restriction.

Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure

On Fri, Aug 13, 2021 at 02:13:00PM +0800, Lin, Gary (HPS OE-Linux) wrote: > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. Besides, QemuKernelLoaderFsDxe wasn't included > in OvmfXen,

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

On Mon, Aug 16, 2021 at 09:07:01AM +0200, Ard Biesheuvel wrote: > Does this series have a cover letter? > Sorry, I forgot to add Cc tags in the cover letter. https://edk2.groups.io/g/devel/topic/84857762#79245 Gary Lin > On Fri, 13 Aug 2021 at 08:13, Lin, Gary (HPS OE-Linux) > wrote: > > > >

Re: [edk2-devel] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field

On Fri, 13 Aug 2021 at 07:05, Jeremy Linton wrote: > > Map->Operation is used to select whether a DMA region that > is being bounced has the source buffer copied to it. Except > Map->Operation isn't yet set, so the behavior is somewhat > random. Instead use the passed in Operation parameter. > >

Re: [edk2-devel] [PATCH v2 1/5] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

Does this series have a cover letter? On Fri, 13 Aug 2021 at 08:13, Lin, Gary (HPS OE-Linux) wrote: > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since >