Sure. I will merge this patch.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Yao, Jiewen
> 发送时间: 2021年8月18日 9:20
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn; 'Stewart, Chris
> (SW Architect)'
> 抄送: Wang, Jian J ; Lu, XiaoyuX
> ; Jiang, Guomin ; 'Leif
> Lindholm' ;
The history was that we didn’t need MmAccessPei without S3.
MmAccessPei was added for S3 resume purpose only.
Today, if there is real use case to rely on MmAccessPei in normal boot path.
Then we can add it.
I could see the potential impact is: If MmAccessPei changes the SMRAM attribute
in
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 8/18/21 5:45 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=38
Set MPath to NULL after free(MPath) to guarantee that MPath
is not used after the free() call.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 8/18/21 4:49 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1664
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
AppPkg/Applications/Sockets/SetHostName/SetHostName.c | 2 +-
1 file changed, 1
Reviewed-by: Rebecca Cran
On 8/13/21 10:33 AM, Michael D Kinney wrote:
From: Jayaprakash Nevara
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3548
A port of Python 3.6.8 interpreter for UEFI uses the
standard C Library from the edk2-libc project. The python
interpreter fails with the
From a design perspective, I disagree this function is the proper place
to try to enforce this.
The single responsibility of this function is to install the MM Access
PPI. That is it.
---
From a security perspective, the boot mode is a weak way to enforce this.
Platform code often
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=38
Set MPath to NULL after free(MPath) to guarantee that MPath
is not used after the free() call.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/LibC/Uefi/Devices/Utility/Path.c | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1664
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
AppPkg/Applications/Sockets/SetHostName/SetHostName.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AppPkg/Applications/Sockets/SetHostName/SetHostName.c
I just followed the DEBUG() message style in the rest of the malloc() function.
It does guarantee that the message starts at the left column, which is important
if the same console is used for both stdout and DEBUG() which can happen for
UEFI Applications.
PEI/DXE/MM/SMM components may have a
Reviewed-by: Rebecca Cran
Not sure the first \n is needed though.
--
Rebecca Cran
On 8/18/21 4:03 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1510
Check for addition overflow in malloc() when computing NodeSize
and return error if overflow is
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 8/17/21 9:32 AM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/PosixLib/GetPass/GetPass.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1510
Check for addition overflow in malloc() when computing NodeSize
and return error if overflow is detected.
Cc: Rebecca Cran
Cc: Yitzhak Briskman
Cc: Jian J Wang
Cc: Yonghong Zhu
Signed-off-by: Michael D Kinney
---
For the entire series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 8/18/21 3:28 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
New in V2
=
* Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order
* Add comments explaining why SocketDxe is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add LibNetUtil to BsdSocketLib INF file that fails with missing
symbols for inet_ntoa(), inet_aton(), inet_ntop(), inet_network()
when BsdSocketLib is linked to another component.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add BsdSocketLib and EfiSocketLib to [LibraryClasses] section
of Python-2.7.10.inf. Even if sockets are disabled in Python
config, with the /WHOLEARCHIVE linker option, there are still
references to the socket related functions. Add these
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Update Python configuration to enable the HAVE_COPYSIGN define
to prevent multiple defined symbols link failure for copysign().
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
AppPkg/Applications/Python/Ia32/pyconfig.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc
after the [Defines] section of AppPkg.dsc.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
AppPkg/AppPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Disable warning 4706 to allow assignments in conditional
statements.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/BsdSocketLib/BsdSocketLib.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Removing the ldtoa.c file from the INF removes the ldtoa()
function from this library. The ldtoa() function is not used
and when /WHOLEARCHIVE linker flag is enabled this unused
function makes references to other functions that are not
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Add /Wv:11 to VS2017/VS2017 CC_FLAGS to match the warning level
used by VS2015.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/StdLib.inc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/StdLib/StdLib.inc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
SocketDxe generates build failures with VS2017 and VS2019 due to
use of weak references and /WHOLEARCHIVE. Disable SocketDxe until
weak references can be removed.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/StdLib.inc |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
New in V2
=
* Add LibNetUtil to StdLib/BsdSocketLib in alphebetic order
* Add comments explaining why SocketDxe is removed from the build.
New TianoCore Bugzilla with more details on this issue:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
Fix missing RegisterFilterLib build failure by adding MdeLibs.dsc.inc
after the [Defines] section of StdLib.dsc.
Cc: Rebecca Cran
Signed-off-by: Michael D Kinney
---
StdLib/StdLib.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git
The Migration Handler runs in the mirror VM. The MH is started
directly by the hypervisor. SetupMigrationHandler runs in the main
VM and sets up the migration entry point. The HV starts execution
of the mirror vCPU at the entry point, which trampolines to
MigrationHandlerMain
Signed-off-by: Tobin
Exposes the address of the Migration Handler entry point via a
GUIDed struct. To support migration, the HV should find this
struct and start one vCPU at the entry point address.
Signed-off-by: Tobin Feldman-Fitzthum
---
OvmfPkg/ResetVector/ResetVector.inf | 1 +
The migration handler communicates with the hypervisor
via a shared mailbox page. The MH can perform four functions
at the behest of the HV: init, save page, restore page, and
reset.
Signed-off-by: Tobin Feldman-Fitzthum
---
.../ConfidentialMigrationDxe.inf | 1 +
The Migration Handler uses its own stack and should avoid
overwriting the stack when importing pages.
Signed-off-by: Tobin Feldman-Fitzthum
---
.../ConfidentialMigrationDxe.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git
While restoring pages, the MH should avoid overwriting its
pagetables or the mailbox it uses to communicate with the HV.
Signed-off-by: Tobin Feldman-Fitzthum
---
.../ConfidentialMigrationDxe.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git
From: Dov Murik
The migration handler builds its own page tables and switches
to them. The MH pagetables are reserved as runtime memory.
When the hypervisor asks the MH to import/export a page, the HV
writes the guest physical address of the page in question to the
mailbox. The MH uses an
The migration handler communicates with the hypervisor using a
special mailbox, a page of shared memory where pending commands
can be written. Another shared page is used to pass the incoming
or outgoing guest memory pages. These pages are set aside in MEMFD,
which this patch expands, and reserved
Confidential Migration relies on two boolean PCDs set from FW_CFG
Signed-off-by: Tobin Feldman-Fitzthum
---
OvmfPkg/PlatformPei/PlatformPei.inf | 2 ++
OvmfPkg/PlatformPei/Platform.c | 10 ++
2 files changed, 12 insertions(+)
diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf
Base enablement of DXE driver that supports confidential migration.
Signed-off-by: Tobin Feldman-Fitzthum
---
OvmfPkg/OvmfPkg.dec | 5 ++
OvmfPkg/AmdSev/AmdSevX64.dsc | 1 +
OvmfPkg/AmdSev/AmdSevX64.fdf | 1 +
With AMD SEV the hypervisor cannot decrypt or move guest memory pages.
This makes migration tricky. While the AMD Secure Processor can
export/import pages wrapped with a transport key, the bandwidth is
limited. We look to provide similar support via firmware. In particular,
we implement a
I've looked into Intel Platforms and we have atleast one platform that could
potentially get impacted. However, it can be addressed by adding BootMode
checks by the caller.
The more important question, as Ray pointed out is, are there security
implications in installing these PPIs in normal
Add VBT for the Acer Aspire VN7-572G board. Changes were ported from
the vendor's VBT (version 200) to VBT version 221 (version 228 changed
the units for some eDP settings). Most of the changes were to display
initialisation timings, which were corroborated with the datasheet.
A display toggle
1. Done.
2. I suppose I don't really get the point? I'm already authoring the commits,
so that counts as "credit for my work," or something like that. I think that
the license covers permissions already (except BSD licenses allow code to be
forked and made closed-source, as I understand, but
Hi Michael,
That's a good idea, I'll try to file the bugs when I get a chance (of course,
there probably isn't an AspireVn7Dash572G keyword yet).
I've removed the #if 0 code in AspireVn7Dash572GBoardBootModeDetect() and
implemented the other function. Now there is only some #if 0 in
Hi Nate,
Firstly, thanks!
I'll respond to these comments here, and the rest on the main patch.
1. I've added it to my to-do list
2. We could also consider calling
+ Sami for ArmPkg review
> -Original Message-
> From: Grzegorz Bernacki
> Sent: Monday, August 16, 2021 6:09 AM
> To: devel@edk2.groups.io
> Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
> ; Sunny Wang
> ; m...@semihalf.com; upstr...@semihalf.com;
> Grzegorz
Reviewed-By: Samer El-Haj-Mahmoud
> -Original Message-
> From: Grzegorz Bernacki
> Sent: Wednesday, August 18, 2021 3:36 AM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; hao.a...@intel.com; Samer El-Haj-Mahmoud
> ; Sunny Wang
> ; m...@semihalf.com; upstr...@semihalf.com;
>
Thanks for the patch!
Reviewed-By: Samer El-Haj-Mahmoud
> -Original Message-
> From: Grzegorz Bernacki
> Sent: Wednesday, August 18, 2021 3:38 AM
> To: devel@edk2.groups.io
> Cc: l...@nuviainc.com; ardb+tianoc...@kernel.org; Samer El-Haj-Mahmoud
> ; Sunny Wang
> ; m...@semihalf.com;
Good idea.
I was going to enter a BZ too.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Wednesday, August 18, 2021 11:32 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove
This makes diffing the follow-up board changes in these files easier.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Michael Kubacki
Signed-off-by: Benjamin Doron
---
Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/{DxeKabylakeRvp3AcpiTableLib.c
=>
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Michael Kubacki
Signed-off-by: Benjamin Doron
---
Platform/Intel/Readme.md | 8
1 file changed, 8 insertions(+)
diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
index 1c4cd9746a38..965009ce2118 100644
---
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Michael Kubacki
Signed-off-by: Benjamin Doron
---
Maintainers.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9b8d6aead923..b73868201a43 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -184,6
Note that the SKU IDs do not represent register values, they were chosen
somewhat arbitrarily. We perform the mapping ourselves, so the
definitions can be changed.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Michael Kubacki
Signed-off-by: Benjamin Doron
---
Add EC read (0x80) and write (0x81) commands, as defined by ACPI.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Michael Kubacki
Signed-off-by: Benjamin Doron
---
Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h | 32
+
This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop)
board to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a
later commit message, there is a second, similar board: VN7-792G.
- VN7-572G = "Rayleigh". Working, supported. Uses PCH-LP.
- VN7-792G = "Newgate". Assumed
Jiewen/Sai, are you thinking about this?
Thanks,
Michael
On 8/12/2021 1:20 AM, Ni, Ray wrote:
Michael,
I need Jiewen's input on why MmAccess and MmCommunication PPIs were not
installed in normal boot path. Without understanding the reason, I don't have
confidence to approve the change.
Sai,
Hi Ray,
It's been a while.
This change is really not that complicated. Can it be merged if there
are no substantial opens?
Regards,
Michael
On 8/12/2021 10:16 PM, Michael Kubacki wrote:
Sure.
Scenario #1:
MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf and
For patches 1,2,4,7-9:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 8/17/21 11:41 PM, Michael D Kinney wrote:
Update AppPkg and StdLib* to build using latest edk2/master and
support VS2017 and VS2019.
Most of the changes are related to warning levels, missing symbols and
duplicate
Maybe add a comment saying why it's disabled, in case fixing it takes
some time?
--
Rebecca Cran
On 8/17/21 11:42 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
SocketDxe generates build failures with VS2017 and VS2019 due to
use of weak references and
Hi Chris,
Thank you for this patch, the changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79494): https://edk2.groups.io/g/devel/message/79494
Mute This Topic:
From: Alyssa
Add the backgroud introduction and build detail steps
in the readme.
Signed-off-by: Yuqi Chen
Cc: Liming Gao gaolim...@byosoft.com.cn
Cc: Yuwei Chen yuwei.c...@intel.com
Cc: Bob Feng bob.c.f...@intel.com
---
ReadMe.rst | 553 +
Google Summer of Code 2021 project: Add clang + gnu make build support
for Edk2 BaseTools in windows
Details of tool combinations and build steps:
https://github.com/alyssachne/edk2/tree/2021-gsoc-llvm-gnumake-v3
Only plan to check-in to edk2-staging right now
Help to send this patch serial for
From: Alyssa
This change allows to build BaseTools with LLVM clang and
gnu make in windows. After this change, there will be three
tool combinations supported in windows to build Basetool:
Clang+ gun make
Clang-cl + nmake
MSVC + nmake
Signed-off-by: Yuqi Chen
Signed-off-by: Steven Shi
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/08/2021, 11:54, "devel@edk2.groups.io on behalf of Gerd Hoffmann via
groups.io"
wrote:
Signed-off-by: Gerd Hoffmann
---
Maintainers.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Maintainers.txt
Hi Chris,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2021, 11:09, "Chris Jones" wrote:
Bugzilla: 3570 (https://bugzilla.tianocore.org/show_bug.cgi?id=3570)
Add parser support for the new "MinTransferSize" field of the System
For this series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/08/2021, 18:02, "Chris Jones" wrote:
Bugzilla: 3563 (https://bugzilla.tianocore.org/show_bug.cgi?id=3563)
This patch series adds support for ACPI 6.4 to the Acpiview PCCT parser
by using Acpi64.h and adding
Bugzilla: 3570 (https://bugzilla.tianocore.org/show_bug.cgi?id=3570)
Add parser support for the new "MinTransferSize" field of the System
Locality, Latency and Bandwidth structure, introduced by the ACPI
specification version 6.4.
Also update the HMAT parser to use the newer ACPI version 6.4
This patch series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/08/2021, 15:52, "Chris Jones" wrote:
Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
This patch series updates the Acpiview GTDT parser and DynamicTables
GTDT
The RealTimeClockLib implemented EFI RealTimeClock
runtime services via RTC Lib.
Signed-off-by: Ling Jia
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec |
1 +
Platform/Phytium/DurianPkg/DurianPkg.dsc |
6 +
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 9b8d6aead9..7266b434d5 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -363,3 +363,11 @@ F: Silicon/SiFive/
M: Abner
The SpiNorFlashDxe provided norflash initialization,
read-write, erase and other interfaces.
Signed-off-by: Ling Jia
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 1 +
Platform/Phytium/DurianPkg/DurianPkg.dsc| 5 +
The FlashFvbDxe provided the fvb protocol,
which requested by the flash operators.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc |1 +
Platform/Phytium/DurianPkg/DurianPkg.fdf |1 +
The SpiDxe is to provide Spi bus read-write interfaces.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 9 +
Platform/Phytium/DurianPkg/DurianPkg.dsc| 5 +
The PCI Segment Library for Phytium platform.
with multiple RCs.
Signed-off-by: Ling Jia
---
Platform/Phytium/DurianPkg/DurianPkg.dsc|9 +-
Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 +
The PlatformLib supported the system library for FT2000/4 chip.
Platform/Phytium: Added the dsc and fdf files of DurianPkg.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec
| 41 +++
Added Acpi driver and table to FT2000/4,
the ACPI Tables providing library AcpiTables.inf uses
a lot of information that is available in the form of PCDs
for differnt platforms.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc
This series added packages to support FT2000/4 chip.
Platform/Phytium: Added DurianPkg, include DurianPkg.dsc and DurianPkg.fdf.
Silicon/Phytium: Added FT2000-4Pkg and PhytiumCommonPkg.
The modules could be runed at the silicon of FT2000/4.
They supported Acpi parameter configuration, Pci bus
The Pci host bridge library is mainly
to get Pci bridge information.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc |
9 +
Platform/Phytium/DurianPkg/DurianPkg.fdf |
6 +
This driver installs SMBIOS information for FT2000/4.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc|
6 +
Platform/Phytium/DurianPkg/DurianPkg.fdf|
6 +
Hi All,
This patch depends on "MdeModulePkg: Add BootDiscoveryPolicyOld
variable" EDK2 patch. It can be merged only if the EDK2 patch is
merged first.
thanks,
greg
śr., 18 sie 2021 o 09:38 Grzegorz Bernacki via groups.io
napisał(a):
>
> This patch adds checks if Boot Discovery Policy has been
>
This patch adds checks if Boot Discovery Policy has been
changed. Only in that case EfiBootManagerRefreshAllBootOption()
should be called.
Signed-off-by: Grzegorz Bernacki
---
Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 24
+++-
1 file changed, 23
This variable is needed to track the change to
BootDiscoveryPolicy variable. Boot options should
be refreshed only if BootDiscoveryPolicy has been
changed.
Signed-off-by: Grzegorz Bernacki
---
MdeModulePkg/Include/Guid/BootDiscoveryPolicy.h | 1 +
1 file changed, 1 insertion(+)
diff --git
75 matches
Mail list logo
