Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table

Hi All, Sorry for the [edk2-platforms] prefix attached to the subject line. This is edk2 patch series. Will fix the prefix in next version. - Omkar. > Changes since v2: > - Addressed the comments given by Sami. > - Added Readme file with all cover letter information. > - Rebased to the latest

[edk2-devel] [edk2-platforms][PATCH v3 5/5] ArmPlatformPkg: Add Readme file

Added a readme file that explains the software framework for dynamic generation of HEST table. Signed-off-by: Omkar Anand Kulkarni --- ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md | 66 1 file changed, 66 insertions(+) diff --git

[edk2-devel] [edk2-platforms][PATCH v3 4/5] EmbeddedPkg: Add helpers for HEST table generation

Add helper macros for the generation of the HEST ACPI table. Macros to initialize the HEST GHESv2 Notification Structure and Error Status Structure are introduced. Signed-off-by: Omkar Anand Kulkarni --- EmbeddedPkg/Include/Library/AcpiLib.h | 20 1 file changed, 20

[edk2-devel] [edk2-platforms][PATCH v3 3/5] ArmPlatformPkg: retreive error source descriptors from MM

Add a driver that retreives error source descriptors from MM and populates those into the HEST ACPI table. The error source descriptors that are available from the MM side are retreived using MM Communicate 2 protocol. The first call into the MM returns the size of MM Communicate buffer required

[edk2-devel] [edk2-platforms][PATCH v3 2/5] ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL

Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL protocol. This protocol can be implemented by MM drivers to publish error source descriptors that have to be populated into HEST table. Co-authored-by: Thomas Abraham Signed-off-by: Omkar Anand Kulkarni ---

[edk2-devel] [edk2-platforms][PATCH v3 1/5] MdeModulePkg: Allow dynamic generation of HEST ACPI table

Introduce the HEST table generation protocol that allows platforms to build the table with multiple error source descriptors and install the table. The protocol provides two interfaces. The first interface allows for adding multiple error source descriptors into the HEST table. The second

[edk2-devel] [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table

Changes since v2: - Addressed the comments given by Sami. - Added Readme file with all cover letter information. - Rebased to the latest upstream code. Hardware Error Source Table (HEST)[1] and Software Delegated Exception Interface (SDEI)[2] ACPI tables are used to acomplish firmware first error

Re: [edk2-devel] [PATCH v2 4/4] ArmPlatformPkg: Add helpers for HEST table generation

Hi Sami, Thanks for reviewing this patch. Please find my response inline. Regards, Omkar > Hi Omkar, > > Thank you for this patch. > > I have a minor suggestion marked inline as [SAMI], other than that this patch > looks good to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami

Re: [edk2-devel] [PATCH v2 3/4] ArmPlatformPkg: retreive error source descriptors from MM

Hi Sami, Thanks for the patch review. Please find my response inline. Regards, Omkar Hi Omkar, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Add a driver that retreives error source descriptors from MM and populates

Re: [edk2-devel] [PATCH v2 2/4] ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL

Hi Sami, Thanks for reviewing this patch. Please find my response inline. Regards, Omkar Hi Omkar, Please find my response below marked [SAMI] Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL

Re: [edk2-devel] [PATCH v2 1/4] ArmPlatformPkg: Allow dynamic generation of HEST ACPI table

Hi Sami, Thanks for reviewing this patch. Please find my response inline. Regards, Omkar Hi Omkar, Please find my response marked inline as [SAMI]. Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: Introduce the HEST table generation protocol that allows platforms to

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

Hi Sami, Thanks for reviewing this patch series. Please find my response inline. Regards, Omkar > Hi Omkar, > > How did you check that the HEST table is populated correctly? > > There is no HEST parser in Acpiview at the moment. Do you plan to add an > HEST parser to Acpiview? > > Regards, >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid

> + ASSERT (HobLength >= sizeof (*BootManagerMenuFile)); > + ASSERT (HobLength >= BootManagerMenuFile->Header.Length); Are the two assertions duplicated? Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79735):

[edk2-devel] [PATCH] SecurityPkg/Tcg: remove TcgMorLockSmm driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3583 TcgMorLockSmm is only for secure MOR V1. VariableSmm covers secure MOR V1 and V2. Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Cc: Ray Ni --- SecurityPkg/SecurityPkg.dsc | 1

Re: [edk2-devel] [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs

Pushed as ff31f8f683..75899d2a8f Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, August 23, 2021 6:58 PM > To: Pedro Falcato ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Leif Lindholm ; Bret Barkelew > > Subject: RE: [edk2-platforms PATCH v2 0/5] Ext4Pkg:

Re: [edk2-devel] [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs

Hi Pedro, Found one VS compat issue with signed/unsigned comparison in last patch. It was a very simple fix for force an unsigned compare. Change: if (Len < EXT4_MIN_DIR_ENTRY_LEN + Entry.name_len) { To: if (Len < (UINTN)(EXT4_MIN_DIR_ENTRY_LEN + Entry.name_len)) { With this one

Re: [edk2-devel] [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix bugs

Series Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Pedro Falcato > Sent: Saturday, August 21, 2021 7:47 AM > To: devel@edk2.groups.io > Cc: Pedro Falcato ; Leif Lindholm > ; Kinney, Michael D > ; Bret Barkelew > Subject: [edk2-platforms PATCH v2 0/5] Ext4Pkg: Fix

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 08/24/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware

[edk2-devel] UefiPayloadPkg build error

Hi, The following commit broke the UefiPayloadPkg build: commit d63595c3c91624f258f291adee329724edeac12e (HEAD) Author: Zhiguang Liu Date: Sun Apr 25 15:50:46 2021 +0800 UefiPayloadPkg: Update the function definition of HobConstructor Environment: GCC5 / openSUSE 15.x build -a IA32

[edk2-devel] [2021-gsoc-llvm-gnumake] enable llvm and gnumake in windows for BaseTools

Hello all, This is Yuqi Chen from GSoC 2021. In this project my task is to enable llvm and gnu make to build BaseTools in windows. The feature was already checked in to the edk2-stage in the link: https://github.com/tianocore/edk2-staging/tree/2021-gsoc-llvm-gnumake . Please feel free to give

[edk2-devel] [PATCH v3 4/4] UefiPayloadPkg: Reserve Payload config in runtime services data

Signed-off-by: Cheng-Chieh Huang Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni --- UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel][2021-gsoc-llvm-gnumake]

Hello all, This is Yuqi Chen from GSoC 2021. In this project my task is to enable llvm and gnu make to build BaseTools in windows. The feature was already checked in to the edk2-stage in the link: https://github.com/tianocore/edk2-staging/tree/2021-gsoc-llvm-gnumake . Please feel free to give

[edk2-devel] [PATCH v3 3/4] UefiPayloadPkg: Update maximum logic processor to 256

Signed-off-by: Cheng-Chieh Huang Reviewed-by: Guo Dong Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v3 0/4] UefiPayloadPkg: LinuxBoot Support in UefiPayload

These are necessary patches to Support LinuxBoot in UefiPayload. With these paches, we can boot to ESXi and Windows from a linux in QEMU. Third parse: address formating comments. LinuxBoot README: https://github.com/linuxboot/edk2/blob/uefipayload/UefiPayloadPkg/README.md v3 PR to tianocore:

[edk2-devel] [PATCH v3 2/4] UefiPayloadPkg: Use legacy timer in Linuxboot payload

HPET timer may fail to init after prior linux taking over. Signed-off-by: Cheng-Chieh Huang Reviewed-by: Guo Dong Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni --- UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++

[edk2-devel] [PATCH v3 1/4] UefiPayloadPkg: Add LINUXBOOT payload target

Initial commit to support linuxboot payload. Signed-off-by: Cheng-Chieh Huang Cc: Cheng-Chieh Huang Cc: Daniel Schaefer Cc: Trammell Hudson Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Ray Ni --- UefiPayloadPkg/UefiPayloadPkg.dsc | 16 +-

[edk2-devel][2021-gsoc-llvm-gnumake] enable llvm and gnumake in windows for BaseTools

Hello all, This is Yuqi Chen from GSoC 2021. In this project my task is to enable llvm and gnu make to build BaseTools in windows. The feature was already checked in to the edk2-stage in the link: https://github.com/tianocore/edk2-staging/tree/2021-gsoc-llvm-gnumake . Please feel free to give

Re: [edk2-devel] [edk2-test][PATCH 1/1] SctPkg: Fix runtime access to boot services functions

This patch is upstreamed through the commit-id: https://github.com/tianocore/edk2-test/commit/f3b3456152dacf26ec0abaa0c21a9432cc176630 > -Original Message- > From: G Edhaya Chandran > Sent: 20 August 2021 12:48 > To: Jeff Brasen ; devel@edk2.groups.io > Cc: gao...@byosoft.com.cn; Samer

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Series reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lin, Gary > (HPS OE-Linux) > Sent: Monday, August 23, 2021 3:09 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; > Anthony Perard ; Julien Grall ; > Jim

Re: [edk2-devel] [PATCH 1/1] BaseTools/tools_def: Fix CLANGPDB X64 RCPATH

On 8/21/21 9:55 PM, Marvin Häuser wrote: > Use the correct X64 path for CLANGPDB RCPATH. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Cc: Vitaly Cheptsov > Signed-off-by: Marvin Häuser Fixes: 15330934dc86 ("BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image")

Re: [edk2-devel] [PATCH v3] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

On 8/23/21 9:08 AM, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3574 > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > v3: > Add the bugzilla link > > Cc: Ard

Re: [edk2-devel] [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support

On 8/23/21 9:09 AM, Lin, Gary (HPS OE-Linux) wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > To avoid the potential inconsistency between PcdAcpiS3Enable and > QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect > S3 support by PcdAcpiS3Enable as modules in

FW: [edk2-devel][2021-gsoc-llvm-gnumake]

Yuqi had email configure problem. Help her to send the email again. From: Yuqi Chen Sent: August 23, 2021 7:35 AM To: devel@edk2.groups.io Subject: [edk2-devel][2021-gsoc-llvm-gnumake] Hello all, This is Yuqi Chen from GSoC 2021.

Re: [edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

On Mon, Aug 23, 2021 at 03:09:22PM +0800, Gary Lin wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3573 > > There are several functions in OvmfPkg/Library using > QemuFwCfgS3Enabled() to detect the S3 support status. However, in > MdeModulePkg, PcdAcpiS3Enable is used to check S3 support.

Re: [edk2-devel] [edk2-platforms PATCH v2] ArmPkg: Enable boot discovery policy for ARM package.

Hi Sami, Thanks for the comments, I will send a new version of patch soon. thanks, greg pt., 20 sie 2021 o 14:04 Sami Mujawar napisał(a): > > Hi Grzegorz, > > Thank you for this patch. I have a few minor suggestions, otherwise this > patch looks good to me. > > I have tested this patch on FVP

[edk2-devel] [PATCH v3 4/4] OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support

https://bugzilla.tianocore.org/show_bug.cgi?id=3573 To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. v3: - Add the bugzilla link Cc: Ard Biesheuvel

[edk2-devel] [PATCH v3 3/4] OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support

https://bugzilla.tianocore.org/show_bug.cgi?id=3573 To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. v3: - Add the bugzilla link Cc: Ard

[edk2-devel] [PATCH v3 2/4] OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support

https://bugzilla.tianocore.org/show_bug.cgi?id=3573 To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. v3: - Add the bugzilla link Cc: Ard Biesheuvel Cc:

[edk2-devel] [PATCH v3 1/4] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

https://bugzilla.tianocore.org/show_bug.cgi?id=3573 There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as

[edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

When using HVM Direct kernel boot with OvmfXen, it could fail at the S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() and PcdAcpiS3Enable. This patch series initializes PcdAcpiS3Enable in . Besides, QemuFwCfgS3Enabled() is replaced with PcdAcpiS3Enable in several OVMF libraries

[edk2-devel] [PATCH v3] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. v3: Add the bugzilla link Cc: Ard Biesheuvel Cc: Jiewen Yao cc: Jordan Justen Cc: Anthony Perard Cc:

Re: [edk2-devel] Using linked lists in EDK II

Good day Ethin, Well, first of all, it's a doubly-linked list from the books, so you have a circular chain in both directions. There is no explicit "list head" type, rather you have a LIST_ENTRY instance that acts as your root (it may or may not contain data on its own based on your own

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuCacheInfoLib: Correct logical for identifying cache type

Reviewed-by: Ray Ni -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79704): https://edk2.groups.io/g/devel/message/79704 Mute This Topic: https://groups.io/mt/84864975/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Default for PeciC10Reset should be 1

Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, August 17, 2021 5:54 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Benjamin Doron > ; Michael Kubacki > > Subject: [edk2-platforms] [PATCH V2]