Re: [edk2-devel] [PATCH V5 1/2] OvmfPkg: Introduce Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-08-31 Thread Ard Biesheuvel
On Wed, 1 Sept 2021 at 08:10, Gerd Hoffmann wrote: > > Hi, > > > > I didn't fully investigate what kind of attacks one can do. I'm pretty > > > sure simply > > > making the variable store larger and the spare smaller works, so parts of > > > the > > > variable store are outside the area you a

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV

2021-08-31 Thread duntan
Hi all, I have push the commit to fix this issue to coreboot.org. Here is the link. https://review.coreboot.org/c/coreboot/+/57296 This issue is caused because the coreboot implementation doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER, resulting in address of UefiPayloadEntry to

Re: [edk2-devel] [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build

2021-08-31 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, August 31, 2021 4:40 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Kinney, Michael D > > Subject: [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build > > Cc: Agyeman Pri

Re: [edk2-devel] [PATCH 00/23] Enable Intel TDX in OvmfPkg (SEC/PEI)

2021-08-31 Thread Gerd Hoffmann
Hi, > Because the total patch-sets for TDVF upstreaming is too big and there are 2 > configurations. > So we split the upstreaming into below waves. > Config-A Config-B Phase > Wave-1Y YResetVector > Wave-

Re: [edk2-devel] [PATCH V5 1/2] OvmfPkg: Introduce Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-08-31 Thread Gerd Hoffmann
Hi, > > I didn't fully investigate what kind of attacks one can do. I'm pretty > > sure simply > > making the variable store larger and the spare smaller works, so parts of > > the > > variable store are outside the area you are measuring. Not fully sure > > whenever > > one can actually re

回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

2021-08-31 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1940 for this patch set. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 duntan > 发送时间: 2021年9月1日 11:32 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Sean Brogan' ; 'Bret Barkelew' > ; Kinney, Michael D > > 主题: Re: [edk2-devel] [PATCH 2/2] .azur

Re: [edk2-devel] [PATCH 00/23] Enable Intel TDX in OvmfPkg (SEC/PEI)

2021-08-31 Thread Min Xu
On August 31, 2021 6:46 PM, Gerd Hoffmann wrote: > Hi, > > > [TDX]: https://software.intel.com/content/dam/develop/external/us/en/ > > documents/tdx-whitepaper-final9-17.pdf > > So, coming back to this after reading through a bunch of docs and patches with > some high-level questions. The whit

Re: [edk2-devel] [PATCH V5 1/2] OvmfPkg: Introduce Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-08-31 Thread Min Xu
On August 31, 2021 6:21 PM, Gerd Hoffmann wrote: > On Tue, Aug 31, 2021 at 06:17:29AM +, Xu, Min M wrote: > > On August 31, 2021 1:13 PM, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > From a security point of view I don't think it is a good idea to > > > > > hard code any assumptions about t

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Move PiSmmCoreMemoryAllocationLib into PiSmmCore

2021-08-31 Thread Ni, Ray
Marvin, Your patch moves the memory allocation lib implementation to PiSmmCore. Can you remove the PiSmmCoreMemoryAllocationLib.inf completely? (or what forbids you remove this lib instance?) Thanks, Ray -Original Message- From: Marvin Häuser Sent: Sunday, August 22, 2021 3:56 AM To: d

[edk2-devel] MdeModulePkg: ARM alignment issues in InsertFpdt function in DxeCorePerformanceLib

2021-08-31 Thread Rebecca Cran
I'm working on getting the BeagleBoardPkg from edk2-platforms functional again, and have run into a few alignment faults in the InsertFpdtRecordfunction in MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c . For example, the Timestamp field of the FPDT_DUAL_GUID_STRING_EVENT_

Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

2021-08-31 Thread duntan
Hi Liming, The patch to fix the build issue has been merged this morning. Would you please help to merge the two patches to enable core CI for UefiPayloadPkg? Thanks, Dun -Original Message- From: gaoliming Sent: Tuesday, August 31, 2021 9:05 AM To: Tan, Dun ; devel@edk2.groups.io Cc:

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/6e68849 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, August 25, 2021 8:56 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Michael Kubacki ; Benjamin Doron Subject: [edk2-devel] [edk2-p

Re: [edk2-devel] [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md for IFWI Ingredients

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-non-osi/commit/eba85cf -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 12:55 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-non-osi] [PATCH V1] Whit

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib return value

2021-08-31 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, August 26, 2021 11:56 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Michael Kubacki > ; Benjamin Doron > > Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Document EcLib > ret

Re: [edk2-devel] [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md for IFWI Ingredients

2021-08-31 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, September 1, 2021 3:55 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel > > Subject: [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md > for IFWI Ingredients >

Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley and Whitley builds

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/98e8ab0 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 3:29 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Oram, Isaac W ; Liming Gao ; Dong, Eric ; Ni, Ray ; Lin, JackX

[edk2-devel] [edk2-platforms] [PATCH V1] SimicsOpenBoardPkg: Fix GCC Build

2021-08-31 Thread Nate DeSimone
Cc: Agyeman Prince Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc b/Platform/Intel/S

Re: [edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley and Whitley builds

2021-08-31 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, August 31, 2021 3:29 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Oram, Isaac W ; Liming Gao ; Dong, Eric ; Ni, Ray ; Lin, JackX Subject: [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley an

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Add LoadFile2 for linux initrd

2021-08-31 Thread Jeff Brasen via groups.io
Add support under a pcd feature for using the new interface to pass initrd to the linux kernel. Signed-off-by: Jeff Brasen --- EmbeddedPkg/EmbeddedPkg.dec | 1 + .../AndroidBootImgLib/AndroidBootImgLib.inf | 3 + .../AndroidBootImgLib/AndroidBootImgLib.c | 147 +++

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/5f67c57 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 10:27 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1]

[edk2-devel] [edk2-platforms] [PATCH V1] MinPlatformPkg: Fix Purley and Whitley builds

2021-08-31 Thread Nate DeSimone
Commit f4e12 causes a re-definition warning for the MAX_SOCKETS macro on PurleyOpenBoardPkg and WhitleyOpenBoardPkg. Cc: Chasel Chiu Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Cc: Jack Lin Signed-off-by: Nate DeSimone --- .../Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c

Re: [edk2-devel] [edk2-libc Patch 0/2] Resolve CLANGPDB build issues

2021-08-31 Thread Rebecca Cran
For the series: Reviewed-by: Rebecca Cran On 8/31/21 3:49 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1618 * Disable warnings for unused variables * Define __FILE__ to be __FILE_NAME__ * Disable warnings for unused command line arguments. * Define __warn_r

Re: [edk2-devel] [edk2-libc Patch] StdLib: Update libs for safe string functional issues

2021-08-31 Thread Rebecca Cran
Reviewed-by: Rebecca Cran On 8/31/21 3:20 PM, Michael D Kinney wrote: From: Jayaprakash Nevara REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 Update use of safe string functions that incorrectly assume that the maximum size of a string is UNICODE_STRING_MAX. This assumption is brea

[edk2-devel] [edk2-libc Patch 2/2] StdLib: Resolve CLANGPDB build issues

2021-08-31 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1618 Disable warnings for unused command line arguments. This is being triggered by -nostdlibinc flag enabled by tools_def.txt. Define __warn_references() to nothing for all toolchains. CLANGPDB by default is GCC like and was pulling in .stabs

[edk2-devel] [edk2-libc Patch 1/2] AppPkg/Applications/Enquire: Resolve CLANGPDB build issues

2021-08-31 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1618 Disable warnings for unused variables This application has a #include statement to include itself based on the built-in macro __FILE__. However, this macro is the full path to the file and the format of this file path generates errors from

[edk2-devel] [edk2-libc Patch 0/2] Resolve CLANGPDB build issues

2021-08-31 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1618 * Disable warnings for unused variables * Define __FILE__ to be __FILE_NAME__ * Disable warnings for unused command line arguments. * Define __warn_references() to nothing for all toolchains. Cc: Rebecca Cran Cc: Sivaraman Signed-off

[edk2-devel] [edk2-libc Patch] StdLib: Update libs for safe string functional issues

2021-08-31 Thread Michael D Kinney
From: Jayaprakash Nevara REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3361 Update use of safe string functions that incorrectly assume that the maximum size of a string is UNICODE_STRING_MAX. This assumption is breaking some standard C applications. Cc: Rebecca Cran Cc: Jayaprakash Neva

[edk2-devel] [edk2-non-osi] [PATCH V1] WhitleyOpenBoardBinPkg: Add Readme.md for IFWI Ingredients

2021-08-31 Thread Nate DeSimone
Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardBinPkg/Ifwi/README.md | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Platform/Intel/WhitleyOpenBoardBinPkg/Ifwi/README.md diff --git a/Platform/Intel/WhitleyOpenBoardBinPkg/I

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 4/4] Maintainers.txt: Add maintainers for WhitleyOpenBoardBinPkg

2021-08-31 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate DeSimone > Sent: Tuesday, August 31, 2021 10:28 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel > ; Kinney, Michael D > > Subject: [edk2-devel] [edk2-non-osi] [PATCH V1 4/

Re: [edk2-devel] [edk2-non-osi] [PATCH V1 0/4] Add IFWI Ingredients for Ice Lake-SP and Cooper Lake Boards

2021-08-31 Thread Oram, Isaac W
Series Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 10:28 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Kinney, Michael D Subject: [edk2-devel] [edk2-non-osi] [PATCH V1 0/4] Add IFWI Ing

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Oram, Isaac W
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, August 31, 2021 10:40 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFW

[edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Adds support for stitching the IFWI (Integrated Firmware Image) for Wilson City and Copper City Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardPkg/CooperCityRvp/build_board.py | 11 +++ .../CooperCityRvp/build_config.cfg| 2 +-

Re: [edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

2021-08-31 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/77bbf33 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Saturday, August 28, 2021 6:19 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Luo, Heng Subject: [edk2-devel] [edk2-platforms] [PATCH

Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP

2021-08-31 Thread Bassa, Damian
It refers to access to the root port device that doesn't exist in case we are dealing with RCiEP device. There can be specific case where RCiEP device has ARI extended capability ID (even though it's unsupported in this case). In such a case PciSearchDevice goes to CreatePciIoDevice through Gath

[edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg: Add support for IFWI stitching

2021-08-31 Thread Nate DeSimone
Adds support for stitching the IFWI (Integrated Firmware Image) for Wilson City and Copper City Cc: Isaac Oram Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../WhitleyOpenBoardPkg/CooperCityRvp/build_board.py | 11 +++ .../CooperCityRvp/build_config.cfg| 2 +-

[edk2-devel] [edk2-non-osi] [PATCH V1 4/4] Maintainers.txt: Add maintainers for WhitleyOpenBoardBinPkg

2021-08-31 Thread Nate DeSimone
Cc: Isaac Oram Cc: Chasel Chiu Cc: Michael D Kinney Signed-off-by: Nate DeSimone --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index b8a4140..6ac132c 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -45,6 +45,11 @@ Platform/

[edk2-devel] [edk2-non-osi] [PATCH V1 0/4] Add IFWI Ingredients for Ice Lake-SP and Cooper Lake Boards

2021-08-31 Thread Nate DeSimone
This patch series adds IFWI ingredients for Ice Lake-SP and Cooper Lake boards. This allows the MinPlatform build to produce a full IFWI (Integrated Firmware Image) instead of just the BIOS region. Cc: Isaac Oram Cc: Chasel Chiu Cc: Michael D Kinney Nate DeSimone (4): WhitleyOpenBoardBinPkg:

Re: [edk2-devel] [PATCH 10/17] OvmfPkg/Microvm: use XenTimerDxe (lapic timer)

2021-08-31 Thread Philippe Mathieu-Daudé
On 8/31/21 11:57 AM, Gerd Hoffmann wrote: > Microvm has no acpi timer, so go use XenTimerDxe > which uses the local apic instead. > > FIXME: timer frequency is wrong. Xen seems to expect a 10MHz timer. Maybe use as constant to make a generic LocalAPICTimer driver used by both Xen and microVM (wit

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message

2021-08-31 Thread Philippe Mathieu-Daudé
On 8/31/21 12:36 AM, Rebecca Cran wrote: > Fix a typo of "memory" in a debug message in RamDiskProtocol.c. > > Signed-off-by: Rebecca Cran > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskProtocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daude

Re: [edk2-devel] [edk2-platforms PATCH v3 1/1] Maintainers.txt: Add maintainer of Ext4Pkg

2021-08-31 Thread Michael D Kinney
Pushed as 98092b8026e3cdee1e66a1fe7ecdb70cd267014c Mike > -Original Message- > From: Kinney, Michael D > Sent: Monday, August 30, 2021 9:28 AM > To: devel@edk2.groups.io; pedro.falc...@gmail.com; Kinney, Michael D > > Cc: Leif Lindholm > Subject: RE: [edk2-devel] [edk2-platforms PATCH

Re: [edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Yao, Jiewen
Thank you. That confirms my guess. If you can add all those info in readme, that would be great, especially the URL https://qemu.readthedocs.io/en/latest/system/i386/microvm.html, as well as the scope. I have not reviewed all detail, and I think it is good idea. Acked-by: Jiewen Yao > -O

Re: [edk2-devel] [edk2-platforms PATCH] Platform/RaspberryPi: Check for Boot Discovery Policy change.

2021-08-31 Thread Ard Biesheuvel
On Wed, 18 Aug 2021 at 09:38, Grzegorz Bernacki wrote: > > This patch adds checks if Boot Discovery Policy has been > changed. Only in that case EfiBootManagerRefreshAllBootOption() > should be called. > > Signed-off-by: Grzegorz Bernacki To be honest, I'm not a fan of this bodge. Can you explai

Re: [edk2-devel] [RESEND PATCH v3] OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe

2021-08-31 Thread Ard Biesheuvel
On Tue, 31 Aug 2021 at 03:30, Lin, Gary (HPS OE-Linux) wrote: > > Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download > the kernel, initrd, and kernel command line from QEMU's fw_cfg. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 > > Cc: Ard Biesheuvel > Cc: Jiew

Re: [edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Gerd Hoffmann
On Tue, Aug 31, 2021 at 12:23:32PM +0200, Ard Biesheuvel wrote: > Hi Gerd, > > On Tue, 31 Aug 2021 at 11:57, Gerd Hoffmann wrote: > > > > This patch series adds basic support for the > > microvm machine type to OVMF. > > > > Can you provide a bit more background on this machine type, and on why

Re: [edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Gerd Hoffmann
On Tue, Aug 31, 2021 at 10:31:31AM +, Yao, Jiewen wrote: > Hi Gerd > I would like to confirm a couple of things: > > -1) Since this is a big new feature, please follow process to submit Bugzilla. > > 0) I hope we can include a readme file to introduce more background and the > scope of the n

Re: [edk2-devel] [RESEND PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

2021-08-31 Thread Ard Biesheuvel
On Tue, 31 Aug 2021 at 03:31, Lin, Gary (HPS OE-Linux) wrote: > > When using HVM Direct kernel boot with OvmfXen, it could fail at the > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled() > and PcdAcpiS3Enable. > > This patch series initializes PcdAcpiS3Enable in > . Besides, QemuF

Re: [edk2-devel] [PATCH 00/23] Enable Intel TDX in OvmfPkg (SEC/PEI)

2021-08-31 Thread Gerd Hoffmann
Hi, > [TDX]: https://software.intel.com/content/dam/develop/external/us/en/ > documents/tdx-whitepaper-final9-17.pdf So, coming back to this after reading through a bunch of docs and patches with some high-level questions. The whitepaper lists two ovmf configs: (1) config-a, supporting norm

Re: [edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Yao, Jiewen
Hi Gerd I would like to confirm a couple of things: -1) Since this is a big new feature, please follow process to submit Bugzilla. 0) I hope we can include a readme file to introduce more background and the scope of the new project. 1) What is the device list of microvm? Or do you mean https:/

Re: [edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Ard Biesheuvel
Hi Gerd, On Tue, 31 Aug 2021 at 11:57, Gerd Hoffmann wrote: > > This patch series adds basic support for the > microvm machine type to OVMF. > Can you provide a bit more background on this machine type, and on why we'd want to support this? Does it have any relation to confidential computing?

Re: [edk2-devel] [PATCH V5 1/2] OvmfPkg: Introduce Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-08-31 Thread Gerd Hoffmann
On Tue, Aug 31, 2021 at 06:17:29AM +, Xu, Min M wrote: > On August 31, 2021 1:13 PM, Gerd Hoffmann wrote: > > Hi, > > > > > > From a security point of view I don't think it is a good idea to > > > > hard code any assumptions about the layout of the vars volume. > > > Do you mean I cannot ass

[edk2-devel] [PATCH 16/17] OvmfPkg/Microvm: use PciHostBridgeLibNull

2021-08-31 Thread Gerd Hoffmann
Shortcut PCI support for now (proper PCIe support will be wired up later). Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index aaab0fda19c1..e3238

[edk2-devel] [PATCH 17/17] OvmfPkg/Microvm: wire up serial console, drop super-io

2021-08-31 Thread Gerd Hoffmann
Microvm has no LPC bridge, so drop the PciSioSerialDxe driver. Use SerialDxe instead, with ioport hardcoded to 0x3f8 aka com1 aka ttyS0. With this tianocore boots to uefi shell prompt on the serial console. Direct kernel boot can be used too. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/Mic

[edk2-devel] [PATCH 14/17] OvmfPkg/ResetSystemLib: add driver for microvm

2021-08-31 Thread Gerd Hoffmann
Uses the generic event device to reset and poweroff. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc| 14 +-- .../BaseResetSystemLibMicrovm.inf | 37 .../DxeResetSystemLibMicrovm.inf | 40 + OvmfPkg/Include/IndustryStandar

[edk2-devel] [PATCH 15/17] OvmfPkg/Microvm: BdsPlatform: PciAcpiInitialization tweak.

2021-08-31 Thread Gerd Hoffmann
Nothing to do here ;) Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c index b0e97429372b..618a9

[edk2-devel] [PATCH 13/17] OvmfPkg/Microvm: PlatformPei/Platform misc tweaks

2021-08-31 Thread Gerd Hoffmann
Add + set microvm id for PcdOvmfHostBridgePciDevId. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Include/IndustryStandard/Microvm.h | 6 ++ OvmfPkg/PlatformPei/Platform.c | 7 +++ 2 files changed, 13 insertions(+) create mode 100644 OvmfPkg/Include/IndustryStandard/Microvm.h di

[edk2-devel] [PATCH 12/17] OvmfPkg/Microvm: PlatformPei/Platform memory map tweaks

2021-08-31 Thread Gerd Hoffmann
Microvm needs ioapic hobs only. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c index d3a20122a2ea..d425a5c429c6 100644 --- a/OvmfPkg/PlatformPei/Platform.c +

[edk2-devel] [PATCH 11/17] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-08-31 Thread Gerd Hoffmann
Skip host bridge setup on microvm. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/MemDetect.c | 4 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c index 2c2c4641ec8a..d736b85e0d90 100644 --- a/OvmfPkg/PlatformPei/MemDetec

[edk2-devel] [PATCH 10/17] OvmfPkg/Microvm: use XenTimerDxe (lapic timer)

2021-08-31 Thread Gerd Hoffmann
Microvm has no acpi timer, so go use XenTimerDxe which uses the local apic instead. FIXME: timer frequency is wrong. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 +-- OvmfPkg/Microvm/MicrovmX64.fdf | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Ov

[edk2-devel] [PATCH 09/17] OvmfPkg/Microvm: use MdePkg/Library/SecPeiDxeTimerLibCpu

2021-08-31 Thread Gerd Hoffmann
Microvm has no acpi timer, so use the generic lib instead. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index d33a5b095205..de68446e7f48

[edk2-devel] [PATCH 08/17] OvmfPkg/Microvm: no emulated scsi

2021-08-31 Thread Gerd Hoffmann
Microvm focus is virtio, so go drop support for emulated scsi host adapters. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 - OvmfPkg/Microvm/MicrovmX64.fdf | 9 - 2 files changed, 18 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microv

[edk2-devel] [PATCH 05/17] OvmfPkg/Microvm: no tpm

2021-08-31 Thread Gerd Hoffmann
Microvm has no TPM support. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 76 +- OvmfPkg/Microvm/MicrovmX64.fdf | 18 2 files changed, 1 insertion(+), 93 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/Micro

[edk2-devel] [PATCH 07/17] OvmfPkg/Microvm: no csm

2021-08-31 Thread Gerd Hoffmann
Guests depending on BIOS will probably not work that well with microvm due to legacy hardware being not available. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 26 -- OvmfPkg/Microvm/MicrovmX64.fdf | 6 -- 2 files changed, 32 deletions(-) diff -

[edk2-devel] [PATCH 06/17] OvmfPkg/Microvm: no sev

2021-08-31 Thread Gerd Hoffmann
Microvm has no SEV support. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 1 - OvmfPkg/Microvm/MicrovmX64.fdf | 2 -- 2 files changed, 3 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc index 6c8f55c7b1bd..646ce5f0d8cf 100644 --- a/Ov

[edk2-devel] [PATCH 02/17] OvmfPkg/Microvm: rename output files, fix includes

2021-08-31 Thread Gerd Hoffmann
Rename the firmware volume files (s/OVMF/MICROVM/). Fix includes so they work with microvm config being in a subdirectory. With this patch applied the build works. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 8 OvmfPkg/Microvm/MicrovmX64.fdf | 14 +++--- 2

[edk2-devel] [PATCH 04/17] OvmfPkg/Microvm: no secure boot

2021-08-31 Thread Gerd Hoffmann
Without SMM secure boot isn't actually secure, so drop it too. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 15 --- OvmfPkg/Microvm/MicrovmX64.fdf | 4 2 files changed, 19 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX6

[edk2-devel] [PATCH 03/17] OvmfPkg/Microvm: no smm

2021-08-31 Thread Gerd Hoffmann
Microvm has no SMM support. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 86 +- OvmfPkg/Microvm/MicrovmX64.fdf | 30 2 files changed, 1 insertion(+), 115 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/

[edk2-devel] [PATCH 01/17] OvmfPkg/Microvm: copy OvmfPkgX64 files as-is

2021-08-31 Thread Gerd Hoffmann
Create Microvm subdirectory. Copy OvmfPkgX64 .dsc and .fdf files unmodified as starting point for MicrovmX64. Changes come as separate patches, to simplify patch review and rebases. Rebase helper: OvmfPkg/Microvm/rebase-update.sh Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc

[edk2-devel] [PATCH 00/17] [RFC] OvmfPkg: Add support for microvm machine type

2021-08-31 Thread Gerd Hoffmann
This patch series adds basic support for the microvm machine type to OVMF. Working: - uefi shell @ serial console. - direct kernel boot. Comming in followup patches: - virtio-mmio support. - pcie support. TODO: - better timer support. Usage: qemu-system-x86_64 -nographic -M microvm