Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-08 Thread Gerd Hoffmann
Hi, > One more question, there is already a > QemuFwCfgLib library for ia32/x64. The naming of QemuFwCfgCommonLib > under Library seems confusing. How about we put this library under > /FDT and also name it as QemuFwCfgLib? Because ARM/RISC-V fw_cfg also > depends on FDT. Move it to

[edk2-devel] [PATCH v1 3/3] MdeModulePkg/Core/Pei: Fix pointer size mismatch in EvacuateTempRam()

2021-09-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3512 In 32-bit PEI, the local variable pointers MigratedFvHeader and RawDataFvHeader in EvacuateTempRam() will be 32-bit in size. The pointers are currently passed to PeiServicesAllocatePages() which expects a 64-bit

[edk2-devel] [PATCH v1 2/3] MdeModulePkg/Core/Pei: Make migrated PEIM message verbose

2021-09-08 Thread Michael Kubacki
From: Michael Kubacki Currently, the debug message that prints the name of a PEIM being migrated is DEBUG_INFO while similar messages are DEBUG_VERBOSE. This change updates the print level to DEBUG_VERBOSE for consistency. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Michael

[edk2-devel] [PATCH v1 1/3] MdeModulePkg/Core/Pei: Fix typo in function descriptions

2021-09-08 Thread Michael Kubacki
From: Michael Kubacki Corrects a typo in the return value description of MigratePeim() and EvacuateTempRam(): "Succesfully" to "Successfully" Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Michael Kubacki --- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 4 ++--

[edk2-devel] [PATCH v1 0/3] MdeModulePkg/Core/Pei: Migration improvements and fixes

2021-09-08 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3512 This patch series contains three patches. The first two are for relatively minor improvments - a typo fix in function descriptions and changing the error level of a debug print. The third patch fixes a pointer size

Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg/Console: Improve encoding of box drawing characters

2021-09-08 Thread Gao, Zhichao
Hi Caden, The patch doesn't address all the comment I point out. If you think I am incorrect, please feel free to point out. See below: > -Original Message- > From: Caden Kline > Sent: Monday, August 23, 2021 10:44 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao,

Re: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC structure

2021-09-08 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Abdul Lateef Attar > Sent: Tuesday, August 24, 2021 11:30 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Abdul Lateef Attar > Subject: [edk2-devel] [PATCH] ShellPkg: Parse I/O APIC and x2APIC

Re: [edk2-devel] [PATCH v1] ShellPkg: Update Acpiview HMAT parser to ACPI spec version 6.4

2021-09-08 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Wednesday, August 18, 2021 7:09 PM > To: Christopher Jones ; > devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Ben > Adderson ; Akanksha Jain > ; Matteo

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

2021-09-08 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Sami Mujawar > Sent: Wednesday, August 18, 2021 5:57 PM > To: Christopher Jones ; > devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Alexei Fedorov ; Ben Adderson > ; Akanksha Jain ; > Matteo Carlini ; nd >

Re: [edk2-devel] [PATCH v1 0/2] Support ACPI 6.4 in Acpiview PCCT parser

2021-09-08 Thread Gao, Zhichao
For this patch set, Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Chris Jones > Sent: Saturday, August 14, 2021 1:03 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > sami.muja...@arm.com; ben.adder...@arm.com; > akanksha.ja...@arm.com;

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid

2021-09-08 Thread Zhiguang Liu
Reviewed-by: Zhiguang Liu From: devel@edk2.groups.io on behalf of duntan Sent: Tuesday, August 31, 2021 13:38 To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Liu, Zhiguang ; Tan, Dun Subject: [edk2-devel] [Patch V2 2/2]

Re: [edk2-devel] [Patch V2 1/2] UefiPayloadPkg: Fix the bug in dump guid HOB info functions

2021-09-08 Thread Zhiguang Liu
Thank Dun for the fix. Reviewed-by: Zhiguang Liu From: Tan, Dun Sent: Tuesday, August 31, 2021 13:38 To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin ; Liu, Zhiguang ; Tan, Dun Subject: [Patch V2 1/2] UefiPayloadPkg: Fix the bug

回复: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

2021-09-08 Thread gaoliming
Acked-by: Liming Gao for this patch set. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2021年8月30日 21:46 > 收件人: Rebecca Cran > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen ; Sean > Brogan ; Sami Mujawar > ; Leif Lindholm ; Ard > Biesheuvel ;

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-08 Thread Min Xu
On September 9, 2021 3:46 AM, Brijesh Singh wrote: > > Thank you so much Yao for reviewing the patches. Based on some comments > from Gerd I may update code around the reset vector area (mainly use the > metadata format etc). For your comments regarding the introducing a new >

Re: [edk2-devel] Compilation error in ArmVExpress-FVP-AArch64.dsc

2021-09-08 Thread ishii.shuuic...@fujitsu.com
Hi, Pierre. Thank you very much for quickly reply. Based on Pierre's advice, I deleted the edk2 directory that I had been using and ran the git clone of edk2 again, also used the master branch to specify the latest commit as of yesterday. I also took Sami's advice and specified Python 3.7.

Re: [edk2-devel] Compilation error in ArmVExpress-FVP-AArch64.dsc

2021-09-08 Thread ishii.shuuic...@fujitsu.com
Hi, Sami. Thank you very much for quickly reply. > Please let me know if switching to Python 3.7 does not fix this issue for you. As advised, I compiled using Python-3.7 (Python-3.7.9). If I simply changed the Python version, the build did not finish successfully and the same error occurred.

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-08 Thread Yao, Jiewen
Many reasons on an Entrypoint not called. I share my experence below (I encountered all of them before): 1) You update the code in a wrong tree. 2) The image is not rebuild. You still use old image. 3) The image is rebuild, but the image is not reburn to the flash. 4) The driver is not in final

Re: [edk2-devel] Compilation error in ArmVExpress-FVP-AArch64.dsc

2021-09-08 Thread ishii . shuuichir
Hi, Pierre. Thank you very much for quickly reply. Based on Pierre's advice, I deleted the edk2 directory that I had been using and ran the git clone of edk2 again, ,also used the master branch to specify the latest commit as of yesterday. I also took Sami's advice and specified Python 3.7.

Re: [edk2-devel] Compilation error in ArmVExpress-FVP-AArch64.dsc

2021-09-08 Thread ishii . shuuichir
I forgot to mention that there may be problems with older python, so I will basically use the newer versions of python as advised. Best regards, Shuuichrou. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80385):

Re: [edk2-devel] Compilation error in ArmVExpress-FVP-AArch64.dsc

2021-09-08 Thread ishii . shuuichir
Hi, Sami. Thank you very much for quickly reply. > Please let me know if switching to Python 3.7 does not fix this issue for you. As advised, I compiled using Python-3.7 (Python-3.7.9). If I simply changed the Python version, the build did not finish successfully and the same error occurred.

Re: [EXTERNAL] [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-08 Thread Oram, Isaac W
That sounds very reasonable to me. I have done something similar with basic PPI/Protocol services to abstract phase specific differences that a lot of code simply doesn't need to care about. I even like the idea of a general "phase agnostic services library" that handles these kinds of things

[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Build: Reduce debug output for default boot.

2021-09-08 Thread Oram, Isaac W
Replace Info with Load, so we still get component loading details Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [EXTERNAL] [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-08 Thread Bret Barkelew via groups.io
Question: I’ve recently brought up with some that the GetVariable##() functions in UefiLib are probably incorrect as they are written (because they assume things like gRT and gBS availability). Would it perhaps make sense to move this interface up into the MdePkg scope and leverage it to start

[edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-08 Thread Oram, Isaac W
Add the VariableReadLib and VariableWriteLib instances to Components to ensure build when building MinPlatformPkg.dsc. Add a NULL library instance that provides the non-functional library instance for VariableReadLib designed for all phase use. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-08 Thread Stefan Berger
On 9/8/21 10:37 AM, Yao, Jiewen wrote: Hi Stefan According to our security policy, the PPI must be sent before EndOfDxe. Then registering PlatformAuth clear at EndOfDxe is safe. I still don’t get your point on why we have do in PlatformBds. At least, I do want to make sure all X86

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-08 Thread Brijesh Singh via groups.io
Thank you so much Yao for reviewing the patches. Based on some comments from Gerd I may update code around the reset vector area (mainly use the metadata format etc). For your comments regarding the introducing a new PcdConfidentialComputingCategory I will look to see what I can come up with

[edk2-devel] [PATCH edk2-test v2 1/1] uefi-sct/SctPkg: fix BuildAtaDeviceNode()

2021-09-08 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3290 When BuildAtaDeviceNode() is called with L"Ata(0,0,0)" it creates a node Ata(1,1,0). This leads to test to an assertion failed test result ../DevicePathToTextBBTestFunction.c:332: Convert result: Ata(0,0,0) - Expected:

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState

2021-09-08 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3390 According to the UEFI specification EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState() may return EFI_UNSUPPORTED if "the device does not support the ability to have its state set." BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1() must not

[edk2-devel] [PATCH v3 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-08 Thread Nhi Pham via groups.io
This adds more helper functions that assist in calculating the checksum, locating an ACPI table by signature, and updating an AML integer object. Cc: Ard Biesheuvel Cc: Daniel Schaefer Signed-off-by: Nhi Pham Acked-by: Leif Lindholm Reviewed-by: Abner Chang --- Changes since v2: + Correct

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-08 Thread Nhi Pham via groups.io
Thanks Abner. I will correct the description for the function AcpiLocateTableBySignature in the v3. Best regards, Nhi On 08/09/2021 11:53, Chang, Abner (HPS SW/FW Technologist) wrote: After below comments are addressed, Reviewed-by: Abner Chang -Original Message- From:

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Limit the boot description to 72 chars

2021-09-08 Thread Ni, Ray
Zhichao, I didn't mean to update UI logic to support scrolling. I meant to update BM logic to show partial string of boot description. Thanks, Ray > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, September 8, 2021 10:29 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang,

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-09-08 Thread Nhi Pham via groups.io
Hi Leif, Thanks for your reviewing. These functions in this patch are consumed in Ampere Mt. Jade platform. We can defer merging this patch until I send the v3 of Ampere Mt. Jade patchset out. Best regards, Nhi On 08/09/2021 01:00, Leif Lindholm wrote: Hi Nhi, On Fri, Sep 03, 2021 at

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc/Readme.md: Updated Readme.md with Python 3.6.8 License details

2021-09-08 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3611 This commit contains updates made to the Readme.md file of edk2-libc repo to add the Python 3.6.8 license at appropriate section in the file Cc: Rebecca Cran Cc: Michael D Kinney --- Readme.md | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-libc Patch 0/1] updated to Readme.md of edk2-libc with py 3.6.8 License file details

2021-09-08 Thread Jayaprakash, N
Jayaprakash Nevara (1): edk2-libc/Readme.md: Updated Readme.md with Python 3.6.8 License details Readme.md | 1 + 1 file changed, 1 insertion(+) -- 2.32.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80370):

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 15:33:34 +, Abner Chang wrote: > > > I prefer to have RISC-V instance because I > > > am not sure if any fw_cfg interface changes would be made on RISC-V > > > QEMU. > > > > The fw_cfg interface should not diverge. ia32/x64 works a bit different > > because there is a

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-08 Thread Abner Chang
> -Original Message- > From: 'Gerd Hoffmann' [mailto:kra...@redhat.com] > Sent: Wednesday, September 8, 2021 9:37 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: Leif Lindholm ; Yao, Jiewen ; > devel@edk2.groups.io; gaoliming ; 'Ard > Biesheuvel' ; Kinney, Michael D > ; Ni, Ray ;

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-08 Thread Yao, Jiewen
Hi Stefan According to our security policy, the PPI must be sent before EndOfDxe. Then registering PlatformAuth clear at EndOfDxe is safe. I still don’t get your point on why we have do in PlatformBds. At least, I do want to make sure all X86 implementation are align to one solution. Also, for

Re: [edk2-devel] [PATCH v1] ShellPkg: Update Acpiview HMAT parser to ACPI spec version 6.4

2021-09-08 Thread Chris Jones
I believe this patch series is just waiting for approval from the ShellPkg maintainers. As this has been waiting for several weeks, please could this get reviewed soon. Thanks, Chris From: Sami Mujawar Sent: Wednesday, August 18, 2021 12:08 PM To: Christopher

Re: [edk2-devel] [PATCH v1 0/2] Support ACPI 6.4 in Acpiview PCCT parser

2021-09-08 Thread Chris Jones
I believe this patch series is just waiting for approval from the ShellPkg maintainers. As this has been waiting for several weeks, please could this get reviewed soon. Thanks, Chris From: Sami Mujawar Sent: Wednesday, August 18, 2021 11:32 AM To: Christopher

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

2021-09-08 Thread Chris Jones
I believe this patch series is just waiting for approval from the ShellPkg maintainers. As this has been waiting for several weeks, please could this get reviewed soon. Thanks, Chris From: Sami Mujawar Sent: Wednesday, August 18, 2021 10:57 AM To: Christopher

[edk2-devel] [PATCH v6 2/9] SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib

2021-09-08 Thread Stefan Berger
Fix some bugs in the original PeiDxeTpmPlatformHierarchyLib.c. Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 23 +-- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git

[edk2-devel] [PATCH v6 0/9] Ovmf: Disable the TPM2 platform hierarchy

2021-09-08 Thread Stefan Berger
This series imports code from the edk2-platforms project related to disabling the TPM2 platform hierarchy in Ovmf and ArmVirtPkg. It addresses the Ovmf aspects of the following bugs: https://bugzilla.tianocore.org/show_bug.cgi?id=3510 https://bugzilla.tianocore.org/show_bug.cgi?id=3499 I have

[edk2-devel] [PATCH v6 8/9] ArmVirtPkg: Reference new TPM classes in the build system for compilation

2021-09-08 Thread Stefan Berger
Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ ArmVirtPkg/ArmVirtQemuKernel.dsc| 1 + ArmVirtPkg/ArmVirtXen.dsc

[edk2-devel] [PATCH v6 7/9] SecurityPkg: Disable TPM platform hierarchy if TPM resume fails (S3 resume)

2021-09-08 Thread Stefan Berger
If Tpm2Startup(TPM_SU_STATE) fails, call ConfigureTPMPlatformHierarchy() to disable the platform hierarchy. Signed-off-by: Stefan Berger --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 2 ++ SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 + 2 files changed, 3 insertions(+) diff --git

[edk2-devel] [PATCH v6 1/9] SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms

2021-09-08 Thread Stefan Berger
Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms. Signed-off-by: Stefan Berger --- .../Include/Library/TpmPlatformHierarchyLib.h | 27 ++ .../PeiDxeTpmPlatformHierarchyLib.c | 266 ++ .../PeiDxeTpmPlatformHierarchyLib.inf | 45 +++ 3 files changed,

[edk2-devel] [PATCH v6 6/9] OvmfPkg: Disable the TPM2 platform hierarchy

2021-09-08 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Do this after handling physical presence interface opcodes because the TPM 2 commands they produce may require access to the platform hierarchy. Signed-off-by: Stefan Berger ---

[edk2-devel] [PATCH v6 9/9] ArmVirtPkg: Disable the TPM2 platform hierarchy

2021-09-08 Thread Stefan Berger
Use the newly added function to disable the TPM2 platform hierarchy. Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + 2 files changed, 7 insertions(+) diff --git

[edk2-devel] [PATCH v6 4/9] SecurityPkg: Introduce new PCD PcdRandomizePlatformHierarchy

2021-09-08 Thread Stefan Berger
Introduce the new PCD gEfiSecurityPkgTokenSpaceGuid.PcdRandomizePlatformHierarchy. Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.inf | 3 +-- SecurityPkg/SecurityPkg.dec | 6 ++ 2 files changed, 7 insertions(+), 2

[edk2-devel] [PATCH v6 3/9] SecurityPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-09-08 Thread Stefan Berger
Add a NULL implementation of the library class TpmPlatformHierarchyLib Signed-off-by: Stefan Berger --- .../PeiDxeTpmPlatformHierarchyLib.c | 19 .../PeiDxeTpmPlatformHierarchyLib.inf | 31 +++ 2 files changed, 50 insertions(+) create mode 100644

[edk2-devel] [PATCH v6 5/9] OvmfPkg: Reference new TPM classes in the build system for compilation

2021-09-08 Thread Stefan Berger
Compile the added TPM related code now. Signed-off-by: Stefan Berger --- OvmfPkg/AmdSev/AmdSevX64.dsc| 2 ++ OvmfPkg/Bhyve/BhyveX64.dsc | 1 + .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-08 Thread Gerd Hoffmann
Hi, > > Are you expecting to need different functionality from the ArmVirtPkg > > one? If not, you could move that one to > > OvmfPkg/Library/QemuFwCfgCommonLib > > or something. > The interfaces provided by ARM QemuFwLib seems works fine with RISC-V > OVMF, however the build fail with the

Re: [edk2-devel] [PATCH v5 0/8] Ovmf: Disable the TPM2 platform hierarchy

2021-09-08 Thread Stefan Berger
On 9/6/21 8:34 AM, Yao, Jiewen wrote: 2) I am curious, why you don't use a DXE driver, but choose to like to BDS lib for the DXE case. You also include a NULL lib there, which seems unnecessary, if you use a DXE/PEI module. The downside of linking to BDS lib is that you have to change all

Re: [edk2-devel] [RFC] RISC-V QEMU virtual package

2021-09-08 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Wednesday, September 8, 2021 1:22 AM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: Yao, Jiewen ; devel@edk2.groups.io; gaoliming > ; 'Ard Biesheuvel' ; > Kinney, Michael D ; Ni, Ray > ; Schaefer, Daniel ;

Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 13:46:43 +0200, Gerd Hoffmann wrote: > On Wed, Sep 08, 2021 at 12:13:12PM +0100, Leif Lindholm wrote: > > On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote: > > > Linaro no longer do gcc releases - Arm creates them now. > > > > > > Update the

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 13:33:51 +0200, Gerd Hoffmann wrote: > On Wed, Sep 08, 2021 at 12:06:46PM +0100, Leif Lindholm wrote: > > On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > > > Skip host bridge setup on microvm. > > > > > > Ref:

Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

2021-09-08 Thread Gerd Hoffmann
On Wed, Sep 08, 2021 at 12:13:12PM +0100, Leif Lindholm wrote: > On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote: > > Linaro no longer do gcc releases - Arm creates them now. > > > > Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to > > switch from Linaro's old

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Gerd Hoffmann
On Wed, Sep 08, 2021 at 12:06:46PM +0100, Leif Lindholm wrote: > On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > > Skip host bridge setup on microvm. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > > Signed-off-by: Gerd Hoffmann > > Acked-by: Jiewen Yao > > ---

Re: [edk2-devel] [PATCH v2 0/2] BaseTools: Switch to downloading the ARM/AARCH64 compiler from Arm's site

2021-09-08 Thread Leif Lindholm
On Sun, Aug 29, 2021 at 23:14:48 -0600, Rebecca Cran wrote: > Linaro no longer do gcc releases - Arm creates them now. > > Update the gcc_[arm,aarch64]_linux_ext_dep.yaml files in BaseTools/Bin to > switch from Linaro's old release to the latest gcc 10.3-2021.07 release > from Arm and fix

Re: [edk2-devel] [PATCH v3 19/19] OvmfPkg/Microvm: add Maintainers.txt entry

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 11:01:19 +0200, Gerd Hoffmann wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > Signed-off-by: Gerd Hoffmann > Reviewed-by: Jiewen Yao Reviewed-by: Leif Lindholm > --- > Maintainers.txt | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Leif Lindholm
On Wed, Sep 08, 2021 at 11:01:11 +0200, Gerd Hoffmann wrote: > Skip host bridge setup on microvm. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 > Signed-off-by: Gerd Hoffmann > Acked-by: Jiewen Yao > --- > OvmfPkg/PlatformPei/MemDetect.c | 4 > 1 file changed, 4

[edk2-devel] [PATCH v3 19/19] OvmfPkg/Microvm: add Maintainers.txt entry

2021-09-08 Thread Gerd Hoffmann
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Reviewed-by: Jiewen Yao --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 41f491bcaed1..52f9aa99ac7d 100644 --- a/Maintainers.txt +++

[edk2-devel] [PATCH v3 18/19] OvmfPkg/Microvm: add README

2021-09-08 Thread Gerd Hoffmann
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/README | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 OvmfPkg/Microvm/README diff --git a/OvmfPkg/Microvm/README

[edk2-devel] [PATCH v3 16/19] OvmfPkg/Microvm: use PciHostBridgeLibNull

2021-09-08 Thread Gerd Hoffmann
Shortcut PCI support for now (proper PCIe support will be wired up later). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v3 17/19] OvmfPkg/Microvm: wire up serial console, drop super-io

2021-09-08 Thread Gerd Hoffmann
Microvm has no LPC bridge, so drop the PciSioSerialDxe driver. Use SerialDxe instead, with ioport hardcoded to 0x3f8 aka com1 aka ttyS0. With this tianocore boots to uefi shell prompt on the serial console. Direct kernel boot can be used too. Ref:

[edk2-devel] [PATCH v3 15/19] OvmfPkg/Microvm: BdsPlatform: PciAcpiInitialization tweak.

2021-09-08 Thread Gerd Hoffmann
Nothing to do here ;) Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c

[edk2-devel] [PATCH v3 13/19] OvmfPkg/Microvm: PlatformPei/Platform: add id.

2021-09-08 Thread Gerd Hoffmann
Add + set microvm id for PcdOvmfHostBridgePciDevId. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Include/IndustryStandard/Microvm.h | 12 OvmfPkg/PlatformPei/Platform.c | 7 +++ 2 files

[edk2-devel] [PATCH v3 14/19] OvmfPkg/ResetSystemLib: add driver for microvm

2021-09-08 Thread Gerd Hoffmann
Uses the generic event device to reset and poweroff. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc| 14 +-- .../BaseResetSystemLibMicrovm.inf | 37

[edk2-devel] [PATCH v3 12/19] OvmfPkg/Microvm: PlatformPei/Platform memory map tweaks

2021-09-08 Thread Gerd Hoffmann
Microvm needs ioapic hobs only. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/PlatformPei/Platform.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/OvmfPkg/PlatformPei/Platform.c

[edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-08 Thread Gerd Hoffmann
Skip host bridge setup on microvm. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/PlatformPei/MemDetect.c | 4 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/PlatformPei/MemDetect.c

[edk2-devel] [PATCH v3 09/19] OvmfPkg/Microvm: use MdePkg/Library/SecPeiDxeTimerLibCpu

2021-09-08 Thread Gerd Hoffmann
Microvm has no acpi timer, so use the generic lib instead. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

[edk2-devel] [PATCH v3 10/19] OvmfPkg/Microvm: use XenTimerDxe (lapic timer)

2021-09-08 Thread Gerd Hoffmann
Microvm has no acpi timer, so go use XenTimerDxe which uses the local apic instead. Set PcdFSBClock to 1000 MHz, which is the lapic timer frequency used by KVM. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao ---

[edk2-devel] [PATCH v3 08/19] OvmfPkg/Microvm: no emulated scsi

2021-09-08 Thread Gerd Hoffmann
Microvm focus is virtio, so go drop support for emulated scsi host adapters. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 - OvmfPkg/Microvm/MicrovmX64.fdf | 9 - 2 files

[edk2-devel] [PATCH v3 06/19] OvmfPkg/Microvm: no sev

2021-09-08 Thread Gerd Hoffmann
Microvm has no SEV support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 1 - OvmfPkg/Microvm/MicrovmX64.fdf | 2 -- 2 files changed, 3 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc

[edk2-devel] [PATCH v3 05/19] OvmfPkg/Microvm: no tpm

2021-09-08 Thread Gerd Hoffmann
Microvm has no TPM support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Berger Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 76 +- OvmfPkg/Microvm/MicrovmX64.fdf | 18 2 files

[edk2-devel] [PATCH v3 07/19] OvmfPkg/Microvm: no csm

2021-09-08 Thread Gerd Hoffmann
Guests depending on BIOS will probably not work that well with microvm due to legacy hardware being not available. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 26 --

[edk2-devel] [PATCH v3 04/19] OvmfPkg/Microvm: no secure boot

2021-09-08 Thread Gerd Hoffmann
Without SMM secure boot isn't actually secure, so drop it too. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 15 --- OvmfPkg/Microvm/MicrovmX64.fdf | 4 2 files changed, 19

[edk2-devel] [PATCH v3 02/19] OvmfPkg/Microvm: rename output files, fix includes

2021-09-08 Thread Gerd Hoffmann
Rename the firmware volume files (s/OVMF/MICROVM/). Fix includes so they work with microvm config being in a subdirectory. With this patch applied the build works. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao ---

[edk2-devel] [PATCH v3 03/19] OvmfPkg/Microvm: no smm

2021-09-08 Thread Gerd Hoffmann
Microvm has no SMM support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 86 +- OvmfPkg/Microvm/MicrovmX64.fdf | 30 2 files changed, 1 insertion(+),

[edk2-devel] [PATCH v3 00/19] OvmfPkg: Add support for microvm machine type

2021-09-08 Thread Gerd Hoffmann
This patch series adds basic support for the microvm machine type to OVMF. Working: - uefi shell @ serial console. - direct kernel boot. Comming in followup patches: - virtio-mmio support. - pcie support. Usage: qemu-system-x86_64 -nographic -M microvm -bios MICROVM.fd ... v2

[edk2-devel] [PATCH v3 01/19] OvmfPkg/Microvm: copy OvmfPkgX64 files as-is

2021-09-08 Thread Gerd Hoffmann
Create Microvm subdirectory. Copy OvmfPkgX64 .dsc and .fdf files unmodified as starting point for MicrovmX64. Changes come as separate patches, to simplify patch review and rebases. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao ---

Re: [edk2-devel] [PATCH 1/5] OvmfPkg/PlatformPei: Extend 64-bit PCI range for multiple host bridges

2021-09-08 Thread Gerd Hoffmann
> +// > +// Root bridge resource information for parsing fw-cfg data > +// > +#pragma pack(1) > +typedef struct { > + BOOLEAN set_pxm; > + BOOLEAN mark_prefetchable_resources_as_cacheable; > + > + UINT8 root_bus_nr; > + UINT8 pxm; > + UINT8 num_hot_plug_slots; > + > + UINT8

Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP

2021-09-08 Thread Wu, Hao A
Really sorry for the late response. So this is a workaround for RCiEP device that is not compliant to the PCIe spec: |> ARI is an optional capability. This capability must be implemented by each |> Function in an ARI Device. It is not applicable to a Root Port, a Switch |> Downstream Port, an

Re: [edk2-devel] [PATCH v6 06/29] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-08 Thread Min Xu
Hi, Brijesh When I go thru the code I find a potential bug in MemEncryptSevEsIsEnabled(). In the current code both SEV and TDX leverage the OvmfWorkArea to record the SEV/TDX information. Byte [0] record the guest type, 0 for legacy guest. 1 for sev, 2 for tdx. Byte [3:1] are reserved. From

Re: [edk2-devel] [PATCH v6 00/29] Add AMD Secure Nested Paging (SEV-SNP) support

2021-09-08 Thread Yao, Jiewen
Yes, that is good idea. > -Original Message- > From: Xu, Min M > Sent: Wednesday, September 8, 2021 10:30 AM > To: Yao, Jiewen ; Brijesh Singh > ; devel@edk2.groups.io > Cc: James Bottomley ; Tom Lendacky > ; Justen, Jordan L ; > Ard Biesheuvel ; Erdem Aktas > ; Michael Roth ; Gerd >