InterruptDxe requires gEfiCpuArchProtocolGuid: change the Depex line for
TexasInstruments/Omap35xxPkg/InterruptDxe so the driver that provides
gEfiCpuArchProtocolGuid is loaded before it.
Signed-off-by: Rebecca Cran
---
Silicon/TexasInstruments/Omap35xxPkg/InterruptDxe/InterruptDxe.inf | 2 +-
Remove the configuration and image headers from the flash image.
This was likely intended for the UEFI firmware to be loaded by the ROM
code, but the BeagleBoard only has 64KB SRAM and so EDK2 needs to be
executed as a second stage loader.
Signed-off-by: Rebecca Cran
---
Since we still have quite a lot of 32-bit ARM code in the tree, it
would be nice to have a physical platform to verify that it still works
correctly. I recently got one of the original BeagleBoard boards and
have been working to get EDK2 booting on it again. These patches let it
get further,
PerformanceLib is related to building the ACPI Firmware Performance
Data Table (FPDT). Since BeagleBoardPkg targets 32-bit ARM systems
where ACPI isn't relevant, remove it.
Signed-off-by: Rebecca Cran
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ---
1 file changed, 3
Add build options to BeagleBoardPkg.dsc to align PE sections to 4K.
This avoids warnings during boot when loading drivers.
Signed-off-by: Rebecca Cran
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 4
1 file changed, 4 insertions(+)
diff --git
If you want, I would suggest to take 2 steps (2 separate patch sets).
1) To add the TCG2 platform auth handling the security pkg (just move the code
from min-platform to securitypkg)
If nothing else is changed, it can be approved easily.
2) To enable QEMU support to make platform auth + TCG PP
Hi Stefan
I notice you signal EndOfDxe at PlatformBootManagerBeforeConsole()
https://github.com/tianocore/edk2/blob/master/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c#L380
I would say, if PP is done after EndOfDxe, then the order is NOT right.
This topic has been debated for years.
On Mon, Aug 30, 2021 at 5:35 AM Min Xu wrote:
> +;
> +; Check if it is Intel Tdx
> +;
> +; Modified: EAX, EBX, ECX, EDX
> +;
> +; If it is Intel Tdx, EAX is zero
> +; If it is not Intel Tdx, EAX is non-zero
> +;
> +IsTdx:
IsTdx returns 0 when TDX is enabled in CPUID but IsTdxEnabled return 1
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
> +UINT8
> +EFIAPI
> +TdMmioRead8 (
> + IN UINTN Address
> + )
> +{
> + UINT64 Value;
> + UINT64 Status;
> +
> + Address |= TdSharedPageMask ();
Why is the
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
> - TdMaxVCpuNum: Get the maximum number of virutal CPUs.
s/virutal/virtual
> - TdVCpuNum : Get the number of virtual CPUs. (In some case VMM may
> add more vCPU in runtime).
s/case/cases
How is this possible
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
> +
> +#include
> +#include "InternalTdxProbe.h"
> +
> +/**
> + TDX only works in X64. So allways return -1 to indicate Non-Td.
s/allways/always
Also, -1 or 1? PROBE_NOT_TD_GUEST is defined as 1.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
>
> +;
> +; Check if it is Intel Tdx
> +;
> +; Modified: EAX, EBX, ECX, EDX
> +;
> +; If it is Intel Tdx, EAX is zero
> +; If it is not Intel Tdx, EAX is non-zero
> +;
> +IsTdx:
IsTdx returns 0 when TDX is enabled in CPUID but IsTdxEnabled return 1
On Thu, Aug 12, 2021 at 2:57 PM Min Xu wrote:
>
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> SevEsIsEnabled return TRUE if SevEsWorkArea->SevEsEnabled is non-zero.
s/return/returns
> It is correct when SevEsWorkArea is only used by SEV. After Intel TDX
> is enabled in Ovmf, the
Pushed as to edk2-platforms as
71f334393361d53e805fe9a01e2cf7bc43e909ce and
7872c983ed45de4c9e4e9295aa249e1369913094, respectively.
On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is
> solving a use case we had.
>
> Had
Series Reviewed-by: Pedro Falcato
On Fri, Sep 10, 2021 at 11:11 PM Jeff Brasen wrote:
>
> I have been using the new Ext4Pkg and been pretty successful and it is
> solving a use case we had.
>
> Had a couple updates to propose
>
> 1. Changed the implementation of the binding protocol to both
> -Original Message-
> From: Ni, Ray [mailto:ray...@intel.com]
> Sent: Friday, September 10, 2021 6:07 PM
> To: devel@edk2.groups.io; l...@nuviainc.com; Chang, Abner (HPS SW/FW
> Technologist)
> Cc: kra...@redhat.com; Yao, Jiewen ; gaoliming
> ; 'Ard Biesheuvel' ;
> Kinney, Michael D ;
Add a new MpServicesTest application under MdeModulePkg/Application that
exercises the EFI_MP_SERVICES_PROTOCOL.
Signed-off-by: Rebecca Cran
---
MdeModulePkg/Application/MpServicesTest/MpServicesTest.c | 389
MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf |
Pushed:
https://github.com/tianocore/edk2-platforms/commit/057f23a2022c7efb9f99c5c523e09125cb66756b
Thanks,
Chasel
> -Original Message-
> From: Benjamin Doron
> Sent: Monday, September 6, 2021 10:56 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
>
Push:
https://github.com/tianocore/edk2-platforms/commit/f1add54453dddb2028c87445c234e746b62d7a12
Thanks,
Chasel
> -Original Message-
> From: Benjamin Doron
> Sent: Monday, September 6, 2021 10:55 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject:
Dear Sir
I am trying to build the alder lake code, but got something wrong.
Could you kindly give some help on it?
Thanks a lot.
build.py...
: error C0DE: Tools code failure
Please send email to devel@edk2.groups.io for help, attaching following
call stack trace!
Traceback (most recent
Support for uncleanly mounted filesystems, if there is a recovery
journal mark filesystem as read-only.
Signed-off-by: Jeff Brasen
---
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c
A couple of improvements to improve performance.
Add check to return ACCESS_DENIED if already connected
Add check to verify superblock magic during supported to reduce start calls
Signed-off-by: Jeff Brasen
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++
I have been using the new Ext4Pkg and been pretty successful and it is solving
a use case we had.
Had a couple updates to propose
1. Changed the implementation of the binding protocol to both check if the
driver is already bound
to the partition as well as added a really quick check to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3617
Create a read-only openSSL BIO wrapper for the existing input
buffer passed to Pkcs7Verify() instead of copying the buffer
into an empty writable BIO which causes memory allocations
within openSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc:
We actually can't open the BlockIo protocol as BY_DRIVER as it is already owned
by the DiskIoDxe driver. Will upload a v3 with the other feedback though.
Thanks,
Jeff
From: Marvin Häuser
Sent: Friday, September 10, 2021 12:09 PM
To: Pedro Falcato
Cc:
On 9/10/21 12:15 PM, Stefan Berger wrote:
On 9/10/21 11:32 AM, Yao, Jiewen wrote:
According to the security policy, PP request must be processed before
EndOfDxe.
May I know when you trigger PP request?
OVMF has 3 implementations invoking it in
PlatformBootManagerAfterConsole():
On 10/09/2021 19:08, Pedro Falcato wrote:
Ah yes, thanks! Although I didn't find the part where they say that
you need to use the same attributes,
after re-reading the spec it seems they recommend using BY_DRIVER.
UEFI 2.9, 11.1, "Device Driver", 2.: "It must use the same Attribute
value that
Pushed as ce35be387725cf6bb1caefa4d4b0bd48ea72cbfa.
--
Rebecca Cran
On 9/8/21 10:54 AM, Jayaprakash Nevara wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3611
This commit contains updates made to the Readme.md file
of edk2-libc repo to add the Python 3.6.8 license at
Sorry for the delay -- I've been trying to find time to make sure I can
follow the process correctly.
I've just pushed the change as ce35be387725cf6bb1caefa4d4b0bd48ea72cbfa.
For future patches, please add a Signed-off-by line.
--
Rebecca Cran
On 9/9/21 12:12 AM, Jayaprakash, N wrote:
Ah yes, thanks! Although I didn't find the part where they say that
you need to use the same attributes,
after re-reading the spec it seems they recommend using BY_DRIVER.
So, change it to BY_DRIVER. The performance should be the same and
it's more consistent.
On Fri, Sep 10, 2021 at 5:56 PM
Yeah we need by_driver on at least one protocol to prevent re-binding to the
controller. It will return ALREADY_STARTED if this driver already has it open
(from in Start) or ACCESS_DENIED if another driver is holding this.
I can covert both to by_driver if that is desired.
Will make the other
I have few naive questions. Sorry if the answers were obvious.
>>TDVF also include a configuration firmware volume (CFV) that is separated
>>from the BFV. The reason is because the CFV is measured in RTMR, while
>>the BFV is measured in MRTD.
If I understand correctly, this means that the BFV is
On 10/09/2021 18:52, Pedro Falcato wrote:
Like Marvin raised in v1, it's a good idea to change the first
OpenProtocol's EFI_OPEN_PROTOCOL_BY_DRIVER
into EFI_OPEN_PROTOCOL_GET_PROTOCOL, for consistency's sake.
Since we're not keeping these protocols open, using BY_DRIVER makes no
difference.
Like Marvin raised in v1, it's a good idea to change the first
OpenProtocol's EFI_OPEN_PROTOCOL_BY_DRIVER
into EFI_OPEN_PROTOCOL_GET_PROTOCOL, for consistency's sake.
Since we're not keeping these protocols open, using BY_DRIVER makes no
difference.
You didn't update Ext4SuperblockCheckMagic's
Good day,
On 09/09/2021 22:41, Jeff Brasen via groups.io wrote:
A couple improvements to improve performance.
Add check to return ACCESS_DENIED if already connected
This "performance improvement" actually aligns the load behaviour with
the UEFI spec, maybe it should be mentioned?
Add
On 9/10/21 11:32 AM, Yao, Jiewen wrote:
According to the security policy, PP request must be processed before EndOfDxe.
May I know when you trigger PP request?
OVMF has 3 implementations invoking it in PlatformBootManagerAfterConsole():
Support for uncleanly mounted filesystems, if there is a recovery
journal mark filesystem as read-only.
Signed-off-by: Jeff Brasen
---
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c
A couple of improvements to improve performance.
Add check to return ACCESS_DENIED if already connected
Add check to verify superblock magic during supported to reduce start calls
Signed-off-by: Jeff Brasen
---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h| 14 +++
I have been using the new Ext4Pkg and been pretty successful and it is solving
a use case we had.
Had a couple updates to propose
1. Changed the implementation of the binding protocol to both check if the
driver is already bound
to the partition as well as added a really quick check to
According to the security policy, PP request must be processed before EndOfDxe.
May I know when you trigger PP request?
Thank you
Yao Jiewen
> -Original Message-
> From: Stefan Berger
> Sent: Friday, September 10, 2021 10:25 PM
> To: devel@edk2.groups.io; stef...@linux.vnet.ibm.com
>
On 9/9/21 1:35 PM, Stefan Berger wrote:
This series imports code from the edk2-platforms project related to
disabling the TPM2 platform hierarchy in Ovmf. It addresses the Ovmf
aspects of the following bugs:
https://bugzilla.tianocore.org/show_bug.cgi?id=3510
I asked similar question to Mike who initially set up the CI.
The answer was: it's ok to pull a edk2-platform code in CI process to verify
edk2 code change.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif Lindholm
> Sent: Friday, September 10, 2021 5:55 PM
> To:
+ Bob for general python language level review.
more comments embedded.
> +def BuildUniversalPayload(args, MacroList):
> +build_target = args.Target
> +tool_chain_tag = args.ToolChain
> +elf_tool_chain = 'CLANGDWARF'
> +entry_module_inf = os.path.join("UefiPayloadPkg",
On Fri, Sep 10, 2021 at 00:08:12 +, Chang, Abner (HPS SW/FW Technologist)
wrote:
> > Move it to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMMIO.{c,inf} ?
> The naming sounds good to me.
>
> Another question,
> Can CI build the package with dependency of edk2-platform? Currently
> RiscVPkg in
The SpiDxe is to provide Spi bus read-write interfaces.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 9 +
Platform/Phytium/DurianPkg/DurianPkg.dsc| 5 +
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Maintainers.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 979553b610..c839c71b22 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -371,3 +371,11 @@ F: Silicon/SiFive/
M: Abner
The RealTimeClockLib implemented EFI RealTimeClock
runtime services via RTC Lib.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec |
1 +
Platform/Phytium/DurianPkg/DurianPkg.dsc
The SpiNorFlashDxe provided norflash initialization,
read-write, erase and other interfaces.
This is a set of special communication protocol for
ft2000/4 chip QSPI controller.
Signed-off-by: Ling Jia
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec | 1 +
The FlashFvbDxe provided the fvb protocol,
which requested by the flash operators.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc |1 +
Platform/Phytium/DurianPkg/DurianPkg.fdf |1 +
The Pci host bridge library is mainly
to get Pci bridge information.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc |
9 +
Platform/Phytium/DurianPkg/DurianPkg.fdf |
6 +
The PCI Segment Library for Phytium platform.
with multiple RCs.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc|9 +-
Silicon/Phytium/FT2000-4Pkg/Library/PciSegmentLib/PciSegmentLib.inf | 28 +
This driver installs SMBIOS information for FT2000/4.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc|
6 +
Platform/Phytium/DurianPkg/DurianPkg.fdf|
6 +
The PlatformLib supported the system library for FT2000/4 chip.
Platform/Phytium: Added the dsc and fdf files of DurianPkg.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dec
| 41 +++
Added Acpi driver and table to FT2000/4,
the ACPI Tables providing library AcpiTables.inf uses
a lot of information that is available in the form of PCDs
for differnt platforms.
Signed-off-by: Ling Jia
Reviewed-by: Leif Lindholm
---
Platform/Phytium/DurianPkg/DurianPkg.dsc
This series added packages to support FT2000/4 chip.
Platform/Phytium: Added DurianPkg, include DurianPkg.dsc and DurianPkg.fdf.
Silicon/Phytium: Added FT2000-4Pkg and PhytiumCommonPkg.
The modules could be runed at the silicon of FT2000/4.
They supported Acpi parameter configuration, Pci bus
Hi,
> > If we can use 4-level paging initially, then we surely should go for option
> > (1)
> > and simply not touch the reset vectors paging code.
> After PoC I find this option is not a good one. Though the reset
> vectors is not touched, there are tricky changes in DxeIpl. To set up
>
Add script to build UniversalPayload, which can be used after edksetup rebuild
The final UPL.elf will be located at root folder of edk2
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Zhiguang Liu
Signed-off-by: Dun Tan
---
UefiPayloadPkg/UniversalPayloadBuild.py | 95
Add script to build UniversalPayload, which can be used after edksetup rebuild
The final UPL.elf will be located at root folder of edk2
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Zhiguang Liu
Signed-off-by: Dun Tan
---
UefiPayloadPkg/UniversalPayloadBuild.py | 95
Add script to build UniversalPayload, which can be used after edksetup rebuild
The final UPL.elf will be located at root folder of edk2
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Zhiguang Liu
Signed-off-by: Dun Tan
---
UefiPayloadPkg/UniversalPayloadBuild.py | 95
From: duntan
V1: Dump this hob infomation from gEdkiiBootManagerMenuFileGuid
V2: Delete the duplicated assertions
V3: Add input parameter in Comment
Cc: Guo Dong
Reviewed-by: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Reviewed-by: Zhiguang Liu
Signed-off-by: Dun Tan
---
From: duntan
The input HobLength of PrintHandler should be data size instead of whole length
of HOB
Cc: Guo Dong
Reviewed-by: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Reviewed-by: Zhiguang Liu
Signed-off-by: Dun Tan
---
UefiPayloadPkg/UefiPayloadEntry/PrintHob.c | 10 +++---
1 file
Fix the bug in dump guid HOB info functions
Dump hob info from gEdkiiBootManagerMenuFileGuid
duntan (2):
UefiPayloadPkg: Fix the bug in dump guid HOB info functions
UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid
UefiPayloadPkg/UefiPayloadEntry/PrintHob.c|
No. My point is the HII usage would require the HII browser engine. That's too
complex for this simple app.
Dandan,
If I am wrong, please help to correct.
Thanks,
Zhichao
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, September 9, 2021 10:55 PM
> To: Gao, Zhichao ; Bi, Dandan
63 matches
Mail list logo
