Re: [edk2-devel] [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

2021-09-16 Thread Nhi Pham via groups.io
On 16/09/2021 17:46, Leif Lindholm wrote: On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote: On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote: From: Vu Nguyen This commit adds the support for Ampere’s Altra processor-based Mt. Jade platform that provides up to 160 processor co

Re: [edk2-devel] [PATCH v3 00/28] Add new Ampere Mt. Jade platform

2021-09-16 Thread Nhi Pham via groups.io
Hi Leif, On 16/09/2021 17:09, Leif Lindholm wrote: Hi Nhi, On Wed, Sep 15, 2021 at 22:54:59 +0700, Nhi Pham wrote: This patch series adds the support for the Mt. Jade platform based on Ampere's Altra Family Processor. Notes: + The current patch series was tested with the edk2-stable202108

Re: [edk2-devel] [PATCH v3] OvmfPkg: set a default value for the WorkAreaHeader PCD

2021-09-16 Thread Corvin Köhne
Hi Yao, looks like the patch isn't formatted correctly. Could you try to apply this patch: From 3c22fffad51e431fbf953809215eea7022168e81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Corvin=20K=C3=B6hne?= Date: Fri, 17 Sep 2021 07:37:24 +0200 Subject: [PATCH] OvmfPkg: set a default value for the Wor

Re: [edk2-devel] [PATCH v3] OvmfPkg: set a default value for the WorkAreaHeader PCD

2021-09-16 Thread Yao, Jiewen
Hi Corvin I try to apply this patch and merge. But I got error: git.exe am --3way --ignore-space-change --keep-cr "C:\home\edkii\edk2\[PATCH-v3]-OvmfPkg-set-a-default-value-for-the-WorkAreaHeader-PCD-warn.patch" Applying: OvmfPkg: set a default value for the WorkAreaHeader PCD Pa

Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg: Add debug log for indicating IBB verified OBB successfully

2021-09-16 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Yang, Longlong > Sent: Friday, September 17, 2021 10:51 AM > To: devel@edk2.groups.io > Cc: Yang, Longlong ; Yao, Jiewen > ; Wang, Jian J ; Xu, Min M > ; Zhang, Qi1 > Subject: [PATCH V2 1/1] SecurityPkg: Add debug log

[edk2-devel] 回复: [PATCH v1 0/3] Add MM Communication PPI definition to MdePkg

2021-09-16 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Kun Qin > 发送时间: 2021年9月16日 8:14 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Sean > Brogan ; Jian J Wang > 主题: [PATCH v1 0/3] Add MM Communication PPI definition to MdePkg > > REF: https://bugzilla.tianocore.

[edk2-devel] 回复: [PATCH 1/1] BaseTools: Change RealPath to AbsPath

2021-09-16 Thread gaoliming
Is there any other case to use RealPath in BaseTools? Or, have you confirm that all RealPath usage have been removed? Liming > -邮件原件- > 发件人: Yuwei Chen > 发送时间: 2021年9月16日 14:59 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > > 主题: [PATCH 1/1] BaseTools: Change RealPath to AbsPa

Re: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/SecCore: Add SecCore source code support

2021-09-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Oram, Isaac W > Sent: Thursday, September 16, 2021 3:05 AM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] > WhitleyOpenBoardPkg/SecCore: Add SecCore sou

Re: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/FspWrapperPlatformLib: Update for large variables

2021-09-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Oram, Isaac W > Sent: Thursday, September 16, 2021 3:05 AM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/2] > WhitleySiliconPkg/FspWrapperPlatformLib: Upd

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Whitley SEC support

2021-09-16 Thread Oram, Isaac W
Series pushed as 38b2e75e94f5fe234ccaf80dc3b33b34a68486cf..64394fd2b48f403330feb8f7e954d1cca0822af5 -Original Message- From: Desimone, Nathaniel L Sent: Thursday, September 16, 2021 2:25 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platfor

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Whitley SEC support

2021-09-16 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Wednesday, September 15, 2021 12:05 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Whitley SEC support This series repl

[edk2-devel] [RFC PATCH 3/3] ArmVirtPkg: Disable the TPM2 platform hierarchy

2021-09-16 Thread Stefan Berger
From: Stefan Berger Disable the TPM2 platform hierarchy by directly calling ConfigureTpmPlatformHierarchy(). Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Stefan Berger --- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 ++ .../

[edk2-devel] [RFC PATCH 2/3] ArmVirtPkg: Reference new TPM classes in the build system for compilation

2021-09-16 Thread Stefan Berger
From: Stefan Berger Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtCloudHv.dsc | 1 + ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ ArmVirtPkg/ArmVirtQemuK

[edk2-devel] [RFC PATCH 1/3] ArmVirtPkg/TPM: Add a NULL implementation of TpmPlatformHierarchyLib

2021-09-16 Thread Stefan Berger
From: Stefan Berger Add a NULL implementation of the library class TpmPlatformHierarchyLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Stefan Berger --- ArmVirtPkg/ArmVirtPkg.dec | 1 + .../Include/Library/TpmPlatformHierarch

[edk2-devel] [RFC PATCH 0/3] ArmVirtPkg: Disable the TPM 2 platform hierarchy

2021-09-16 Thread Stefan Berger
This series of patches disables the TPM 2 platform hierarchy. We just added the same functionality to the OvmfPkg. However, on x86, we could use the notification mechanism around gEfiDxeSmmReadyToLockProtocolGuid to indirectly invoke ConfigureTpmPlatformHierarchy(). Since ARM does not have an SMM m

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Build: Reduce debug output for default boot.

2021-09-16 Thread Nate DeSimone
Is it a big increase in messages to have both INFO and LOAD? -Original Message- From: Oram, Isaac W Sent: Wednesday, September 8, 2021 3:35 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Build

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-16 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/2cd3be4 -Original Message- From: Oram, Isaac W Sent: Wednesday, September 8, 2021 3:30 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel][edk2-platforms][PATCH

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] MinPlatformPkg/Variable*Lib: Build VariableRead and VariableWrite libs

2021-09-16 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Wednesday, September 8, 2021 3:30 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1

Re: [edk2-devel] [PATCH] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP

2021-09-16 Thread Bassa, Damian
I was looking for anything that wouldn't include reading register but only thing that distinguish device PCI_IO_DEVICE instances with root bridge instances is population of BusNumberRanges structure. This technically could be used since this is populated only for root bridges and not devices but

Re: [edk2-devel] RFC: Add BaseLib/QuickSort in MdePkg

2021-09-16 Thread Chan, Amy
Just to double confirm, will we have the null instance of QuickSort in MdePkg? Regards, Amy From: gaoliming Sent: Thursday, September 16, 2021 10:23 AM To: 'Andrew Fish' ; 'edk2-devel-groups-io' Cc: Ni, Ray ; Kinney, Michael D ; 'Gao, Liming' ; Liu, Zhiguang ; Wang, Jian J ; Gao, Zhichao ;

[edk2-devel] [PATCH v3 3/3] RFC: OvmfPkg/PlatformPei: stop using cmos for memory detection

2021-09-16 Thread Gerd Hoffmann
Not needed for qemu 1.7 (released in 2013) and newer. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3593 Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/MemDetect.c | 59 +++-- 1 file changed, 4 insertions(+), 55 deletions(-) diff --git a/OvmfPkg/PlatformP

[edk2-devel] [PATCH v3 2/3] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-09-16 Thread Gerd Hoffmann
Prefer the e820 map provided via qemu firmware config interface for memory detection. Use rtc cmos only as fallback, which should be rarely needed these days as qemu supports etc/e820 since 2013. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3593 Signed-off-by: Gerd Hoffmann Reviewed-by: P

[edk2-devel] [PATCH v3 1/3] OvmfPkg/PlatformPei: ScanOrAdd64BitE820Ram improvements

2021-09-16 Thread Gerd Hoffmann
Add a bool parameter to ScanOrAdd64BitE820Ram to explicitly specify whenever ScanOrAdd64BitE820Ram should add HOBs for high memory (above 4G) or scan only. Also add a lowmem parameter so ScanOrAdd64BitE820Ram can report the memory size below 4G. This allows a more flexible usage of ScanOrAdd64Bit

[edk2-devel] [PATCH v3 0/3] OvmfPkg/PlatformPei: prefer etc/e820 for memory detection

2021-09-16 Thread Gerd Hoffmann
Don't use cmos for memory detection if possible. qemu provides the etc/e820 firmware config file as alternative since 2013. v2: - fix lowmem detection. - pick up review tags. - add rfc patch to completely drop cmos support. v3: - fix CI failure. Gerd Hoffmann (3): OvmfPkg/PlatformPei: Scan

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ProcessorSubClassDxe: Fix the format of ProcessorId

2021-09-16 Thread Leif Lindholm
On Thu, Sep 16, 2021 at 04:45:29 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran > > > -- > > Rebecca Cran > > > On 9/15/21 7:55 AM, Nhi Pham wrote: > > According to SMBIOS 3.4, section 7.5.3.3 ARM64-class CPUs, if > > SMCCC_ARCH_SOC_ID is supported, the first DWORD is the JEP-106 code

[edk2-devel] [PATCH v2 3/5] ShellPkg: add a Graph option to the Parser Flags

2021-09-16 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This option informs the parser to generate a dot graph of a table. This can be useful to understand or debug a table, such as the PPTT table. Signed-off-by: Joey Gouly --- ShellPkg/Library/Uef

[edk2-devel] [PATCH v2 0/5] Dot graph generator for PPTT

2021-09-16 Thread Joey Gouly
This series adds functionality to print a dot graph of a PPTT table. This helps with understanding and debugging PPTT tables. The dot graph generator functionality is generic and could be used by other tables that would benefit from graph output. Bugzilla: 3378 (https://bugzilla.tianocore.org/show

[edk2-devel] [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFlags'

2021-09-16 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This is preparation for adding a second flag to the parsers. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 77 +++- Sh

[edk2-devel] [PATCH v2 4/5] ShellPkg: add dot file generator functions

2021-09-16 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) These can be used to generate dot files, that can be used to visualise graphs in tables, such as PPTT. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiV

[edk2-devel] [PATCH v2 5/5] ShellPkg: add PPTT dot file genration

2021-09-16 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This generates a dot file from the PPTT table that can be used to visualise the topology of the CPUs and Caches. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Pars

[edk2-devel] [PATCH v2 2/5] ShellPkg: add a helper function for getting a new file name

2021-09-16 Thread Joey Gouly
From: Marc Moisson-Franckhauser Bugzilla: 3378 (https://bugzilla.tianocore.org/show_bug.cgi?id=3378) This new helper will not overwrite existing files, by appending a number to the end of the filename. Signed-off-by: Joey Gouly --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.h | 25

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: SecCoreNative without ResetVector

2021-09-16 Thread Marvin Häuser
This will also help with PE file alignment in FD, as SecCore no longer needs to be pinned to the very top. Thank you! Best regards, Marvin On 16/09/2021 16:26, Ashraf Ali S wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3492 Currently SecCore.inf having the resetvector code under I

[edk2-devel] [PATCH v2] UefiCpuPkg: SecCoreNative without ResetVector

2021-09-16 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3492 Currently SecCore.inf having the resetvector code under IA32. if the user wants to use both SecCore and UefiCpuPkg ResetVector it's not possible, since SecCore and ResetVector(VTF0.INF/ResetVector.inf) are sharing the same GUID which is BFV.

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, September 17, 2021 #cal-cancelled

2021-09-16 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST TZOFFSETFROM

Re: [edk2-devel] [PATCH v7] UefiCpuPkg: VTF0 Linear-Address Translation to a 1-GByte Page till 512GB

2021-09-16 Thread Ashraf Ali S
Hi., Ray We cannot add ResetVector1G.inf in the DSC file since FILE_GUID should be the VTF GUID. So it's better to be added in the YAML file as we were doing for FixupVtf/Vtf.inf. Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From: Ni, Ray Sent: Thursday,

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume

2021-09-16 Thread Ni, Ray
Reviewed-by: Ray Ni I merged the patch with the "#ifndef .." removed. > -Original Message- > From: Lou, Yun > Sent: Thursday, September 16, 2021 5:27 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric > ; Laszlo Ersek > ; Kumar, Rahul1 > Subject: [PATCH v2 1/2] UefiCp

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg: Prevent from re-initializing CPU features during S3 resume

2021-09-16 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Lou, Yun > Sent: Thursday, September 16, 2021 5:27 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric > ; Laszlo Ersek > ; Kumar, Rahul1 > Subject: [PATCH v2 2/2] UefiCpuPkg: Prevent from re-initializing CPU features >

Re: [edk2-devel] [PATCH v7] UefiCpuPkg: VTF0 Linear-Address Translation to a 1-GByte Page till 512GB

2021-09-16 Thread Ni, Ray
Wait a sec. I think you don't need to edit yaml file. You can directly include the new INF to DSC file. -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Thursday, September 16, 2021 8:40 PM To: S, Ashraf Ali ; devel@edk2.groups.io Cc: Kumar, Rahul1 ; De, Debkumar

Re: [edk2-devel] [PATCH v7] UefiCpuPkg: VTF0 Linear-Address Translation to a 1-GByte Page till 512GB

2021-09-16 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: S, Ashraf Ali Sent: Thursday, September 16, 2021 8:07 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Kumar, Rahul1 ; De, Debkumar ; Han, Harry ; West, Catharine ; V, Sangeetha ; Chaganty, Rangasai V ; Dureja, Sahil Subject: [P

[edk2-devel] [PATCH v4 19/20] OvmfPkg/Microvm: add README

2021-09-16 Thread Gerd Hoffmann
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/README | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 OvmfPkg/Microvm/README diff --git a/OvmfPkg/Microvm/README

[edk2-devel] [PATCH v4 20/20] OvmfPkg/Microvm: add Maintainers.txt entry

2021-09-16 Thread Gerd Hoffmann
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Reviewed-by: Jiewen Yao --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 41f491bcaed1..52f9aa99ac7d 100644 --- a/Maintainers.txt +++ b/Mainta

[edk2-devel] [PATCH v4 18/20] OvmfPkg/Microvm: wire up serial console, drop super-io

2021-09-16 Thread Gerd Hoffmann
Microvm has no LPC bridge, so drop the PciSioSerialDxe driver. Use SerialDxe instead, with ioport hardcoded to 0x3f8 aka com1 aka ttyS0. With this tianocore boots to uefi shell prompt on the serial console. Direct kernel boot can be used too. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=35

[edk2-devel] [PATCH v4 17/20] OvmfPkg/Microvm: use PciHostBridgeLibNull

2021-09-16 Thread Gerd Hoffmann
Shortcut PCI support for now (proper PCIe support will be wired up later). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Mi

[edk2-devel] [PATCH v4 16/20] OvmfPkg/Microvm: BdsPlatform: PciAcpiInitialization tweak.

2021-09-16 Thread Gerd Hoffmann
Nothing to do here ;) Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b

[edk2-devel] [PATCH v4 15/20] OvmfPkg/ResetSystemLib: add driver for microvm

2021-09-16 Thread Gerd Hoffmann
Uses the generic event device to reset and poweroff. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc| 14 +-- .../BaseResetSystemLibMicrovm.inf | 37 .../DxeResetSy

[edk2-devel] [PATCH v4 14/20] OvmfPkg/Microvm: PlatformPei/Platform: set id.

2021-09-16 Thread Gerd Hoffmann
Set PcdOvmfHostBridgePciDevId to MICROVM_PSEUDO_DEVICE_ID. Return and skip i440fx/q35 chipset tweaks. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/PlatformPei/Platform.c | 6 ++ 1 file changed, 6 insertions(+) diff -

[edk2-devel] [PATCH v4 00/20] OvmfPkg: Add support for microvm machine type

2021-09-16 Thread Gerd Hoffmann
This patch series adds basic support for the microvm machine type to OVMF. Working: - uefi shell @ serial console. - direct kernel boot. Comming in followup patches: - virtio-mmio support. - pcie support. Usage: qemu-system-x86_64 -nographic -M microvm -bios MICROVM.fd ... v2 changes:

[edk2-devel] [PATCH v4 13/20] OvmfPkg/Microvm: PlatformPei/Platform memory map tweaks

2021-09-16 Thread Gerd Hoffmann
Microvm needs ioapic hobs only. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/PlatformPei/Platform.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c

[edk2-devel] [PATCH v4 12/20] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-09-16 Thread Gerd Hoffmann
Set mHostBridgeDevId to MICROVM_PSEUDO_DEVICE_ID using a compile time switch. Skip host bridge setup on microvm. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 +++ OvmfPkg/PlatformPei/MemDetect

[edk2-devel] [PATCH v4 11/20] OvmfPkg/Microvm: add header file

2021-09-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- OvmfPkg/Include/IndustryStandard/Microvm.h | 12 1 file changed, 12 insertions(+) create mode 100644 OvmfPkg/Include/IndustryStandard/Microvm.h diff --git a/OvmfPkg/Include/IndustryStandard/Microvm.h b/OvmfPkg/Include/IndustryStandard/Microvm.h new

[edk2-devel] [PATCH v4 10/20] OvmfPkg/Microvm: use XenTimerDxe (lapic timer)

2021-09-16 Thread Gerd Hoffmann
Microvm has no acpi timer, so go use XenTimerDxe which uses the local apic instead. Set PcdFSBClock to 1000 MHz, which is the lapic timer frequency used by KVM. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/Microv

[edk2-devel] [PATCH v4 09/20] OvmfPkg/Microvm: use MdePkg/Library/SecPeiDxeTimerLibCpu

2021-09-16 Thread Gerd Hoffmann
Microvm has no acpi timer, so use the generic lib instead. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/OvmfPkg/Microvm/Mi

[edk2-devel] [PATCH v4 08/20] OvmfPkg/Microvm: no emulated scsi

2021-09-16 Thread Gerd Hoffmann
Microvm focus is virtio, so go drop support for emulated scsi host adapters. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 9 - OvmfPkg/Microvm/MicrovmX64.fdf | 9 - 2 files changed

[edk2-devel] [PATCH v4 05/20] OvmfPkg/Microvm: no tpm

2021-09-16 Thread Gerd Hoffmann
Microvm has no TPM support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Reviewed-by: Stefan Berger Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 76 +- OvmfPkg/Microvm/MicrovmX64.fdf | 18 2 files ch

[edk2-devel] [PATCH v4 07/20] OvmfPkg/Microvm: no csm

2021-09-16 Thread Gerd Hoffmann
Guests depending on BIOS will probably not work that well with microvm due to legacy hardware being not available. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 26 -- OvmfP

[edk2-devel] [PATCH v4 06/20] OvmfPkg/Microvm: no sev

2021-09-16 Thread Gerd Hoffmann
Microvm has no SEV support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 1 - OvmfPkg/Microvm/MicrovmX64.fdf | 2 -- 2 files changed, 3 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/

[edk2-devel] [PATCH v4 04/20] OvmfPkg/Microvm: no secure boot

2021-09-16 Thread Gerd Hoffmann
Without SMM secure boot isn't actually secure, so drop it too. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 15 --- OvmfPkg/Microvm/MicrovmX64.fdf | 4 2 files changed, 19 deleti

[edk2-devel] [PATCH v4 03/20] OvmfPkg/Microvm: no smm

2021-09-16 Thread Gerd Hoffmann
Microvm has no SMM support. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/MicrovmX64.dsc | 86 +- OvmfPkg/Microvm/MicrovmX64.fdf | 30 2 files changed, 1 insertion(+), 1

[edk2-devel] [PATCH v4 01/20] OvmfPkg/Microvm: copy OvmfPkgX64 files as-is

2021-09-16 Thread Gerd Hoffmann
Create Microvm subdirectory. Copy OvmfPkgX64 .dsc and .fdf files unmodified as starting point for MicrovmX64. Changes come as separate patches, to simplify patch review and rebases. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao ---

[edk2-devel] [PATCH v4 02/20] OvmfPkg/Microvm: rename output files, fix includes

2021-09-16 Thread Gerd Hoffmann
Rename the firmware volume files (s/OVMF/MICROVM/). Fix includes so they work with microvm config being in a subdirectory. With this patch applied the build works. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/Micr

[edk2-devel] [PATCH v7] UefiCpuPkg: VTF0 Linear-Address Translation to a 1-GByte Page till 512GB

2021-09-16 Thread Ashraf Ali S
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3473 X64 Reset Vector Code can access the memory range till 4GB using the Linear-Address Translation to a 2-MByte Page, when user wants to use more than 4G using 2M Page it will leads to use more number of Page table entries. using the 1-GByte Pag

Re: [edk2-devel] [PATCH v3 04/28] AmperePlatformPkg: Add FailSafe and WDT support

2021-09-16 Thread Leif Lindholm
On Wed, Sep 15, 2021 at 22:55:03 +0700, Nhi Pham wrote: > The FailSafeDxe is a driver for the FailSafe feature which reverts the > system's configuration to known good values if the system fails to boot > up multiple times. Also, this driver implements the Watchdog Timer > Architectural Protocol to

Re: [edk2-devel] [PATCH v7 17/31] OvmfPkg/SecMain: pre-validate the memory used for decompressing Fv

2021-09-16 Thread Brijesh Singh via groups.io
On 9/16/21 3:58 AM, Gerd Hoffmann wrote: > Hi, > >> + ## The range of memory that need to be pre-validated in the SEC phase >> + # when SEV-SNP is active in the guest VM. >> + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecPreValidatedStart|0|UINT32|0x56 >> + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnp

Re: [edk2-devel] [PATCH v7 11/31] OvmfPkg/PlatformPei: register GHCB gpa for the SEV-SNP guest

2021-09-16 Thread Brijesh Singh via groups.io
On 9/16/21 3:33 AM, Gerd Hoffmann wrote: > On Mon, Sep 13, 2021 at 01:19:21PM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C6495c28531da4bc30ce508d

Re: [edk2-devel] [PATCH v7 09/31] OvmfPkg/SecMain: register GHCB gpa for the SEV-SNP guest

2021-09-16 Thread Brijesh Singh via groups.io
On 9/16/21 3:30 AM, Gerd Hoffmann wrote: > Hi, > >> Good point, there is no reason to read and restore the old GHCB, I will >> remove it in next version. The function does not set this as a GHCB address, >> it send request to hypervisor saying that it would like to use this address. >> If hyper

Re: [edk2-devel] [PATCH v7 06/31] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-16 Thread Brijesh Singh via groups.io
On 9/16/21 3:26 AM, Gerd Hoffmann via groups.io wrote: > Hi, > >> +; GHCB page table >> +GhcbPageTable: >> + DD GHCB_PT_ADDR >> + DD GHCB_PT_SIZE >> + DD OVMF_SECTION_TYPE_SEC_MEM > Hmm, TDX will re-use those pages for something else. So as long as TDX > is happy with OVMF_SECTION_TYPE_S

Re: [edk2-devel] [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

2021-09-16 Thread Leif Lindholm
On Thu, Sep 16, 2021 at 11:40:45 +0100, Leif Lindholm wrote: > On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote: > > From: Vu Nguyen > > > > This commit adds the support for Ampere’s Altra processor-based Mt. Jade > > platform that provides up to 160 processor cores in a dual socket > > con

Re: [edk2-devel] [PATCH v7 05/31] OvmfPkg: reserve CPUID page

2021-09-16 Thread Brijesh Singh via groups.io
On 9/16/21 3:07 AM, Gerd Hoffmann wrote: > Hi, > >> +; The section contains the hypervisor pre-populated CPUID values. In the >> +; case of SEV-SNP, the CPUID values are filtered and measured by the SEV-SNP >> +; firmware. > Pointer to the struct spec would be nice here, Noted. thanks -=-=

Re: [edk2-devel] [PATCH 1/1] ArmPkg/ProcessorSubClassDxe: Fix the format of ProcessorId

2021-09-16 Thread Rebecca Cran
Reviewed-by: Rebecca Cran -- Rebecca Cran On 9/15/21 7:55 AM, Nhi Pham wrote: According to SMBIOS 3.4, section 7.5.3.3 ARM64-class CPUs, if SMCCC_ARCH_SOC_ID is supported, the first DWORD is the JEP-106 code and the second DWORD is the SoC revision value. But in the current implementation,

Re: [edk2-devel] [PATCH v3 01/28] Ampere: Initial support for Ampere Altra processor and Mt. Jade platform

2021-09-16 Thread Leif Lindholm
On Wed, Sep 15, 2021 at 22:55:00 +0700, Nhi Pham wrote: > From: Vu Nguyen > > This commit adds the support for Ampere’s Altra processor-based Mt. Jade > platform that provides up to 160 processor cores in a dual socket > configuration. The essential modules are wired up enough to boot system > to

Re: [edk2-devel] [PATCH v3 00/28] Add new Ampere Mt. Jade platform

2021-09-16 Thread Leif Lindholm
Hi Nhi, On Wed, Sep 15, 2021 at 22:54:59 +0700, Nhi Pham wrote: > This patch series adds the support for the Mt. Jade platform based on Ampere's > Altra Family Processor. > > Notes: > + The current patch series was tested with the edk2-stable202108 tag. + the added common functions in Emb

Re: [edk2-devel] [PATCH v6] UefiCpuPkg: VTF0 Linear-Address Translation to a 1-GByte Page till 512GB

2021-09-16 Thread Ni, Ray
Hi, https://github.com/tianocore/edk2/pull/1979 detected errors. Can you check and update a new patch to fix? Thanks, Ray -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Thursday, September 16, 2021 1:58 PM To: S, Ashraf Ali ; devel@edk2.groups.io Cc: Kumar, Rahu

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg: Refactor initialization of CPU features during S3 resume

2021-09-16 Thread Jason Lou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3621 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3631 Refactor initialization of CPU features during S3 resume. In addition, the macro ACPI_CPU_DATA_STRUCTURE_UPDATE is used to fix incompatibility issue caused by ACPI_CPU_DATA structure

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg: Prevent from re-initializing CPU features during S3 resume

2021-09-16 Thread Jason Lou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3621 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3631 Current CPU feature initialization design: During normal boot, CpuFeaturesPei module (inside FSP) initializes the CPU features. During S3 boot, CpuFeaturesPei module does nothing, and

Re: [edk2-devel] [PATCH v7 25/31] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled

2021-09-16 Thread Ni, Ray
Brijesh, thank you for looking into this now! -Original Message- From: Gerd Hoffmann Sent: Thursday, September 16, 2021 5:16 PM To: Brijesh Singh Cc: devel@edk2.groups.io; Ni, Ray ; James Bottomley ; Xu, Min M ; Yao, Jiewen ; Tom Lendacky ; Justen, Jordan L ; Ard Biesheuvel ; Erdem

Re: [edk2-devel] [PATCH v7 25/31] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled

2021-09-16 Thread Gerd Hoffmann
On Tue, Sep 14, 2021 at 09:21:50AM -0500, Brijesh Singh wrote: > Hi Ray, > > I was hoping that refactor can be done later but sounds like we want to > do it before the SNP. Let me look into it. Well, the problem with the "do it later" approach is that these tasks then tend to fall down to the bot

Re: [edk2-devel] [Patch V3] UefiPayloadPkg: Add script to build UniversalPayload in UefiPayloadPkg

2021-09-16 Thread duntan
Hi all, I just delete Trailing whitespaces of a blank line in this version of patch. Besides, this script has been tested and can successfully build UniversalPayload on both windows and linux. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of duntan Sent: Thursday,

[edk2-devel] [Patch V3] UefiPayloadPkg: Add script to build UniversalPayload in UefiPayloadPkg

2021-09-16 Thread duntan
V1: Add script to build UniversalPayload, which can be used after edksetup rebuild The final UPL.elf will be located at root folder of edk2 V2: Revise the ouput directory of generated files and coding style in the script Cc: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Zh

[edk2-devel] [PATCH v3] OvmfPkg: set a default value for the WorkAreaHeader PCD

2021-09-16 Thread Corvin Köhne
SEC checks in IsSevGuest if the PCD defined WorkAreaHeader size matches the size of the WorkAreaHeader struct definition. Set a default value for the PCD to avoid unnecessary DSC/FDF file changes in all OVMF DSC/FDF files. Signed-off-by: Corvin Köhne Reviewed-by: Jiewen Yao --- OvmfPkg/Include/

Re: [edk2-devel] [PATCH v7 17/31] OvmfPkg/SecMain: pre-validate the memory used for decompressing Fv

2021-09-16 Thread Gerd Hoffmann
Hi, > + ## The range of memory that need to be pre-validated in the SEC phase > + # when SEV-SNP is active in the guest VM. > + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecPreValidatedStart|0|UINT32|0x56 > + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSnpSecPreValidatedEnd|0|UINT32|0x57 I guess TDX need

Re: [edk2-devel] [PATCH v2] OvmfPkg: set a default value for the WorkAreaHeader PCD

2021-09-16 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Corvin > Köhne > Sent: Thursday, September 16, 2021 2:22 PM > To: devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; Yao, Jiewen ; Justen, > Jordan L ; kra...@redhat.com; rebe...@bsdio.com; > gre...

Re: [edk2-devel] [PATCH v7 11/31] OvmfPkg/PlatformPei: register GHCB gpa for the SEV-SNP guest

2021-09-16 Thread Gerd Hoffmann
On Mon, Sep 13, 2021 at 01:19:21PM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The SEV-SNP guest requires that GHCB GPA must be registered before using. > See the GHCB specification section 2.3.2 for more details. Already done in SEC phase (patch #9),

Re: [edk2-devel] [PATCH v7 09/31] OvmfPkg/SecMain: register GHCB gpa for the SEV-SNP guest

2021-09-16 Thread Gerd Hoffmann
Hi, > Good point, there is no reason to read and restore the old GHCB, I will > remove it in next version. The function does not set this as a GHCB address, > it send request to hypervisor saying that it would like to use this address. > If hypervisor is not okay with the address then it may rec

Re: [edk2-devel] [PATCH v7 06/31] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-16 Thread Gerd Hoffmann
Hi, > +; GHCB page table > +GhcbPageTable: > + DD GHCB_PT_ADDR > + DD GHCB_PT_SIZE > + DD OVMF_SECTION_TYPE_SEC_MEM Hmm, TDX will re-use those pages for something else. So as long as TDX is happy with OVMF_SECTION_TYPE_SEC_MEM everything should work fine and just mentioning that in the c

Re: [edk2-devel] [PATCH v7 05/31] OvmfPkg: reserve CPUID page

2021-09-16 Thread Gerd Hoffmann
Hi, > +; The section contains the hypervisor pre-populated CPUID values. In the > +; case of SEV-SNP, the CPUID values are filtered and measured by the SEV-SNP > +; firmware. Pointer to the struct spec would be nice here, take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receiv

Re: [edk2-devel] [PATCH V6 1/1] OvmfPkg: Enable TDX in ResetVector

2021-09-16 Thread Gerd Hoffmann
> typedef struct _CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER { >UINT8 GuestType; > - UINT8 Reserved1[3]; > + UINT8 SubType; > + UINT8 Reserved1[2]; > } CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER; I think we should use the s

Re: [edk2-devel] [PATCH v6 06/29] OvmfPkg/ResetVector: pre-validate the data pages used in SEC phase

2021-09-16 Thread Gerd Hoffmann
On Tue, Sep 14, 2021 at 03:49:31AM +, Yao, Jiewen wrote: > I can explain why we prefer DQ instead of DD. > > You are right that current TD entrypoint is 32bit. However, we cannot predict > that is always TRUE for the future. So a "save space in MEMFD" vs. "be future proof" tradeoff. > Back