Re: [edk2-devel] [PATCH v6 1/1] MdePkg/BaseLib: Add QuickSort function on BaseLib

2021-10-05 Thread Jen Gua
Hi Marvin Thanks for reply on Patch V5 I think the patch should eliminate your concern. IanX Kuo 於 2021年10月6日 週三 上午8:31 寫道: > From: IanX Kuo > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 > > Add QuickSort function into BaseLib > > Cc: Ray Ni > Cc: Michael D Kinney > Cc:

[edk2-devel] [PATCH v6 1/1] MdePkg/BaseLib: Add QuickSort function on BaseLib

2021-10-05 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Add QuickSort function into BaseLib Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: IanX Kuo --- MdePkg/Include/Library/BaseLib.h | 49

[edk2-devel] [PATCH v6 0/1] Add function QuickSort into MdePkg/BaseLib

2021-10-05 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 First change 1. MdePkg/BaseLib: Add QuickSort function It need to seperate to second change 2. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 3. CryptLib/CryptLib: Remove duplicate QuickSortWorker 4.

[edk2-devel][edk2-platforms][PATCH V2 5/5] WhitleyOpenBoardPkg: Enable VT-D support

2021-10-05 Thread Oram, Isaac W
From: "Oram, Isaac W" Implements VT-D DMAR table functionality. VT-D is currently implemented as an OpenBoardPkg feature. More work would be needed to promote to an Advanced Feature. Specifically reducing dependencies and improving API and integration with OpenBoardPkg ACPI implementation. This

[edk2-devel][edk2-platforms][PATCH V2 3/5] WhitleySiliconPkg/Interfaces: Remove PcdsDynamic use.

2021-10-05 Thread Oram, Isaac W
Remove Dynamic PCD options in favor of DynamicEx only. Delete some dead code and misleading comments. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Silicon/Intel/WhitleySiliconPkg/CpRcPkg.dec | 4 ++-- Silicon/Intel/WhitleySiliconPkg/Cpu/CpuRcPkg.dec | 2 +-

[edk2-devel][edk2-platforms][PATCH V2 2/5] WhitleySiliconPkg/Interfaces: Update to Server-RC-0.2.2.003a

2021-10-05 Thread Oram, Isaac W
This updates IIO interface adding AltAttenTable and the corresponding PCD and defaults. Adds HideWriteDataParityLogs. Updates PCD defaults for a variety of settings. Removes Dynamic PCD options in favor of DynamicEx only. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram ---

[edk2-devel][edk2-platforms][PATCH V2 4/5] WhitleyOpenBoardPkg/Acpi: Use binary AcpiPlatform driver

2021-10-05 Thread Oram, Isaac W
This uses the binary AcpiPlatform driver from FvLateOpenBoard to produce and update more complete ACPI tables. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 4 Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf | 2 --

[edk2-devel][edk2-platforms][PATCH V2 0/5] WhitleyOpenBoardPkg: Enable VT-D support

2021-10-05 Thread Oram, Isaac W
This patch series enables VT-D support in the WhitleyOpenBoardPkg. For the initial patch, I missed that there was a different AcpiPlatform driver required. This patch series incorporates that requirement and the additional changes that requires. The AcpiPlatform driver leverages SMBIOS and the

[edk2-devel][edk2-platforms][PATCH V2 1/5] WhitleyOpenBoardPkg/Smbios: Add SMBIOS PCD

2021-10-05 Thread Oram, Isaac W
This adds PCD that need to be produced by the board port to properly populate the FvOpenBoardPkg SMBIOS support and generate reasonable SMBIOS tables. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 107

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-05 Thread Ard Biesheuvel
On Tue, 5 Oct 2021 at 23:25, Jeremy Linton wrote: > > Hi, > > On 10/5/21 5:11 AM, Ard Biesheuvel wrote: > > On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: > >> > >> In theory we should be properly cleaning up all the device drivers before > >> pulling the big switch. Particularly the

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-05 Thread Jeremy Linton
Hi, On 10/5/21 5:11 AM, Ard Biesheuvel wrote: On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: In theory we should be properly cleaning up all the device drivers before pulling the big switch. Particularly the partition mgr will issue flush commands to attached disks as it goes down. This

Re: [edk2-devel] [PATCH 2/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-05 Thread Jeremy Linton
Hi, On 10/5/21 5:12 AM, Ard Biesheuvel wrote: On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: While debugging problems with the GET/SET_CLOCK mailbox calls it appeared that the locking in most of the mailbox commands isn't perfectly correct. All UEFI firmware calls to the RPi mailbox share

Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance

2021-10-05 Thread Leif Lindholm
On Mon, Oct 04, 2021 at 19:03:40 +0700, Nhi Pham wrote: > Hi Leif, > > There are two comments that I would like to clarify with you. > > On 23/09/2021 20:49, Leif Lindholm wrote: > > > +VOID > > > +Ac01PcieMmioWr ( > > > + UINT64 Addr, > > > + UINT32 Val > > > + ) > > > +{ > > > +

Re: [edk2-devel] Mergify is no longer auto closing personal Github PRs

2021-10-05 Thread Michael D Kinney
Hi Rebecca, Yes. This is the new behavior after changes were added in July 9, 2021. https://github.com/tianocore/edk2/commit/b491eace373ea3fa435a0136db3c38e0360e6f11#diff-a3528dea46dcf4932a9c3dfdd1a9e320daeed9256f3906d4174915470add4189 .mergify: Simplify Mergify rules using GitHub

Re: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-10-05 Thread Andrew Fish via groups.io
Should we move to require a min Python version at some point? > On Oct 5, 2021, at 9:48 AM, Cole wrote: > > On 9/6/21 9:18 PM, gaoliming wrote: >> Bob: >> >> Yes. Python3 is the formal support. We recommend user to use Python3. >> But, if user meets the issue in Python2, user can still report

Re: 回复: [edk2-devel] Python2.7 is not working with the EDK2 build system

2021-10-05 Thread Cole
On 9/6/21 9:18 PM, gaoliming wrote: > Bob: > >  Yes. Python3 is the formal support. We recommend user to use Python3. > But, if user meets the issue in Python2, user can still report the issue > in BaseTools. Its priority may be low. For this case, it is the > regression issue caused by the

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

2021-10-05 Thread Sami Mujawar
Merged as 06a326caf125..942c9bd357d8 Thanks. Regards, Sami Mujawar On 16/08/2021 03:52 PM, Chris Jones wrote: Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565) This patch series updates the Acpiview GTDT parser and DynamicTables GTDT generator to support ACPI 6.4. This

Re: [edk2-devel] [PATCH v1] DynamicTablesPkg: Update FADT generator to ACPI 6.4

2021-10-05 Thread Sami Mujawar
Merged as 862e814de403..06a326caf125 Thanks. Regards, Sami Mujawar On 17/08/2021 02:50 PM, Chris Jones wrote: Bugzilla: 3568 (https://bugzilla.tianocore.org/show_bug.cgi?id=3568) Update the FADT generator to use Acpi64.h. As the FADT revision tracks the ACPI revision this updates the minor

[edk2-devel] Mergify is no longer auto closing personal Github PRs

2021-10-05 Thread Rebecca Cran
I noticed that Mergify is no longer auto closing personal builds: for example https://github.com/tianocore/edk2/pull/2026 is still open. Compare that to https://github.com/tianocore/edk2/pull/1708 where mergify commented "All checks passed. Auto close personal build." -- Rebecca Cran

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

2021-10-05 Thread Abner Chang
Hi Ard, This way reduces the impact of MdePkg. We can try it. Thanks Abner From: devel@edk2.groups.io on behalf of Ard Biesheuvel Sent: Tuesday, October 5, 2021 5:30 PM To: edk2-devel-groups-io ; Chang, Abner (HPS SW/FW Technologist) Cc: Ard Biesheuvel ;

Re: [edk2-devel] [PATCH v1 12/13] DynamicTablesPkg: Add CM_ARM_LPI_INFO object

2021-10-05 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois Introduce the CM_ARM_LPI_INFO CmObj in the ArmNameSpaceObjects. This allows to describe LPI state information, as described in

Re: [edk2-devel] [PATCH v1 13/13] DynamicTablesPkg: SSDT CPU topology and LPI state generator

2021-10-05 Thread Sami Mujawar
Hi Pierre, I ahve a few minor suggestions marked inline as [SAMI]. With those changed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois In the GIC interrupt model, logical processors are required to have a

Re: [edk2-devel] [PATCH v3 00/19] OvmfPkg: Add support for microvm machine type

2021-10-05 Thread Ard Biesheuvel
On Wed, 8 Sept 2021 at 11:01, Gerd Hoffmann wrote: > > This patch series adds basic support for the > microvm machine type to OVMF. > > Working: > - uefi shell @ serial console. > - direct kernel boot. > > Comming in followup patches: > - virtio-mmio support. > - pcie support. > > Usage:

Re: [edk2-devel] [PATCH v3 11/19] OvmfPkg/Microvm: PlatformPei/MemDetect tweaks

2021-10-05 Thread Ard Biesheuvel
On Thu, 9 Sept 2021 at 12:58, Gerd Hoffmann wrote: > > > > Sure. Suggestions? Add a Pcd and set it in Microvm.dsc? > > > Or is there some better way? > > > > It's all a question of how much we want to overengineer things :) > > > > I'm tempted to suggest a balanced version would be adding > >

Re: [edk2-devel] [PATCH 2/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-05 Thread Ard Biesheuvel
On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: > > While debugging problems with the GET/SET_CLOCK mailbox calls it appeared > that the locking in most of the mailbox commands isn't perfectly > correct. All UEFI firmware calls to the RPi mailbox share a single > mDmaBuffer which is used to

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-05 Thread Ard Biesheuvel
On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: > > In theory we should be properly cleaning up all the device drivers before > pulling the big switch. Particularly the partition mgr will issue > flush commands to attached disks as it goes down. This assures that > devices running in WB mode

Re: [edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached

2021-10-05 Thread Ard Biesheuvel
On Sat, 2 Oct 2021 at 03:14, Andrei Warkentin wrote: > > I may have misunderstood the flags as being valid ways of mapping the added > range. Should we also then take out WC and WT? No, you understood correctly. The problem is that normal memory ceases to behave like normal memory when you map

Re: [edk2-devel] [PATCH v4 0/3] ArmVirtPkg: Disable the TPM 2 platform hierarchy

2021-10-05 Thread Ard Biesheuvel
Merged as #2041 What is the status of the OVMF series with the same purpose? On Mon, 4 Oct 2021 at 21:56, Stefan Berger wrote: > > Yao, > > I think this series has the needed R-b's and should be commit-able. > > Cheers! > > Stefan > > > On 9/24/21 7:42 AM, Stefan Berger wrote: > > This

Re: [edk2-devel] [PATCH v2 1/1] Platform/RaspberryPi: Always use non translating DMA in DT mode

2021-10-05 Thread Ard Biesheuvel
On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote: > > One of the many issues with the PCIe on this platform is > its inbound DMA is either constrained to the lower 3G, or > on later SoC's a translation can be used. That translation > was problematic with some of the OS's expected to boot > on

Re: [edk2-devel] [PATCH 1/1] ArmPkg: SmbiosMiscDxe: Don't populate ExtendedBiosSize when size < 16MB

2021-10-05 Thread Ard Biesheuvel
On Tue, 5 Oct 2021 at 05:05, Nhi Pham wrote: > > Thanks, Rebecca for the patch. > > Acked-by: Nhi Pham > Merged as #2040 Thanks, > Best regards, > Nhi > > On 05/10/2021 01:00, Sami Mujawar wrote: > > Hi Rebecca, > > > > Thank you for this patch. These changes look good to me. > > > >

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

2021-10-05 Thread Ard Biesheuvel
On Thu, 30 Sept 2021 at 03:43, Abner Chang wrote: > > In V3: Address comments on V2. > In V2: Remove HPE license on the files that just moved around or >the changes in the file are just code removal. > > edk2 BZ #: 3665 > edk2 platform corresponding changes will be submitted after > this

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Improvements for booting to Linux on RISC-V

2021-10-05 Thread Abner Chang
All good. Reviewed-by: Abner Chang From: Schaefer, Daniel Sent: Monday, October 4, 2021 7:28 PM To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Sunil V L ; Leif Lindholm Subject: [edk2-platforms][PATCH v2 0/5] Improvements for booting to