Re: [edk2-devel] [PATCH] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image

It seems make sense. Would you please: 1) Fila a Bugzilla - https://bugzilla.tianocore.org/ 2) Describe what unit test you have done. Especially, if multiple cert list/data have been tested. I ask this because we use a for-loop to check cert in list one by one. Thank you Yao Jiewen > -Origi

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

Min, The change is to provide a totally different MP service in TDX case. It makes the MpInitLib more complicated. How about? 1. Change CpuMpPei/CpuMpDxe to return directly in TDX case. 2. Add new TdxCpuMpPei/TdxCpuMpDxe to provide a new set simple MP service in TDX case. This makes the whole co

[edk2-devel] [PATCH 4/4] Silicon/ChaosKeyDxe: Test the ControllerHandle is managed by this driver

From: Kazuhiko Sakamoto Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kazuhiko Sakamoto Signed-off-by: Masami Hiramatsu --- Silicon/Openmoko/ChaosKeyDxe/ChaosKeyDriver.h |1 + Silicon/O

[edk2-devel] [PATCH 3/4] Silicon/AtSha204a: Test the ControllerHandle is managed by this driver

From: Kazuhiko Sakamoto Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kazuhiko Sakamoto Signed-off-by: Masami Hiramatsu --- Silicon/Atmel/AtSha204a/AtSha204aDriver.h |1 + Silicon/Atmel

[edk2-devel] [PATCH 2/4] Silicon/SynQuacerI2cDxe: Test the ControllerHandle is managed by this driver

From: Kazuhiko Sakamoto Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kazuhiko Sakamoto Signed-off-by: Masami Hiramatsu --- .../Drivers/SynQuacerI2cDxe/ComponentName.c| 13 +++

[edk2-devel] [PATCH 1/4] Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this driver

From: Kazuhiko Sakamoto Test the @ControllerHandle is not NULL and is actually managed by this driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kazuhiko Sakamoto Signed-off-by: Masami Hiramatsu --- .../Drivers/Net/NetsecDxe/ComponentName.c | 13 +++

[edk2-devel] [PATCH 0/4] SynQuacer drivers test the ControllerHandle correctly

Hello, Here are the patches to fix the SynQuacer related drivers to test whether the ControllerHandle is managed by that driver correctly. These bugs are found by edk2-test. Thank you, --- Kazuhiko Sakamoto (4): Silicon/SynQuacerNetsecDxe: Test the ControllerHandle is managed by this dri

Re: [edk2-devel] [PATCH] Silicon/SynQuacerI2cDxe: Wait for bus busy

Hello Ard, Would you have any comment on this fix? Thank you, 2021年9月30日(木) 14:44 Masami Hiramatsu via groups.io : > If an EFI application frequently repeats SetTime and GetTime, > the I2C bus can be busy and failed to start. To fix this issue, > add waiting loop for the bus busy status. (Usual

Re: [edk2-devel] [PATCH V2 07/28] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

Min, Comments below: -Original Message- From: Xu, Min M Sent: Tuesday, October 5, 2021 11:39 AM To: devel@edk2.groups.io Cc: Xu, Min M ; Dong, Eric ; Ni, Ray ; Kumar, Rahul1 ; Brijesh Singh ; Erdem Aktas ; James Bottomley ; Yao, Jiewen ; Tom Lendacky Subject: [PATCH V2 07/28] UefiCp

Re: [edk2-devel] [PATCH V9 4/4] OvmfPkg: Enable TDX in ResetVector

On October 12, 2021 3:43 PM, Gerd Hoffmann wrote: > Hi, > > > +; Load the GDT and set the CR0. > > +; > > +; Modified: EAX, EBX, CR0, CR4, DS, ES, FS, GS, SS, CS ; > > +ReloadFlat32: > > + > > +cli > > +mov ebx, ADDR_OF(gdtr) > > +lgdt[ebx] > > No need to modify ebx here, e

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Remove SystemTableInfo GUID.

Reviewed-by: Ray Ni -Original Message- From: Kesavan Balakrishnan, ThiyaguX Sent: Wednesday, October 13, 2021 1:08 PM To: devel@edk2.groups.io Cc: Kesavan Balakrishnan, ThiyaguX ; Ma, Maurice ; Dong, Guo ; Ni, Ray ; You, Benjamin ; Liu, Zhiguang Subject: [PATCH v2] UefiPayloadPkg: R

[edk2-devel] [PATCH v2] UefiPayloadPkg: Remove SystemTableInfo GUID.

SystemTableInfo GUID is not a Spec defined GUID. But the latest SBL uses SystemTableInfo to get ACPI and SMBIOS table information. So moving the SystemTableInfo GUID implementation to SblParseLib. Cc: Maurice Ma Cc: Guo Dong Cc: Ray Ni Cc: Benjamin You Cc: Zhiguang Liu Signed-off-by: Guo Don

Re: [edk2-devel] [PATCH V2 21/28] OvmfPkg: Update PlatformPei to support TDX

Hi, > 2. Relocate mailbox > At the beginning of system boot, a 4K-aligned, 4K-size memory (Td > mailbox) is pre-allocated by host VMM. BSP & APs do the page accept > together in that memory region. > After that TDVF is designed to relocate the mailbox to a 4K-aligned, > 4K-size memory

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

Hi Hua, It looks a bit odd to me to add 'IsLocked' parameter and acquire lock inside CoreValidateHandle() if it's FALSE. Maybe we can keep the function prototype as-is but do something like below: a) Just keep ASSERT_LOCKED(&gProtocolDatabaseLock) in CoreValidateHandle() b) Call CoreAcqui

Re: [edk2-devel] [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Ma, Hua > Sent: Tuesday, October 12, 2021 4:34 PM > To: devel@edk2.groups.io > Cc: Ma, Hua ; Wang, Jian J ; > Liming Gao ; Bi, Dandan ; > Ni, Ray > Subject: [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterat

Re: [edk2-devel] [PATCH 2/2] Allow wildcards in hostname

It seems the Bugzilla only describes the ECC, but no much info on why we need allow wildcards in hostname. The git log in mu is also unclear to me - "This enables certain local network recovery stories. May re-evaluate as those stories change. " I am OK with ECC change, and give R-B. But I wou

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Reviewed-by: Jiewen Yao > -Original Message- > From: Vineel Kovvuri > Sent: Tuesday, October 12, 2021 1:38 PM > To: devel@edk2.groups.io; Yao, Jiewen ; > sean.bro...@microsoft.com; bret.barke...@microsoft.com; > michael.tur...@microsoft.com > Cc: Vineel Kovvuri > Subject: [PATCH 1/2] R

Re: [edk2-devel] [PATCH] UserAuthFeaturePkg/UserAuthenticationDxeSmm: The SMI to handle the user authentication should be unregister before booting to OS

Patch is submitted via commit 23ca68c23dd600973e961de4368abacf4db8c5c0 https://github.com/tianocore/edk2-platforms/commit/23ca68c23dd600973e961de4368abacf4db8c5c0 Thanks, Dandan > -Original Message- > From: Bi, Dandan > Sent: Friday, October 8, 2021 9:44 AM > To: Shi, Hao ; devel@edk2.g

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

OVMF did a similare change on Time Driver, please refer to https://github.com/tianocore/edk2/commit/239b50a863704f7960525799eda82de061c7c458 I do not think this will be apply for ArmPkg/TimerDxe. If one real issue happened on platform, it seems that interrupt was reenabled by reigstered time

Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmbeddedPkg:Fix compiler warning

Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > wenyi,xie via groups.io > Sent: Tuesday, October 12, 2021 4:16 PM > To: devel@edk2.groups.io; l...@nuviainc.com; ardb+tianoc...@kernel.org; > Chang, Abner (HPS SW/FW Techno

Re: [edk2-devel] [PATCH v2] CryptoPkg/BaseCryptLib: Eliminate extra buffer copy in Pkcs7Verify()

https://github.com/tianocore/edk2/pull/2055 pushed: https://github.com/tianocore/edk2/commit/f22feb0e3b3f08b95201b258b104c45a2acef71f > -Original Message- > From: Yao, Jiewen > Sent: Saturday, September 11, 2021 11:30 PM > To: Bob Morgan ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xia

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 10/12/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

[edk2-devel] 回复: [PATCH v9 1/1] MdePkg/BaseLib: Add QuickSort function on BaseLib

I have no other comments. Reviewed-by: Liming Gao > -邮件原件- > 发件人: Kuo, IanX > 发送时间: 2021年10月12日 11:51 > 收件人: Ni, Ray ; devel@edk2.groups.io; Kinney, Michael > D ; Liming Gao > 抄送: Chan, Amy ; Liu, Zhiguang > > 主题: RE: [PATCH v9 1/1] MdePkg/BaseLib: Add QuickSort function on > BaseLib >

Re: [edk2-devel] [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm

On October 12, 2021 9:23 PM, Lendacky Thomas wrote: > On 10/11/21 9:37 PM, Min Xu wrote: > > diff --git a/OvmfPkg/ResetVector/Main.asm > > b/OvmfPkg/ResetVector/Main.asm index ae90a148fce7..a501fbe880f2 > 100644 > > --- a/OvmfPkg/ResetVector/Main.asm > > +++ b/OvmfPkg/ResetVector/Main.asm > > @@ -3

Re: [edk2-devel] [PATCH V9 1/4] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector

On October 12, 2021 3:02 PM, Gerd Hoffmann wrote: > On Tue, Oct 12, 2021 at 10:37:47AM +0800, Min Xu wrote: > > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > Previously OvmfPkg/ResetVector uses the Main.asm in > > UefiCpuPkg/ReseteVector/Vtf0. In this Main.asm there is only Main1

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

From: Ashish Singhal Sent: Tuesday, October 12, 2021 10:32 AM To: Marc Zyngier Cc: Shanker Donthineni ; Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   From: Marc Zyngier Sent: Tuesday, Oct

[edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image

If the image is signed but not allowed by DB and the hash of image is not found in DB/DBX, then the EFI_IMAGE_INFO_ACTION of the load of said image should be set to, EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND, rather then being left unset as EFI_IMAGE_EXECUTION_AUTH_UNTESTED. Cc: Jiewen Yao Cc: Jian

[edk2-devel] [PATCH 1/1] SecurityPkg/DxeImageVerificationLib: Set Action for failed unsigned image

If the image is not signed and the hash of image is not found in DB/DBX, then the EFI_IMAGE_INFO_ACTION of the load of said image should be set to, EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND, rather then being left unset as EFI_IMAGE_EXECUTION_AUTH_UNTESTED. Cc: Jiewen Yao Cc: Jian J Wang Cc: Min Xu

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

From: Marc Zyngier Sent: Tuesday, October 12, 2021 10:27 AM To: Ashish Singhal Cc: Shanker Donthineni ; Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   External email: Use caution opening links

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

From: Marc Zyngier Sent: Tuesday, October 12, 2021 9:44 AM To: Ashish Singhal Cc: Ard Biesheuvel ; edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal   External email: Use caution opening links or attachments Ashi

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

+ Shaker Get Outlook for iOS From: Ashish Singhal Sent: Tuesday, October 12, 2021 8:56:58 AM To: Marc Zyngier ; Ard Biesheuvel Cc: edk2-devel-groups-io ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

Hi Min, Thank you for this patch. I think it would greatly help if the EFI_TD_PROTOCOL is changed to something more architecture neutral. As I understand, this patch series is removing the dependency on TPM for measurement and is instead providing a lightweight interface for extending measurem

Re: [edk2-devel] [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal

Marc, In the document ARM062-1010708621-30 (AArch64 Programmer's Guides Generic Timer), towards the end of section 3.4 it says: "When writing an interrupt handler for the timers, it is important that software clears the interrupt before deactivating the interrupt in the GIC. Otherwise, the GIC

Re: [edk2-devel] [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm

On 10/11/21 9:37 PM, Min Xu wrote: RFC： https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3429&data=04%7C01%7Cthomas.lendacky%40amd.com%7Cc4c4ac9654a940ada92308d98d2994d0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637696032012206979%

[edk2-devel] [PATCH] SecurityPkg/DxeImageVerificationLib: Set Action for failed signed image

From: Joseph Hemann If the image is signed but not allowed by DB and the hash of image is not found in DB/DBX, then the EFI_IMAGE_INFO_ACTION of the load of said image should be set to, EFI_IMAGE_EXECUTION_AUTH_SIG_NOT_FOUND, rather then being left unset as EFI_IMAGE_EXECUTION_AUTH_UNTESTED. Cc:

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > TDX guest supports LocalApicTimer. But in current OvmfPkg the supported > timer is 8254TimerDxe. So gUefiOvmfPkgTokenSpaceGuid.PcdTimerSelector > is introduced to select the runni

Re: [edk2-devel] [PATCH V2 27/28] OvmfPkg: Update IoMmuDxe to support TDX

Hi, > +#define IO_MMU_LEGACY 0x0 > +#define IO_MMU_SEV 0x01 > +#define IO_MMU_TDX 0x02 > + > +UINTN mIoMmuType = IO_MMU_LEGACY; Yet another place where you should be able to just use the ConfidentialComputing PCD. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You recei

Re: [edk2-devel] [PATCH V2 25/28] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library

> +/** > + Initialize a buffer pool for page table use only. > + > + To reduce the potential split operation on page table, the pages reserved > for > + page table should be allocated in the times of PAGE_TABLE_POOL_UNIT_PAGES > and > + at the boundary of PAGE_TABLE_POOL_ALIGNMENT. So the pag

Re: [edk2-devel] [PATCH V2 24/28] OvmfPkg: Add TdxDxe driver

Hi, > Besides above features, TdxDxe driver will update the ACPI MADT > Mutiprocessor Wakeup Table. > + ACPI_MADT_MPWK_STRUCT *MadtMpWk; > + NewBufferSize = 1 * sizeof (*Madt) + > + CpuCount * sizeof (*LocalApic)

Re: [edk2-devel] [PATCH V2 14/28] OvmfPkg: Update SecEntry.nasm to support Tdx

Hi, > - AcceptPages: >To mitigate the performance impact of accepting pages in SEC phase on >BSP, BSP will parse memory resources and assign each AP the task of >accepting a subset of pages. This command may be called several times >until all memory resources are processed. In a

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

Hi, > + do { > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); Again: this should use PCD. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81823): https://edk2.groups.io/g/devel/message/81823 Mute This Topic: htt

Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

Hi, > + if (ExceptionType == VE_EXCEPTION) { > +EFI_STATUS Status; > +// > +// #VE needs to be handled immediately upon enabling exception handling > +// and therefore can't use the RegisterCpuInterruptHandler() interface. Can please you explain in more detail why this is the

Re: [edk2-devel] [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665

No issues with these, as long as they're merged (very shortly) after the edk2 set. Although please fix the typo in all of the commit messages complaint -> compliant (But please don't send a v4 just for that.) For the ones where you need it: Acked-by: Leif Lindholm On Mon, Oct 04, 2021 at 17:

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT

On Fri, Oct 08, 2021 at 16:18:44 +0200, Ard Biesheuvel wrote: > On Fri, 8 Oct 2021 at 12:34, Leif Lindholm wrote: > > > > The MADT GICC structure contains the field PhysicalBaseAddress, which > > is needed for a GICv1/v2 implementation, or to indicate legacy > > compatibility in modern GICs. > > >

Re: [edk2-devel] [PATCH V2 07/28] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

Hi, > + do { > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); Use ConfidentialComputing PCD ? > +BOOLEAN > +EFIAPI > +AccessMsrNative ( I'd suggest to reverse the logic, i.e. have a AccessMsrTdxCall() which returns true in case (a) tdx is active and (b) the msr is not on the white list fo

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

On Tue, Oct 05, 2021 at 11:39:17AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Intel TDX architecture does not prescribe a specific software convention > to perform I/O from the guest TD. Guest TD providers have many choices to > provide I/O to the guest. Th

Re: [edk2-devel] [Patch V4 1/1] BaseTools: Change RealPath to AbsPath

Reviewed-by: Bob Feng -Original Message- From: Chen, Christine Sent: Tuesday, October 12, 2021 12:08 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao Subject: [Patch V4 1/1] BaseTools: Change RealPath to AbsPath Currently the realpath is used when parse modules, which shows th

[edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

This commit is a cherry pick of project mu's commit https://github.com/microsoft/mu_tiano_plus/commit/1f3b135ddc821718a78c352316197889c5d3e0c2 Reconfigure OpensslLib to add elliptic curve chipher algorithms. The only file manually changed is process_files.pl. Running the script changes the other t

[edk2-devel] [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record

-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81816): https://edk2.groups.io/g/devel/message/81816 Mute This Topic: https://groups.io/mt/86257812/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/

[edk2-devel] [PATCH 2/2] Allow wildcards in hostname

This PR is cherry-picked from https://github.com/microsoft/mu_basecore/commit/d0c7733400c35722499eedcd4279042a9bcb0eb4 BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3679 Signed-off-by: Vineel Kovvuri --- NetworkPkg/HttpDxe/HttpsSupport.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [edk2-devel] [PATCH] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

Hi Dandan, Thanks for the comment. Patch v2 is just sent with the update. Please help to review. Thank you, Ma Hua > -Original Message- > From: Bi, Dandan > Sent: Tuesday, October 12, 2021 12:13 PM > To: Ma, Hua ; devel@edk2.groups.io > Cc: Wang, Jian J ; Liming Gao > ; Ni, Ray > Subje

[edk2-devel] [PATCH v2] MdeModulePkg/Core/Dxe: Acquire a lock when iterating gHandleList

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3680 This patch fixes the following issue: The global variable gHandleList is a linked list. This list is locked when a entry is added or removed from the list, but there is no lock when iterating this list in function CoreValidateHandle(). It c

Re: [edk2-devel] [PATCH edk2-test v2 1/1] uefi-sct/SctPkg: fix BuildAtaDeviceNode()

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81811): https://edk2.groups.io/g/devel/message/81811 Mute This Topic: https://groups.io/mt/85467867/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: h

Re: [edk2-devel] [PATCH V2 05/28] MdePkg: Add TdxLib to wrap Tdx operations

> +// PageSize is mapped to PageLevel like below: > +// 4KB - 0, 2MB - 1 > +UINT64 mTdxAcceptPageLevelMap[2] = { > + SIZE_4KB, > + SIZE_2MB No 1G pages? > +UINTN > +GetGpaPageLevel ( > + UINT64 PageSize Uh, UINT32 is not enough? Keep the door open for 512G pages? > +{ > + UINTN Index; > +

[edk2-devel] [PATCH EDK2 v1 1/1] EmbeddedPkg:Fix compiler warning

Fixes the following compiler warning in VS2019. edk2\EmbeddedPkg\Library\GdbSerialDebugPortLib\GdbSerialDebugPortLib.c(127): error C2220: the following warning is treated as an error edk2\EmbeddedPkg\Library\GdbSerialDebugPortLib\GdbSerialDebugPortLib.c(127): warning C4244: 'function': conversion

[edk2-devel] [PATCH EDK2 v1 0/1] EmbeddedPkg:Fix compiler warning

Main Changes : 1.Changing definition of gTimeOut from UINTN to UINT32 2.Changing definition of CompressedDataLength from UINTN to UINT32 Wenyi Xie (1): EmbeddedPkg:Fix compiler warning EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +- EmbeddedPkg/Library/PrePiLib/FwVol.

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState

On Thu, Sep 9, 2021 at 12:45 AM, Heinrich Schuchardt wrote: > > BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1 Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81807): https://edk2.groups.io/g/devel/messa

Re: [edk2-devel] [PATCH V2 04/28] MdePkg: Add Tdx.h

On Tue, Oct 05, 2021 at 11:39:15AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Tdx.h includes the Intel Trust Domain Extension definitions. > > Detailed information can be found in below document: > https://software.intel.com/content/dam/develop/external/us

Re: [edk2-devel] [PATCH V9 4/4] OvmfPkg: Enable TDX in ResetVector

Hi, > +; Load the GDT and set the CR0. > +; > +; Modified: EAX, EBX, CR0, CR4, DS, ES, FS, GS, SS, CS > +; > +ReloadFlat32: > + > +cli > +mov ebx, ADDR_OF(gdtr) > +lgdt[ebx] No need to modify ebx here, eax should do fine. > +mov eax, SEC_DEFAULT_CR0 > +mov

Re: [edk2-devel] [PATCH V9 3/4] OvmfPkg: Add IntelTdxMetadata.asm

Hi, > +; - Type field means this section is of BFV. This field is designed for the > +; purpose that in some case host VMM may do some additional processing > based > +; upon the section type. TdHob section is an example. Host VMM pass the > +; physical memory information to the guest fir

Re: [edk2-devel] [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm

On Tue, Oct 12, 2021 at 10:37:48AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Previously WORK_AREA_GUEST_TYPE was cleared in SetCr3ForPageTables64. > This is workable for Legacy guest and SEV guest. But it doesn't work > after Intel TDX is introduced. It is

Re: [edk2-devel] [PATCH V9 1/4] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector

On Tue, Oct 12, 2021 at 10:37:47AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Previously OvmfPkg/ResetVector uses the Main.asm in > UefiCpuPkg/ReseteVector/Vtf0. In this Main.asm there is only Main16 > entry point. > > This patch-set is to introduce Intel