Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-10-15 Thread Sami Mujawar
Hi Rebecca, I will review this next week. Regard Sami Mujawar From: Rebecca Cran Sent: Saturday, 16 October 2021, 7:33 am To: devel@edk2.groups.io; Jian J Wang; Liming Gao Cc: Ard Biesheuvel; Samer El-Haj-Mahmoud; Leif Lindholm; Sami Mujawar; Gerd Hoffmann Sub

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

2021-10-15 Thread Rebecca Cran
(cc Leif, Ard, Sami, Samer, Gerd) Could someone review this please? -- Rebecca Cran On 9/20/21 9:47 AM, Rebecca Cran via groups.io wrote: Add a new MpServicesTest application under MdeModulePkg/Application that exercises the EFI_MP_SERVICES_PROTOCOL. Signed-off-by: Rebecca Cran --- MdeM

[edk2-devel] [`edk2-devel][PATCH v2] UefiPayloadPkg: Fix ECC reported issues

2021-10-15 Thread Guo Dong
From: Guo Dong V2: Fix more header files on #ifdef variable ECC reported some issues on UefiPayloadPkg, this patch fixed most of them except several files including ElfLib\Elf32.h, coreboot.h, CbParseLib.c, etc. It also removed unused functions in ResetSystemLib and Hob.c. Signed-off-by: Guo Do

Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
@Marvin Häuser Thank to catch it. I dropped it on my patch v2. Compiler Status Linux GCC5 (gcc 10.2.0/9.3.0/8.4.0/7.5.0/5.5.0/5.4.0) Pass Windows CLANGPDB (clang 12.0.0), Linux CLANGPDB (clang 12.0.0) Pass Windows MSVC (VS2015/VS2017/VS2019) Pass Mac XCODE5 (clang 11.0.0

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 9 - .../Library/CpuCacheInfoLib/DxeCpuCacheInfoLib

[edk2-devel] [PATCH v2 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 92 +-- 1

[edk2-devel] [PATCH v2 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 115 + .../Library/UefiSortLib/UefiSortLib.

[edk2-devel] [PATCH v2 0/3] Add function QuickSort into MdePkg/BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo 1. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 1-1: Drop cast (V2) 2. CryptLib/CryptLib: Remove duplicate QuickSortWorker 3. CpuCacheInfoLib: Remove MdeModulePkg dependency 3-1: Drop cast (V2) 3-2: Add runtime check (V2) IanX Kuo (3): MdeModulePkg/SortLib: Ad

[edk2-devel][edk2-platforms][PATCH V1 08/11] SimicsOpenBoardPkg/ReportFvLib: Update ReportFvLib

2021-10-15 Thread Oram, Isaac W
Update file naming to match other ReportFvLib implementations. Also fix duplicate GUID for libary name. Cc: Agyeman Prince Signed-off-by: Isaac Oram --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 +- Platform/Intel/Simic

[edk2-devel][edk2-platforms][PATCH V1 11/11] MinPlatformPkg/ReportFvLib: Remove obsolete PeiReportFvLib instance

2021-10-15 Thread Oram, Isaac W
All boards have been updated to use the new libraries or custom instances. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 1 - Platform/Intel/MinPlatformPk

[edk2-devel][edk2-platforms][PATCH V1 07/11] PurleyOpenBoardPkg/ReportFvLib: Update ReportFvLib

2021-10-15 Thread Oram, Isaac W
Update custom ReportFvLib to match other board implementations. Also fix duplicate GUID for libary name. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc

[edk2-devel][edk2-platforms][PATCH V1 09/11] MinPlatformPkg/SpifvbService: Publish FV based on board request

2021-10-15 Thread Oram, Isaac W
Change MM reporting to use ReportFvLib API ReportMmFv (); This removed the hardcoded table of FV to publish. Also removed the unused "default" table. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- Platform/Intel/MinPlatformPkg/Flash/SpiFvbService

[edk2-devel][edk2-platforms][PATCH V1 10/11] MinPlatformPkg/SpiFvbService: Reduce duplicate code

2021-10-15 Thread Oram, Isaac W
Consolidate all the entry point functions into SpiFvbServiceMm.c This reduces the number of files and makes the code easier to understand. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServ

[edk2-devel][edk2-platforms][PATCH V1 06/11] WhitleyOpenBoardPkg/ReportFvLib: Add board support for custom MM FV

2021-10-15 Thread Oram, Isaac W
ReportFvLib added a new fuction for boards to communicate MM required FV The custom instance allows Whitley boards to publish an FV for WHEA use. Also fixed duplicate GUID library name. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/Library/R

[edk2-devel][edk2-platforms][PATCH V1 05/11] WhiskeyLakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-15 Thread Oram, Isaac W
MinPlatformPkg shared ReportFvLib has split into PEI and SMM instances. Default versions are already included via CorePeiLib.dsc and CoreDxeLib.dsc Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc| 1 - Pla

[edk2-devel][edk2-platforms][PATCH V1 04/11] TigerLakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-15 Thread Oram, Isaac W
MinPlatformPkg shared ReportFvLib has split into PEI and SMM instances. Default versions are already included via CorePeiLib.dsc and CoreDxeLib.dsc Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Isaac Oram --- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc

[edk2-devel][edk2-platforms][PATCH V1 02/11] CometlakeOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-15 Thread Oram, Isaac W
MinPlatformPkg shared ReportFvLib has split into PEI and SMM instances. Default versions are already included via CorePeiLib.dsc and CoreDxeLib.dsc Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Isaac Oram --- Plat

[edk2-devel][edk2-platforms][PATCH V1 03/11] KabyOpenBoardPkg/ReportFvLib: Switch to new library instances.

2021-10-15 Thread Oram, Isaac W
MinPlatformPkg shared ReportFvLib has split into PEI and SMM instances. Default versions are already included via CorePeiLib.dsc and CoreDxeLib.dsc Cc: Chasel Chiu Cc: Nate DeSimone Cc: Benjamin Doron Cc: Jeremy Soller Signed-off-by: Isaac Oram --- Platform/Intel/KabylakeOpenBoardPkg/AspireV

[edk2-devel][edk2-platforms][PATCH V1 01/11] MinPlatformPkg/ReportFvLib: Add ReportMmFv to API

2021-10-15 Thread Oram, Isaac W
Add ReportMmFv (); API for enabling boards to publish additional regions for MM driver use. This results in different instances of the library for PEI and MM. Added MinPlatformPkg library instances to the CorePeiLib.dsc and CoreDxeLib.dsc as the default library instances. Cc: Chasel Chiu Cc: Nate

[edk2-devel][edk2-platforms][PATCH V1 00/11] Enable board customization of SMM FV reporting

2021-10-15 Thread Oram, Isaac W
This patch allows boards to customize the MM FV list via the ReportFvLib board instance. The SpiFvbService driver publishes a set of FV for MM use. This currently includes variable store and microcode region. MinPlatformPkg contains the common instance of ReportFvLib for PEI and MM use used by mo

[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix ECC reported issues

2021-10-15 Thread Guo Dong
From: Guo Dong ECC reported some issues on UefiPayloadPkg, this patch fixed most of them except several files including ElfLib\Elf32.h, coreboot.h, CbParseLib.c, etc. It also removed unused functions in ResetSystemLib and Hob.c. Signed-off-by: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin Y

Re: [edk2-devel] [PATCH v1 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-15 Thread Marvin Häuser
Good day Ianx, On 15.10.21 16:33, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 5

Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-15 Thread Marvin Häuser
Good day Ianx, On 15.10.21 16:33, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 117 +

[edk2-devel] [PATCH 6/6] uefi-sct/SctPkg: TCG2 Protocol: add SubmitCommand test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for SubmitCommand() -checkpoint for test function with GET_RANDOM Command Signed-off-by: Joseph Hemann Change-Id: I364001c915b9d8d8b79eb4381d828400a1ef72a0 --- .../EFI/Protocol/TCG2/BlackBoxTest/Guid.c | 4 + .../EFI/Protocol/

[edk2-devel] [PATCH 5/6] uefi-sct/SctPkg: TCG2 Protocol: add GetEventLog test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetEventLog() -checkpoint for test function with invalid eventlog format -checkpoint for test function with valid eventlog format Signed-off-by: Joseph Hemann Change-Id: Ie5399f24622ce849d8f1140c56bd71cf886423e3 --- .../EFI/Protocol/T

[edk2-devel] [PATCH 4/6] uefi-sct/SctPkg: TCG2 Protocol: add HashLogExtendEvent test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for HashLogExtendEvent() -checkpoint for test of function with invalid parameters -checkpoint for test of function with valid parameters Signed-off-by: Joseph Hemann Change-Id: Icac3857a5e0d877e9b21f85c20f7d391a380043e --- .../EFI/Protoco

[edk2-devel] [PATCH 3/6] uefi-sct/SctPkg: TCG2 Protocol: add GetActivePcrBanks test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -add initial TCG2 protocol test for GetActivePcrBanks() -checkpoint for NULL pointer passed for buffer -checkpoint for test of function with proper input Signed-off-by: Joseph Hemann Change-Id: Ibf289085dc0f21952ff210757b4736619ac34046 --- .../EFI/Protocol/TCG2

[edk2-devel] [PATCH 2/6] uefi-sct/SctPkg: TCG2 Protocol: add GetCapability Test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann -implement initial infrastructure for the TCG2 protocol test including updates to .dsc file, inf file, GUID source files, update to Category.ini. -add initial TCG2 protocol test for GetCapability(), as defined in the TCG EFI Protocol Spec 6.4.4. -checkpoint for NULL pointer

[edk2-devel] [PATCH 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann Signed-off-by: Joseph Hemann Change-Id: Ib8fafb94c99fbc71f606d23bcdd18963fc7386de --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 174 +++ 1 file changed, 174 insertions(+) create mode 100644 uefi-sct/SctPkg/UEFI/Protocol/TCG2.h diff --git a/uefi-sct/Sct

[edk2-devel] [PATCH 0/6] Implementation of TCG2 Protocol test

2021-10-15 Thread Joseph Hemann
From: Joseph Hemann This patch series implements a set of SCT tests, for the TCG2 UEFI protocol as defined in the TCG EFI Protocol Specification. The series implements the code for the test, and the infrastructure needed to run the test from the SCT UI. Patch 1 adds header file with TCG2 protoco

Re: [edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt

2021-10-15 Thread Yao, Jiewen
OK. I recommend to add those background info in comments. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, October 15, 2021 12:53 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Ard Biesheuvel ; Justen, Jordan L > > Su

Re: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

2021-10-15 Thread Yao, Jiewen
OK. I recommend to add those info in Bugzilla and the description as well. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Friday, October 15, 2021 12:57 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Justen, > Jordan L > Subjec

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

2021-10-15 Thread Brijesh Singh via groups.io
On 10/14/21 10:26 PM, Gerd Hoffmann wrote: > On Thu, Oct 14, 2021 at 05:11:22PM -0500, Brijesh Singh wrote: >> On 10/14/21 1:58 AM, Gerd Hoffmann wrote: >>> On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: When SEV-SNP is active, the CPUID and Secrets memory range contains the

Re: [edk2-devel] [PATCH v2 5/8] DynamicTablesPkg: IORT set reference to Id array only if present

2021-10-15 Thread PierreGondois
Hi Sami, The patch looks good to me: Reviewed-by: Pierre Gondois Regards, Pierre On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > The IORT table generator is setting up a reference to ID array for > nodes even when the ID Mapping count is zero. This is not an issue as an > OS would only a

Re: [edk2-devel] [PATCH v2 2/8] MdePkg: IORT header update for IORT Rev E.b spec

2021-10-15 Thread PierreGondois
Hi Sami, Just a minor comment: On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > Bugzilla: 3458 - Add support IORT Rev E.b specification updates > (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) > > The IO Remapping Table, Platform Design Document, Revision E.b, > Feb 2021 (ht

[edk2-devel] [PATCH v1 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 92 +-- 1

[edk2-devel] [PATCH v1 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 5 - UefiCpuPkg/Library/CpuCacheInfoLib/DxeCpuCache

[edk2-devel] [PATCH v1 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 117 + .../Library/UefiSortLib/UefiSortLib.

[edk2-devel] [PATCH v1 0/3] Add function QuickSort into MdePkg/BaseLib

2021-10-15 Thread IanX Kuo
From: IanX Kuo 1. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 2. CryptLib/CryptLib: Remove duplicate QuickSortWorker 3. CpuCacheInfoLib: Remove MdeModulePkg dependency IanX Kuo (3): MdeModulePkg/SortLib: Add QuickSort function on BaseLib CryptoPkg/CryptLib: Add QuickSort f

Re: [edk2-devel] [PATCH v2 3/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment

2021-10-15 Thread PierreGondois
Hi Sami, The patch looks good to me: Reviewed-by: Pierre Gondois Regards, Pierre On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > Some field names in the IORT table parser were longer than the > OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of > the output print alignment

Re: [edk2-devel] [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot

2021-10-15 Thread Ma, Maurice
There is a typo ' failue' in the commit message. Other than that, looks good. Reviewed-by: Maurice Ma > -Original Message- > From: Dong, Guo > Sent: Thursday, October 14, 2021 22:08 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [`ed

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

2021-10-15 Thread Abner Chang
Merged. The fastest review process I ever experienced. :-D Thanks Abner From: devel@edk2.groups.io on behalf of Leif Lindholm Sent: Friday, October 15, 2021 6:54 PM To: Chang, Abner (HPS SW/FW Technologist) Cc: devel@edk2.groups.io ; Ard Biesheuvel ; Schaefe

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
Can you add some details on how a producer of this interface would know the values to be assigned here? Does this contain any sort of encoding of generation and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-generation changes it will

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
Can you add some details on how a producer of this interface would know the values to be assigned here? Does this contain any sort of encoding of generation and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-generation changes it will

Re: [edk2-devel] [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-15 Thread Maciej Czajkowski
What's the difference between SOC and CPU? SOC die differs from typical CPU die in Intel's chiplet design. What the purpose of "DieIndex"? We want to have an indication to which exactly die given protocol instance is referring to (in example in multi socket/multi PCH designs). Have you considere

Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

2021-10-15 Thread Leif Lindholm
On Fri, Oct 15, 2021 at 15:32:56 +0800, Abner Chang wrote: > In V3: Fix the commit message in each patch. >ArmVirtPkg->ArmPkg > In V2: Fix the invalid email address. Less haste, more speed ;) Acked-by: Leif Lindholm > This patch set fixes the build error caused by referring to > PcdPciM

Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

2021-10-15 Thread Leif Lindholm
On Thu, Oct 14, 2021 at 06:05:59 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran Acked-by: Leif Lindholm Merged as 7e43d3e08611. Thanks! / Leif > > On 10/14/21 1:23 AM, Ming Huang wrote: > > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > > for 64K granularity. > >

[edk2-devel] [PATCH edk2 v1 1/3] StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field

2021-10-15 Thread Ming Huang
TF-A: TrustedFirmware-A SPM: Secure Partition Manager(MM) In TF-A, the name of this field is sp_shared_buf_size. This field is the size of range for transmit data from TF-A to standaloneMM when SPM enable. SpPcpuSharedBufSize is pass from TF-A while StandaloneMM initialize. So, SpPcpuSharedBufSiz

[edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-10-15 Thread Ming Huang
There are two scene communicate with StandaloneMm(MM): 1 edk2 -> TF-A -> MM, communicate MM use non-secure buffer which specify by EFI_SECURE_PARTITION_BOOT_INFO.SpNsCommBufBase; 2 RAS scene: fiq -> TF-A -> MM, use secure buffer which specify by EFI_SECURE_PARTITION_BOOT_INFO.SpShareBufBase; F

[edk2-devel] [PATCH edk2 v1 0/3] Fix several issues in StanaloneMmPkg

2021-10-15 Thread Ming Huang
Fix issues in StandaloneMmPkg for supporting communicate from TF-A with secure buffer. Ming Huang (3): StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR StandaloneMmPkg: Fix check buffer address failed issue from TF-A .../Driver

[edk2-devel] [PATCH edk2 v1 2/3] StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR

2021-10-15 Thread Ming Huang
DEBUG_ERROR should be used in error branch. Signed-off-by: Ming Huang --- StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 6 +++--- StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/StandaloneM

[edk2-devel] [edk2-platforms][PATCH V3 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

[edk2-devel] [edk2-platforms][PATCH V3 9/9] Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Peng

[edk2-devel] [edk2-platforms][PATCH V3 8/9] Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Peng

[edk2-devel] [edk2-platforms][PATCH V3 5/9] Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Tho

[edk2-devel] [edk2-platforms][PATCH V3 7/9] Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

[edk2-devel] [edk2-platforms][PATCH V3 4/9] Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

[edk2-devel] [edk2-platforms][PATCH V3 6/9] Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

[edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

2021-10-15 Thread Abner Chang
In V3: Fix the commit message in each patch. ArmVirtPkg->ArmPkg In V2: Fix the invalid email address. This patch set fixes the build error caused by referring to PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from MdePkg because of the PCD relocation (BZ:#3665). https://b

[edk2-devel] [edk2-platforms][PATCH V3 3/9] Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

[edk2-devel] [edk2-platforms][PATCH V3 2/9] Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc: Lei

Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
sigh... typo. Should be ArmPkg, will send V3. Abner From: devel@edk2.groups.io on behalf of Ard Biesheuvel Sent: Friday, October 15, 2021 3:59 PM To: Chang, Abner (HPS SW/FW Technologist) Cc: edk2-devel-groups-io ; Ard Biesheuvel ; Leif Lindholm ; Schaefer,

[edk2-devel] [edk2-platforms][PATCH V2 8/9] Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc:

[edk2-devel] [edk2-platforms][PATCH V2 9/9] Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Leif Lindholm Cc:

[edk2-devel] [edk2-platforms][PATCH V2 7/9] Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 4/9] Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 6/9] Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 5/9] Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 3/9] Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH V2 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

2021-10-15 Thread Abner Chang
In V2: Fix the invalid email address. This patch set fixes the build error caused by referring to PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from MdePkg because of the PCD relocation (BZ:#3665). https://bugzilla.tianocore.org/show_bug.cgi?id=3665 BZ:#3665 is to migrate some

[edk2-devel] [edk2-platforms][PATCH V2 2/9] Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Ard Biesheuvel
On Fri, 15 Oct 2021 at 09:58, Abner Chang wrote: > > Compliant with BZ: #3665 > https://bugzilla.tianocore.org/show_bug.cgi?id=3665 > > PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged > by both ARM and RISC-V arch. This patch uses the one from MdePkg > instead the one under A

[edk2-devel] [edk2-platforms][PATCH 4/9] Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 5/9] Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 6/9] Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 2/9] Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

2021-10-15 Thread Abner Chang
Compliant with BZ: #3665 https://bugzilla.tianocore.org/show_bug.cgi?id=3665 PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged by both ARM and RISC-V arch. This patch uses the one from MdePkg instead the one under ArmVirtPkg. Signed-off-by: Abner Chang Cc: Ard Biesheuvel Cc:

[edk2-devel] [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

2021-10-15 Thread Abner Chang
This patch set fixes the build error caused by referring to PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from MdePkg because of the PCD relocation (BZ:#3665). https://bugzilla.tianocore.org/show_bug.cgi?id=3665 BZ:#3665 is to migrate some modules from ArmVirtPkg to under OvmfP

Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg

2021-10-15 Thread Abner Chang
Hi Pierre, Seems like I missed the platform corresponding changes with these two PCDs. I am fixing it now. thanks Abner From: Pierre Gondois Sent: Friday, October 15, 2021 1:21 AM To: devel@edk2.groups.io ; Chang, Abner (HPS SW/FW Technologist) Cc: Ard Biesheuv