[edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-17 Thread Xu, Wei6
From: yangjie REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3655 The code in FmpDevicePkg called the deprecated interface VariableLockRequestToLock. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang Jie

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add support for config editor to handle multiple UPD

2021-10-17 Thread Tung Lun
Sure Chasel, thanks for the feedback. Will work on it. -Original Message- From: Chiu, Chasel Sent: Monday, October 18, 2021 1:10 PM To: Loo, Tung Lun ; devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: RE: [PATCH] IntelFsp2Pkg: Add support for config

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add support for config editor to handle multiple UPD

2021-10-17 Thread Chiu, Chasel
Hi Tung Lun, Should we update ConfigEditorUserManual.md for this new function? Thanks, Chasel > -Original Message- > From: Loo, Tung Lun > Sent: Friday, October 15, 2021 8:39 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star ;

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-17 Thread Yao, Jiewen
Series: Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Friday, October 15, 2021 2:17 AM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; Tom Lendacky > ; Justen, Jordan L ; > Ard

[edk2-devel] [PATCH v6 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 115 +

[edk2-devel] [PATCH v6 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 3 ++-

[edk2-devel] [PATCH v6 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 92 +-- 1

[edk2-devel] [PATCH v6 0/3] Add function QuickSort into MdePkg/BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo 1. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 1-1: Drop cast (V2) 2. CryptLib/CryptLib: Remove duplicate QuickSortWorker 2-1: Drop cast (V3) 2-2: Add cast (BASE_SORT_COMPARE) to prevent incompatible types (V6) 'function': incompatible types - from 'int

Re: [edk2-devel] [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
Thanks for the comment. It will be taken care by V5 patch. Thanks, Ian Kuo -Original Message- From: Ni, Ray Sent: Monday, October 18, 2021 11:42 AM To: Kuo, IanX ; devel@edk2.groups.io Cc: Chan, Amy ; Dong, Eric ; Kumar, Rahul1 Subject: RE: [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib:

[edk2-devel] [PATCH v5 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 3 ++-

[edk2-devel] [PATCH v5 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 92 +-- 1

[edk2-devel] [PATCH v5 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 115 +

[edk2-devel] [PATCH v5 0/3] Add function QuickSort into MdePkg/BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo 1. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 1-1: Drop cast (V2) 2. CryptLib/CryptLib: Remove duplicate QuickSortWorker 2-1: Drop cast (V3) 3. CpuCacheInfoLib: Remove MdeModulePkg dependency 3-1: Drop cast (V2) 3-2: Add runtime check (V2) 3-3: Drop assert

[edk2-devel] [PATCH v4 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 3 ++-

[edk2-devel] [PATCH v4 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 92 +-- 1

[edk2-devel] [PATCH v4 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 115 +

[edk2-devel] [PATCH v4 0/3] Add function QuickSort into MdePkg/BaseLib

2021-10-17 Thread IanX Kuo
From: IanX Kuo 1. MdeModulePkg/SortLib: Use QuickSort instead of QuickSortWorker 1-1: Drop cast (V2) 2. CryptLib/CryptLib: Remove duplicate QuickSortWorker 2-1: Drop cast (V3) 3. CpuCacheInfoLib: Remove MdeModulePkg dependency 3-1: Drop cast (V2) 3-2: Add runtime check (V2) 3-3: Drop assert

Re: [edk2-devel] [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread Ni, Ray
Ian, Thanks for cleaning up the code to remove MdeModulePkg dependency. Minor comments below: UINTN NextIndex; + VOID *QuickSortBuffer; 1. Can you use local variable? "CPU_CACHE_INFOSortBuffer". -PerformQuickSort (LocalCacheInfo,

回复: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-17 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 IanX Kuo > 发送时间: 2021年10月17日 6:34 > 收件人: devel@edk2.groups.io > 抄送: amy.c...@intel.com; ray...@intel.com; IanX Kuo > ; Jian J Wang ; Liming Gao > > 主题: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/SortLib: Add QuickSort >

Re: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
@Liming Gao or @Wang, Jian J Sorry to bother you. May I get one of your help to review the code change from maintainer side ? Thanks, Ian Kuo -Original Message- From: Kuo, IanX Sent: Sunday, October 17, 2021 6:34 AM To: devel@edk2.groups.io Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX ; Wang,

Re: [edk2-devel] [PATCH v3 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-17 Thread IanX Kuo
@Dong, Eric, @Ni, Ray or @Kumar, Rahul1 Sorry to bother you. May I get one of your approval for this patch ? Thanks, Ian Kuo -Original Message- From: Kuo, IanX Sent: Sunday, October 17, 2021 6:34 AM To: devel@edk2.groups.io Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX ; Dong, Eric ; Kumar,

Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Support CLANGPDB builds

2021-10-17 Thread Steven Shi
Acked-by: Shi Steven Hello Ard, Could you review and check-in this patch? It blocks our clang build. Thanks Steven Shi > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > Häuser > Sent: Friday, October 15, 2021 3:06 AM > To: devel@edk2.groups.io > Cc: Ard

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD

2021-10-17 Thread Dov Murik
On 17/10/2021 1:32, Brijesh Singh wrote: > > On 10/16/21 1:38 PM, Dov Murik wrote: >> [+Tobin] >> >> >> On 14/10/2021 21:17, Brijesh Singh wrote: >>> The commit 80e67af9afca added support for the generic work area concept >>> used mainly by the encrypted VMs but missed update the AmdSev

[edk2-devel] FL1100 usb chipset/Mac OS OVMF/XhciDxe issues with bootable usb 3.0 devices

2021-10-17 Thread Daniele Crudo
Hi, I'm using OVMF/qemu/kvm/libvirt to boot a mac os system. In my setup I'm passing through a fresco logic usb controller with FL1100 chipset. I noticed that: 1. If I plug a usb 3.0 device in a usb 3.0 port of the FL1100 controller with a mac os installer, the bootloader is unable to see the