Re: [edk2-devel] [PATCH V3 22/29] MdeModulePkg: Set shared bit in Mmio region for Tdx guest

> +++ b/MdeModulePkg/Core/DxeIplPeim/X64/DxeIplTdVmcall.nasm > @@ -0,0 +1,146 @@ > +;-- > +;* > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved. > +;* SPDX-License-Identifier: BSD-2-Clause-Patent > +;*

Re: [edk2-devel] [PATCH V3 21/29] MdeModulePkg: EFER should not be changed in TDX

On Mon, Nov 01, 2021 at 09:16:10PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > In TDX IA32_ERER is RO to host VMM. It could not be changed. > PcdIa32EferChangeAllowed is added in MdeModulePkg.dec and it is > to be set to FALSE in Tdx guest. > > Cc: Jian J W

Re: [edk2-devel] [PATCH V3 20/29] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

> +/** > + Check if it is Tdx guest > + > + @retvalTRUE It is Tdx guest > + @retvalFALSE It is not Tdx guest > +**/ > +BOOLEAN > +QemuFwCfgIsTdxGuest ( QemuFwCfgIsCC() > + return (CcWorkAreaHeader != NULL && CcWorkAreaHeader->GuestType == > GUEST_TYPE_INTEL_TDX); GuestType != GUE

[edk2-devel] [PATCH v6] IntelSiliconPkg/IntelVTdDxe: Support Multi PCI Root Bus

Some system may has multi PCI root bridges. It needs to use PciRootBridgeIo protocol to get the root bridge count. Scan each root bridge to get all PCI devices. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3695 Signed-off-by: Robert Kowalewski Signed-off-by: Sheng Wei Cc: Jenny Huang

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

Hi, > - AcceptPages: >To mitigate the performance impact of accepting pages in SEC phase on >BSP, BSP will parse memory resources and assign each AP the task of >accepting a subset of pages. This command may be called several times >until all memory resources are processed. In a

Re: [edk2-devel] [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix readme files in edk2-libc

Hi Mike, Has this change been merged to master? Regards, JP -Original Message- From: Kinney, Michael D Sent: 02 November 2021 00:30 To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, Michael D Cc: Rebecca Cran Subject: RE: [edk2-libc Patch V4 6/6] AppPkg/Applications/Python: to fix

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

> +++ b/UefiCpuPkg/Library/MpInitLib/X64/IntelTdcall.nasm > @@ -0,0 +1,120 @@ > +;-- > +;* > +;* Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved. > +;* SPDX-License-Identifier: BSD-2-Clause-Patent > +;* >

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

Hi, > > > Does SEV need and/or use SMM mode? Looking through AmdSevX64.dsc > > > doesn't give a clear answer, on one hand there is a > > > LibraryClasses.common.SMM_CORE section, but on the other hand it uses > > > the non-SMM variable driver stack. > > > > I think SEV doesn't work with SMM.

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

On Wed, Nov 03, 2021 at 09:46:01AM +0800, Lange Tang wrote: > Hi Gerd: > Thanks for your reply. In fact, I have no choice, only QXL in my work. > 1. I wonder why the device display be normal when it hung on > bus=pci.8,addr=0x0, but it is abnormal when bus=pci.9,addr=0x1 or > bus=pci.7,addr=0x0.

[edk2-devel] [PATCH] EmulatorPkg: Re-enable IA32 GCC5 CI builds

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3156 This commit re-enables the EmulatorPkg IA32 GCC5 CI builds with fixing library dependencies. The IA32 GCC5 CI builds are broken as the CI runner environment has changed. According to commit `612edbe6cd71f4392b681b75849b2ab6e48f592d`, which t

Re: [edk2-devel] [Patch 4/6] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping

Reviewed-by: Daniel Schaefer On 11/3/21 11:05, Michael D Kinney wrote: > Fix build breaks for all architectures by adding RngLib mapping. > > Cc: Jian J Wang > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: Michael D Kinney > --- > SignedCapsulePkg/SignedCapsul

Re: [edk2-devel] [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64

Reviewed-by: Daniel Schaefer On 11/3/21 13:28, Yao, Jiewen wrote: > Acked-by: Jiewen Yao > > Need ARM/RISC-V owner to confirm. > >> -Original Message- >> From: Kinney, Michael D >> Sent: Wednesday, November 3, 2021 11:06 AM >> To: devel@edk2.groups.io >> Cc: Yao, Jiewen ; Wang, Jian J

Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Perfect, thanks. I think BaseRngLib has an implementation for ARM or perhaps only AARCH64. I'm working one for RISCV64: https://bugzilla.tianocore.org/show_bug.cgi?id=3676 But until then this is good. Reviewed-by: Daniel Schaefer On 11/3/21 11:05, Michael D Kinney wrote: > Fix NetworkPkg build

Re: [edk2-devel] [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64

Acked-by: Jiewen Yao Need ARM/RISC-V owner to confirm. > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, November 3, 2021 11:06 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Ard Biesheuvel ; Chang, Abner > ; Schaefer, Daniel > Subject: [Patch 3/6] S

[edk2-devel] [Patch 4/6] SignedCapsulePkg/SignedCapsulePkg.dsc: Add RngLib mapping

Fix build breaks for all architectures by adding RngLib mapping. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney --- SignedCapsulePkg/SignedCapsulePkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/SignedCapsulePkg/Signed

[edk2-devel] [Patch 6/6] MdeModulePkg/Variable/RuntimeDxeUnitTest: Fix 32-bit GCC builds

When using will_return() on a pointer value, it must be cast to UINTN to be compatible with 32-bit GCC builds. This uses the same approach in samples provided in the UnitTestFramworkPkg when passing pointer values to UT_ASSERT_EQUAL(). Cc: Hao A Wu Cc: Liming Gao Cc: Bret Barkelew Signed-off-by

[edk2-devel] [Patch 5/6] UefiCpuPkg/MtrrLib/UnitTest: Fix 32-bit GCC build issues

When using UT_ASSERT_EQUAL() on a pointer value, it must be cast to UINTN. This follows the samples provided with the UnitTestFrameworkPkg. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Michael D Kinney --- UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 10 +- 1 fi

[edk2-devel] [Patch 3/6] SecurityPkg/SecurityPkg.dsc: Add missing RngLib for ARM and RISCV64

Fix SecurityPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Jiewen Yao Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney --- SecurityPkg/SecurityPkg.dsc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) dif

[edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib mapping. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Michael D Kinney --- NetworkPkg/NetworkPkg.dsc | 6 ++ 1 file changed, 6 insertions(+) diff --g

[edk2-devel] [Patch 0/6] Fix package build issues

This patch series fixes a number of diffent package build issues. These were discovered when evaluating the source format changes from uncrustify and there where valid package builds that are not working before applying the uncrustify changes. * Missing RngLib mappings * Missing ArmSoftFloatLib

[edk2-devel] [Patch 1/6] DynamicTablesPkg: Add missing BaseStackCheckLib instance

Fix ARM and AARCH64 build issues by adding the BaseStackCheckLib instance. Cc: Sami Mujawar Cc: Alexei Fedorov Cc: Ard Biesheuvel Signed-off-by: Michael D Kinney --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Dyna

Re: [edk2-devel] [PATCH V4 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

On November 2, 2021 2:25 PM, Jiewen Yao wrote: > May I know which platform you have run the test? > > I think we need cover both TD and TPM in real platform. > I have run the test in Intel's internal hardware platform (covering both TD and TPM). The test all pass. Thanks Min -=-=-=-=-=-=-=-=

Re: [edk2-devel] [PATCH V4 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

On November 2, 2021 2:25 PM, Jiewen Yao wrote: > May I know which platform you have run the test? > > I think we need cover both TD and TPM in real platform. > I have run the test in Intel's internal hardware platform (covering both TD and TPM). The test all pass. Thanks Min -=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Add MpServicesTest application to exercise MP Services

Sami, I don't see your review. Did you review this, or just the separate patch to add EFI_MP_SERVICES_PROTOCOL for AArch64? -- Rebecca Cran On 10/16/21 12:54 AM, Sami Mujawar wrote: Hi Rebecca, I will review this next week. Regard Sami Mujawar -

[edk2-devel] 回复: [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Bob Morgan > 发送时间: 2021年11月3日 4:40 > 收件人: devel@edk2.groups.io > 抄送: Bob Morgan ; Jian J Wang > ; Liming Gao ; Guomin > Jiang > 主题: [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file > name capsule > > Enhance RelocateCapsuleToRam() t

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

Hi Gerd: Thanks for your reply. In fact, I have no choice, only QXL in my work. 1. I wonder why the device display be normal when it hung on bus=pci.8,addr=0x0, but it is abnormal when bus=pci.9,addr=0x1 or bus=pci.7,addr=0x0. 2. Why cache properties are going to cause QXL display abnormal on ARM

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/02/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

回复：回复: [edk2-devel] About how to submit a new architecture called LoongArch

Liming:    Yes, I will keep going to do this work, we will conduct an internal review before submitting, and then merge it into my personal or our group repo in GitHub, if I am finish, I will let you know.Thanks,Chao Li-- Chao: Can y

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hello Vineel May I know if you have send out v2? > -Original Message- > From: Vineel Kovvuri > Sent: Tuesday, October 19, 2021 4:06 AM > To: Yao, Jiewen ; Vineel Kovvuri > ; devel@edk2.groups.io; Sean Brogan > ; Bret Barkelew > ; Mike Turner > > Cc: Jancarlo Perez > Subject: RE: [PATCH

Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances

The series has been pushed as 04bfa22~..bae4725 Thank you for all the excellent work on this Michael! -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ; Don

Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

> On Nov 2, 2021, at 12:45 PM, Bret Barkelew via groups.io > wrote: > > Good call. Maintainers, your opinion? > > - Bret > > From: Leif Lindholm via groups.io > Sent: Tuesday, November 2, 2021 2:55 AM > To: brbar...@microsoft.com

Re: [edk2-devel] [PATCH v6 52/52] WhiskeylakeOpenBoardPkg: Update for SPI2 PPI

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v6 52/52] WhiskeylakeOpenBoardPkg: Update for SPI2 PPI From: Michael Kubacki REF:https:

Re: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Luo, Heng Subject: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPk

Re: [edk2-devel] [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol From: Michael Ku

Re: [edk2-devel] [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

Re: [edk2-devel] [PATCH v6 47/52] KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortlibSpiFlash to build

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Benjamin Doron Subject: [PATCH v6 47/52] KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortl

Re: [edk2-devel] [PATCH v6 46/52] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Benjamin Doron Subject: [PATCH v6 46/52] KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update

Re: [edk2-devel] [PATCH v6 45/52] KabylakeSiliconPkg: Update for SPI2 PPI and Protocol

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 45/52] KabylakeSilico

Re: [edk2-devel] [PATCH v6 44/52] KabylakeSiliconPkg: Identify flash regions by GUID

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 44/52] KabylakeSilico

Re: [edk2-devel] [PATCH v6 43/52] CometlakeOpenBoardPkg: Remove unnecessary gPchSpiPpiGuid reference

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan Su

Re: [edk2-devel] [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and P

Re: [edk2-devel] [PATCH v6 41/52] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 41/52] CoffeelakeSil

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

Reviewed-by: Nate DeSimone I will correct the commit message during the upstreaming process. Thanks, Nate -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel

Re: [edk2-devel] [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceS

Re: [edk2-devel] [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm From: Michae

[edk2-devel] [PATCH v1] Maintainers.txt: Change SimicsOpenBoardPkg Maintainer

To help keep edk2-platforms healthy, I would like to offer to maintain SimicsOpenBoardPkg, SimicsX58SktPkg, and SimicsIch10Pkg. The current maintainer for those packages has changed jobs and is no longer active in the community. Cc: Agyeman Prince Cc: Leif Lindholm Cc: Michael D Kinney Signed-o

Re: [edk2-devel] [edk2-[PATCH v1 0/2] APIC table updates

The series has been pushed as 34df404~..30865b8 -Original Message- From: Abdul Lateef Attar Sent: Friday, October 22, 2021 7:48 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-[PATCH v1 0/2] APIC table updates Fixes the AP

[edk2-devel] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Enhance RelocateCapsuleToRam() to skip creation of the Capsule on Disk file name capsule if PcdSupportUpdateCapsuleReset feature is not enabled. This avoids an EFI_UNSUPPORTED return status from UpdateCapsule() when the file name capsule is encountered and PcdSupportUpdateCapsuleReset is FALSE. Cc

Re: [edk2-devel] 回复: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Thanks Liming. I will send a v2 patch with that change. -bob -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Monday, November 1, 2021 7:12 PM To: devel@edk2.groups.io; Bob Morgan Cc: 'Jian J Wang' ; 'Guomin Jiang' Subject: 回复: [edk2-devel] 回复

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Thanks a lot Maciej. Much appreciated. From: Rabeda, Maciej Sent: Tuesday, November 2, 2021 12:54 PM To: devel@edk2.groups.io; vinee...@microsoft.com; Wu, Jiaxin; vineel.kovv...@gmail.com; Rabeda, Maciej; Yao, Jiewen; Jancarlo Perez; Mike Turner; Sean Brogan; Br

[edk2-devel] [PATCH v2 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 4741a9

[edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ArmPlatformPkg/ArmPlatf

[edk2-devel] [PATCH v2 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

From: Bret Barkelew Drop X64 references. Update GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/Library/StandaloneMmCoreEntr

[edk2-devel] [PATCH v2 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

From: Sean Brogan The previously Arm-specific "ArmMmuLib" has been generalized as "MmuLib". The Arm implementation of this lib can still use the existing library logic to back it. As such, this implementation is currently just a shim to the old library, while enabling higher-level code to be mor

[edk2-devel] [PATCH v2 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v2 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew --- StandaloneMmPkg/Library/StandaloneMmPeCoffExtraActionLib/AArch64/StandaloneMmPeCoffExtra

[edk2-devel] [PATCH v2 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Si

[edk2-devel] [PATCH v2 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc:

[edk2-devel] [PATCH v2 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {ArmPkg/Include => MdePkg/Include/AArch64}/AsmMacroIoLibV8.h | 0 {ArmPkg/Include => MdePkg/Include/Arm}/AsmMacroIoLib.h | 0

[edk2-devel] [PATCH v2 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew TODO: Might keep the name of the .inf. Pending discussion. This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=364

[edk2-devel] [PATCH v2 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec

[edk2-devel] [PATCH v2 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class (without any change to the interface itself), so this module can now change its dependency. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jie

[edk2-devel] [PATCH v2 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-b

[edk2-devel] [PATCH v2 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Review

[edk2-devel] [PATCH v2 00/16] Un-siloing Arm common code

This series of patch commits moves a number of modules and libraries around in order to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some duplicate code was abstracted, and generally things were cleaned up so that common code (e.g. MdePkg, MdeModulePkg, Standalone

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Hi Vineel, I will integrate the change to edk2 tomorrow. For now: Reviewed-by: Maciej Rabeda Thanks, Maciej On 02-Nov-21 19:57, Vineel Kovvuri via groups.io wrote: Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the

Re: [edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

If the implementation didn't make so many calls into Arm-specific libs for SMC servicing, it could stay right where it is. It's just that untangling that Gordian knot is outside my ken. On Tue, Nov 2, 2021 at 3:00 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:44 -0700, brbar...@microso

Re: [edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

Will address. On Tue, Nov 2, 2021 at 2:57 AM Leif Lindholm wrote: > > On Mon, Nov 01, 2021 at 12:56:43 -0700, brbar...@microsoft.com wrote: > > From: Sean Brogan > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 > > Some description please. > > > Cc: Leif Lindholm > > Cc: Ard Bi

Re: [edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

Will address. Thanks! On Tue, Nov 2, 2021 at 2:25 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:39 -0700, brbar...@microsoft.com wrote: > > From: Bret Barkelew > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

Good call. Maintainers, your opinion? - Bret From: Leif Lindholm via groups.io Sent: Tuesday, November 2, 2021 2:55 AM To: brbar...@microsoft.com Cc: devel@edk2.groups.io; Ard Biesheuvel

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

I’d be amenable to that. @Sean? - Bret From: Leif Lindholm via groups.io Sent: Tuesday, November 2, 2021 2:51 AM To: brbar...@microsoft.com Cc: devel@edk2.groups.io; Ard Bi

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the same in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning Thanks, Vineel -Original Message- From: Wu, Jiaxin Sent: Monday, Novembe

Re: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

Thanks for incorporating the feedback. Few more minor comments based on the new patch: 1. The description of "DieIndex" perhaps should be modified to " Index of the die in the package" to make it more apt. 2. The description of "DieId" perhaps should be modified to " Unique ID specific to the d

[edk2-devel] [PATCH v2 2/4] OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecuityPkg

Copy the TPM 1.2 physical presence interface support from SecurityPkg DxeTcgPhysicalPresenceLib.c along with its .inf and .uni files into OvmfPkg. Fix EFI_F_INFO and EFI_D_ERROR to meet code standards. Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 1455 +++

[edk2-devel] [PATCH v2 0/4] Add support for TPM 1.2 Physical Presence Interface and Menu

This series adds support for the full TPM 1.2 Physical Presence Interface (PPI) and activates the TPM 1.2 menu at the end. PPI is a prerequisite for the menu to work. The modifications to the original code are mostly due to the fact that we are using a memory region for PPI in QEMU. I tried to kee

[edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

Enable the physical presence interface for TPM 1.2. It is required for the TPM 1.2 menu to work. The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using in QEMU for presenting the supported PPI commands and results to the OS via ACPI as well as to store the PPI opcode to exec

[edk2-devel] [PATCH v2 1/4] SecurityPkg: Store physical presence code by submitting to PreOS func

Modify SavePpRequest to look like its TPM 2 equivalent SaveTcg2PpRequest and have it submit the physical presence opcode to the PreOS function so that we can choose our own method for how to store it. Move the existing code into DxeTcgPhysicalPresenceLib.c and adapt the return codes. Cc: Jiewen Y

[edk2-devel] [PATCH v2 4/4] OvmfPkg: add TPM 1.2 config menu

From: Gerd Hoffmann When building OVMF with TPM 1.2 support enabled do also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + 2 files changed, 2 insertions(+) di

Re: [edk2-devel] About how to submit a new architecture called LoongArch

Chao, This is probably a little out of date, but in case it helps http://vzimmer.blogspot.com/2014/11/porting-to-new-architecture.html?m=1 > On Nov 2, 2021, at 7:32 AM, gaoliming wrote: > > Chao: > Can you follow Mike's suggestion to share the your code change in your > personal GitHub repo

Re: [edk2-devel] [PATCH V3 13/29] MdePkg: Add macro to check SEV/TDX guest

On Mon, Nov 01, 2021 at 09:16:02PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add macros CC_GUEST_IS_TDX/CC_GUEST_IS_SEV to check SEV/TDX guest. > > Cc: Michael Roth > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Eric Dong > Cc: James Bottomley > Cc: Min Xu >

Re: [edk2-devel] [PATCH V3 12/29] UefiCpuPkg: Define ConfidentialComputingGuestAttr

Hi, > .../Include/ConfidentialComputingGuestAttr.h | 25 +++ > MdePkg/MdePkg.dec | 4 +++ Subject doesn't match patch (UefiCpuPkg vs MdePkg). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH V3 11/29] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

On Mon, Nov 01, 2021 at 09:16:00PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed > directly from/to CPU. Some should be accessed via explicit requests > from the host VMM using TDCALL(TDG.VP.

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

On Mon, Nov 01, 2021 at 09:15:59PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > TdxLib is included in BaseXApicX2ApicLib. To prevent any build > breakage, update the UefiPayloadPkg.dsc to include the TdxLib > library. > > Cc: Guo Dong > Cc: Ray Ni > Cc: Ma

回复: [edk2-devel] About how to submit a new architecture called LoongArch

Chao: Can you follow Mike's suggestion to share the your code change in your personal GitHub repo as the first step? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年10月29日 13:19 > 收件人: devel@edk2.groups.io; kilater...@163.com; Kinney, Michael D >

Re: [edk2-devel] [PATCH V3 05/29] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

On Mon, Nov 01, 2021 at 09:15:54PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add base support to handle #VE exceptions. Update the common exception > handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib > library when a #VE is encountered.

Re: [edk2-devel] [PATCH V3 04/29] OvmfPkg: Extend VmgExitLib to handle #VE exception

Hi, > +MmioExit ( > + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs, > + IN TDCALL_VEINFO_RETURN_DATA *Veinfo > + ) > +{ > + do { > +OpCode = *Rip++; > +if (OpCode == 0x66) { > + OpSize = 2; Oh, wow. So the VE exit data doesn't provide the information which io/mmio access actu

Re: [edk2-devel] [PATCH V3 03/29] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception

On Mon, Nov 01, 2021 at 09:15:52PM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > VmgExitLib performs the necessary processing to handle a #VC exception. > VmgExitLibNull is a NULL instance of VmgExitLib which provides a > default limited interface. In this com

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On 11/2/21 8:53 AM, Dov Murik wrote: On 02/11/2021 15:29, Gerd Hoffmann wrote: Hi, I'm wondering whenever you actually tried to boot a sev guest in microvm? No I haven't tried. Do you want Microvm to be able to boot SEV guests, or do you intentionally want to keep functionality out so

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

Hi, > +UINT64 mTdSharedPageMask = 0; > +UINT32 mTdMaxVCpuNum = 0; > +UINT32 mTdVCpuNum= 0; > +UINT64 > +EFIAPI > +TdSharedPageMask ( > + VOID > + ) > +{ > + UINT64 Status; > + UINT8 Gpaw; > + TD_RETURN_DATA TdReturnData

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On 02/11/2021 15:29, Gerd Hoffmann wrote: > Hi, > >>> I'm wondering whenever you actually tried to boot a sev guest >>> in microvm? >> >> No I haven't tried. Do you want Microvm to be able to boot SEV guests, >> or do you intentionally want to keep functionality out so it stays small? > > N

Re: [edk2-devel][PATCH v3] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

It looks like you have a typo in "LockVaraible". It might be a good idea to fix that. Best regards, Pedro On Tue, 2 Nov 2021, 06:38 Yang Jie, wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699 > The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated > interface Va

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

On Tue, Nov 02, 2021 at 08:55:39PM +0800, Lange Tang wrote: > Hi everyone: > > > In order to support QXL display during the UEFI phase of the arm64 virtual > machine, Not going to fly. Use virtio-gpu instead. Anything with a virtual pci memory bar is going to have cache attribute problems on

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

Hi, > > I'm wondering whenever you actually tried to boot a sev guest > > in microvm? > > No I haven't tried. Do you want Microvm to be able to boot SEV guests, > or do you intentionally want to keep functionality out so it stays small? Need to look at it on a case by case base. It is clearl

[edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

Hi everyone: In order to support QXL display during the UEFI phase of the arm64 virtual machine, the modified code is as follows (based on master branch, commit id:17143c4837393d42c484b42d1789b85b2cff1aaf): diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 7ef5e7297b.

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

Hi Gerd, (I assume your comments are for patch 2/2) On 02/11/2021 12:03, Gerd Hoffmann wrote: > On Tue, Nov 02, 2021 at 07:34:21AM +, Dov Murik wrote: >> The SEV launch secret area and the QEMU hashes table area were specified >> in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPk

Re: [edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

Hi, > You can see no reallocation is triggered; the unsupported PCR banks are left > active and no extend operations occur on them, thus leaving them uncapped. I have seen this effect too the compiling OVMF with SHA1 support disabled, the firmware left the SHA1 bank active then ... take care,

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

Usually, we put those information in the header of module INF file. > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, November 2, 2021 6:21 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Xu, Min M ; Ard Biesheuvel > ; Justen, Jordan L ; > Brijesh Singh ; Erdem Aktas > ; Jame

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

On Tue, Nov 02, 2021 at 10:05:56AM +, Yao, Jiewen wrote: > We can state, this driver is to support fixed frequency. > If a real platform happens to have fixed frequency, then it can be used. > > gEfiMdePkgTokenSpaceGuid.PcdFSBClock is defined in MdePkg. > The consumer need set PcdFSBClock. >

  1   2   >