[edk2-devel] 回复: [Patch V2 0/3] Remove git reset and optimize

2021-11-23 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年11月24日 0:31 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Liming Gao ; > Michael Kubacki > 主题: [Patch V2 0/3] Remove git reset and optimize > > REF:

[edk2-devel] 回复: [Patch V2 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git diff output

2021-11-23 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年11月24日 1:32 > 收件人: devel@edk2.groups.io > 抄送: Sean Brogan ; Bret Barkelew > ; Liming Gao ; > Michael Kubacki > 主题: [Patch V2 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git > diff output > > REF:

回复: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS

2021-11-23 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年11月24日 1:26 > 收件人: devel@edk2.groups.io > 抄送: Andrew Fish ; Ray Ni ; Michael > Kubacki > 主题: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS > > REF:

回复: edk2-stable202111 Re: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Skip the potential NULL pointer access

2021-11-23 Thread gaoliming
Leif: Thanks for your suggestion. I am OK to merge this patch into stable tag20211. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leif Lindholm > 发送时间: 2021年11月23日 21:19 > 收件人: Rebecca Cran ; gaolim...@byosoft.com.cn > 抄送: devel@edk2.groups.io; Hao A Wu ; Ray Ni > ; Andrew Fish

Re: [edk2-devel] [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Gao, Zhichao
Acked-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, November 24, 2021 5:21 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sean > Brogan ; Bret Barkelew > ; Liming Gao ; > Michael Kubacki > Subject: [Patch 09/12]

[edk2-devel] Uncrustify Conversion Detailed Plan and Extended Hard Freeze

2021-11-23 Thread Michael D Kinney
Hello, Michael Kubacki and I have prepared the patches required to apply the uncrustify changes and enable EDK II CI to check all submitted patches have been run through uncrustify. There are a couple minor updates expected over the next day. New versions of this email will be sent with the

Re: [edk2-devel] [PATCH v3 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
I just realized that I changed the plugin name in the patch but did not update the commit subject. Since I'm already planning to send a v4, I will update it to ".pytool/Plugin/UncrustifyCheck: Add Uncrustify CI plugin" at that time. Thanks, Michael On 11/23/2021 10:38 PM, Michael Kubacki

[edk2-devel] [PATCH v3 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance of source code to the EDK II C Coding Standards Specification. An external dependency is added in the plugin directory to retrieve

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Yao, Jiewen
My apology - fix typo: objection on the discussion => objective on the discussion. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Wednesday, November 24, 2021 11:16 AM > To: j...@linux.ibm.com; devel@edk2.groups.io > Cc: Gerd Hoffmann ; Xu, Min M ; >

[edk2-devel] [PATCH] uefi-sct/SctPkg:Enhance BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1()

2021-11-23 Thread Gao Jie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2386 Enhance BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1() to handle ReadKeyStrokeEx implementation which returns EFI_NOT_READY but without touching KeyToggleState. Signed-off-by: Barton Gao ---

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Yao, Jiewen
I think we are discussing under different context. First, the term "isolation" shall be clarified. In my context, "isolation" means two domain cannot impact each other. The isolation is enforced by a 3rd higher privileged component. Examples: Ring3 apps are isolated by OS. TDs are isolated by

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/23/2021 #cal-reminder

2021-11-23 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

2021-11-23 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 11/23/2021 7:44 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750 Large patches that modify a large number of files(e.g uncrustify) take longer to process through CI checks such as ECC. Increase the max job time from 1 hour

Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

2021-11-23 Thread Michael Kubacki
I wouldn't expect it to extend past 1 hour that often either. An occasional audit sounds good though. Do you think a BZ could be filed to track the ECC optimization work? I didn't see anything obvious with a quick search. Thanks, Michael On 11/23/2021 7:54 PM, Kinney, Michael D wrote: Hi

Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

2021-11-23 Thread Michael D Kinney
Hi Michael, I would like to see some optimization work applied to the ECC tool to see if we can reduce the time that tool requires. If we find some easy improvements that allow larger patch series to complete in 60 minutes, then I am in favor of reducing back down to 60 minutes. Unless we

Re: [edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

2021-11-23 Thread Michael Kubacki
Hi Mike, Is the plan to keep it at a 2 hour limit indefinitely (not just for these large series currently outstanding)? Thanks, Michael On 11/23/2021 7:44 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750 Large patches that modify a large number of

[edk2-devel] [Patch 1/1] .azurepipelines/templates: Update max pipeline job time to 2 hours

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3750 Large patches that modify a large number of files(e.g uncrustify) take longer to process through CI checks such as ECC. Increase the max job time from 1 hour to 2 hours to accommodate larger patch series. Cc: Sean Brogan Cc: Bret

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
Sounds good. I'll include that in v3. On 11/23/2021 6:53 PM, Kinney, Michael D wrote: Hi Michael, Thanks for the clarification. It would be good to make it clear that UncrustifyCheck is by default enabled for all packages and that the only way to disabled it is to add that section to the

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael D Kinney
Hi Michael, Thanks for the clarification. It would be good to make it clear that UncrustifyCheck is by default enabled for all packages and that the only way to disabled it is to add that section to the package YAML files and set AuditOnly to True. Probably best to add this clarification at the

Re: [edk2-devel] [Patch 00/12] Update Package YAML to ignore specific ECC files/errors

2021-11-23 Thread Ard Biesheuvel
On Tue, 23 Nov 2021 at 22:21, Michael D Kinney wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 > > Update package YAML files to ignore ECC errors that are > already present. These issues must be fixed in the future, > but should not block source code changes for these known >

Re: [edk2-devel] [Patch V2 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git diff output

2021-11-23 Thread Michael Kubacki
Acked-by: Michael Kubacki On 11/23/2021 12:31 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3746 Use --output option in git diff command to remove code diffs from build log on stdout when LicenseCheck plugin is run. Instead, create a temp directory for the

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
Hi Mike, I'm fine with changing the CI plugin name to "UncrustifyCheck". It does only check files. I will make this change in a V3. That section does not need to be present. It is just giving an example of how to add the section and how to set the various config options available. Thanks,

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
Hi Mike, The simplest way to stay up-to-date is to let the stuart_update command check that the local version matches the version specified in "uncrustify_ext_dep.yaml". The version "73.0" is based on the upstream tag of Uncrustify: https://github.com/uncrustify/uncrustify/tags Each release

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael D Kinney
Hi Michael, In order to match some of the other naming conventions of plugins, should this plugin be called "UncrustifyCheck". It only checks if the sources match the expected format. It does not actually change the format of any source files when either run locally or by EDK II CI. Right?

Re: [edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael D Kinney
Hi Michael, When I download and install uncrustify from the nuget feed referenced in this patch, I see the following when I check the version of the uncrustify tool: >uncrustify.exe --version Uncrustify-c82ee034 But the source link and version in the deps file says 73.0.3 > + "source": >

[edk2-devel] [Patch 10/12] StandaloneMmPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc:

[edk2-devel] [Patch 08/12] SecurityPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Qi Zhang Cc: Rahul Kumar Cc: Sean Brogan Cc: Bret

[edk2-devel] [Patch 11/12] UefiPayloadPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You

[edk2-devel] [Patch 12/12] UnitTestFrameworkPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Cc:

[edk2-devel] [Patch 09/12] ShellPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Ray Ni Cc: Zhichao Gao Cc: Sean Brogan Cc: Bret

[edk2-devel] [Patch 07/12] MdePkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Cc:

[edk2-devel] [Patch 06/12] MdeModulePkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Jian J Wang Cc: Liming Gao Cc: Sean Brogan Cc: Bret

[edk2-devel] [Patch 01/12] ArmPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan

[edk2-devel] [Patch 02/12] ArmPlatformPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan

[edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin

[edk2-devel] [Patch 03/12] ArmVirtPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [Patch 05/12] EmulatorPkg: Update YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Andrew Fish Cc: Ray Ni Cc: Sean Brogan Cc: Bret

[edk2-devel] [Patch 00/12] Update Package YAML to ignore specific ECC files/errors

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749 Update package YAML files to ignore ECC errors that are already present. These issues must be fixed in the future, but should not block source code changes for these known issues. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3748 Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance of source code to the EDK II C Coding Standards Specification. An external dependency is added in the plugin directory to retrieve

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
Response below. On 11/23/2021 3:19 PM, Kinney, Michael D wrote: Hi Michael, Comments below. Mike -Original Message- From: Michael Kubacki Sent: Tuesday, November 23, 2021 12:07 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Liming Gao ; Sean Brogan ; Bret Barkelew Subject:

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael D Kinney
Hi Michael, Comments below. Mike > -Original Message- > From: Michael Kubacki > Sent: Tuesday, November 23, 2021 12:07 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Liming Gao ; Sean Brogan > ; Bret Barkelew > > Subject: Re: [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
I'll file a BZ and add it. I don't see a difference comparing my template file contents against the corresponding files in the branch you linked. Am I missing something? I saw the temp file directory change recently added to those plugin patches. My concern is that .pytool/ is tracked by git

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael D Kinney
Hi Michael, Have you opened a BZ for this feature? Can you do that and add REF: to the commit message? Also, the template files for uncrustify need to be updated to match the contents from the EDK II C Coding Standard. Pease see the file and function header templates in this location:

Re: [edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS

2021-11-23 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 11/23/2021 12:25 PM, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747 * Remove deprecated option /Gm that generates a warning. * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT profile from tools_def.txt

[edk2-devel] [Patch V2 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git diff output

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3746 Use --output option in git diff command to remove code diffs from build log on stdout when LicenseCheck plugin is run. Instead, create a temp directory for the diff output file and remove the temp directory after the diff output is

[edk2-devel] [Patch V2 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git diff output

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3746 Use --output option in git diff command to remove code diffs from build log on stdout when LicenseCheck plugin is run. Instead, create a temp directory for the diff output file and remove the temp directory after the diff output is

[edk2-devel] [Patch 1/1] EmulatorPkg/Win/Host: Update CC_FLAGS

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3747 * Remove deprecated option /Gm that generates a warning. * Remove /Zi and use '=' instead of '== to let DEBUG/RELEASE/NOOPT profile from tools_def.txt enable debug information * Remove /Gs8192 option that is overriding the larger setting

[edk2-devel] [Patch 1/1] .pytools/Plugin/LicenseCheck: Use temp directory for git diff output

2021-11-23 Thread Michael D Kinney
Use --output option in git diff command to remove code diffs from build log on stdout when LicenseCheck plugin is run. Instead, create a temp directory for the diff output file and remove the temp directory after the diff output is processed. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao

[edk2-devel] [PATCH v3 14/15] DynamicTablesPkg: Add FdtHwInfoParser library

2021-11-23 Thread PierreGondois
From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. FdtHwInfoParser library is an

[edk2-devel] [PATCH v3 15/15] DynamicTablesPkg: Handle 16550_WITH_GAS id

2021-11-23 Thread PierreGondois
From: Pierre Gondois Handle the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS id when generating an AML description of a serial port. The same _HID/_CID as the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550 are generated. Signed-off-by: Pierre Gondois --- Notes: v2: - New patch.

[edk2-devel] [PATCH v3 12/15] DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher

2021-11-23 Thread PierreGondois
From: Pierre Gondois The GIC Dispatcher is the top-level component that is responsible for invoking the respective parsers for GICC, GICD, GIC MSI Frame, GIC ITS and the GICR. Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 212 ++

[edk2-devel] [PATCH v3 13/15] DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois On platforms that implement PCIe, the PCIe configuration space information must be described to a standards-based operating system in the Memory mapped configuration space base address Description (MCFG) table. The PCIe information is described in the platform Device Tree,

[edk2-devel] [PATCH v3 11/15] DynamicTablesPkg: FdtHwInfoParser: Add GICR parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois The GIC Redistributor (GICR) structure is part of the Multiple APIC Description Table (MADT) that enables the discovery of GIC Redistributor base addresses by providing the Physical Base Address of a page range containing the GIC Redistributors. More than one GICR Structure

[edk2-devel] [PATCH v3 10/15] DynamicTablesPkg: FdtHwInfoParser: Add ITS parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois Arm GIC v3/v4 optionally includes support for GIC Interrupt Translation Service (ITS). The GIC ITS Structure is part of the Multiple APIC Description Table (MADT) that describes the GIC Interrupt Translation service to the OS. The GIC Interrupt Translation Service

[edk2-devel] [PATCH v3 09/15] DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois Arm GIC version 2 systems that support Message Signalled Interrupts implement GICv2m MSI frame(s). Each GICv2m MSI frame consists of a 4k page which includes registers to generate message signalled interrupts to an associated GIC distributor. The frame also includes

[edk2-devel] [PATCH v3 08/15] DynamicTablesPkg: FdtHwInfoParser: Add GICD parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois On ARM-based systems the Generic Interrupt Controller (GIC) manages interrupts on the system. Each interrupt is identified in the GIC by an interrupt identifier (INTID). ACPI GSIVs map one to one to GIC INTIDs for peripheral interrupts, whether shared (SPI) or private (PPI).

[edk2-devel] [PATCH v3 06/15] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois The Microsoft Debug Port Table 2 (DBG2), the Serial Port Console Redirector (SPCR) table are mandatory tables required for booting a standards-based operating system. The DBG2 table is used by the OS debugger while the SPCR table is used to configure the serial terminal.

[edk2-devel] [PATCH v3 07/15] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois The GIC CPU Interface (GICC) structure is part of the Multiple APIC Description Table (MADT) that describes the interrupt model for the platform. The MADT table is a mandatory table required for booting a standards-based operating system. Arm requires the GIC interrupt

[edk2-devel] [PATCH v3 05/15] DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois The Generic Timer Description Table (GTDT) is a mandatory table required for booting a standards-based operating system. It provides an OSPM with information about a system's Generic Timer configuration. The Generic Timer (GT) is a standard timer interface implemented on ARM

[edk2-devel] [PATCH v3 04/15] DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser

2021-11-23 Thread PierreGondois
From: Pierre Gondois The Fixed ACPI Description Table (FADT) is a mandatory table required for booting a standards-based operating system. The FADT table has an 'ARM Boot Architecture Flags' field that is used by an OS at boot time to determine the code path during boot. This field is used to

[edk2-devel] [PATCH v3 03/15] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

2021-11-23 Thread PierreGondois
From: Pierre Gondois The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects. Therefore, add a set of helper functions to simplify parsing of the platform Device Tree. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v3 01/15] DynamicTablesPkg: Definition for HwInfoParser interface

2021-11-23 Thread PierreGondois
From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. The Configuration Manager can

[edk2-devel] [PATCH v3 02/15] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

2021-11-23 Thread PierreGondois
From: Pierre Gondois FdtHwInfoParserLib is an instance of the HwInfoParser. The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects that describe the platform hardware. These Configuration Manager objects are

[edk2-devel] [PATCH v3 00/15] Implement a FdtHwInfoParserLib

2021-11-23 Thread PierreGondois
From: Pierre Gondois v3: - Populate the 64 bits of the MPIDR field of the GicC CmObj. [Sami] - Fix typos. [Sami] v2: - Handle absence of Pci legacy interrupts in Pci parser. [Pierre] - Handle Affinity3 field in GicC parser. [Sami] - Add pl011 compatible string in serial port parser.

[edk2-devel] [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncrustify plugin

2021-11-23 Thread Michael Kubacki
From: Michael Kubacki Adds a new CI plugin for Uncrustify. This is used to check coding standard compliance of source code to the EDK II C Coding Standards Specification. An external dependency is added in the plugin directory to retrieve the Uncrustify executable. Currently, the executable is

[edk2-devel] [Patch V2 3/3] .pytool/Plugin/EccCheck: Add performance optimizations

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 Improve the performance of EccCheck by using a temp file instead of stdout to capture the results of the git diff commands. If a large patch set is passed into EccCheck, using stdout could be slow and also added the large diff content to

[edk2-devel] [Patch V2 2/3] .pytool/Plugin/EccCheck: Remove temp directory on exception

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 Add try/except to RunBuildPlugin() to remove temporary directory if a KeyboardInterrupt exception or an unexpected exception is detected. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Michael D

[edk2-devel] [Patch V2 0/3] Remove git reset and optimize

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 New in V2 -- * Change temp directory path from Build/ecctemp to Build/.pytool/Plugin/EccCheck to provide a unique temp directory location for any .pytool Plugin. * Set working directory when ECC runs to temp directory to

[edk2-devel] [Patch V2 1/3] .pytool/Plugin/EccCheck: Remove RevertCode()

2021-11-23 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 The RevertCode() method uses git reset which can remove local changes. Instead of modifying the local files, a copy of the package passed into the EccCheck tool is copied to a temp directory in Build/ecctemp. This same temp directory is

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread James Bottomley
On Tue, 2021-11-23 at 15:10 +, Yao, Jiewen wrote: > I would say the PEI owns the system and all memory (including the > DXE). > > A bug in PEI may override the loaded DXE memory or the whole system. That's not the correct way to analyse the security properties. From the security point of

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Yao, Jiewen
I would say the PEI owns the system and all memory (including the DXE). A bug in PEI may override the loaded DXE memory or the whole system. In history I did see PEI security issues. Some security issue in PEI caused system compromised completely. You even have no chance to run DXE. thank

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread James Bottomley
On Tue, 2021-11-23 at 14:36 +, Yao, Jiewen wrote: > > This strict isolation between DXE and PEI means that once we're in > > DXE, any bugs in PEI can't be exploited to attack the DXE > > environment. > > [jiewen] I would disagree the statement above. > There is not strict isolation.

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Yao, Jiewen
> This strict isolation between DXE and PEI means that once we're in DXE, > any bugs in PEI can't be exploited to attack the DXE environment. [jiewen] I would disagree the statement above. There is not strict isolation. Actually no isolation at all. The DXE is loaded by PEI. A bug in PEI has

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread James Bottomley
On Tue, 2021-11-23 at 13:07 +, Yao, Jiewen wrote: > Comment below only: > > > I am persuaded to let config-a adopt the OVMF way, because the > > threat model of config-A is same as the normal OVMF. > > But config-B is NOT. > > Different threat model drives different solution. > > I completely

edk2-stable202111 Re: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Skip the potential NULL pointer access

2021-11-23 Thread Leif Lindholm
Since BZ3732 has been triggered by a standard build of a platform in edk2-platforms, I would request that this fix is brought into the upcoming stable tag. SbsaQemu isn't a "real" platform, so I don't consider that in itself sufficient reason, but I feel the risk of it affecting other (including

Re: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Skip the potential NULL pointer access

2021-11-23 Thread Rebecca Cran
Acked-by: Rebecca Cran I've confirmed that this patch fixes the exception I was seeing when running the DEBUG build of SbsaQemu. -- Rebecca Cran On 11/15/21 7:53 PM, gaoliming wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3732 Recent change

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Yao, Jiewen
Comment below only: > I am persuaded to let config-a adopt the OVMF way, because the threat model > of config-A is same as the normal OVMF. > But config-B is NOT. > Different threat model drives different solution. > I completely don't understand why they must be same. I don't understand why

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

2021-11-23 Thread Gerd Hoffmann
Hi, > > That totally makes sense. I expect TDVF Config-B will look alot like > > the existing AmdSev configuration variant which is stripped down too. > > [Jiewen] I don't think TDVF config-B will be like the AMD SEV is right > statement. > TDVF and SEV are two different platforms. Yes, of

[edk2-devel] [PATCH v2 2/3] Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library

2021-11-23 Thread Khasim Mohammed
The BasePCISegment Library in MdePkg doesn't allow configuring multiple segments required for PCIe and CCIX root port enumeration. Therefore, a custom PCI Segment library is adapted from SynQuacerPciSegmentLib and ported for N1Sdp. Change-Id: I0a124b0ea2fb7a8ee652de2d66b977d848c509b4

[edk2-devel] [PATCH v2 3/3] Silicon/ARM/NeoverseN1Soc: Add CCIX root complex support

2021-11-23 Thread Khasim Mohammed
This patch enables CCIX root complex support by updating the root complex node info in PciHostBridge library and enabling PciSegment library for N1Sdp. Change-Id: I0510b1023aec16365b614d4eaf81858851d9fa28 Signed-off-by: Khasim Syed Mohammed --- .../ConfigurationManagerDxe.inf | 3

[edk2-devel] [PATCH v2 1/3] Silicon/ARM/NeoverseN1Soc: Update PciExpressLib to enable CCIX port

2021-11-23 Thread Khasim Mohammed
Update the PciExpressLib to enable CCIX port as PCIe root host by validating the PCIe addresses and introducing corresponding PCD entries. Change-Id: I0d1167b86e53a3781f59c4d68a3b2e61add4317e Signed-off-by: Deepak Pandey Signed-off-by: Khasim Syed Mohammed --- .../PciExpressLib.c

[edk2-devel] [PATCH v2 0/3] Enable CCIX port as PCIe root host on N1SDP

2021-11-23 Thread Khasim Mohammed
The patch series enables CCIX port as PCIe root on N1SDP. V2: - Removed few PCDs entries that were not used. - Migrated to latest version edk2-platform and validated the patches. V1: - The PciExpressLib is updated to validate the PCIe addresses and introducing corresponding PCD entries. - A

Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-23 Thread Michael Brown
On 23/11/2021 06:41, Marvin Häuser wrote: 23.11.2021 00:17:30 Michael Brown : I would very strongly recommend having the non-debug version of the macro use something like: #define ASSERT(Expression) do {   \ if (FALSE) {  \    (VOID) (Expression);    \ }   

[edk2-devel] [PATCH v2 2/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenGenerator

2021-11-23 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

[edk2-devel] [PATCH v2 0/5] Add DynamicPlatRepoLib

2021-11-23 Thread PierreGondois
From: Pierre Gondois v2: - Various small fixes (change status returned, reset values when freeing memory, ...). [Sami] Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=3743 The DynamicPlatRepoLib is library allowing to receive and then give Configuration Manager (CM) objects. After being

[edk2-devel] [PATCH v2 3/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenFixer

2021-11-23 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

[edk2-devel] [PATCH v2 5/5] DynamicTablesPkg: Add DynamicPlatRepo library

2021-11-23 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

[edk2-devel] [PATCH v2 1/5] DynamicTablesPkg: Definition for DynamicPlatRepoLib interface

2021-11-23 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepoLib library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility

[edk2-devel] [PATCH v2 4/5] DynamicTablesPkg: DynamicPlatRepo: Add TokenMapper

2021-11-23 Thread PierreGondois
From: Pierre Gondois The DynamicPlatRepo library allows to handle dynamically created CmObj. The dynamic platform repository can be in the following states: 1 - Non-initialised 2 - Transient: Possibility to add CmObj to the platform, but not to query them. 3 - Finalised: Possibility to

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

2021-11-23 Thread Marvin Häuser
Ping? :) On 16.08.21 15:10, Marvin Häuser wrote: Hey Ray, On 16/08/2021 11:42, Ni, Ray wrote: Marvin, So lucky to have you in the edk2 project looking into these fundamentals! Thank you. :) +  #define ALIGNOF(TYPE) OFFSET_OF (struct { CHAR8 C; TYPE A; }, A) 1. Does struct{} inside a

Re: [edk2-devel] [PATCH V3 3/3] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg

2021-11-23 Thread Gerd Hoffmann
Hi, > > 2. Can SourceLevelDebug (rely on Local APIC timer) work if this driver is > > chosen as DXE timer driver? > After checking the code and running the PoC (enable SourceLevelDebug and > LocalApicTimerDxe), I find this driver doesn't work anymore. > Actually it asserts in >

Re: [edk2-devel] [PATCH V3 3/3] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg

2021-11-23 Thread Min Xu
On November 22, 2021 11:05 AM, Ni Ray wrote: > Min, > What's the reason of moving this driver to UefiCpuPkg? Please refer to the discussion in https://edk2.groups.io/g/devel/topic/86735078#83126 Because localApicTimerDxe is hardware feature. There is no specific OVMF or QEMU related thing there.