On Thu, Dec 16, 2021 at 01:50:18PM +0100, Ard Biesheuvel wrote:
> On Thu, 16 Dec 2021 at 10:50, Gerd Hoffmann wrote:
> >
> > Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we
> > want use that library.
> >
> > Signed-off-by: Gerd Hoffmann
>
> What guarantees that these accesses
Hi,
> I don't think this is very idiomatic for EDK2, and I wonder if it
> would be better to use [fixed] PCDs for build time configuration, and
> perhaps expose the other width/height data (and the associated policy
> of what takes precedence over what) via a protocol instead.
Well, yes. Ideal
On Thu, Dec 16, 2021 at 09:41:40PM -0500, Stefan Berger wrote:
> For GPU passthrough support we have to initialize the console after
> EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
> this. This was the calling order before the TCG physical presence support
> had to be mov
Hi,
> + //
> + // GPU passthrough only allows console enablement after ROM image load
> + //
> + PlatformInitializeConsole (
> +XenDetected() ? gXenPlatformConsole : gPlatformConsole);
> +
AmdSev build breaks:
/home/kraxel/projects/edk2/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPla
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
TPM must go to Idle state on CRB command completion by rodrigog-intel · Pull
Request #2320 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2320 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You rec
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
Reallocate TPM Active PCRs based on platform support by rodrigog-intel · Pull
Request #2322 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2322 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You re
Ran CI on this version of the patch using a draft pull request: SecurityPkg:
Debug code to audit BIOS TPM extend operations by rodrigog-intel · Pull Request
#2321 · tianocore/edk2 (github.com) (
https://github.com/tianocore/edk2/pull/2321 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive
Jeff's statement about the TPLs in variable and PCD drivers seems correct, not
sure the impact to change them. No good idea from me about the TPL change in
ScsiDisk. 😊
Side question: Variable service is an arch service which should be ready at DXE
phase, ScsiDisk is a driver model driver which
How about adding the minor comments like below? 😊
#
# Non-0 means PcdFspmUpdDataAddress will be ignored, otherwise
PcdFspmUpdDataAddress will be used.
#
gIntelFsp2WrapperTokenSpaceGuid.PcdFspmUpdDataAddress64|0x|UINT64|0x5002
#
# Non-0 means PcdFspsUpdDataAddress will be ignored, othe
Thanks Ashraf!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, December 16, 2021 4:10 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Kuo, Ted ; Duggapu, Chinni B
> ; Chaganty, Rangas
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3515
In V4: Fixed patch format and uncrustify cleanup
In V3: Cleaned up comments, debug prints and updated patch to use the
new debug ENUM definitions.
- Replaced EFI_D_INFO with DEBUG_INFO.
- Replaced EFI_D_VERBOSE with DEBUG_VERBOSE.
In V2:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3463
In V2: Fixed patch format and uncrustify cleanup
In V1: To follow the TCG CRB protocol specification, on every CRB TPM
command completion the TPM should return to Idle state, regardless of
the CRB Idle Bypass capability reported by the TPM
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2858
In V2: Fixed patch format and uncrustify cleanup
In V1: Add debug functionality to examine TPM extend operations
performed by BIOS and inspect the PCR 00 value prior to
any BIOS measurements.
Signed-off-by: Rodrigo Gonzalez del Cueto
Cc:
Thank you Stefan to fix this.
Acked-by: Jiewen Yao
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Stefan
> Berger
> Sent: Friday, December 17, 2021 10:42 AM
> To: devel@edk2.groups.io
> Cc: marcandre.lur...@redhat.com; shivans...@gmail.com; Stefan Berger
> ; Ard Biesheuv
v2 had lost the cc: list for some reason.
I opened this PR: https://github.com/tianocore/edk2/pull/2319
Stefan
On 12/16/21 21:41, Stefan Berger wrote:
For GPU passthrough support we have to initialize the console after
EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
For GPU passthrough support we have to initialize the console after
EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
this. This was the calling order before the TCG physical presence support
had to be moved and the console initialized earlier so user interaction
could be sup
For GPU passthrough support we have to initialize the console after
EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after
this. This was the calling order before the TCG physical presence support
had to be moved and the console initialized earlier so user interaction
could be sup
Hi Ted,
Some bootloaders may choose to always use PcdFspmUpdDataAddress64 regardless
32bit or 64bit builds, we do not need to block such usage cases by checking
UINTN size.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, December 16, 2021 6:47 PM
> To: S, Ash
Thank you for making this change Stefan. I tested your patch locally on my
GPU passthrough Windows 10 VM and it successfully fixes it.
I added a "Tested-by:" note inline in your patch.
Thank you,
Shivanshu Goyal
On Wed, Dec 15, 2021 at 7:44 AM Stefan Berger wrote:
> For GPU passthrough support
Can we use the size of UINTN instead of the value of PcdFspmUpdDataAddress64 to
decide which PCD should be returned in GetFspmUpdDataAddress and
GetFspsUpdDataAddress?
Thanks,
Ted
-Original Message-
From: S, Ashraf Ali
Sent: Thursday, December 16, 2021 4:10 PM
To: devel@edk2.groups.io
On 12/16/21 6:16 AM, Ard Biesheuvel wrote:
There were some changes a while ago to support standalone MM in 32-bit
mode, but I don't think any of the Platform/ARM platforms implement
that. So the best fix here is to simply stop lying about ARM support.
As for RdkQemu - I think it is time we just
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc
b/Silicon/Hisilicon/Hisil
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update FT2000-4Pkg
PlatformLib.
Signed-off-by: Rebecca Cran
---
Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Phytium/PhytiumCommonPkg/Phytium
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update ArmPlatformLib.
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletio
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the Styx code in
AcpiPlatformDxe, PlatInitPei and StyxDtbLoaderLib.
Signed-off-by: Rebecca Cran
---
Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 3 +--
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Platform/RaspberryP
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/SoftIron/Overdrive1000Board/O
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
b/P
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
dif
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48
++--
1 file changed, 24 insertions(+),
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
2 files change
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8
1 file changed, 4 insertions(+), 4 deletion
The ARM_CORE_INFO struct has been updated so the MPIDR is now a single
field instead of separate cluster/core fields. Update the initializer.
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12
++--
Platform/ARM/VExpressPkg/Library/Ar
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
b/Sil
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
b/Platform/Qemu/SbsaQemu/
MpInitLib is now required for all users of ArmPkg/Drivers/CpuDxe. Add
ArmPkg/Library/MpInitLib/DxeMpInitLib.inf .
Signed-off-by: Rebecca Cran
---
Platform/ARM/JunoPkg/ArmJuno.dsc | 1 +
Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 +
Platform/ARM/N1Sdp/N1SdpPlatform.dsc |
Changes from v1:
Fixed Platform/SoftIron, Platform/RaspberryPi, Silicon/AMD,
Silicon/Ampere, Silicon/Phytium, Silicon/Hisilicon.
Patches 1/17 through 8/17 are the same as v1.
The following platforms are already broken:
o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due t
Thank you! I really appreciate your responsiveness!
Sebastien
From: Yao, Jiewen
Sent: Wednesday, December 15, 2021 6:14:07 PM
To: devel@edk2.groups.io ; a...@kernel.org
; Boeuf, Sebastien
Cc: kra...@redhat.com
Subject: RE: [edk2-devel] CMOS needed for Cloud Hyp
On Thu, 16 Dec 2021 at 04:57, Nhi Pham wrote:
>
> This patchset leverages the OemUpdateSmbiosInfo API functions from
> OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
> because they may be updated dynamically during UEFI booting with the
> data being passed from the pre-UEF
On Thu, 16 Dec 2021 at 19:55, Sami Mujawar wrote:
>
> Hi Ard,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
> On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io"
> wrote:
>
> On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
> wrote:
> >
> > W
Hi Ard,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io"
wrote:
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
wrote:
>
> W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
>
> >>> Platform/L
On 12/16/21 8:26 AM, Pierre Gondois wrote:
The following patchset should enable a CI in edk2-platforms for the Juno
platorm, but it was tested before uncrustify was enabled. The patch-set is also
relying on a modification in edk2-pytool-extensions:
https://edk2.groups.io/g/devel/message/83803
Thank you Nate and Isaac for all your help.
-Manic
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85006): https://edk2.groups.io/g/devel/message/85006
Mute This Topic: https://groups.io/mt/87722713/21656
Group Owner: devel+ow...@edk2.gro
On 12/16/21 6:26 AM, Sami Mujawar wrote:
[SAMI] I posted the following patches to fix some of the issues you mention
above:
Platform/Socionext: Fix build break for SynQuacerEvalBoard
(https://edk2.groups.io/g/devel/message/83553)
Platform/LeMaker: Fix build break for CelloBoard
(https://edk2.g
Hi Rebecca,
On 12/16/21 3:59 PM, Rebecca Cran wrote:
> On 12/16/21 6:26 AM, Sami Mujawar wrote:
>
>> [SAMI] I posted the following patches to fix some of the issues you mention
>> above:
>> Platform/Socionext: Fix build break for SynQuacerEvalBoard
>> (https://edk2.groups.io/g/devel/message/8355
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
wrote:
>
> W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
>
> >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
>
> > As for RdkQemu - I think it is time we just remove that.
>
> I would vote for removal of CelloBoard as well. It never went into any
On 12/16/21 6:26 AM, Sami Mujawar wrote:
[SAMI] I posted the following patches to fix some of the issues you mention
above:
Platform/Socionext: Fix build break for SynQuacerEvalBoard
(https://edk2.groups.io/g/devel/message/83553)
Platform/LeMaker: Fix build break for CelloBoard
(https://edk2.
On Thu, 16 Dec 2021 at 15:30, Gerd Hoffmann wrote:
>
> See last patch in the series for details.
>
> Gerd Hoffmann (5):
> OvmfPkg: add PcdVideoResolutionSource
> OvmfPkg/QemuVideoDxe: simplify InitializeBochsGraphicsMode
> OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_BOCHS_MODES->ColorDepth
> Ovm
It's a UINT8 (enum) PCD telling where the PcdVideoHorizontalResolution
and PcdVideoVerticalResolution values are coming from. It can be:
0 (unset aka default from dsc file), or
1 (from PlatformConfig), or
2 (set by Video Driver).
It will be used by video drivers to avoid overriding PlatformCo
Check whenever an EDID blob is present. In case it is get the display
resolution from it. Unless PcdVideoResolutionSource indicates the
display resolution has been set already update
PcdVideoHorizontalResolution and PcdVideoVerticalResolution accordingly.
Also add the resolution to the mode list.
Add helper function to add a video mode to the list of modes.
Move code. Minor debug logging tweaks, no other functional
change.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/Initialize.c | 77 +++
1 file changed, 47 insertions(+), 30 deletions(-)
diff --git
struct QEMU_VIDEO_MODE_DATA has all the data needed to set the video
mode, there is no need to take the extra indirection and use
struct QEMU_VIDEO_BOCHS_MODES.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/Qemu.h | 3 +--
OvmfPkg/QemuVideoDxe/Driver.c | 14 +++---
Ovm
All video modes in the list are 32-bit,
so drop the useless ColorDepth field.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/Qemu.h | 1 -
OvmfPkg/QemuVideoDxe/Initialize.c | 80 +++
2 files changed, 39 insertions(+), 42 deletions(-)
diff --git a/OvmfPk
See last patch in the series for details.
Gerd Hoffmann (5):
OvmfPkg: add PcdVideoResolutionSource
OvmfPkg/QemuVideoDxe: simplify InitializeBochsGraphicsMode
OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_BOCHS_MODES->ColorDepth
OvmfPkg/QemuVideoDxe: factor out QemuVideoBochsAddMode
OvmfPkg/QemuV
Hi,
> > Oh, wow. So you compile in PEI, then decide at runtime whenever you use it
> > or not?
> Yes.
> In OvmfPkgX64.dsc above code will not be built into the image. So it follows
> the SEC->PEI->DXE flow.
> In IntelTdxX64.dsc, it if is Tdx guest, it jumps from SEC to DXE (see
> TdxStartup (
W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
Platform/LeMaker/CelloBoard/CelloBoard.dsc
As for RdkQemu - I think it is time we just remove that.
I would vote for removal of CelloBoard as well. It never went into any
serious mass production and nowadays you probably count working ones
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 13:14, "Rebecca Cran" wrote:
On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
> You appear to have missed a few instances:
>
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> Platfo
On Thu, 16 Dec 2021 at 14:13, Rebecca Cran wrote:
>
> On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
>
> > You appear to have missed a few instances:
> >
> > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > Platform/Hisilicon/D03/D03.dsc
> >
On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
You appear to have missed a few instances:
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
Platform/Hisilicon/D03/D03.dsc
Platform/Hisilicon/D05/D05.dsc
Platform/Hisilicon/D06/D06.dsc
Platform/Hisil
On Thu, 16 Dec 2021 at 10:50, Gerd Hoffmann wrote:
>
> Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we
> want use that library.
>
> Signed-off-by: Gerd Hoffmann
What guarantees that these accesses only ever see the correct, updated value?
> ---
> OvmfPkg/PlatformPei/Platfor
On December 15, 2021 6:42 PM, Gerd Hoffmann wrote:
> > Patch 2/3:
> > This patch-set leverage the PrePiLib and MemoryAllocationLib in
> > EmbeddedPkg. Some new funtions are added to meet the Tdvf Config-B
> > requirement.
>
> Care to explain why this is needed? How is tdvf different from other pe
On December 15, 2021 6:28 PM, Gerd Hoffmann wrote:
> On Tue, Dec 14, 2021 at 09:41:24PM +0800, Min Xu wrote:
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> >
> > Tdvf Config-B skip PEI phase to reduce attack surface. So instead of
> > jumping to SecStartupPhase2 (), TdxStartup () is
On December 15, 2021 6:09 PM, Gerd Hoffmann wrote:
> > + PageTables = 0;
> > + if (FeaturePcdGet (PcdDxeIplBuildPageTables)) {
>
> Can this ever be false in a x64 build?
You're right. This cannot be false in X64 build. I will refactor it in the
next version.
>
> > +EFI_STATUS
> > +FindDxeCore
On Thu, 16 Dec 2021 at 09:07, Masahisa Kojima
wrote:
>
> Hi Ard,
>
> On Wed, 15 Dec 2021 at 17:45, Ard Biesheuvel wrote:
> >
> > (+ Masahisa, Masami)
> >
> >
> > On Fri, 15 Oct 2021 at 11:07, Ming Huang
> > wrote:
> > >
> > > TF-A: TrustedFirmware-A
> > > SPM: Secure Partition Manager(MM)
> > >
You may try to enlarger stmm_ns_comm_buf_size in Optee to check if it could
solve ASSERT issue.
fanjianf...@byosoft.com.cn
From: Masahisa Kojima
Date: 2021-12-16 16:07
To: Ard Biesheuvel
CC: Ming Huang; Masami Hiramatsu; edk2-devel-groups-io; Sami Mujawar; Ard
Biesheuvel; Jiewen Yao; Supreet
On Thu, 16 Dec 2021 at 10:50, Gerd Hoffmann wrote:
>
> io range is not mandatory according to pcie spec,
> so allow bridge configurations without io address
> space assigned.
>
> Signed-off-by: Gerd Hoffmann
Reviewed-by: Ard Biesheuvel
> ---
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBrid
io range is not mandatory according to pcie spec,
so allow host bridges without io address space.
Signed-off-by: Gerd Hoffmann
---
.../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/OvmfPkg/Fdt/FdtPciHostBridgeL
Link in pcie and host bridge bits. Enables support for PCIe in microvm
(qemu-system-x86_64 -M microvm,pcie=on).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Microvm/MicrovmX64.dsc | 40 +-
OvmfPkg/Microvm/READM
microvm places the 64bit mmio space at the end of the physical address
space. So mPhysMemAddressWidth must be correct, otherwise the pci host
bridge setup throws an error because it thinks the 64bit mmio window is
not addressable.
On microvm we can simply use standard cpuid to figure the address
Those old windows versions which need the vbeshim hack
will not run on microvm anyway.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c
index 8faa146b6cce..2a04821
Needs two little tweaks in PCI code because microvm supports mmio only.
Other than that just wire up the existing code (the PCIe host adapter
used by microvm is the same (virtual) hardware used by the arm/aarch64
virtual machines).
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777
Gerd Hof
Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we
want use that library.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/PlatformPei/PlatformPei.inf | 2 +-
OvmfPkg/PlatformPei/MemDetect.c | 4 ++--
OvmfPkg/PlatformPei/Platform.c | 4 ++--
3 files changed, 5 insertions(+), 5
io range is not mandatory according to pcie spec,
so allow bridge configurations without io address
space assigned.
Signed-off-by: Gerd Hoffmann
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/
On Wed, 15 Dec 2021 at 01:03, Rebecca Cran wrote:
>
> This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support
> for AARCH64" series which is in the process of being reviewed (I'm
> sending a v2 soon).
>
> With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers
> of
Hey all,
> On 15. Dec 2021, at 16:02, Ming Huang wrote:
>
>
>
>> On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote:
>> Hi Ming,
>> Thanks for this patch. This patch helps to resolve Standalone MM issue while
>> exercising RAS use case.
>> Few comments mentioned inline.
>> - Omkar
>>> On 10/15/
Hi
>
> On Mon, Dec 13, 2021 at 08:57:02PM +0800, Min Xu wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
> >
> > OvmfPkg.dec is removed from [Packages] because it doesn't depend on
> > OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg.
>
> >if (mTimerNotifyFunction != NULL)
Hi
> > @@ -357,6 +360,7 @@ GetPageTableEntry (
> >
> >// 4k
> >L1PageTable = (UINT64 *)(UINTN)(L2PageTable[Index2] & ~AddressEncMask
> & PAGING_4K_ADDRESS_MASK_64);
> > +
> >if ((L1PageTable[Index1] == 0) && (Address != 0)) {
>
> Hmm?
The blank line will be dropped.
>
> With that drop
Hi
> > +EFI_STATUS
> > +EFIAPI
> > +BspAcceptMemoryResourceRange (
> > + IN EFI_PHYSICAL_ADDRESS PhysicalAddress,
> > + IN EFI_PHYSICAL_ADDRESS PhysicalEnd
> > + )
> > +{
> > + EFI_STATUS Status;
> > + UINT32 AcceptPageSize;
> > + UINT64 StartAddress1;
> > + UINT64 StartAdd
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to building
error. when a module built-in X64 function pointer will be the size of
64bit width which cannot be fit in 32bit address which will lead to
error. to overcome this issue i
Hi Ard,
On Wed, 15 Dec 2021 at 17:45, Ard Biesheuvel wrote:
>
> (+ Masahisa, Masami)
>
>
> On Fri, 15 Oct 2021 at 11:07, Ming Huang wrote:
> >
> > TF-A: TrustedFirmware-A
> > SPM: Secure Partition Manager(MM)
> >
> > In TF-A, the name of this field is sp_shared_buf_size. This field is
> > the si
82 matches
Mail list logo
