[edk2-devel] Test mail

2022-01-27 Thread Chao Li
This is a test email, please do not reply. Thanks, Chao Li -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86138): https://edk2.groups.io/g/devel/message/86138 Mute This Topic: https://groups.io/mt/88740806/21656 Group Owner: devel+ow...

Re: [edk2-devel] [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib

2022-01-27 Thread Min Xu
On January 26, 2022 9:04 PM, Gerd Hoffmann wrote: > On Sun, Jan 23, 2022 at 09:36:53AM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > There are multi-variants of PlatformPei in OvmfPkg, for example, > > - OvmfPkg/PlatformPei > > - OvmfPkg/Bhyve/PlatformP

Re: [edk2-devel] [PATCH V5 18/33] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

2022-01-27 Thread Min Xu
On January 26, 2022 8:06 PM, Gerd Hoffmann wrote: > > +BOOLEAN > > +QemuFwCfgIsTdxGuest ( > > + VOID > > + ) > > +{ > > + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER *CcWorkAreaHeader; > > + > > + CcWorkAreaHeader = (CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER > > +*)FixedPcdGet32 (PcdOvmfWorkAreaBase

Re: [edk2-devel] [PATCH V5 17/33] OvmfPkg: Update Sec to support Tdx

2022-01-27 Thread Min Xu
On January 26, 2022 7:53 PM, Gerd Hoffmann wrote: > > PcdTdxAcceptPageSize is added for page accepting. Currently TDX > > supports 4K and 2M accept page size. The default value is 4K. > > Is there a good reason to not use 2M by default? In case that fails the code > will > fallback to 4K pages,

回复: [edk2-devel] [PATCH 1/1] MdeModulePkg/RuntimeDxe: clear mVirtualMapMaxIndex

2022-01-27 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gerd > Hoffmann > 发送时间: 2022年1月21日 20:59 > 收件人: devel@edk2.groups.io > 抄送: Dandan Bi ; Pawel Polawski > ; Jian J Wang ; Liming Gao > ; Gerd Hoffmann > 主题: [edk2-devel] [PATCH 1/1] MdeModulePkg/RuntimeDxe: clear > mVirtualMa

Re: [edk2-devel] Question about Block IO protocol devices

2022-01-27 Thread valerij zaporogeci
Thanks again for your explanatory answers. Indeed, BlockIo->Media->LogicalPartition is more than enough. Admittedly, I overlooked that field. And now I can confidently tell to those firmware writers about the bug. it's uboot cough cough. :D -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] Question about Block IO protocol devices

2022-01-27 Thread Andrew Fish via groups.io
> On Jan 27, 2022, at 6:19 PM, valerij zaporogeci wrote: > > Thank you, Andrew, for the clarification. > >> I don’t remember the use case for HD(0,MBR, sign) type of device path node? > > don't know, how much of usability it would have per se, but > representing a raw disk this way, would giv

Re: [edk2-devel] Question about Block IO protocol devices

2022-01-27 Thread valerij zaporogeci
Thank you, Andrew, for the clarification. > I don’t remember the use case for HD(0,MBR, sign) type of device path node? don't know, how much of usability it would have per se, but representing a raw disk this way, would give an easier way to find them out. because all such would end with the same

Re: [edk2-devel] Question about Block IO protocol devices

2022-01-27 Thread Andrew Fish via groups.io
> On Jan 27, 2022, at 4:34 PM, valerij zaporogeci wrote: > > Hi, edk2. I would be glad to clarify one thing. When I request all > handles, on which Block IO protocol (BIOP) is installed (through > LocateHandleBuffer(ByProtocol), and then open Device Path protocol > (DPP) on every of them to se

Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl submodule to v3.0

2022-01-27 Thread Andrew Fish via groups.io
Very cool idea but ….. 1) We don’t always use the systems native compiler and sometimes we use a cross compiler so making assumptions about system libs is not always valid. On a Mac with Xcode clang I’ve got full SysV ABI libs (not supper helpful for EFI), but not EFI/MSFT x86_64 ABI. For bonus

[edk2-devel] Question about Block IO protocol devices

2022-01-27 Thread valerij zaporogeci
Hi, edk2. I would be glad to clarify one thing. When I request all handles, on which Block IO protocol (BIOP) is installed (through LocateHandleBuffer(ByProtocol), and then open Device Path protocol (DPP) on every of them to see what devices support BIOP, I don't see ones, that should represent the

Re: [edk2-devel] 回复: [PATCH v3 0/6] MM communicate functionality in variable policy

2022-01-27 Thread Kun Qin
Hi Liming, Thanks for the help! Regards, Kun On 01/25/2022 17:41, gaoliming wrote: Hi, all If no other comment, I will merge this patch set tomorrow. Thanks Liming -邮件原件- 发件人: Kun Qin 发送时间: 2022年1月26日 3:39 收件人: devel@edk2.groups.io 抄送: Jian J Wang ; Liming Gao ; Hao A Wu ; Michae

Re: [edk2-devel][PATCH] BaseTools/GenFw: Enhance to add export table in PE-COFF

2022-01-27 Thread Michael Kubacki
Got it, thanks for the update. On 1/26/2022 10:04 PM, Huang, Li-Xia wrote: Hi Michael, Thanks for your response. Sorry I didn't give enough context for my question, I mean the ' SizeOfInitializedData' in Optional header of PE-COFF file. SizeOfInitializedData The size of the initialized data s

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, February 4, 2022 #cal-cancelled

2022-01-27 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - 01/27/2022 #cal-notice

2022-01-27 Thread devel@edk2.groups.io Calendar
*TianoCore edk2-test Bug Triage Meeting* *When:* 01/27/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subject=Re:%20Eve

Re: [edk2-devel] [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob

2022-01-27 Thread Gerd Hoffmann
Hi, > + EFI_HOB_GUID_TYPE *GuidHob; > + EFI_HOB_PLATFORM_INFO *PlatformInfo = NULL; >// Query Host Bridge DID to determine platform type > + // Tdx guest stores the HostBridgePciDevId in a GuidHob. > + // So we first check if this HOB exists Hmm, wouldn't it be better to create a

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - 01/27/2022 #cal-reminder

2022-01-27 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCAT

Re: [edk2-devel] [PATCH V2 07/10] OvmfPkg/IntelTdx: Add Sec to bring up both Legacy and Tdx guest

2022-01-27 Thread Gerd Hoffmann
On Tue, Jan 25, 2022 at 02:33:15PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > OvmfPkg/IntelTdx/Sec is a simplied version of OvmfPkg/Sec. There > are below differences between these 2 Sec > - IntelTdx/Sec only supports Legacy guest and Tdx guest. > - Intel

Re: [edk2-devel] [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings

2022-01-27 Thread Gerd Hoffmann
> This patch-sets is to bring up Legacy guest and Tdx guest without > PEI phase. So platform initialization has to be done in SEC phase. > It is similar with the work of OvmfPkg/PlatformPei. In > OvmfPkg/PlatformPei some PCDs are set during platform initialization, > such as PcdPciMmio64Base. But i

Re: [edk2-devel] [PATCH V2 03/10] OvmfPkg: Add TdxWorkArea definition

2022-01-27 Thread Gerd Hoffmann
> +// > +// The TDX work area definition > +// > +typedef struct _SEC_TDX_WORK_AREA { > + UINT32PageTableReady; > + UINT32Gpaw; > + UINT64HobList; > +} SEC_TDX_WORK_AREA; > + > +typedef struct _TDX_WORK_AREA { > + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADERHeader; > + SEC_TDX_WORK_

Re: [edk2-devel] [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase

2022-01-27 Thread Gerd Hoffmann
On Tue, Jan 25, 2022 at 02:33:10PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add PcdTdxWorkAreaBase to indicate the area of memory where > the TDX work area block lives. Why have both PcdSevEsWorkAreaBase and PcdTdxWorkAreaBase when we have a shared work

Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib

2022-01-27 Thread Gerd Hoffmann
On Mon, Jan 24, 2022 at 09:52:07PM +0800, Abner Chang wrote: > Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg. > RISC-V Virt platform can leverage the same library to access PCI Express > registers through PCI Express base address set in PcdPciExpressBaseAddress > and cache

Re: [edk2-devel] [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM override

2022-01-27 Thread Ard Biesheuvel
On Sat, 22 Jan 2022 at 02:41, Michael D Kinney wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3811 > > Remove ASSERT() statements that are triggered if a platform provides > an override of PCI ROM attached to a PCI Controller. The PCI Platform > Protocol allows the platform to pro

Re: [edk2-devel] [PATCH V5 27/33] OvmfPkg/BaseMemEncryptTdxLib: Add TDX helper library

2022-01-27 Thread Gerd Hoffmann
On Sun, Jan 23, 2022 at 09:36:58AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add Intel Tdx helper library. The library provides the routines to: > - set or clear Shared bit for a given memory region. > - query whether TDX is enabled. > > Please be noted

Re: [edk2-devel] [PATCH V5 25/33] OvmfPkg: Update PlatformPei to support Tdx guest

2022-01-27 Thread Gerd Hoffmann
Hi, > +/** > + This Function checks if TDX is available, if present then it sets > + the dynamic PCDs for Tdx guest. It also builds Guid hob which contains > + the Host Bridge DevId. > + **/ > +VOID > +IntelTdxInitialize ( > + VOID > + ) > +{ > + #ifdef MDE_CPU_X64 > + EFI_HOB_PLATFORM_IN

Re: [edk2-devel] [PATCH V5 24/33] OvmfPkg: Update PlatformInitLib to support Tdx guest

2022-01-27 Thread Gerd Hoffmann
On Sun, Jan 23, 2022 at 09:36:55AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > In Tdx guest, the system memory is passed in TdHob by host VMM. So > the major task of PlatformTdxPublishRamRegions is to walk thru the > TdHob list and transfer the ResourceDescr