回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 02/15/2022 #cal-reminder

2022-02-14 Thread gaoliming
Hi, all There are total 814 open BZ issues in Edk2 project. The detail report can be found in below link. Please help review your own issues and update their status. Let’s work together to clean up them.

[edk2-devel] Please comment on the XhciDxe driver and UsbMassStorageDxe driver optimization suggestions

2022-02-14 Thread liuyang
Hello, Recently, we found that when we plug and remove USB3.0 devices quickly under UEFI Shell on LoongArch platform, there will be a lag of about 3~15 minutes (the keyboard and mouse do not reflect under Setup), which looks like the system has halted. Here we find two possible areas

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Kowalewski, Robert
Reviewed-by: Robert Kowalewski -Original Message- From: Sheng, W Sent: Tuesday, February 15, 2022 7:58 AM To: Kuo, Ted ; devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: RE: [PATCH v2] IntelSiliconPkg/VTd: Fix to support

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] BeepDebugFeaturePkg: Enable FixedAtBuild PCD type

2022-02-14 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Oram, Isaac W Sent: Friday, February 11, 2022 4:13 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] BeepDebugFeaturePkg: Enable

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Sheng Wei
The change is good to me. Reviewed-by: Sheng Wei > -Original Message- > From: Kuo, Ted > Sent: 2022年2月15日 14:47 > To: devel@edk2.groups.io > Cc: Sheng, W ; Ni, Ray ; Chaganty, > Rangasai V ; Huang, Jenny > ; Kowalewski, Robert > > Subject: [PATCH v2] IntelSiliconPkg/VTd: Fix to

Re: [edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Sheng Wei
Hi Ted, Since we use UINTN as the return type of ParseDmarAcpiTableDrhd (), Could we keep UINTN here and change define of PROCESS_DRHD_CALLBACK_FUNC ? typedef VOID (*PROCESS_DRHD_CALLBACK_FUNC) ( IN OUT VOID *Context, IN UINT32 VTdIndex, // change

[edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Fix to support IntelVTdDmarPei in 64bit

2022-02-14 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3836 Changed VtdIndex defined in PROCESS_DRHD_CALLBACK_FUNC from UINT32 to UINTN to avoid type incompatible error when enable PEI in 64bit. Cc: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by:

Re: [edk2-devel] [PATCH v1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-02-14 Thread Yao, Jiewen
Thanks for the update. Feedback below: 1) How block size is determined for below API? BOOLEAN EFIAPI ParallelHash256HashAll ( IN CONST VOID*Input, IN UINTN InputByteLen, OUT VOID*Output, IN UINTN OutputByteLen, IN CONST VOID

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] BaseTools: Catch the exception in build.py.

2022-02-14 Thread Mingyue Liang
Hi fengyunhua: This patch is used to report error messages. For the contents of the error messages you mentioned, please submit another bugzilla. On Thu, Nov 5, 2020 at 09:15 AM, fengyunhua wrote: > > I tried this patch, modified OvmfPkgIa32.fdf > INF OvmfPkg/Sec/SecMain.inf > ===> > INM

回复: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py

2022-02-14 Thread gaoliming
It has been merged at d4ac53aa91b8a3602166c6adcb9ba8678e0ae969 Thanks Liming 发件人: devel@edk2.groups.io 代表 Jake Garver via groups.io 发送时间: 2022年2月14日 21:10 收件人: Jake Garver ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py Hi folks, Any

Re: [edk2-devel] [PATCH] Updating brotli submodules to build with GCC 11.

2022-02-14 Thread Bob Feng
The edk2 CI was restored and PR 2514 was merged. https://github.com/tianocore/edk2/pull/2514 Thanks, Bob -Original Message- From: gaoliming Sent: Tuesday, February 15, 2022 9:04 AM To: devel@edk2.groups.io; leonardo.gar...@linaro.org Cc: Feng, Bob C ; Chen, Christine ; Wang, Jian J

Re: [edk2-devel] **NOTICE** EDK II CI using Azure Pipelines Agents Failing - Update 2-14-2022 Back Up!

2022-02-14 Thread Michael D Kinney
Hello, The EDK II CI agents are running again. I have requested all the back logged PRs to rerun their CI checks and all of those have completed. I have also observed new PRs being processed as expected. We do not have a complete root cause of the issue yet. We are continuing to collect

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 02/15/2022 #cal-reminder

2022-02-14 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

回复: [edk2-devel] [PATCH] Updating brotli submodules to build with GCC 11.

2022-02-14 Thread gaoliming
Garcia: PR https://github.com/tianocore/edk2/pull/2514 has been created for this change. But now, CI meets with the problem. This change is not merged. Some people is investigating CI issue. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Leonardo > Garcia > 发送时间: 2022年2月14日

Re: [edk2-devel] Regression found with latest edk2/OVMF SECUREBOOT/SMM build

2022-02-14 Thread dann frazier
[+ Brijesh] On Fri, Feb 11, 2022 at 05:48:38PM -0700, dann frazier wrote: > On Fri, Feb 11, 2022 at 06:31:35PM +, Aaron Young wrote: > > Hello, my apologies if this has already been > > discovered/discussed/addressed, but we are seeing a reproducible exception > > with latest

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add PlatformGopPolicy

2022-02-14 Thread Guo Dong
+ SECTION PE32 = UefiPayloadPkg/IntelGopDriver.efi I didn't see file IntelGopDriver.efi in this patch while this file is added into FDF file. Is this a generic GOP driver that could work on different platform? Thanks, Guo -Original Message- From: devel@edk2.groups.io On Behalf Of

Re: [edk2-devel] [PATCH] Updating brotli submodules to build with GCC 11.

2022-02-14 Thread Moritz Fischer via groups.io
On Mon, Feb 14, 2022 at 10:24 AM Leonardo Garcia wrote: > > From: Leonardo Garcia > > GCC 11.1.0 introduced a new warning for variable length arrays as > parameters (vla-parameter). Brotli compression library had issues with > this which were fixed upstream by commits >

[edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

2022-02-14 Thread Jeff Brasen via groups.io
Add support for partial free of non cached buffers. If a request for less than the full size is requested new allocations for the remaining head and tail of the buffer are added to the list. Added verification that Buffer is EFI_PAGE_SIZE aligned. The XHCI driver does this if the page size for the

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO #cal-invite

2022-02-14 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

[edk2-devel] Updated Event: TianoCore Community Meeting - EMEA / NAMO #cal-invite

2022-02-14 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-14 Thread Ojeda Leon, Nicolas via groups.io
>> > Hmm, so you are hiding the #define here to avoid updating >> > Protocol/PciHostBridgeResourceAllocation.h ... >> > >> > I suspect if this can't be implemented in the pci enumerator alone there >> > is just no way around actually extending uefi protocols. But it's also >> > not fully clear

Re: [edk2-devel] [edk2-platform PATCH v1 1/1] Platform/RaspberryPi: Make SetVariable return EFI_UNSUPPORTED at runtime

2022-02-14 Thread Tinh Nguyen via groups.io
Hi everyone, I found my answer, Reclaim() function calls Fault Tolerant Write protocol, it is a boot-time service and not available on runtime Maybe it is a dummy question, why do we support Fault Tolerant Write protocol in runtime? Thanks a lot Tinh Nguyen -=-=-=-=-=-=-=-=-=-=-=- Groups.io

[edk2-devel] [PATCH] Updating brotli submodules to build with GCC 11.

2022-02-14 Thread Leonardo Garcia
From: Leonardo Garcia GCC 11.1.0 introduced a new warning for variable length arrays as parameters (vla-parameter). Brotli compression library had issues with this which were fixed upstream by commits 0a3944c8c99b8d10cc4325f721b7c273d2b41f7b and 27dd7265403d8e8fed99a854b9c3e1db7d79525f in brotli

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add support for Firmware Volume Block Protocol

2022-02-14 Thread Guo Dong
Hi Sean, This is a big patch. Here are some high level comments. For BlSMMStoreDxe/BlSMMStoreDxe.inf, how about rename it to SmmStoreFvb/SmmStoreFvbRuntimeDxe.inf with below reasons? a) We don't need "Bl" since Payload would always work with bootloader. b) We could keep "SMMStore" but I

Re: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py

2022-02-14 Thread Jake Garver via groups.io
Hi folks, Any interest in accepting this simple fix? Thanks, Jake -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86654): https://edk2.groups.io/g/devel/message/86654 Mute This Topic: https://groups.io/mt/88573504/21656 Group Owner:

Re: [edk2-devel] [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob

2022-02-14 Thread Min Xu
On February 14, 2022 6:03 PM, Gerd Hoffmann wrote: > On Tue, Feb 08, 2022 at 08:20:20AM +, Xu, Min M wrote: > > On January 27, 2022 9:49 PM, Gerd Hoffmann wrote: > > > > + EFI_HOB_GUID_TYPE *GuidHob; > > > > + EFI_HOB_PLATFORM_INFO *PlatformInfo = NULL; > > > > > > >// Query Host

[edk2-devel] [edk2-platforms][PATCH V1 6/6] Platform/Sgi: add IORT table for IO virtualization block on RD-N2

2022-02-14 Thread Vivek Kumar Gautam
Arm reference design RD-N2 platform has multiple I/O virtualization blocks that allow connecting PCIe root bus or non-PCIe devices to the system. Each of the I/O virtualization blocks (IoVirtBlk) consists of an Arm SMMUv3 compliant MMU-700 controller to handle address translations and a GIC-700

[edk2-devel] [edk2-platforms][PATCH V1 5/6] Platform/Sgi: add IORT table for IO virtualization block on RD-N2-Cfg1

2022-02-14 Thread Vivek Kumar Gautam
Arm reference design RD-N2-Cfg1 platform has multiple I/O virtualization blocks that allow connecting PCIe root bus or non-PCIe devices to the system. Each of the I/O virtualization blocks (IoVirtBlk) consists of an Arm SMMUv3 compliant MMU-700 controller to handle address translation and a

[edk2-devel] [edk2-platforms][PATCH V1 3/6] Platform/Sgi: Initialize additional uart controllers

2022-02-14 Thread Vivek Kumar Gautam
From: Shriram K The IO virtualization block on reference design platforms allow connecting non-discoverable devices such as PL011 UART. On platforms that support this, initialize the UART controller connected to the IO virtualization block. Signed-off-by: Shriram K Signed-off-by: Vivek Gautam

[edk2-devel] [edk2-platforms][PATCH V1 4/6] Platform/Sgi: add helper macros for ITS, SMMUv3 and DMA IORT nodes

2022-02-14 Thread Vivek Kumar Gautam
Add preprocessor macros for ITS, SMMUv3 and DMA named component nodes of IORT table that can be used to describe the IO topology connected to the IO Virtualization block. An IO virtualization block could be used to connect PCIe root bus or non-PCIe devices. For a non-PCIe IO-Virtualization block,

[edk2-devel] [edk2-platforms][PATCH V1 2/6] Platform/Sgi: add ssdt table for non-discoverable IO virtualization block

2022-02-14 Thread Vivek Kumar Gautam
Arm reference design platforms such as RD-N2 and RD-N2-Cfg1 have multiple IO virtualization blocks that allow connecting PCIe root bus or non-PCIe devices to the system. For platforms that connect non-discoverable (non- PCI) devices to IO virtualization block, add a SSDT table to describe such

[edk2-devel] [edk2-platforms][PATCH V1 0/6] Add non-discoverable IO block for Rd-N2

2022-02-14 Thread Vivek Kumar Gautam
Arm reference design platforms such as RD-N2 and RD-N2-Cfg1 have multiple I/O virtualization blocks that allow connecting PCIe root bus or non-PCIe (non-discoverable) devices to the system. Each of the I/O virtualization blocks consists of an Arm SMMUv3 compliant MMU-700 controller to handle

[edk2-devel] [edk2-platforms][PATCH V1 1/6] Platform/Sgi: add PCDs for SMMUv3 base address and interrupts

2022-02-14 Thread Vivek Kumar Gautam
The SMMUv3 node in IORT table requires interrupt vector information of 4 programmable interrupts - Event, PRI, Global error, and Sync. In addition to these interrupt vectors, DeviceID information is required to support MSI interrupts using GIC ITS block. Add the PCD entries for SMMUv3 base

Re: [edk2-devel] [PATCH v4 7/8] PciHostBridgeDxe: Extend service to get base addresses before allocation

2022-02-14 Thread Gerd Hoffmann
On Fri, Feb 04, 2022 at 09:17:48AM +, Ojeda Leon, Nicolas wrote: > Hi Gerd, > > > Hmm, so you are hiding the #define here to avoid updating > > Protocol/PciHostBridgeResourceAllocation.h ... > > > > I suspect if this can't be implemented in the pci enumerator alone there is > > just no

Re: [edk2-devel] [PATCH V2 09/10] OvmfPkg: Update DxeAcpiTimerLib to read HostBridgeDevId in PlatformInfoHob

2022-02-14 Thread Gerd Hoffmann
On Tue, Feb 08, 2022 at 08:20:20AM +, Xu, Min M wrote: > On January 27, 2022 9:49 PM, Gerd Hoffmann wrote: > > > + EFI_HOB_GUID_TYPE *GuidHob; > > > + EFI_HOB_PLATFORM_INFO *PlatformInfo = NULL; > > > > >// Query Host Bridge DID to determine platform type > > > + // Tdx guest

Re: [edk2-devel] [PATCH V2 05/10] OvmfPkg: Update EFI_HOB_PLATFORM_INFO with more platform settings

2022-02-14 Thread Gerd Hoffmann
On Mon, Feb 14, 2022 at 02:34:30AM +, Xu, Min M wrote: > Hi > > > --- a/OvmfPkg/Include/IndustryStandard/IntelTdx.h > > > +++ b/OvmfPkg/Include/IndustryStandard/IntelTdx.h > > > > With this being more widely used it doesn't make sense to have it in > > IntelTdx.h ... > > > I am thinking

Re: [edk2-devel] [PATCH V2 02/10] UefiCpuPkg: Add PcdTdxWorkAreaBase

2022-02-14 Thread Gerd Hoffmann
Hi, > $ grep -rn --exclude-dir=Build PcdSevEsWorkAreaBase - > UefiCpuPkg/Library/MpInitLib/AmdSev.c There is 'git grep' btw. > I would suggest Renaming PcdSevEsWorkAreaBase to PcdCcWorkAreaBase be in a > separate patch-set. > Gerd, What's your thought? Fine with me. I'd suggest to

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build

2022-02-14 Thread Ni, Ray
The patch itself looks good to me. But when I read the code further, the SwapStack() is implemented as below. I think you need to enhance it to support the case when RSP is above 4GB. 1. Change UINT32 NewStack to UINTN 2. Change CoreStack from UINT32 to UINTN. UINT32 SwapStack ( IN UINT32

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64 Build

2022-02-14 Thread Ni, Ray
Ashraf, GetStackFramePointer() only returns the lower 32 bits of RBP. Is that expected? -Original Message- From: devel@edk2.groups.io On Behalf Of Ashraf Ali S Sent: Monday, February 14, 2022 12:27 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Chiu, Chasel ; Desimone, Nathaniel L ;