[edk2-devel] [PATCH] UefiPayloadPkg: Use Boot Splash

2022-02-20 Thread Sean Rhodes
Build with BootLogo using default image by default. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 3 +++ .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ UefiPaylo

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Sean Rhodes
We would prefer to keep PCD, as Esc can conflict with Grub on normal (not Chromebook) devices Thank you On Mon, 21 Feb 2022 at 05:26, Ni, Ray wrote: > Can you just map both ESC and F2 to the UI? So that PCD is not needed. > > Thanks, > Ray > > -Original Message- > From: Sean Rhodes > S

Re: [edk2-devel] [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2022-02-20 Thread Gao, Zhichao
Patchset Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Abdul Lateef Attar > Sent: Wednesday, February 16, 2022 7:14 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sami > Mujawar > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield

[edk2-devel] [PATCH v3 1/1] UefiPayloadPkg/PayloadLoaderPeim: Use INT64 as input parameter

2022-02-20 Thread Guomin Jiang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3818 It will have some potential issue when memory larger than 2G because the high memory address will be fill with 0x when do the operation of INTN + INT64 but it is 32 bit normal data in fact. Should use same data type INT64 + INT64.

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Ni, Ray
Can you just map both ESC and F2 to the UI? So that PCD is not needed. Thanks, Ray -Original Message- From: Sean Rhodes Sent: Monday, February 21, 2022 5:39 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPk

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-02-20 Thread Ni, Ray
Can you avoid introducing the PCD by always including BootLogo driver? By the way, you changed brotli version. Is that expected? -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, February 21, 2022 5:34 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes,

Re: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the binary size

2022-02-20 Thread Guomin Jiang
Comment inline Thank Guomin > -Original Message- > From: Kinney, Michael D > Sent: Friday, February 18, 2022 11:34 AM > To: devel@edk2.groups.io; Jiang, Guomin ; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the > binary size > > Guomin, >

[edk2-devel] [PATCH] UefiPayloadPkg: Add build option for Above 4G Memory

2022-02-20 Thread Sean Rhodes
When build option ABOVE_4G_MEMORY is set to true, nothing will change and EDKII will use all available memory. Setting it to false will create memory type information HOB in payload entry, so that EDKII will reserve enough memory below 4G for EDKII modules. This option is useful for bootloaders th

[edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Sean Rhodes
Provide a build option to use [Esc] instead of [F2] for devices such as Chromebooks that don't have F-keys. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- .../Library/BrotliCustomDecompressLib/brotli | 2 +- .../PlatformBootManager.c

[edk2-devel] [PATCH 1/2] MdeModulePackage: Add option to follow BGRT spec

2022-02-20 Thread Sean Rhodes
Add option to centre the Boot Logo 38.2% from the top of screen, following the BGRT specification. Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Sean Rhodes --- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c| 7 ++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf | 3 +++ MdeModu

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hookup BGRT build option

2022-02-20 Thread Sean Rhodes
Hook FOLLOW_BGRT_SPEC build option to FollowBGRTSpec PCD. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPay

[edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-02-20 Thread Sean Rhodes
Provide a build option to use a Boot Splash logo. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- MdeModulePkg/Library/BrotliCustomDecompressLib/brotli | 2 +- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 5 + .../PlatformBootMa

[edk2-devel] [PATCH] BlSupportSmm: fix definition of SetSmrr()

2022-02-20 Thread Sean Rhodes
From: Matt DeVillier Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Matt DeVillier Change-Id: Id5b077ad6c79717a9d97d4228145791ef062962c --- MdeModulePkg/Library/BrotliCustomDecompressLib/brotli | 2 +- UefiPayloadPkg/BlSupportSmm/BlSupportSmm.c| 1 + 2 fi

Re: [edk2-devel] [PATCH 08/18] UefiPayloadPkg: Fix case of protocol

2022-02-20 Thread Patrick Rudolph
Hi, can you please have a look at this patch? It fixes a build failure. Regards, Patrick Rudolph On Thu, Feb 10, 2022 at 10:24 PM Sean Rhodes wrote: > > Fix case match in to avoid build failure on > Linu. > > Signed-off-by: Sean Rhodes > --- > UefiPayloadPkg/BlSupportSmm/BlSupportSmm.h | 2 +-

Re: [edk2-devel] [PATCH 10/18] BlSupportSmm: fix definition of SetSmrr()

2022-02-20 Thread Patrick Rudolph
Hi, Can you please have a look at this patch? The BlSupportSmm currently doesn't compile and this patch fixes the issue. It would be very nice if you could add build tests for every option defaulting to false to catch those issues in the future. Regards, Patrick Rudolph On Thu, Feb 10, 2022 at 10

[edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Sean Rhodes
Provide a build option to use [Esc] instead of [F2] for devices such as Chromebooks that don't have F-keys. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- .../Library/BrotliCustomDecompressLib/brotli | 2 +- .../PlatformBootManager.c