Reviewed-by: Ray Ni
-Original Message-
From: Kuo, Ted
Sent: Friday, March 11, 2022 3:29 PM
To: devel@edk2.groups.io
Cc: Ni, Ray ; De, Debkumar ; Han,
Harry ; West, Catharine
Subject: [edk2-devel][PATCH v2] UefiCpuPkg: Support FFS3 GUID in
SearchForBfvBase.asm
Can you avoid changing the spaces?
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guomin Jiang
Sent: Friday, March 11, 2022 9:01 AM
To: devel@edk2.groups.io
Cc: Ni, Ray
Subject: [edk2-devel] [edk2-platforms Patch 3/3] OptionRomPkg: Remove all UGA
support
REF:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3862
The new algorithm searches BFV address with FFS3 GUID first.
If not found, it will search BFV address with FFS2 GUID.
Cc: Ray Ni
Cc: Debkumar De
Cc: Harry Han
Cc: Catharine West
Signed-off-by: Ted Kuo
---
can you avoid the unnecessary changes (e.g.: spacing)?
-Original Message-
From: devel@edk2.groups.io On Behalf Of Guomin Jiang
Sent: Friday, March 11, 2022 9:01 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Chiu, Chasel
Subject: [edk2-devel] [edk2-platforms Patch 1/3]
On March 11, 2022 11:20 AM, Gao Liming wrote:
> Min:
> I have one minor comment for TdxLib.h. This header file doesn't need to
> include
> below header files. Other patches in MdePkg are good to me. Reviewed-by:
> Liming Gao
>
> #include
> #include
> #include
> #include
>
Thanks for the
Hi Wenyi,
Please add my RB in the commit message and create the PR against edk2, let me
know the link to PR as well.
Thanks,
Abner
From: Chang, Abner (HPS SW/FW Technologist)
Sent: Friday, March 11, 2022 1:48 PM
To: Wenyi Xie ; devel@edk2.groups.io
; Wang,
The warm reboot requests are mapped to cold reboot as the power control
module was not capable of handling the warm reboot requests in the
legacy implementation. The support for warm reboot support is added into
the power control module. To support warm reset, update
ArmPsciResetSystemLib, and
Hi Ard,
Thanks for your suggestions. Please find my reply inline.
Regards,
Pranav
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, March 10, 2022 8:56 PM
> To: Pranav Madhu
> Cc: edk2-devel-groups-io ; Ard Biesheuvel
> ; Sami Mujawar
> Subject: Re: [edk2][PATCH V1 1/1]
Hi Sami,
Thanks for your comments. Please find my reply inline.
Regards,
Pranav
> -Original Message-
> From: Sami Mujawar
> Sent: Thursday, March 10, 2022 9:01 PM
> To: Pranav Madhu ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; nd
> Subject: Re: [edk2][PATCH V1 1/1] ArmPkg: Handle
Thanks for catching this.
Reviewed-by: Abner Chang
> -Original Message-
> From: Wenyi Xie
> Sent: Thursday, March 10, 2022 7:26 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> ; Wang, Nickle (Server BIOS)
>
> Cc: songdongku...@huawei.com; xiewen...@huawei.com
>
Add new function to initialize the GOP, move over setup code. Handle
initialization first, specifically before calling GopQueryMode(), so
GopQueryMode is never called before GopInitialize() did complete.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/Gop.c | 47
Try query native display resolution from the host. When successfull
setup PcdVideoHorizontalResolution and PcdVideoVerticalResolution
accordingly and add the video mode to the GOP mode list if needed.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/VirtioGpu.inf | 6 ++
Call GopQueryMode() in GopSetMode(), use the ModeInfo returned when
setting the mode. This is needed to properly handle modes which are
not on the static mGopResolutions list.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/Gop.c | 60 --
1 file
Add support for sending a GetDisplayInfo command.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioGpuDxe/VirtioGpu.h | 6 ++
OvmfPkg/VirtioGpuDxe/Commands.c | 20
2 files changed, 26 insertions(+)
diff --git a/OvmfPkg/VirtioGpuDxe/VirtioGpu.h
Add GetDisplayInfo command, reply and data struct to the
virtio-gpu specification header file.
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/Include/IndustryStandard/VirtioGpu.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
QemuVideoDxe recently got support for picking up
display resolution configuration from the host.
This series does the same for VirtioGpuDxe.
Gerd Hoffmann (6):
OvmfPkg/VirtioGpuDxe: add VirtioGpuSendCommandWithReply
OvmfPkg/VirtioGpuDxe: add GetDisplayInfo to virtio-gpu spec header.
Extend VirtioGpuSendCommand() to support commands which return data,
rename the function to VirtioGpuSendCommandWithReply() to indicate that.
Add a new VirtioGpuSendCommand() function which is just a thin wrapper
around VirtioGpuSendCommandWithReply() so existing code continues to
work without
Min:
I have one minor comment for TdxLib.h. This header file doesn't need to
include below header files. Other patches in MdePkg are good to me.
Reviewed-by: Liming Gao
#include
#include
#include
#include
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Min Xu
> 发送时间:
Brent:
Please update commit title as MdePkg Include: Update Protocol
PxeBaseCodeCallBack.h
With this change, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> brentholtsclaw
> 发送时间: 2022年3月9日 7:19
> 收件人: devel@edk2.groups.io
> 抄送: brentholtsclaw
> 主题:
For the series...
Reviewed-by: Nate DeSimone
-Original Message-
From: Oram, Isaac W
Sent: Thursday, March 10, 2022 2:41 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Chiu, Chasel
Subject: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform
driver
This
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Ray Ni
Signed-off-by: Guomin Jiang
---
.../CirrusLogic5430Dxe/CirrusLogic5430.c | 522 +++---
.../CirrusLogic5430Dxe/CirrusLogic5430.h | 136 ++---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support in PurleyOpenBoardPkg
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Guomin Jiang
---
.../Library/BoardBdsHookLib/BoardBdsHook.h| 70 +--
1 file changed, 33 insertions(+), 37 deletions(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Eric Dong
Cc: Liming Gao
Signed-off-by: Guomin Jiang
---
.../Library/BoardBdsHookLib/BoardBdsHook.h| 70 +--
1 file changed, 33 insertions(+), 37 deletions(-)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2368
Remove all UGA support
Cc: Nate DeSimone
Cc: Chasel Chiu
Cc: Eric Dong
Cc: Liming Gao
Cc: Ray Ni
Guomin Jiang (3):
PurleyOpenBoardPkg: Remove All UGA support
BoardModulePkg: Remove all UGA support
OptionRomPkg: Remove all UGA
Yu and Ray:
I review UefiCpuLib. I think they are generic enough (X86 arch) to be
placed in MdePkg.
Mike:
What's your comments for this proposal?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Pu, Yu
> 发送时间: 2022年3月10日 16:47
> 收件人: Ni, Ray ; Kinney, Michael D
> ; Gao, Liming
Pedro,
It sounds good to me. I am exposing our formerly proprietary code without much
refactoring. But I see no reason to have CRC related code in multiple
libraries.
Regards,
Isaac
From: Pedro Falcato
Sent: Thursday, March 10, 2022 3:19 PM
To: edk2-devel-groups-io ; Oram, Isaac W
Cc:
Hi,
I've just noticed this patch adds CRC16, which I've already added to my
Ext4Pkg (
https://github.com/tianocore/edk2-platforms/blob/master/Features/Ext4Pkg/Ext4Dxe/Crc16.c
).
I suggest we add CRC16 (and possibly CRC32C, which I already have in my
package as well) to MdePkg, as to de-duplicate
Core only supports CRC32, this library adds CRC16 support.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h | 42
Platform/Intel/WhitleyOpenBoardPkg/Library/BaseCrcLib/BaseCrcLib.c | 71
There is an unnecessary inheritance of a SKX build option that has
confused the build settings.
Removed unused IE_ENABLE, PCH_PKG_OPTIONS, and SECURITY_OPTIONS
Fix a bug where changes in PlatformPkgConfig.dsc were not
taking effect because of missing [Defines] context.
Cc: Nate DeSimone
Cc:
UbaPlatLib is required by AcpiTablesLib used by AcpiPlatform driver.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Library/UbaPlatLib/DxeUbaGpioPlatformConfigLib.c
| 388
Enables boards to modify the AcpiPlatform driver behaviors.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformSpecificAcpiTableLib.h
| 129
Adds various definitions needed to move the AcpiPlatform driver from
FvLateOpenBoard binary to open source.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciHostBridge/PciHostBridge.inf
| 1 +
AcpiPlatform DXE driver loads and patches ACPI tables before publishing.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c
| 754 +
Library for building tables during the boot.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Platform/Intel/WhitleyOpenBoardPkg/Include/Library/BuildAcpiTablesLib.h
| 111 +
This series converts the AcpiPlatform driver for Whitley ICX to open source.
The driver requires libraries providing:
16-bit CRC service
A library to update the tables based on boot time data.
A board hook library to control publishing individual tables and to modify
tables.
A library to build
Needed to convert FvLateOpenBoard ACPI binary drivers to open source.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
Silicon/Intel/WhitleySiliconPkg/CpRcPkg.dec
| 3 +
Silicon/Intel/WhitleySiliconPkg/Cpu/Include/CpuDataStruct.h
Yes, if you do it only when you could locate gEdkiiPlatformLogoProtocolGuid.
This way you don’t need a PCD and the build option is only used for logo module
built-in or not.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87423):
Do you mean check if the protocol exist in PlatformBootManager.c? i.e.
if (gEdkiiPlatformLogoProtocolGuid ) {
gST->ConOut->ClearScreen (gST->ConOut);
If not, can I ask the reasoning, as if I understand it, that would be a complex
solution for saving one PCD
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
According to the Debug Port Table 2 (DBG2) specification,
February 17, 2021, the NamespaceString is a NULL terminated
ASCII string that consists of a fully qualified reference
to the object that represents the serial port device in the
ACPI namespace.
The DBG2 table generator did not populate the
Resuming this PATCH to see if there are any additional thoughts on this.
In response to the query about DXE/BDS services we have some internal
connection logic that runs in DXE to connect the devices that are needed for
arch services that have to be connected prior the end of dxe.
Thanks,
Jeff
Hi, Mike, Liming,
This patch makes MdeModulePkg depend on UefiCpuPkg.
Ray and me would like to move the UefiCpuLib from UefiCpuPkg to MdePkg, do you
agree with it ?
Thanks,
Yu
-Original Message-
From: Ni, Ray
Sent: Monday, March 7, 2022 11:55 AM
To: Kinney, Michael D ; Gao, Liming
Hi Pranav,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/03/2022 01:10 PM, Pranav Madhu wrote:
The warm reboot requests are mapped to cold reboot as the power control
module was not capable of handling the warm reboot requests in the
On Thu, 10 Mar 2022 at 14:10, Pranav Madhu wrote:
>
> The warm reboot requests are mapped to cold reboot as the power control
> module was not capable of handling the warm reboot requests in the
> legacy implementation. The support for warm reboot support is added into
> the power control module.
The warm reboot requests are mapped to cold reboot as the power control
module was not capable of handling the warm reboot requests in the
legacy implementation. The support for warm reboot support is added into
the power control module. To support warm reset, update
ArmPsciResetSystemLib, and
Update the Rd-N2-Cfg1 platform specific ACPI tables to ACPI version
v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Madt.aslc | 112 ++--
Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Pptt.aslc | 80 +++---
2 files changed, 97 insertions(+), 95
Update the Rd-N2 platform specific ACPI tables to ACPI version v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc | 163 ++--
Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc | 84 +-
2 files changed, 128 insertions(+), 119 deletions(-)
Update the Rd-V1 multichip platform specific ACPI tables to ACPI version
v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Hmat.aslc | 64
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc | 165 ++--
Update the Rd-V1 platform specific ACPI tables to ACPI version v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdV1/Madt.aslc | 159 ++--
Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc | 84 ++-
2 files changed, 126 insertions(+), 117 deletions(-)
Update the Rd-E1-Edge platform specific ACPI tables to ACPI version
v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc | 247 ++--
Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc | 115 -
2 files changed, 186 insertions(+), 176
Update the Rd-N1-Edge multichip platform specific ACPI tables to ACPI
version v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Hmat.aslc | 52 ---
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 151 ++--
Update the Rd-N1-Edge platform specific ACPI tables to ACPI version
v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc | 105 +++-
Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc | 97 +-
2 files changed, 106 insertions(+),
Update the SGI-575 platform specific ACPI tables to ACPI version v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Madt.aslc | 105 +++-
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc | 86
2 files changed, 100 insertions(+), 91
Update the common ACPI tables used by all the Neoverse Reference Design
platforms to ACPI version v6.4.
Signed-off-by: Pranav Madhu
---
Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 221 ++--
Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc| 30 +--
Arm infrastructure reference design platforms uses ACPI tables to
provide the hardware information to the operating system. Currently the
ACPI tables are aligned with ACPI v6.2 and v6.3 specification. This
patch series update the tables to ACPI v6.4 specificaion.
The first patch in this series
Hi Ray,
Please find my inline comments with [Ted].
Thanks,
Ted
-Original Message-
From: Ni, Ray
Sent: Thursday, March 10, 2022 12:15 PM
To: Kuo, Ted ; devel@edk2.groups.io
Cc: De, Debkumar ; Han, Harry ;
West, Catharine
Subject: RE: [edk2-devel][PATCH] UefiCpuPkg: Support FFS3 GUID
Main Changes :
1.free the allocated memory when function collectionEvalOp return.
2.optimeze the code, no functional change.
Wenyi Xie (1):
RedfishPkg: fix memory leak issue
RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16
+++-
1 file changed, 7
The calloc memory is not free when function collectionEvalOp
return in the halfway.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Wenyi Xie
---
RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16
+++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff
Hi Jiewen,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/03/2022, 05:49, "Yao, Jiewen" wrote:
HI Sami
I think it is OK to update signature to `CCEL`. That means it will be
applicable for other CC, right?
[SAMI] Yes, the same table can then be used by
To keep the declaration same with definition, remove the last optional
in declaration of WakeUpAP.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Wenyi Xie
---
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Main Changes :
1.Remove suffix optional in declaration of WakeUpAP to keep declaration same
with definition.
Wenyi Xie (1):
UefiCpuPkg/MpInitLib:remove optional in declaration
UefiCpuPkg/Library/MpInitLib/MpLib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
60 matches
Mail list logo
