Re: [edk2-devel] [PATCH v2] BaseTools/GenFw: Enhance GenFw to support PRM GCC build

2022-03-13 Thread Bob Feng
This patch looks good to me. Reviewed-by: Bob Feng -Original Message- From: Huang, Li-Xia Sent: Monday, March 14, 2022 1:27 PM To: devel@edk2.groups.io Cc: Huang, Li-Xia ; Gao, Liming ; Feng, Bob C ; Chen, Christine Subject: [edk2-devel] [PATCH v2] BaseTools/GenFw: Enhance GenFw to

Re: [edk2-devel] [PATCH v5 1/1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-03-13 Thread Yao, Jiewen
Thanks. It is close to final version, but there are some compatibility issue need to be address. 1) Whenever you add a new field in the data structure, please add it at the end. Don't add them in the middle. E.g. PCD_CRYPTO_SERVICE_FAMILY_ENABLE, _EDKII_CRYPTO_PROTOCOL 2) Whenever you add a new

[edk2-devel] [PATCH v2] BaseTools/GenFw: Enhance GenFw to support PRM GCC build

2022-03-13 Thread Huang, Li-Xia
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3802 Since PRM module needs to support export table in PE-COFF, we'll enhance GenFw tool to support this. Add one export flag in GenFw tool. If export flag is set: Step1: Scan ELF symbol table based on PRM module descriptor to get descriptor off

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2

2022-03-13 Thread Jagadeesh Ujja
Hi Sami, The patch is tested and looks good to me: Tested-by: Jagadeesh Ujja On Fri, Mar 11, 2022 at 6:38 PM PierreGondois wrote: > > Hi Sami, > The patch looks good to me: > > Reviewed-by: Pierre Gondois > > On 3/10/22 18:39, Sami Mujawar wrote: > > According to the Debug Port Table 2 (DBG2)

[edk2-devel][PATCH] IntelFsp2Pkg: BaseFspCommonLib Support for X64

2022-03-13 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3867 Add BaseFspCommonLib Support for X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/FspSecCore/SecFsp.c | 2 +- IntelFsp2Pkg/FspSecCore/SecFsp.h

Re: [edk2-devel] [PATCH EDK2 v1 1/1] UefiCpuPkg/MpInitLib:remove optional in declaration

2022-03-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of wenyi,xie via groups.io Sent: Thursday, March 10, 2022 4:06 PM To: devel@edk2.groups.io; Dong, Eric ; Ni, Ray ; Kumar, Rahul1 Cc: songdongku...@huawei.com; xiewen...@huawei.com Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error

2022-03-13 Thread Ni, Ray
I don't understand the need of "+ DEFINE PLATFORMX64_ENABLE = TRUE". -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Friday, March 11, 2022 9:41 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH v2] BaseTools/GenFw: Enhance GenFw to support PRM GCC build

2022-03-13 Thread Huang, Li-Xia
Hi Liming, BZ link is added. PRM option currently only supports DXE RUNTIME driver and X64 arch, GenFw will report error message if PRM option is specified for other arch or other module type. Thanks. Regards, Lisa -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming

[edk2-devel][PATCH v2] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64

2022-03-13 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3832 Add BaseFspSwitchStackLib Support for X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo --- IntelFsp2Pkg/Include/PushPopRegsNasm.inc | 67 .../BaseFspSwitchStackL

Re: [edk2-devel] [PATCH] Maintainers: Update Maintainers.txt for edk2 Redfish modules

2022-03-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner (HPS SW/FW Technologist) Sent: Monday, March 14, 2022 9:21 AM To: devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray ; Wang, Nickle Subject: [edk2-devel] [PATCH] Maintainers: Update Maintainers.txt

[edk2-devel][PATCH v2] IntelFsp2Pkg: BaseFspDebugLibSerialPort Support for X64

2022-03-13 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3833 Add BaseFspDebugLibSerialPort Support for X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Ted Kuo Signed-off-by: Ted Kuo --- .../BaseFspDebugLibSerialPort.inf | 5 ++- .../Library/BaseFspDebu

[edk2-devel] [PATCH] Maintainers: Update Maintainers.txt for edk2 Redfish modules

2022-03-13 Thread Abner Chang
Add maintainer and reviewer for the edk2 Redfish-related modules under EmulatorPkg. Signed-off-by: Abner Chang Cc: Andrew Fish Cc: Ray Ni Cc: Nickle Wang --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index d26f91c02e..e32507dd6e

Re: [edk2-devel] [PATCH v1] MdeModulePkg/DxeIpl: Create 5-level page table for long mode

2022-03-13 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Lou, Yun Sent: Friday, March 11, 2022 11:59 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Bi, Dandan ; Gao, Liming Subject: [PATCH v1] MdeModulePkg/DxeIpl: Create 5-level page table for long mode REF: https://bugzilla.tianocore.org/