Re: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV / TDX guest

2022-03-16 Thread Min Xu
Hi, Liming Can you help to review this patch? https://edk2.groups.io/g/devel/message/87480 Thanks Min > -Original Message- > From: devel@edk2.groups.io On Behalf Of Min Xu > Sent: Saturday, March 12, 2022 9:54 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Michael Roth ; > Ni, Ray ;

Re: [edk2-devel][PATCH v2] UefiCpuPkg: Support FFS3 GUID in SearchForBfvBase.asm

2022-03-16 Thread Ni, Ray
Ted, Have you considered a case that BFV is a FFS2 FV and the logic may find a FFS3 FV just below the BFV? Thanks, Ray -Original Message- From: devel@edk2.groups.io On Behalf Of Ni, Ray Sent: Friday, March 11, 2022 3:42 PM To: Kuo, Ted ; devel@edk2.groups.io Cc: De, Debkumar ; Han,

[edk2-devel] [PATCH v6 1/1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-03-16 Thread Li, Zhihao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3596 Parallel hash function ParallelHash256HashAll, as defined in NIST's Special Publication 800-185, published December 2016. It utilizes multi-process to calculate the digest. Passed CI test. Onprotocol version code passed test. Cc: Jiewen

Re: [edk2-devel] **NOTICE** EDK II CI downloading gcc_arm_linux tools Failing

2022-03-16 Thread Bob Feng
Thank you. The CI was recovered. Thanks, Bob From: Sami Mujawar Sent: Wednesday, March 16, 2022 1:43 PM To: devel@edk2.groups.io; Feng, Bob C ; Kinney, Michael D ; Sean Brogan Cc: nd Subject: Re: [edk2-devel] **NOTICE** EDK II CI downloading gcc_arm_linux tools Failing Hi Bob, The

Re: [edk2-devel] [PATCH v5 1/1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-03-16 Thread Yao, Jiewen
Sounds good. Thanks for the update. > -Original Message- > From: Li, Zhihao > Sent: Thursday, March 17, 2022 10:43 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 ; > Jiang, Guomin ; Fu, Siyuan > Subject: RE: [edk2-devel] [PATCH v5 1/1] CryptoPkg: Add new

Re: [edk2-devel] [PATCH v5 1/1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

2022-03-16 Thread Li, Zhihao
Will send patch_v6 with following update soon. 1. adjust the position of new field in the data structure. 2.update the version of data structure if it existing. 3.With the usability test, the CrytoLibOnProtocol version code can be used normally as static version. Best Regard Zhihao

Re: [edk2-devel] [PATCH V8 00/47] Enable Intel TDX in OvmfPkg (Config-A)

2022-03-16 Thread Min Xu
On March 17, 2022 9:00 AM, Gao Liming wrote: > Min: > I suggest to add it into OvmfPkg/Library/PlatformInitLib/IntelTdx.c as the > internal implementation. > Thanks for the suggestion. It will be updated in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel][PATCH] MdeModulePkg: Make RSP 16-byte boundary aligned for PEI 64bit

2022-03-16 Thread Kuo, Ted
Hi Liming and Mike, Can you please review the change? Thanks, Ted -Original Message- From: devel@edk2.groups.io On Behalf Of Kuo, Ted Sent: Thursday, March 10, 2022 2:21 PM To: devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; De, Debkumar ; Han, Harry ; West, Catharine ; Wang,

回复: [edk2-devel] [PATCH V8 00/47] Enable Intel TDX in OvmfPkg (Config-A)

2022-03-16 Thread gaoliming
Min: I suggest to add it into OvmfPkg/Library/PlatformInitLib/IntelTdx.c as the internal implementation. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Min Xu > 发送时间: 2022年3月15日 15:12 > 收件人: devel@edk2.groups.io; Gao, Liming > 抄送: 'Brijesh Singh' ; Dong, Eric > ; Aktas, Erdem

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

2022-03-16 Thread Sean Rhodes
Hi Ray Would you be able to review please? :) Thanks Sean On Fri, 18 Feb 2022 at 02:16, Wu, Hao A wrote: > Acked-by: Hao A Wu > I recommend to get Ray's input for this patch before merging. > > Best Regards, > Hao Wu > > > -Original Message- > > From: devel@edk2.groups.io On

[edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: Add Pcd to prioritize internal devices

2022-03-16 Thread Sean Rhodes
From: Matt DeVillier Add Pcd to allow configuring internal devices to be prioritized over internally-attached USB devices, such as card readers, over SATA, NVMe and eMMC drives. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Matt DeVillier Signed-off-by: Sean Rhodes ---

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hookup Prioritise Internal build option

2022-03-16 Thread Sean Rhodes
Hook PRIORITISE_INTERNAL build option to PrioritiseInternal PCD. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- MdeModulePkg/MdeModulePkg.dec | 7 +-- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-)

[edk2-devel] [GSoC 2022] Introducing Myself

2022-03-16 Thread ayushdevel1325
Hello everyone, I am Ayush Singh, a 2nd-year student from India. I am interested in the proposal: *Add Rust support to EDK II*. I am experienced in Rust, C, and Python. However, I have very little experience with Assembly. I am currently participating in Season of KDE (

[edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css

2022-03-16 Thread littlefox via groups.io
Fix the check for NVMe command set being supported by the controller. Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe. Uncovered by commit 9dd14fc (

Re: [edk2-devel] Applying for GSoC

2022-03-16 Thread Nate DeSimone
Hi Tejesh, Great to meet you and welcome to the TianoCore project! Great to hear you are interested! Apologize for the tardiness in my response. I did not see any emails from you on the mailing list, you might want to contact the groups.io tech support for help in getting your email sent to

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/JunctionCity: Build ACPI content

2022-03-16 Thread Oram, Isaac W
Thanks for the confirmation. I didn't have any trouble applying the patch on the same commit. Best idea is that maybe something went wrong extracting the patch from the email. Regards, Isaac From: Manickavasakam Karpagavinayagam Sent: Tuesday, March 15, 2022 12:22 PM To: Oram, Isaac W ;

Re: [edk2-devel] [PATCH edk2-platforms 1/3] Platform/ARM/JunoPkg: Convert AcpiSsdtRootPci.asl from tabs to spaces

2022-03-16 Thread Sami Mujawar
Hi Rebecca, Thank you for this patch. These change look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/03/2022 04:19 AM, Rebecca Cran wrote: Other .asl files in Platform/ARM/JunoPkg/AcpiTables use spaces, while AcpiSsdtRootPci.asl uses tabs. To be consistent, convert it

Re: [edk2-devel] [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-16 Thread Min Xu
On March 16, 2022 4:37 PM, Ni Ray wrote: > > GetProcessorInfo() can return the information for index#0 CPU. > Other suggestions look good to me. > Agree. It will be updated in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH v3 0/5] Http Fixes

2022-03-16 Thread Gerd Hoffmann
On Tue, Mar 15, 2022 at 02:42:24PM +0100, Oliver Steffen wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 > > This set of patches fixes booting from HTTP/1.0 servers. > It also improves the interaction with HTTP/1.1 servers by recognizing > the 'Connection: close' header field,

Re: [edk2-devel] [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish service

2022-03-16 Thread Nickle Wang
Some typos. Platform Redfish credential library shouldn't stop the service at either EndOfDXE or ExitBootService notification. RedfishConfigureHandler UEFI driver is responsible to stop the Redfish service when EndOfDXE or ExitBootService event is triggered. Reviewed-by: Nickle Wang

Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics

2022-03-16 Thread Gerd Hoffmann
On Tue, Mar 15, 2022 at 05:08:55PM +, Pedro Falcato wrote: > Gerd, > > Have you considered just pulling in LLVM's compiler-rt builtins? It > implements essentially everything we'll ever need for a GNU-like toolchain, > for all the architectures we support, and also has unit tests ( >

Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics

2022-03-16 Thread Gerd Hoffmann
On Tue, Mar 15, 2022 at 03:27:58PM +, Michael D Kinney wrote: > Hi Gerd, > > Thanks for working on this. I raised this topic in the new TianoCore build > and CI > meeting yesterday because the intrinsic libs are closely tied to the > toolchains > supported by TianoCore. > > I agree with

[edk2-devel] [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish service

2022-03-16 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3859 Platform Redfish credential library shouldn't top the service at either EndOfDXE or ExitBootService notification. RedfishConfiguHandler UEFI driver is responsible to stop the Redfish service when EndOfDXE or ExitBootService event is

Re: [edk2-devel] [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-16 Thread Ni, Ray
GetProcessorInfo() can return the information for index#0 CPU. Other suggestions look good to me. -Original Message- From: Xu, Min M Sent: Wednesday, March 16, 2022 4:32 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Brijesh Singh ; Aktas, Erdem ; James Bottomley ; Yao, Jiewen ; Tom

Re: [edk2-devel] [PATCH V8 13/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-16 Thread Min Xu
On March 15, 2022 3:58 PM, Ni Ray wrote: > > Min, > I don't quite understand. > > Of all MP services, the TDX version only supports: > * GetNumberOfProcessors > * GetProcessorInfo > > And even when TDX MP returns 3 or 4 threads from GetNumberOfProcessors(), > StartupAllAPs() is an NOP. > Will

Re: [edk2-devel] [PATCH V8 22/47] OvmfPkg/PlatformPei: Refactor MaxCpuCountInitialization

2022-03-16 Thread Min Xu
On March 15, 2022 4:05 PM, Gerd Hoffmann wrote: > > Hi, > > > +/** > > + Fetch the boot CPU count and the possible CPU count from QEMU, and > expose > > + them to UefiCpuPkg modules. Set the mMaxCpuCount variable. > > +**/ > > Another outdated comment. > Thanks for reminder. It will be