Re: [edk2-devel] Clarification of Memory management in PEI phase

Thanks for the wonderful answer. Ayush Singh On Thu, Jun 9 2022 at 01:26:58 PM -0700, Andrew Fish wrote: On Jun 9, 2022, at 10:28 AM, Ayush Singh > wrote: Hello everyone, Can anyone help me with understanding dynamic memory management in PEI phase?

[edk2-devel] [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3788 Removed an outdated reference to py2.7 in the Windows systems wiki page and replaced it with the py3.7 to align with the updated build instructions Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Jayaprakash N ---

[edk2-devel] [edk2 Patch 0/1] updated py2.7 reference in wiki build instructions

This patch is to fix the documentation issue in wiki page where it had reference to py2.7 in the build instructions. This has been updated to refer to py3.7 to align with the rest of the build instructions. Jayaprakash Nevara (1): Windows-systems.mediawiki: replaced p2.7 reference with py3.7

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: Add Definition of EDKII_PEI_VARIABLE_PPI

I just saw the comment in the cover letter about the additional implementation. Thanks, Michael On 6/9/2022 9:59 PM, Michael Kubacki wrote: Is this change just adding the interface to Tianocore or is there additional implementation planned as well? --- I thought we were following this

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: Add Definition of EDKII_PEI_VARIABLE_PPI

Is this change just adding the interface to Tianocore or is there additional implementation planned as well? --- I thought we were following this convention now: "#ifndef __PEI_VARIABLE_PPI_H_" -> "#ifndef PEI_VARIABLE_PPI_H_" Some other comments are inline. Regards, Michael On 6/9/2022

[edk2-devel] [PATCH V1 1/1] MdeModulePkg: Add Definition of EDKII_PEI_VARIABLE_PPI

Adds definition of EDKII_PEI_VARIABLE_PPI, a pre-cursor to enabling variable writes in the PEI environment. Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Isaac Oram Cc: Chasel Chiu Cc: Gao Cheng Cc: Di Zhang Cc: Daocheng Bu Cc: Michael Kubacki Signed-off-by: Nate DeSimone ---

[edk2-devel] [PATCH V1 0/1] Add EDKII_PEI_VARIABLE_PPI

This patch series proposes a new architectural PPI: EDKII_PEI_VARIABLE_PPI This PPI provides services to read and write to UEFI variables during the PEI environment. While an implementation of this PPI does not exist yet, Intel is working on a new implementation of the PEI variable services that

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib

Reviewed-by: Michael Kubacki On 6/9/2022 7:51 PM, Marcin Wojtas wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 This patch adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable

[edk2-devel] [edk2-platforms PATCH 1/1] Marvell: Add VariableFlashInfoLib

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 This patch adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable driver to build that has a dependency on this library class and does not

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Platform and Silicon Intel maintainers

Pushed as 9a3ff0e812..86119cb496 -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, June 8, 2022 2:52 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Leif Lindholm ; Kinney, Michael D ; Chaganty, Rangasai V Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Isaac Oram to common Intel packages

Pushed as 499011f5c9..9a3ff0e812 -Original Message- From: Kinney, Michael D Sent: Wednesday, June 8, 2022 8:24 AM To: Oram, Isaac W ; devel@edk2.groups.io; Kinney, Michael D Cc: Leif Lindholm Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Isaac Oram to

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs

Pushed: https://github.com/tianocore/edk2-platforms/commit/499011f -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, June 6, 2022 4:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Sinha, Ankit ; Kubacki, Michael ; Soller, Jeremy Subject:

Re: [edk2-devel] [edk2-platforms] [PATCH V2 0/4] Enable CPU pwr mgmt in FADT for Intel client boards

The series has been pushed as ~af3727a..19d3b5d -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, June 6, 2022 4:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Sinha, Ankit ; Chaganty, Rangasai V ; Kubacki, Michael ; Luo, Heng ; Kethi Reddy,

Re: [edk2-devel] [PATCH V2 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

Pushed: https://github.com/tianocore/edk2-platforms/commit/f427247 -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, June 7, 2022 4:23 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Chiu, Chasel ; Gao, Liming ; Dong, Eric ; Kubacki, Michael

Re: [edk2-devel] [PATCH V2 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Tuesday, June 7, 2022 4:23 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Chiu, Chasel ; Gao, Liming ; Dong, Eric ; Kubacki, Michael Subject: [edk2-devel] [PATCH V2 1/1]

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout

Pushed as c546cc01f1..2a236ae742 -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, June 8, 2022 2:53 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure

Re: [edk2-devel] Clarification of Memory management in PEI phase

> On Jun 9, 2022, at 10:28 AM, Ayush Singh wrote: > > Hello everyone, > > Can anyone help me with understanding dynamic memory management in PEI > phase? In the UEFI Platform Integration Specification, version 1.7 > Errata A, Section 4.6, PEI Memory services are given which include: > > 1.

[edk2-devel] [edk2-platforms][PATCH V1 7/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1

RD-N2-Cfg1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the

[edk2-devel] [edk2-platforms][PATCH V1 6/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2

RD-N2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the interconnect

[edk2-devel] [edk2-platforms][PATCH V1 5/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC

RD-V1-MC platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V1 3/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2

RD-N1-Edge-X2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V1 4/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1

RD-V1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V1 2/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge

RD-N1-Edge platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms

The DSDT ACPI table used for Neoverse reference design platforms include the _LPI control method for the kernel to enter idle states. This patch series fixes bugs in the existing _LPI control method due to which certain high level OS failed to boot on the supported Neoverse reference design

[edk2-devel] [edk2-platforms][PATCH V1 1/7] Platform/Sgi: Fix ACPI Low Power Idle states for SGI575

SGI-575 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu ---

[edk2-devel] [PATCH v2 1/1] Tools\FitGen: Add extra parameter fixed FIT address

From: fanwang2intel Add "-T " parameter to provide fixed FIT address on flash region. When this parameter is set to a valid address in the input FD/FV file, tool will directly generate FIT on this address. It's users' responsibilities to reserve enough size for FIT table and option modules on

[edk2-devel] Clarification of Memory management in PEI phase

Hello everyone, Can anyone help me with understanding dynamic memory management in PEI phase? In the UEFI Platform Integration Specification, version 1.7 Errata A, Section 4.6, PEI Memory services are given which include: 1. InstallPeiMemory() 2. AllocatePages() 3. AllocatePool() 4. CopyMem() 5.

[edk2-devel] [edk2-platforms][PATCH V3 8/9] Platform/Sgi: Update ACPI version to v6.4 for RD-N2 platform

Update the RD-N2 platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 9/9] Platform/Sgi: Update ACPI version to v6.4 for RD-N2-Cfg1 platform

Update the RD-N2-Cfg1 platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 7/9] Platform/Sgi: Update ACPI version to v6.4 for RD-V1-MC platform

Update the RD-V1-MC platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 6/9] Platform/Sgi: Update ACPI version to v6.4 for RD-V1 platform

Update the RD-V1 platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 5/9] Platform/Sgi: Update ACPI version to v6.4 for RD-E1-Edge platform

Update the RD-E1-Edge platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 4/9] Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge-X2 platform

Update the RD-N1-Edge-X2 platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 2/9] Platform/Sgi: Update ACPI version to v6.4 for SGI575 platform

Update the SGI575 platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 3/9] Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge platform

Update the RD-N1-Edge platform specific ACPI tables to ACPI version v6.4. Significant changes introduced are to add SPE overflow interrupt number field to GICC structure of MADT table and adding cache ID field to the cache structure of PPTT table. Signed-off-by: Pranav Madhu ---

[edk2-devel] [edk2-platforms][PATCH V3 1/9] Platform/Sgi: Update ACPI version to v6.4

Update the common ACPI tables used by all the Neoverse Reference Design platforms to ACPI version v6.4. Significant changes introduced are update API/macro definitions to incorporate with the extra fields introduced in ACPI 6.4, such as SPE overflow interrupt number field to GICC structure of MADT

[edk2-devel] [edk2-platforms][PATCH V3 0/9] Upadate the ACPI tables for RD platforms

Changes since V2: - Rebased on top of latest master branch - Update PPTT table with unique cache ID across the system for different levels of cache. Changes since V1: - Rebased on top of latest master branch. - Rebased on top of patch to remove SLC cache entries from PPTT (link for the same

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, June 10, 2022 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20220317T223602Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai

[edk2-devel] [PATCH v2 1/2] SctPkg: Fix X64 build errors for GCC toolchain

Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off-by: Abdul Lateef Attar ---

[edk2-devel] [PATCH v2 0/2] SctPkg: GCC compilation support

Removes duplicate function definations. Adds EFIAPI to function definations/declerations. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Signed-off-by: Abdul Lateef Attar Abdul Lateef Attar (2):

Re: [edk2-devel] [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp

On Thu, Jun 09, 2022 at 09:34:10AM +, Ni, Ray wrote: > Do you think maybe creating a CompilerIntrinsicLib.h in > MdePkg/Include/Library/ helps people understand how many intrinsic functions > are provided for different ARCH? Documenting the intrinsics supported looks useful to me. Not sure

[edk2-devel] [PATCH 5/5] uefi-sct/SctPkg: Add a category for RISCV_EFI_BOOT_PROTOCOL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3837 Provide a name for the GUID of RISCV_EFI_BOOT_PROTOCOL in the SCT. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Ard Biesheuvel Cc:

[edk2-devel] [PATCH 4/5] uefi-sct/SctPkg: Install RISCV_EFI_BOOT_PROTOCOL test module

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3837 Enable installing the RISCV_EFI_BOOT_PROTOCOL test cases into the SCT directory. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Ard

[edk2-devel] [PATCH 3/5] uefi-sct/SctPkg: Build test cases of RISCV_EFI_BOOT_PROTOCOL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3837 Enable building test cases of RISCV_EFI_BOOT_PROTOCOL as part of SCT build. Cc: G Edhaya Chandran Cc: Barton Gao Cc: Carolyn Gjertsen Cc: Samer El-Haj-Mahmoud Cc: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Ard Biesheuvel

[edk2-devel] [PATCH 2/5] uefi-sct/SctPkg: Add test cases for RISCV_EFI_BOOT_PROTOCOL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3837 RISC-V platforms need to support new RISCV_EFI_BOOT_PROTOCOL to communicate the boot hart ID to the operating system. Add the required test cases for this protocol. The specification of the protocol is maintained at:

[edk2-devel] [PATCH 1/5] uefi-sct/SctPkg: Add header file for RISCV_EFI_BOOT_PROTOCOL

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3837 RISC-V platforms need to support new RISCV_EFI_BOOT_PROTOCOL to communicate the boot hart ID to the operating system. Add the required header file for this protocol. The specification of the protocol is maintained at:

[edk2-devel] [PATCH 0/5] Add UEFI-SCT test cases for RISCV_EFI_BOOT_PROTOCOL

RISC-V platforms need to support new RISCV_EFI_BOOT_PROTOCOL to communicate the boot hart ID to the OS. This patch series adds the test cases to UEFI SCT for this protocol. The protocol spec is maintained at: https://github.com/riscv-non-isa/riscv-uefi These tests are tested with u-boot and

Re: [edk2-devel] [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp

Do you think maybe creating a CompilerIntrinsicLib.h in MdePkg/Include/Library/ helps people understand how many intrinsic functions are provided for different ARCH? > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, June 9, 2022 2:34 PM > To: Ni, Ray > Cc:

Re: [edk2-devel] Why need to put AP in HLT/MWAIT in ExitBootServices callback

Jiewen, You are right!:) * In the Pentium 4, Intel Xeon, and P6 family processors, when a processor that is designated as an * application processor during an MP initialization sequence is waiting for a startup IPI (SIPI), it is in * a mode where SMIs are masked. However if a SMI is received

Re: [edk2-devel] Why need to put AP in HLT/MWAIT in ExitBootServices callback

I remember a wait-for-SIPI CPU cannot response to SMI. We do want to let AP response SMI to perform some action, because some SMM code will rely on all APs in SMM. Thank you Yao Jiewen > -Original Message- > From: Ni, Ray > Sent: Thursday, June 9, 2022 4:46 PM > To:

[edk2-devel] Why need to put AP in HLT/MWAIT in ExitBootServices callback

All, When I am reviewing today's MpInitLib code, I don't understand why below complex logic is there to put AP in HLT or MWAIT on a ExitBootServices event callback. https://github.com/tianocore/edk2/blob/ff36b2550f94dc5fac838cf298ae5a23cfddf204/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c#L423

Re: [edk2-devel] [PATCH v3 17/28] SecurityPkg: Add Protected Variable Services

On June 9, 2022 2:03 PM, Vang, Judah wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > V3: Change placement of buffer used for confidentiality crypto > operation to fix an issue when enabling confidentiality. Remove > un-needed increment of monotonic counter. > > V1: Add

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Add support for logging to CBMEM console

Reviewed-by: Sean Rhodes On Wed, 8 Jun 2022 at 16:05, Lean Sheng Tan wrote: > Reviewed-by: Lean Sheng Tan > > > > On Mon, 6 Jun 2022 at 02:56, Benjamin Doron > wrote: > >> Writes TianoCore debug logs into the CBMEM console ringbuffer, from >> where the user can retrieve them with the `cbmem`

Re: [edk2-devel] [PATCH v4 4/9] MdePkg/CompilerIntrinsicsLib: move ia32 intrinsics and strcmp

On Thu, Jun 09, 2022 at 03:57:16AM +, Ni, Ray wrote: > Gerd, > I am interested in this patch sets. But I have some trouble to get all the > patches. Do you have a branch that contains all the changes? https://github.com/kraxel/edk2/tree/intrinsics https://github.com/tianocore/edk2/pull/2542

[edk2-devel] [PATCH v3 26/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1

[edk2-devel] [PATCH v3 25/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc

[edk2-devel] [PATCH v3 27/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1

[edk2-devel] [PATCH v3 24/28] OvmfPkg: Add ProtectedVariableLib reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Jiewen Yao Cc: Min Xu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Tom Lendacky Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C

[edk2-devel] [PATCH v3 22/28] EmulatorPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3

[edk2-devel] [PATCH v3 23/28] OvmfPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah

[edk2-devel] [PATCH v3 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib otherwise build fails. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v3 21/28] UefiPayloadPkg: Add ProtectedVariable reference

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib so build is successful. Cc: Jian J Wang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry

[edk2-devel] [PATCH v3 28/28] CryptoPkg: Enable cypto HMAC KDF and AES library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Fix build issue when DiSABLE_SHA1_DEPRECATED_INTERFACES is defined. Percolate the #ifndef DiSABLE_SHA1_DEPRECATED_INTERFACES to all the Sha1 functions. Replace AllocatePool() with AllocatePages() and FreePool() with FreePages() because

[edk2-devel] [PATCH v3 11/28] SecurityPkg: Update RPMC APIs with index

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Update RPMC APIs with index parameter because sometimes there are more than 1 RPMC counter on the platform. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by:

[edk2-devel] [PATCH v3 16/28] SecurityPkg: Add EncryptionVariable lib with AES

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Change AllocateZeroPool() with AllocatePages() and FreePool() with FreePages(). FreePool() is not supported in PEI phase so this was causing a memory leak. Reverse the order of the FreePages() call. V1: Add encryption/decryption of

[edk2-devel] [PATCH v3 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v3 19/28] SecurityPkg: Add references to new *.inf files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add references to the different *ProtectedVariableLib.inf. Also add references to VariableKeyLibNull.inf, EncryptionVariableLibNull.inf, ProtectedVariableNull.inf. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian

[edk2-devel] [PATCH v3 15/28] SecurityPkg: Add VariableKey library function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide function that retrieves the key for protected variables. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v3 12/28] SecurityPkg: Add new variable types and functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new variable encryption/decryption function prototypes. Add new variable digest structure. Add new Protected variable function prototypes. Update RPMC APIs to Add an index because there is could more than one counter. Cc: Jian J Wang

[edk2-devel] [PATCH v3 10/28] SecurityPkg: Add new KeyService types and defines

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Ppi/KeyServicePpi.h | 57

[edk2-devel] [PATCH v3 13/28] SecurityPkg: Fix GetVariableKey API

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v3 14/28] SecurityPkg: Add null encryption variable libs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide null ecryption variable libraries. These will be used by default for platforms that don't support protected variable encryption. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by:

[edk2-devel] [PATCH v3 06/28] MdeModulePkg: Add new include files

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add EncryptionVariableLib.h for providing encryption and decryption services for protected variables. Add ProtectedVariableLib.h for providing integrity or variables. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by:

[edk2-devel] [PATCH v3 02/28] SecurityPkg: Add new GUIDs for

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 The gEdkiiProtectedVariableGlobalGuid HOB contains the global configuration data structure which is verified in PEI Phase. The gEdkiiMetaDataHmacVariableGuid is used for saving the meta data HMAC variable. The

[edk2-devel] [PATCH v3 08/28] MdeModulePkg: Add new Variable functionality

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Update GetNvVariableStore() to call GetVariableFlashNvStorageInfo() and SafeUint64ToUint32(). V1: Provide new APIs for retrieving variable information. Add new function stubs for retrieving Protected variable information. Cc: Jian J

[edk2-devel] [PATCH v3 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v3 07/28] MdeModulePkg: Add Null ProtectedVariable Library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add Null versions of the ProtectedVariable Library. This will be the default libraries for platforms that do not support ProtectedVariable. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by:

[edk2-devel] [PATCH v3 03/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Added NameSize and State to AUTH_VARIABLE_INFO struct. The size of the name and state is needed when creating the variable digest. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C

[edk2-devel] [PATCH v3 01/28] MdeModulePkg: Add new GUID for Variable Store Info

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Discover if Variable Store Info HOB has been published by platform driver. It contains information in regards to HOB or NV Variable Store availability Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang

[edk2-devel] [PATCH v3 04/28] MdeModulePkg: Add reference to new Ppi Guid

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid which contains information whether variable store is available. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry

[edk2-devel] [PATCH v3 00/28] UEFI variable protection

For a more detail description of the UEFI variable protected feature you can view the Readme.md located at the following location: https://github.com/judahvang/edk2/tree/rpmc-update Patch 08 - Update GetNvVariableStore() to call GetVariableFlashNvStorageInfo() and SafeUint64ToUint32(). Patch 09