Re: [edk2-devel] [PATCH] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch are not working with I2C touch panel

2022-07-19 Thread Dandan Bi
Reviewed-by: Dandan Bi -Original Message- From: Thangaraj, KalaiyarasanX Sent: Tuesday, July 19, 2022 5:23 PM To: devel@edk2.groups.io Cc: Thangaraj, KalaiyarasanX ; Bi, Dandan ; Gao, Liming ; Pethaiyan, Madhan ; Esakkithevar, Kathappan ; Balaji, Madhusudhan Subject: [PATCH]

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/19/2022 #cal-reminder

2022-07-19 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 07/19/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly calling for gcc command

2022-07-19 Thread Ni, Ray
Does every cc support dumpversion? thanks, ray From: devel@edk2.groups.io on behalf of Yuwei Chen Sent: Wednesday, July 20, 2022 8:21:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch V2 1/1] BaseTools: remove directly

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add missing FV PCD

2022-07-19 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Monday, July 18, 2022 5:15 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L ; Dong, Eric ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support.

2022-07-19 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, July 19, 2022 10:09 AM To: devel@edk2.groups.io Cc: Zhang, Hongbin1 ; Desimone, Nathaniel L ; Zeng, Star ; Chiu, Chasel Subject: [PATCH v2] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support. From:

[edk2-devel] [Patch V2 1/1] BaseTools: remove directly calling for gcc command

2022-07-19 Thread Yuwei Chen
In some environment, the directly calling for gcc is not supported. This patch fixes the issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/C/DevicePath/GNUmakefile | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [edk2-devel] [PATCH 0/2] Support 64bit FspResetType in X64 build.

2022-07-19 Thread Chiu, Chasel
patch series merged: https://github.com/tianocore/edk2/commit/140446cd595cad870a0e8cef7a367bae8f09effa https://github.com/tianocore/edk2/commit/24eac4caf31afae48349af44588a52783c1819b8 Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 18, 2022 9:42 PM > To:

Re: [edk2-devel] [PATCH v2 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-19 Thread Chiu, Chasel
This patch series has been merged: cfd7e5f231fd644a5cb585d8ab68aa701af6a286 0f836bd4e3e18b9bd0d1a73b849a554519ee82fa Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 18, 2022 5:37 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L >

Re: [edk2-devel][edk2-platforms][PATCH V2 0/2] Add MinPlatformPkg NOOPT build option

2022-07-19 Thread Chiu, Chasel
For this series, Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Tuesday, July 19, 2022 12:43 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Dong, Eric > Subject:

Re: [edk2-devel] [PATCH 0/2] Support 64bit FspResetType in X64 build.

2022-07-19 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 18, 2022 9:42 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH 0/2] Support 64bit FspResetType in X64 build. > > REF:

[edk2-devel] [PATCH] EmulatorPkg/PosixFileSystem: Add NULL check on memory allocation

2022-07-19 Thread Miki Shindo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4001 This commit adds NULL check on memory allocation of the size for FileName in ASCII string format at PosixFileSetInfo(). Signed-off-by: Miki Shindo Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/Unix/Host/PosixFileSystem.c | 2 +- 1 file

Re: [edk2-devel] [PATCH v2 0/2] MinPlatformPkg: FspResetType support for X64 build.

2022-07-19 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Monday, July 18, 2022 5:37 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: [PATCH v2 0/2] MinPlatformPkg:

[edk2-devel] Capturing Stdio of an image loaded using EFI_BOOT_SERVICES.LoadImage()

2022-07-19 Thread Ayush Singh
Hello everyone. So while trying to make Rust `remote-test-server`, I found out that it also needs to be able to launch other UEFI applications (which will be the tests themselves). The Stdout and Stderr of these tests is supposed to be captured and sent back to the `remote-test-client` over

[edk2-devel][edk2-platforms][PATCH V2 2/2] MinPlatformPkg/Build: Reduce duplication

2022-07-19 Thread Oram, Isaac W
Removed needless duplication between sections. Addes spaces after commas. Remove commented out code. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- .../MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 57 +--

[edk2-devel][edk2-platforms][PATCH V2 0/2] Add MinPlatformPkg NOOPT build option

2022-07-19 Thread Oram, Isaac W
V2: Wrap DXE performance library with feature PCD V1: Add the NOOPT build option. Use the same libraries for DEBUG and NOOPT Clean up some duplication and coding style issues with the include files. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram

[edk2-devel][edk2-platforms][PATCH V2 1/2] MinPlatformPkg/Build: Add NOOPT build

2022-07-19 Thread Oram, Isaac W
Add NOOPT build support to enable easy debugging of unoptimized code. Generally the same libraries are desired for DEBUG and NOOPT. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- .../Intel/MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc | 11

Re: [edk2-devel] [PATCH v4 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTP Boot Basic Authentication

2022-07-19 Thread Maciej Rabeda
Change merged. PR: https://github.com/tianocore/edk2/pull/3103 Commit: https://github.com/tianocore/edk2/commit/671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d On 19 lip 2022 17:46, Maciej Rabeda wrote: Thank you for the patch. Reviewed-by: Maciej Rabeda On 19 lip 2022 15:54, Saloni Kasbekar

Re: [edk2-devel] [PATCH v2 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-07-19 Thread Ashraf Ali S
Hi, For the register offset doing the division operation of having a size UINTN in below code, I think we should use DivU64x32 function for Division operation right, correct me if I'm wrong. Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From:

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support.

2022-07-19 Thread Chiu, Chasel
Hi, I have sent V2 to assign ApiIdx to RAX in X64 case to avoid confusion. Please help to review again, Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, July 18, 2022 4:41 PM > To: Pedro Falcato ; edk2-devel-groups-io > > Cc: Chiu, Chasel ; Zhang,

[edk2-devel] [PATCH v2] IntelFsp2Pkg/FspSecCore: Add FSP-I API for SMM support.

2022-07-19 Thread Chiu, Chasel
From: Hongbin1 Zhang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3993 Add FSP-I API entry point for SMM support. Also update 64bit API entry code to assign ApiIdx to RAX to avoid confusion. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Signed-off-by: Hongbin1 Zhang ---

Re: [edk2-devel] [PATCH edk2-platforms v4 00/17] Fix build breaks and update IORT revision macro

2022-07-19 Thread Sami Mujawar
Hi All, The IORT Rev E.d seriesfor edk2 has received the r-b from the respective maintainers. Can the following package maintainers review this series and provide feedback, please? - Silicon/AMD/Styx - Silicon/Socionext/SynQuacer - Platform/LeMaker - Platform/Socionext - Silicon/NXP &

Re: [edk2-devel] [edk2-platforms][PATCH 00/10] Ext4Pkg: Code security and correctness improvements

2022-07-19 Thread Pedro Falcato
For the record, I suggested to Savva (off-list) to squash the patch set into one, for v2. On Tue, Jul 19, 2022 at 1:10 PM Savva Mitrofanov wrote: > Hi all, > > This patchset attempts to improve security of code sections by fixing > integer overflows, > missing aligment checks, unsafe casts.

Re: [edk2-devel][edk2-platforms][PATCH V1 2/2] MinPlatformPkg/Build: Reduce duplication

2022-07-19 Thread Chiu, Chasel
Hi Isaac, Please see my question below inline. Thanks, Chasel > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, June 29, 2022 3:12 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming ; > Dong, Eric > Subject:

Re: [edk2-devel] [PATCH v4 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTP Boot Basic Authentication

2022-07-19 Thread Maciej Rabeda
Thank you for the patch. Reviewed-by: Maciej Rabeda On 19 lip 2022 15:54, Saloni Kasbekar wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2504 Add support for TLS Client Authentication using Basic Authentication for HTTP Boot Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu

[edk2-devel] [PATCH] BaseTools/VolInfo: Show FV section boundaries

2022-07-19 Thread Konstantin Aladyshev
Currently there is no labels for start and end of the EFI_SECTION_FIRMWARE_VOLUME_IMAGE type section. Therefore it is not possible to see where the FV section ends and another section starts. Add labels for start and end of the FV sections to fix the issue. Signed-off-by: Konstantin Aladyshev

Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Create support library

2022-07-19 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. I have some minor updates like removing ssdtpcieosctemplate_aml_code[] from SsdtPcieGenerator.h as it has been moved to SsdtPcieSupportLibPrivate.h, and adding SsdtPcieSupportLib to DynamicTables.dsc.inc so that the Package Dsc build succeeds. Otherwise,

Re: [edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF

2022-07-19 Thread Sami Mujawar
Hi Jeff, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91537): https://edk2.groups.io/g/devel/message/91537 Mute This Topic:

Re: [edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value

2022-07-19 Thread Sami Mujawar
Hi Jeff, Thank you for this fix. This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91536): https://edk2.groups.io/g/devel/message/91536 Mute This Topic:

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

2022-07-19 Thread Jeff Brasen via groups.io
Yes, Universal Flash Storage is based on the SCSI architectural model and installs gEfiExtScsiPassThruProtocolGuid to function. Thanks, Jeff > -Original Message- > From: gaoliming > Sent: Monday, July 18, 2022 7:44 PM > To: devel@edk2.groups.io; Jeff Brasen > Cc:

[edk2-devel] [PATCH 1/1] OvmfPkg/QemuBootOrderLib: add StoreQemuBootOrder()

2022-07-19 Thread Gerd Hoffmann
The function reads the boot order from qemu fw_cfg, translates it into device paths and stores them in 'QemuBootOrder' variables. In case there is no boot ordering configured the function will do nothing. Use case: Allow applications loaded via 'qemu -kernel bootloader.efi' obey the boot

[edk2-devel] [PATCH] BaseTools/GenSec: Fix typo

2022-07-19 Thread Konstantin Aladyshev
Fix typo in the help message. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/C/GenSec/GenSec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/GenSec/GenSec.c b/BaseTools/Source/C/GenSec/GenSec.c index b1d05367ec..35a1ac64ea 100644 ---

[edk2-devel] [PATCH v4 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTP Boot Basic Authentication

2022-07-19 Thread Saloni Kasbekar
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2504 Add support for TLS Client Authentication using Basic Authentication for HTTP Boot Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- MdePkg/Include/IndustryStandard/Http11.h | 8 ++

[edk2-devel] [PATCH 1/1] OvmfPkg/XenPvBlkDxe: Fix memory barrier macro

2022-07-19 Thread Anthony PERARD via groups.io
From: Anthony PERARD The macro "xen_mb()" needs to be a full memory barrier, that is it needs to also prevent stores from been reorder after loads which an x86 CPU can do (as I understand from reading [1]). So this patch makes use of "mfence" instruction. Currently, there's a good chance that

[edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool

2022-07-19 Thread Konstantin Aladyshev
If the guided section was encoded with GenCrc32 tool the resulting 'EFI_GUID_DEFINED_SECTION.DataOffset' field points to the start of the meaningfull data that follows the CRC32 value. But if we want to decode the section with GenCrc32 tool we need to provide a buffer that includes the CRC32 value

[edk2-devel] [PATCH v2] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

2022-07-19 Thread Konstantin Aladyshev
Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. The same mistake is present in the parsing of CRC32 guided section case. Use correct arguments to fix the

[edk2-devel] [PATCH v2] BaseTools/VolInfo: Show encapsulation sections

2022-07-19 Thread Konstantin Aladyshev
Currently there is no labels for start and end of the encapsulation sections. Therefore it is not possible to see where the encapsulation section ends and another section starts. Add labels for start and end of encapsulation sections to fix the issue. Signed-off-by: Konstantin Aladyshev ---

[edk2-devel] [PATCH] BaseTools/VolInfo: Show encapsulation sections

2022-07-19 Thread Konstantin Aladyshev
Currently there is no labels for start and end of the encapsulation sections. Therefore it is not possible to see where the encapsulation section ends and another section starts. Add labels for start and end of encapsulation sections to fix the issue. Signed-off-by: Konstantin Aladyshev ---

[edk2-devel] [PATCH] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing

2022-07-19 Thread Konstantin Aladyshev
Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. Use correct arguments to fix the issue. Signed-off-by: Konstantin Aladyshev ---

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran
Upstreamed through commit :  https://github.com/tianocore/edk2-test/commit/4a25c3b3c79f63bd9f98b4fffcb21b5c66dd14bb -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91525): https://edk2.groups.io/g/devel/message/91525 Mute This Topic:

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Don't always check PixelInformation

2022-07-19 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91524): https://edk2.groups.io/g/devel/message/91524 Mute This Topic: https://groups.io/mt/92068027/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 01/10] UefiCpuPkg: Create CpuPageTableLib for manipulating X86 paging structs

2022-07-19 Thread Ni, Ray
It has been in my todo list for years. I wish this lib could be created earlier so that existing duplicated page table manipulation logics could be avoided. The Map() supports different PagingModes (4Level, 4Level1G, 5Level, 5Level1G). It creates big page entry as the PagingMode allows (e.g.:

[edk2-devel] [PATCH v2 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume the new SerialPortLib

2022-07-19 Thread kavya
Let DxeMain.inf consume new SerialPortLib to support multiple channel debug message on early DXE. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Kavya --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v2 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-07-19 Thread kavya
Add new Serial port library instance that consumes the HOB defined in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support multiple UART's. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Kavya ---