[edk2-devel] [PATCH v4 2/2] UefiPayloadPkg: Allow DxeMain.inf to consume the new SerialPortLib

2022-07-25 Thread kavya
Let DxeMain.inf consume new SerialPortLib to support multiple channel debug message on early DXE. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg

[edk2-devel] [PATCH v4 1/2] UefiPayloadPkg: Implement a new SerialPortLib instance

2022-07-25 Thread kavya
Add new Serial port library instance that consumes the HOB defined in MdeModulePkg/Include/UniversalPayload/SerialPortInfo.h to support multiple UART's. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/Library/BaseSerialPortLibHob/BaseSerialPortLibH

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Ayush Singh
Hi Andrew. Thanks for all your work. The more I look at this, the more it feels like it might be a problem on the LLVM side instead of Rust. I also found some more tests (all related to numbers btw) which can cause different types of exceptions, so I think I will try filing bugs upstream. Your

Re: [edk2-devel] [edk2-staging][PATCH v2 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Comment in-line. You can search [Chang, Abner] for the comment. > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2

Re: [edk2-devel] [edk2-staging][PATCH v2 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Comment in line. > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 04/15] edk2-staging/RedfishClientPkg: > Introd

Re: [edk2-devel] [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg:

Re: [edk2-devel] [edk2-staging][PATCH v2 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 02/15] edk2-staging/RedfishClientPkg:

Re: [edk2-devel] [edk2-staging][PATCH v2 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 01/15] edk2-staging/RedfishClientPkg:

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/26/2022 #cal-reminder

2022-07-25 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 07/26/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77

Re: [edk2-devel] [PATCH v4 05/21] MdePkg/TrngLib: Definition for TRNG library class interface

2022-07-25 Thread Yao, Jiewen
Hi Please allow me to clarify the position of this library class. In this library header file, there are 4 references: - [1] Arm True Random Number Generator Firmware, Interface 1.0, Platform Design Document. (https://developer.arm.com/documentation/den0098/latest/) - [2] NIST

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 07/25/2022 #cal-notice

2022-07-25 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 07/25/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1542977 ) *Description:* TianoCore community, Micros

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to support selection of CryptoDxe driver

2022-07-25 Thread Hsieh, PaytonX
PR create : https://github.com/tianocore/edk2/pull/3138 -Original Message- From: Dong, Guo Sent: Monday, July 25, 2022 11:29 PM To: Hsieh, PaytonX ; devel@edk2.groups.io Cc: Ni, Ray ; Lu, James ; Guo, Gua Subject: RE: [PATCH] UefiPayloadPkg: Add macro to support selection of CryptoDxe

Re: [edk2-devel] [Patch v3 3/3] Maintainers.txt: Remove reviewer Harry Han

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Harry Han > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > Reviewed-by: Harry Han > --- > Maintainers.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Maintainer

Re: [edk2-devel] [Patch v3 0/3] Update Maintainers.txt

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Daniel Schaefer > Cc: Sean Rhodes > Cc: Debkumar De > Cc: Erdem Aktas > Cc: Harry Han > Cc: Gary Lin > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
I guess I could at least dump to the end (req)…. Going backwards is a bit painful in x86. (lldb) dis -s 0x000140001B60 -b -c 30 hello_world_std.efi[0x140001b60]: 48 8b 09 movq (%rcx), %rcx hello_world_std.efi[0x140001b63]: 48 01 c1 addq %rax,

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
Ops… Looks like your PE/COFF is linked at 0x00014000, so 0x140001b60 is the interesting bit. (lldb) dis -s 0x000140001B60 -b hello_world_std.efi[0x140001b60]: 48 8b 09 movq (%rcx), %rcx hello_world_std.efi[0x140001b63]: 48 01 c1 addq %r

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
Ayush, CR2 is the fault address so 0x. Given for EFI Virt == Physical the fault address looks like a bad pointer. Sorry I’ve not used VC++ in a long time so I don’t know how to debug with VC++, but If I was using clang/lldb I’d look at the source and assembly for the fault add

[edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Ayush Singh
Hello everyone.While running Rust tests in UEFI environment, I have come across a numeric test that causes a pagefault. A simple reproducible example for this is given below: ```rust fn main() {     use std::hint::black_box as b;     let z: i128 = b(1);     assert!((-z as f64) < 0.0); } ```

[edk2-devel] [PATCH v1 3/3] LogoFeaturePkg,BoardModulePkg: Set existing logo as BGRT

2022-07-25 Thread Benjamin Doron
In MinPlatform, FSP-S displays the logo to the user early. However, this means that no BGRT is written either. To reduce duplication in the flash image, a new LogoDxe will set this BMP as the BGRT buffer. The previous LogoDxe drivers here, along with a BootLogoEnableLogo() patch to BDS libraries, w

[edk2-devel] [PATCH v1 2/3] UserAuthFeaturePkg: Included DXE versions are mutually exclusive

2022-07-25 Thread Benjamin Doron
Versions of the DXE module perform nearly identical functions, and are therefore mutually exclusive. Including both modules results in at least a duplicate HII package and an "already started" assert. Therefore, add a new PCD to determine which module will be included. However, now a second bug ca

[edk2-devel] [PATCH v1 1/3] AcpiDebugFeaturePkg: Included modules are mutually exclusive

2022-07-25 Thread Benjamin Doron
The DXE and SMM versions of AcpiDebug perform the same task and are therefore mutually exclusive. Including both modules results in a duplicate ACPI table, resulting in the feature not working at all. Therefore, add a new PCD to determine which module will be included. Now, either version successf

Re: [edk2-devel] [PATCH v2] BaseTools/VolInfo: Show encapsulation sections

2022-07-25 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Konstantin Aladyshev Sent: Tuesday, July 19, 2022 8:29 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Konstantin Aladyshev Subject: [PATCH v2] BaseTools/VolInfo: Show encapsulation sections Currently there

[edk2-devel] [PATCH] BaseTools/GenFds: Correct file type set for the PIC section

2022-07-25 Thread Konstantin Aladyshev
Corrently the set of file types for the PIC section contains two duplicate values. Replace the duplicate value with the correct one to fix the issue. Signed-off-by: Konstantin Aladyshev --- BaseTools/Source/Python/GenFds/FdfParser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[edk2-devel] [PATCH v4] BaseTools/Capsule: Support signtool input subject name to sign capsule file

2022-07-25 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to support selection of CryptoDxe driver

2022-07-25 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Hsieh, PaytonX Sent: Friday, July 22, 2022 12:02 AM To: devel@edk2.groups.io Cc: Hsieh, PaytonX ; Dong, Guo ; Ni, Ray ; Lu, James ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Add macro to support selection of CryptoDxe driver From: Pa

[edk2-devel] [PATCH v4] BaseTools/Capsule: Support signtool input subject name to sign capsule file

2022-07-25 Thread Lin, Jason1
From: Jason1 Lin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3928 Windows-based system using signtool.exe to sign the capsule. Add the support to using "--subject-name" argument to assign the subject name used to sign the capsule file. This argument would pass to signtool.exe as a part o

Re: [edk2-devel] [PATCH v3] BaseTools/Capsule: Add support for signtool to input subject name to sign capsule file

2022-07-25 Thread Bob Feng
Created the PR for merge. https://github.com/tianocore/edk2/pull/3137 -Original Message- From: gaoliming Sent: Monday, July 25, 2022 12:27 PM To: devel@edk2.groups.io; Lin, Jason1 Cc: Feng, Bob C ; Chen, Christine ; Kinney, Michael D ; Chiang, Dakota Subject: 回复: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-25 Thread Rohit Mathew
Hi Sami/Thanu, Please find my response inline - On Mon, Jul 25, 2022 at 02:54 PM, Thanu Rangarajan wrote: > > > > Hi Rohit, > > > > The decision to use the SBSA defined HID for the Generic UART was taken > after extensive discussions within the Arm ecosystem. And as Sami points > out, no

Re: [edk2-devel] [edk2-staging][PATCH v2 2/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBiosDxe driver

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ray Ni ; Chang, > Abner ; Yang, Atom ; > Nick Ramirez > Subject: [edk2-staging][PATCH v2 2/2] edk2-st

Re: [edk2-devel] [edk2-staging][PATCH v2 1/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBootDxe driver

2022-07-25 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ray Ni ; Chang, > Abner ; Yang, Atom ; > Nick Ramirez > Subject: [edk2-staging][PATCH v2 1/2] edk2-st

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-25 Thread Thanu Rangarajan
Hi Rohit, The decision to use the SBSA defined HID for the Generic UART was taken after extensive discussions within the Arm ecosystem. And as Sami points out, now that formal Linux driver support for this HID is available, it would be good if it is used by other components in the stack as well.

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Enhance bus scan for all root bridge instances

2022-07-25 Thread Nong, Foster
Hi Mike, Yes. With this chance, each root bridge will have the bus resource size except the one which Meet the bus shortage case. Then the Bus Rebalance handle of EfiPciHostBridgeEndBusAllocation on platform BIOS will Have a chance to adjust the bus resource assignment for each root bridges w

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-07-25 Thread Sami Mujawar
Hi Rebecca, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 21/07/2022 05:23 pm, Sami Mujawar via groups.io wrote: Hi Rebecca, Ard, On Tue, May 3, 2022 at 12:43 AM, Ard Biesheuvel wrote: // Data Cache enabled on Primary core when MMU is enabled. ArmDisableDataCache ();

Re: [edk2-devel] [edk2][PATCH V4 1/1] ArmPlatformPkg/PrePeiCore: Invoke constructors for SEC phase

2022-07-25 Thread Sami Mujawar
Hi Rohit, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/07/2022 06:02 pm, Rohit Mathew wrote: On platforms that do not have the serial console port pre-initialized prior to the SEC phase and due to the absence of a call to "SerialPortInitialize", this re

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

2022-07-25 Thread Sami Mujawar
Hi Rohit, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 22/07/2022 01:46 pm, Rohit Mathew wrote: Hi Sami, Thank you for the review. Regarding the use of Dynamic Tables Framework, there are no short term plans to migrate to it. Please find my response for your commen