[edk2-devel] [edk2-platforms: PATCH] Modify processor _UID ordering by CPU default fused in MADT

2022-07-26 Thread JackX Lin
BIOS should not reordering cpu processor_uid Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Dong Eric Cc: Jiewen Yao Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Donald Kuo Cc: Chandana C Kumar Cc: JackX Lin --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 14 +- 1

Re: [edk2-devel] [edk2-staging][PATCH v2 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-26 Thread Nickle Wang
Thanks Abner! Review comments for 04/15 and 05/15 are addressed in version 3. Nickle -Original Message- From: Chang, Abner Sent: Tuesday, July 26, 2022 10:04 AM To: Wang, Nickle (Server BIOS) ; devel@edk2.groups.io Cc: Yang, Atom ; Nick Ramirez Subject: RE: [edk2-staging][PATCH v2 05/1

[edk2-devel] [edk2-staging][PATCH v3 15/15] edk2-staging/RedfishClientPkg: Introduce Bios feature driver

2022-07-26 Thread Nickle Wang
Introduce new feature driver to support Bios version 1.0.9 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 741 .../Featu

[edk2-devel] [edk2-staging][PATCH v3 14/15] edk2-staging/RedfishClientPkg: Introduce Computer System feature driver

2022-07-26 Thread Nickle Wang
Introduce new feature driver to support Computer System version 1.5.0 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1_5_0/Common/ComputerSystemCommon.c | 1614 +++

[edk2-devel] [edk2-staging][PATCH v3 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver

2022-07-26 Thread Nickle Wang
Introduce new feature driver to support Computer System Collection schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.c | 667 ++

[edk2-devel] [edk2-staging][PATCH v3 12/15] edk2-staging/RedfishClientPkg: Rename Memory feature driver

2022-07-26 Thread Nickle Wang
Rename Memory driver by removing Redfish prefix. Update memory feature driver and support all properties under Memory schema. Also support "Identify" action in this driver. Corresponding changes are made to honor newly introduced library and protocol. Signed-off-by: Nickle Wang Cc: Abner Chang C

[edk2-devel] [edk2-staging][PATCH v3 11/15] edk2-staging/RedfishClientPkg: Rename RedfishMemoryCollection driver

2022-07-26 Thread Nickle Wang
Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update memory collection driver to support "Identify" action and also have code refactoring to support Redfish operation. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../MemoryCollectionDxe.c}

[edk2-devel] [edk2-staging][PATCH v3 09/15] edk2-staging/RedfishClientPkg: Update RedfishLib

2022-07-26 Thread Nickle Wang
RedfishLib has no capability to return HTTP header in response. However, feature driver needs to know the information like "ETag" or "Location" in HTTP response header per Redfish specification. Add corresponding function to return HTTP header in response data. Signed-off-by: Nickle Wang Cc: Abne

[edk2-devel] [edk2-staging][PATCH v3 08/15] edk2-staging/RedfishClientPkg: Update Redfish feature core driver

2022-07-26 Thread Nickle Wang
Update Redfish feature core driver to support Redfish resource with multiple parents. A resource may be presented in different resource and the link in different resource point to the same location. Also add interchange data interface in feature core driver so feature core driver can talk to featur

[edk2-devel] [edk2-staging][PATCH v3 07/15] edk2-staging/RedfishClientPkg: Update ETag driver

2022-07-26 Thread Nickle Wang
Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec| 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +- RedfishCli

[edk2-devel] [edk2-staging][PATCH v3 06/15] edk2-staging/RedfishClientPkg: Introduce RedfishConfigLangMap driver

2022-07-26 Thread Nickle Wang
Introduce Redfish configure language map driver. This driver keeps the mapping between configure language and Redfish URI for internal use. This saves the communication time between feature drivers and Redfish service. It also provides the history records so that feature drivers can do provisioning

[edk2-devel] [edk2-staging][PATCH v3 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-26 Thread Nickle Wang
Add EdkIIRedfishResourceConfigLib in order to work with Redfish Config Protocol and do the communication between each feature drivers. Also introduce Redfish interchange data protocol to exchange data efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .

[edk2-devel] [edk2-staging][PATCH v3 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-26 Thread Nickle Wang
Introduce resource identify library which works with resource config protocol to identify Redfish resource. This library provides the flexibility for platform to implement its own policy and identify resource. Two library implementation are provided as demonstration code. NULL version of library ac

[edk2-devel] [edk2-staging][PATCH v3 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-26 Thread Nickle Wang
Update Redfish resource config protocol to support Identify action in order to identify remote resource and see if this is resource belongs to current owner or not. Use unicode string instead of ASCII string for all interfaces to align with HTTP interface. Signed-off-by: Nickle Wang Cc: Abner Cha

[edk2-devel] [edk2-staging][PATCH v3 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-26 Thread Nickle Wang
Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Library/RedfishVers

[edk2-devel] [edk2-staging][PATCH v3 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-26 Thread Nickle Wang
Add RedfishEventLib to handle Redfish event. There are two events defined in this library. One is the event before feature driver provisioning and the other one is the event after all provisioning is finished. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../I

[edk2-devel] [edk2-staging][PATCH v3 00/15] Update RedfishClientpkg

2022-07-26 Thread Nickle Wang
In this series of patch files, additional three feature drivers are enabled. Corresponding libraries and protocols are introduced to help performing Redfish operation like provisioning, consuming and updating Redfish resource between UEFI HII driver and Redfish service hosted at BMC side. Nickle

Re: [edk2-devel] [Patch 0/2] Remove MptScsi and PvScsi reviewers

2022-07-26 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, July 27, 2022 3:47 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm > ; Ard Biesheuvel ; > Yao, Jiewen ; Justen, Jordan L > ; Gerd Hoffmann > Subject: [Patch 0/2] Remove MptScsi and

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/26/2022 #cal-reminder

2022-07-26 Thread gaoliming via groups.io
Few issues are reported this week. Let’s cancel the meeting. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2022年7月26日 9:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/26/2022 #cal-reminder Reminder: TianoCore Bug Triag

[edk2-devel] Recent change in edk2 causing problems with USB, SD and MMC devices

2022-07-26 Thread Sean Rhodes
Hi All For a large number of boards running coreboot (reported on CML, TGL, ADL, SKL and APL), a change in the last few months has caused an indefinite hang. For the last three years, coreboot has used a default value of 1000 for gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue, but to

Re: [edk2-devel] [Patch 0/2] Remove MptScsi and PvScsi reviewers

2022-07-26 Thread Ard Biesheuvel
On Tue, 26 Jul 2022 at 12:46, Michael D Kinney wrote: > > The email addresses for the reviewers of the MptScsi and > PvScsi in the OvmfPkg are no longer valid. Remove the > reviewers for the MptScsi and PvScsi drivers until new > maintainers/reviewers can be identified. > > Cc: Andrew Fish > Cc:

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/XenHypercallLib: Fix naming of AArch64

2022-07-26 Thread Ard Biesheuvel
On Tue, 26 Jul 2022 at 12:30, Kinney, Michael D wrote: > > Reviewed-by: Michael D Kinney > Acked-by: Ard Biesheuvel > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Anthony > > PERARD via groups.io > > Sent: Wednesday, July 20, 2022 6:17 AM > > To: devel@edk2.groups

[edk2-devel] [Patch 2/2] Maintainers.txt: Remove MptScsi and PvScsi reviewers

2022-07-26 Thread Michael D Kinney
The email addresses for the reviewers of the MptScsi and PvScsi in the OvmfPkg are no longer valid. Remove the reviewers for the MptScsi and PvScsi drivers until new maintainers/reviewers can be identified. Cc: Andrew Fish Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen

[edk2-devel] [Patch 0/2] Remove MptScsi and PvScsi reviewers

2022-07-26 Thread Michael D Kinney
The email addresses for the reviewers of the MptScsi and PvScsi in the OvmfPkg are no longer valid. Remove the reviewers for the MptScsi and PvScsi drivers until new maintainers/reviewers can be identified. Cc: Andrew Fish Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen

[edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-07-26 Thread Michael D Kinney
The email addresses for the reviewers of the MptScsi and PvScsi are no longer valid. Disable the MptScsi and PvScsi drivers in all DSC files until new maintainers/reviewers can be identified. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Sebastien Boeuf Cc: Brijes

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/XenHypercallLib: Fix naming of AArch64

2022-07-26 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Anthony PERARD > via groups.io > Sent: Wednesday, July 20, 2022 6:17 AM > To: devel@edk2.groups.io > Cc: Anthony PERARD ; Ard Biesheuvel > ; Yao, Jiewen > ; Justen, Jordan L ; Gerd > Hoffmann

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-26 Thread Ayush Singh
When I mentioned upstream, I was talking about Rust repository, since as you said, I am not sure if this is LLVM problem yet. There is already a similar bug filed in rust repo about u128 division causing exception [1], and there is a possible fix [2] (which does not work for the page fault). I

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-26 Thread Pedro Falcato
Fyi, please don't file bugs upstream just now. You're not sure if they're LLVM problems (and they're likely not, else they would affect everyone else, not just UEFI code). Try to get a simpler, reliable repro (and do share with us!) before saying it's an LLVM bug. In my experience, most "what the h

Re: [edk2-devel] Confirm your kevin.p.ngu...@intel.com email address

2022-07-26 Thread Nguyen, Kevin P
Please allow to join the group. Best regards, Kevin P Nguyen From: Groups.io Notification Sent: Tuesday, July 26, 2022 11:14 AM To: Nguyen, Kevin P Subject: [edk2-devel] Confirm your kevin.p.ngu...@intel.com email address Hello, Thank you for your interest in the https://edk2.groups.io/g/d

[edk2-devel] [PATCH 1/1] AsfPkg: Add Alert standard format support

2022-07-26 Thread CrystalLee [李怡萱] via groups . io
Alert Standard format specification(DSP0136) REF:https://www.dmtf.org/sites/default/files/standards/documents/DSP0136.pdf Send standard alert message base on the status code reported by drivers. Report Asf configuration and capabilities in Asf ACPI table More information: I'm not sure which packa

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-26 Thread Andrew Fish via groups.io
> On Jul 25, 2022, at 10:43 PM, Ayush Singh wrote: > > Hi Andrew. Thanks for all your work. The more I look at this, the more it > feels like it might be a problem on the LLVM side instead of Rust. I also > found some more tests (all related to numbers btw) which can cause different > types of

Re: [edk2-devel] [Patch v3 2/3] Maintainers.txt: Add missing github ids

2022-07-26 Thread Julien Grall
On 21/07/2022 22:07, Michael D Kinney wrote: Cc: Andrew Fish Cc: Leif Lindholm Cc: Daniel Schaefer Cc: Sean Rhodes Cc: Debkumar De Cc: Erdem Aktas Cc: Gary Lin Cc: Julien Grall Signed-off-by: Michael D Kinney Reviewed-by: Daniel Schaefer Reviewed-by: Sean Rhodes Reviewed-by: Debkuma

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Sami Mujawar
Hi Oliver, Both your and Rebecca’s patches are using SerialPortWrite() which should work regardless of the debug print level and for release builds as well. Rebecca’s patch additionally initialises the serial port which is required if the UART has not been setup by any previous firmware. I belie

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Oliver Steffen
Hi Sami, Thank you for pointing to that patch. It pretty much does the same thing and I would be OK with using it instead of these changes here. Except that the message only shows up in debug mode and seems to depend on the debug mask. It would be nice if it would show up all the time. We are bui

Re: [edk2-devel] Question about signed uefi vars at OS level

2022-07-26 Thread James Bottomley
On Tue, 2022-07-26 at 10:09 -0300, Rafael Machado wrote: > Hey everyone > > I have a question for the experts. > > Suppose I have a BIOS feature that can be set from the OS via some OS > application (.exe) that calls the runtime services set variable (). > > To set this feature I have a UEFI var

[edk2-devel] Question about signed uefi vars at OS level

2022-07-26 Thread Rafael Machado
Hey everyone I have a question for the experts. Suppose I have a BIOS feature that can be set from the OS via some OS application (.exe) that calls the runtime services set variable (). To set this feature I have a UEFI var, that during DXE is processed by some uefi module. In case I define thi

[edk2-devel] Capsule update with USBIO in FmpDxe.

2022-07-26 Thread gordontcp
Hi all, In \FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c There are comments for RegisterFmpInstaller: /** Used to pass the FMP install function to this lib. This allows the library to have control of the handle that the FMP instance is installed on. This allows the library to use Driv

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Sami Mujawar
Hi Oliver, There is a patch for review at https://edk2.groups.io/g/devel/message/4 which prints the firmware version string. I believe with Ard's comments addressed that patch can be merged. Would that patch solve your purpose to print an early message for debug purpose? Regards, Sami Muja

Re: [edk2-devel] ‘EmbeddedDrivers’ option in Capsule file.

2022-07-26 Thread gordontcp
Hi Michael, Thanks for your reply. A few more questions please: 1. In general, not in the Minnowboard environment, but in the Microsoft Windows environment, are EmbeddedDrivers usually specified? 2. Should the ‘EmbeddedDrivers’ parameter be assigned to ‘FmpDxe.efi’? or assigned to ‘SystemFirmwar

Re: [edk2-devel] [PATCH v4 05/21] MdePkg/TrngLib: Definition for TRNG library class interface

2022-07-26 Thread PierreGondois
Hello Jiewen, On 7/26/22 03:11, Yao, Jiewen wrote: Hi Please allow me to clarify the position of this library class. In this library header file, there are 4 references: - [1] Arm True Random Number Generator Firmware, Interface 1.0, Platform Design Document. (https://deve

[edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

2022-07-26 Thread Sean Rhodes
When set to true, the Logo is positioned according to the BGRT specification, 38.2% from the top of the screen. When set to false, no behaviour is changed and the logo is positioned centrally. Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModuleP

[edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow BGRT specification

2022-07-26 Thread Sean Rhodes
Add an option to position the logo 38.2% from the top of the screen, which follows the BGRT specification. Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- MdeModulePkg/Library/BootLogoLib/BootLog

[edk2-devel] [PATCH 3/3] UefiPayloadPkg: Hook up FOLLOW_BGRT_SPEC macro

2022-07-26 Thread Sean Rhodes
Hook up FOLLOW_BGRT_SPEC macro to PcdFollowBGRTSpecification. Cc: Guo Dong Cc: Ray Ni Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc index 862d440b16..

[edk2-devel] [PATCH 3/3] ArmVirtPkg: set early hello message

2022-07-26 Thread Oliver Steffen
From: Laszlo Ersek Set the text for the early hello message in ArmVirtPkg. This prints a friendly banner on QEMU, regardless of debug mask settings. Signed-off-by: Laszlo Ersek Signed-off-by: Oliver Steffen --- ArmVirtPkg/ArmVirtQemu.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Arm

[edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Oliver Steffen
From: Laszlo Ersek Print the early hello message to the serial port. The FixedPcdGetSize() macro expands to an integer constant, therefore an optimizing compiler can eliminate the new code, if the platform DSC doesn't override the empty string (size=1) default of PcdEarlyHelloMessage. Signed-of

[edk2-devel] [PATCH 1/3] ArmPlatformPkg: introduce fixed PCD for early hello message

2022-07-26 Thread Oliver Steffen
From: Laszlo Ersek Add a PCD for defining a hello message that gets printed to the serial port very early in the boot process, regardless of debug masks. This is useful for debugging boot problems (especially in virtual machines) and informs interactive users that the firmware is running. If a p

[edk2-devel] [PATCH 0/3] ArmPlatformPkg, ArmVirtPkg: Add early hello message

2022-07-26 Thread Oliver Steffen
Add the ability to print an early hello message independent of debug mask to the serial port when the firmware starts. Introduce a PCD entry to set the message text (ArmPlatformPkg). If the message text is empty (default) then nothing is printed. The message is useful for debugging boot problems