Re: [edk2-devel] [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier

On Tue, 2 Aug 2022 at 20:04, wrote: > > From: Michael Kubacki > > These debug messages are repeated in both NorFlashBlockIoReadBlocks() > and NorFlashBlockIoWriteBlocks(): > > "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x" > "bytes (%d kB), BufferPtr @ 0x%08x)\n" > > Alth

Re: [edk2-devel] [PATCH V2 3/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib

On Sun, 26 Jun 2022 at 05:06, Min Xu wrote: > > From: Min M Xu > > AllocateRuntimePages is used to allocate one or more 4KB pages of > type EfiRuntimeServicesData. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Gerd Hoffmann > Signed-off-by: Min Xu

[edk2-devel] [PATCH] Add support for SMBIOS Spec 3.6.0 to SmBios.h

Updated SmBios.h with new fields added as part of SMBIOS 3.6.0 spec update. Signed-off-by: Sainadh Nagolu CC: Vasudevan Sambandan CC: Sundaresan S --- MdePkg/Include/IndustryStandard/SmBios.h | 88 1 file changed, 61 insertions(+), 27 deletions(-) diff --git a/MdePk

Re: [edk2-devel] [PATCH V2 3/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib

Hi, Leif/Ard/Abner/Daniel Since you're maintainers/reviewers of EmbeddedPkg. Do you have any comments to this patch? The same reminder mail has been sent out two weeks ago but no response is received. Or anyone else can comment on this patch? Thanks much! Min > -Original Message- > Fro

Re: [edk2-devel] [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

Reviewed-by: Dandan Bi mailto:dandan...@intel.com>> Thanks, Dandan From: Balaji, Madhusudhan Sent: Wednesday, August 3, 2022 1:02 AM To: Thangaraj, KalaiyarasanX ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Pethaiyan, Madhan ; Esakkithevar, Kathappan ; Balaji, Madhusudhan Subject:

[edk2-devel] Updated Event: Tools, CI, Code base construction meeting series #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros

For changes in: MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, August 3, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Bi

Re: [edk2-devel] [PATCH v1 4/5] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, August 3, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > > Subject: [PATCH v1 4/5] RedfishPkg/RedfishRestExDxe: Remove ext

Re: [edk2-devel] [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier

Reviewed-by: Jiewen Yao > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, August 3, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul R > Subject: [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add m

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Add missing Github IDs for OvmfPkg TPM/TGC modules

Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, July 28, 2022 9:31 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Gerd > Hoffmann ; Marc-André Lureau > ; Stefan Berger > Subject: [Patch 1/1] Maintainers.tx

[edk2-devel] [edk2-platforms][PATCH v3 2/6] U5SeriesPkg: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve U5SeriesPkg platforms build. Cc: Abner Chang Cc: Gilbert Chen Cc: Daniel Schaefer Signed-off-by: Kun Qin --- Notes: v2:

[edk2-devel] [edk2-platforms][PATCH v3 5/6] AmpereAltraPkg: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve AmpereAltraPkg platforms build. Cc: Nhi Pham Cc: Vu Nguyen Cc: Thang Nguyen Cc: Chuong Tran Cc: Leif Lindholm Signed-off-by

[edk2-devel] [edk2-platforms][PATCH v3 6/6] PhytiumCommonPkg: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve PhytiumCommonPkg platforms build. Cc: Leif Lindholm Cc: Peng Xie Cc: Ling Jia Cc: Yiqi Shu Signed-off-by: Kun Qin Reviewed-

[edk2-devel] [edk2-platforms][PATCH v3 4/6] Socionext: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve DeveloperBox platforms build. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Masami Hiramatsu Signed-off-by: Kun Qin --- Notes:

[edk2-devel] [edk2-platforms][PATCH v3 3/6] VExpressPkg: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve ArmVExpress platforms build. Cc: Ard Biesheuvel Cc: Thomas Abraham Cc: Sami Mujawar Signed-off-by: Kun Qin Reviewed-by: Sami

[edk2-devel] [edk2-platforms][PATCH v3 0/6] Resolving SecureBootVariableLib dependency

This v2 series is a follow up of previously submitted patches: https://edk2.groups.io/g/devel/message/91669 The main update in v3 patches are: - Updated a commit message to include Review-by tag - Dumped a commit for Qemu platform as it was fixed by others Patch v3 branch:https://github.com/kuqin

[edk2-devel] [edk2-platforms][PATCH v3 1/6] RaspberryPi: Pipeline: Resolving newly introduced dependency

The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from SecurityPkg to resolve RaspberryPi platforms build. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Jeremy Linton Signed-off-by: Kun Qin Reviewed-by: Jere

Re: [edk2-devel] [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

- Reviewed-by:Balaji, Madhusudhan madhusudhan.bal...@intel.com -- From: Thangaraj, KalaiyarasanX Sent: Tuesday, August 2, 2022 2:49 PM To: devel@edk2.groups.io Cc: Thangaraj, KalaiyarasanX ; Bi, Dandan ; Gao, Liming ; Pethaiyan, Madhan

[edk2-devel] [PATCH] Changes to support SNI feature in CryptoPkg

--- CryptoPkg/Library/TlsLib/TlsConfig.c | 71 1 file changed, 71 insertions(+) diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c b/CryptoPkg/Library/TlsLib/TlsConfig.c index 0673c9d532..aac1a88edf 100644 --- a/CryptoPkg/Library/TlsLib/TlsConfig.c +++ b/CryptoPkg/Lib

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable Boot Logo

Add a macro called BOOTSPLASH_IMAGE, which when enabled, will display a logo at boot time. Cc: Guo Dong Cc: Ray Ni Signed-off-by: Sean Rhodes --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 9 + .../PlatformBootManagerLib/PlatformBootManagerLib.inf| 1 + UefiPayloadP

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Load Boot Logo into ACPI table

If the boot logo is enabled, this will allow edk2 to pass the logo to the OS via ACPI. Cc: Guo Dong Cc: Ray Ni Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 10 ++ UefiPayloadPkg/UefiPayloadPkg.fdf | 4 2 files changed, 14 insertions(+) diff --git a/UefiPayl

[edk2-devel] [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier

From: Michael Kubacki The debug macro modified in this change was missing a print specifier for a debug message argument given. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Michael Kubacki --- SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPrese

[edk2-devel] [PATCH v1 4/5] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument

From: Michael Kubacki The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki --- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- 1 file chang

[edk2-devel] [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros

From: Michael Kubacki Updates debug macros in the package that have an imbalanced number of print specifiers to arguments. These changes try to preserve what was likely intended by the author. In cases information was missing due to the bug, the specifier may be removed since it was not previousl

[edk2-devel] [PATCH v1 2/5] FatPkg/FatPei: Remove extraneous debug message argument

From: Michael Kubacki This debug macro should take one argument based on the number of print specifiers defined. However, two arguments are given. It looks like the code may have been refactored such that the second argument was moved to a new print and this argument was not removed. In any case

[edk2-devel] [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier

From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. T

[edk2-devel] [PATCH v1 0/5] Fix imbalanced debug macros

From: Michael Kubacki After noticing a few occurrences of DEBUG macros with a mismatched number of arguments, I wrote a script to automatically detect this. This patch series is the result of matches found by the script. I would like to eventually check the script in as a build plugin but that

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu

On Tue, 2 Aug 2022 at 16:22, Dimitrije Pavlov wrote: > > Commit 6eb407947592e084110a124be089bef167af1383 added a new dependency > of PlatformPKProtectionLib to SecureBootVariableLib. This causes the > build of SbsaQemu to fail. > > Add the PlatformPKProtectionLib library instance to SbsaQemu.dsc >

Re: [edk2-devel] [PATCH] ArmVirtPkg: Fix KVM Guest Firmware

On Tue, 2 Aug 2022 at 18:28, Edward Pickup wrote: > > Fix build of KVM Guest Firmware, broken by commit > 4c55f6394fafe0494ec24e7c05cb68c938d7852d > > Signed-off-by: Edward Pickup Thanks for the fix. Merged as #3169 > --- > > The change can be seen at > https://github.com/edpickup/edk2/tree/23

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

On Tue, 2 Aug 2022 at 17:32, Jeff Brasen wrote: > > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Friday, July 29, 2022 9:48 AM > > To: Jeff Brasen > > Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com; > > quic_llind...@quicinc.com; ardb+tianoc...@kernel.org >

Re: [edk2-devel] [edk2-platforms:PATCH] Modify processor _UID ordering by CPU default fused in MADT

Reviewed-by: Kumar, Chandana C > -Original Message- > From: Lin, JackX > Sent: Thursday, July 28, 2022 12:55 PM > To: devel@edk2.groups.io > Cc: Lin, JackX ; Lin, JackX ; Chiu, > Chasel ; Dong, Eric ; Yao, Jiewen > ; Ni, Ray ; Chaganty, Rangasai V > ; Kuo, Donald ; Kumar, > Chandana C ;

[edk2-devel] [PATCH] ArmVirtPkg: Fix KVM Guest Firmware

Fix build of KVM Guest Firmware, broken by commit 4c55f6394fafe0494ec24e7c05cb68c938d7852d Signed-off-by: Edward Pickup --- The change can be seen at https://github.com/edpickup/edk2/tree/2321_fix_kvm_guest_v1 ArmVirtPkg/KvmtoolCfgMgrDxe/ConfigurationManager.c | 2 +- 1 file changed, 1 inserti

Re: [edk2-devel] [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe: Allow partial FreeBuffer

> -Original Message- > From: Ard Biesheuvel > Sent: Friday, July 29, 2022 9:48 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com; > quic_llind...@quicinc.com; ardb+tianoc...@kernel.org > Subject: Re: [PATCH v2] MdeModulePkg/NonDiscoverablePciDeviceDxe

[edk2-devel] [PATCH] BaseTools: Correct initialization data size check for array PCDs

Currently it is not possible to initialize all elements in the array PCD. For example, this PCD would result to a build failure: gTokenSpaceGuid.PcdArray|{0x11, 0x22}|UINT8[2]|0x4C4CB9A3 Correct logical operator in the initialization data size checks to fix the issue. Signed-off-by: Konstantin A

[edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/Qemu: Fix build break in SbsaQemu

Commit 6eb407947592e084110a124be089bef167af1383 added a new dependency of PlatformPKProtectionLib to SecureBootVariableLib. This causes the build of SbsaQemu to fail. Add the PlatformPKProtectionLib library instance to SbsaQemu.dsc to fix the build. Cc: Ard Biesheuvel Cc: Jeff Booher-Kaeding Cc

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

Hi Sami, Gentle reminder for this patch series. Regards, Rohit. From: devel@edk2.groups.io On Behalf Of Rohit Mathew via groups.io Sent: 25 July 2022 15:56 To: Thanu Rangarajan ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi

[edk2-devel] [PATCH 2] VirtualKeyboardFeaturePkg: Pre OS virtual keyboard touch response are very slow with I2C touch panel

On one Touch, multiple Reads happend and this reads varying based on Key Press time. Resulting in Multiple key press update on screen. This condition avoids KeyPressed skips resulting due to faster key press and update only on valid key press. Cc: Dandan Bi dandan...@intel.com