Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg: Introduce alternate UefiDriverEntrypoint to inhibit driver load

On 08/17/22 17:11, Ard Biesheuvel wrote: > Add a new library that can be incorporated into any driver built from > source, and which permits loading of the driver to be inhibited based on > the value of a QEMU fw_cfg boolean variable. This will be used in a > subsequent patch to allow dispatch of

Re: [edk2-devel] [PATCH 1/2] CloudHv/arm: add PeiMemInfoLib

Hi Sami, Thanks for review. All the comments are Ok for me. Just one inline reply: + +struct CloudHvMemNodeInfo CloudHvMemNode[CLOUDHV_MAX_MEM_NODE_NUM]; + +RETURN_STATUS +EFIAPI +CloudHvVirtMemInfoPeiLibConstructor ( + VOID + ) +{ + VOID *DeviceTreeBase; +

Re: [edk2-devel] [PATCH] IntelSiliconPkg/VTd: Add DMAR SIDP Table dumpping

Reviewed-by: Robert Kowalewski -Original Message- From: Sheng, W Sent: Wednesday, August 17, 2022 8:20 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH] IntelSiliconPkg/VTd: Add DMAR SIDP Table dumpping VT-d spec 4.0

Re: [edk2-devel] CcProbeLib not working for runtime calls

On Thu, Aug 18, 2022 at 01:47:37AM +, Xu, Min M wrote: > On August 17, 2022 7:05 PM, Gerd Hoffmann wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=2114858 > > > > I think the call chain is: > > > > -> linux does efi runtime call > > -> some debug message printed > > ->

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

These seem like perfect examples to write host based unit tests for the bmpsupportlib. Then you could run all sorts of different bmp contents thru the lib routines. Have you thought about adding that Thanks Sean From: devel@edk2.groups.io on behalf of

[edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if the format of bmp file is error, it maybe has no color map when BitPerPixel is 1,4,8. The condition checking now can not catch this issue. Cc: Jian J Wang Cc: Liming Gao Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Wenyi

[edk2-devel] [PATCH EDK2 v2 0/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

Main Changes since v1 : 1.fix format issue found by Uncrustify Wenyi Xie (1): MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 6 ++ 1 file changed, 6 insertions(+) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] CcProbeLib not working for runtime calls

On August 17, 2022 7:05 PM, Gerd Hoffmann wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=2114858 > > I think the call chain is: > > -> linux does efi runtime call > -> some debug message printed > -> OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c > ->

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName

Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: Dimitrije Pavlov > Sent: Wednesday, August 17, 2022 10:35 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Liming Gao ; Sunny > Wang ; Jeff Booher-Kaeding kaed...@arm.com>; Samer El-Haj-Mahmoud

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z

[edk2-devel] Updated Event: TianoCore Community Meeting - EMEA / NAMO - Thursday, September 15, 2022 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z

[edk2-devel] [Patch V2 edk2-stable202208 1/1] BaseTools/Source/C/GenSec: Fix EFI_SECTION_FREEFORM_SUBTYPE_GUID header

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4021 When the size of a EFI_SECTION_FREEFORM_SUBTYPE_GUID section required the use of EFI_FREEFORM_SUBTYPE_GUID_SECTION2 header, set the section type to EFI_SECTION_FREEFORM_SUBTYPE_GUID. Cc: Leif Lindholm Cc: Andrew Fish Cc: Konstantin

Re: [edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config

Hi Sami, Thank you for the help! I agree that we can drop this patch and merge the rest when the window is open. Pierre, Thanks for your input on the usage as well! Regards, Kun On 8/17/2022 5:06 AM, Sami Mujawar wrote: Hi Kun, I plan to get this series merged when the merge window

[edk2-devel] [PATCH v3] DynamicTablesPkg: Add support to build _DSD

Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package {"Name", Integer} Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/AmlLib.h | 60 +

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PcdAcpiGpe1BlockLength for FADT from board package

Hello, Patch has been merged: https://github.com/tianocore/edk2-platforms/commit/d56523d0c1fae5311f5bcecd93ccabd8a5c73830 Thanks, Chasel > -Original Message- > From: Chen, Aryeh > Sent: Monday, August 15, 2022 1:36 AM > To: devel@edk2.groups.io > Cc: Chen, Aryeh ; Chiu, Chasel > ;

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Correct cluster index

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, August 17, 2022 1:01 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; > ardb+tianoc...@kernel.org; sami.muja...@arm.com; > alexei.fedo...@arm.com > Subject: Re: [PATCH] DynamicTablesPkg: Correct

Re: [edk2-devel] [PATCH 3/3] RedfishPkg: The functions for Redfish requests do not fully complied with specification

Sorry, it's a typo. I mean use RedfishPostToUri() makes more sense to me. Abner Get Outlook for Android From: Chang, Abner Sent: Wednesday, August 17, 2022, 11:09 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.w...@hpe.com

[edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support

Wire up the newly added UefiDriverEntrypoint in a way that ties dispatch of the Ip4Dxe and Ip6Dxe drivers to QEMU fw_cfg variables 'opt/org.tianocore/IPv4Support' and 'opt/org.tianocore/IPv6Support' respectively. Setting both variables to 'n' disables IP based networking entirely, without the

[edk2-devel] [PATCH v2 1/2] OvmfPkg: Introduce alternate UefiDriverEntrypoint to inhibit driver load

Add a new library that can be incorporated into any driver built from source, and which permits loading of the driver to be inhibited based on the value of a QEMU fw_cfg boolean variable. This will be used in a subsequent patch to allow dispatch of the IPv6 and IPv6 network protocol driver to be

[edk2-devel] [PATCH v2 0/2] Ovmf: Allow IPv4 and IPv6 to be disabled at runtime

Add some generic plumbing and wire it up for OvmfPkgX64 so that IPv4 and/or IPv6 networking can be turned off from the QEMU command line. This is a follow-up to Yuan's patch '[PATCH v1 0/2] Add support to disable VirtIo net at runtime' which only targeted the virtio network driver specifically.i

Re: [edk2-devel] [PATCH 3/3] RedfishPkg: The functions for Redfish requests do not fully complied with specification

[AMD Official Use Only - General] Yes, I think we can remove 'Ex' because there is no RedfishPostToUri () in RedfishLib.c. Also, RedfishPostToUriEx() has the same parameters as postUriFromService() in service.c. Using RedfishPostToUriEx () makes more sense to me. Thanks Abner > -Original

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Introduce NULL class library to inhibit driver load

On Wed, 17 Aug 2022 at 11:22, Laszlo Ersek wrote: > > On 08/17/22 10:39, Ard Biesheuvel wrote: > > > Agree with all of the above. At this point, I think the only way to do > > this properly is to create an alternative UefiDriverEntrypoint library > > with the fw_cfg check folded into it. This is

Re: [edk2-devel] [PATCH 3/3] RedfishPkg: The functions for Redfish requests do not fully complied with specification

Hi Abner, I just thought that since I'm adding new functions (extending API) I call those functions with Ex suffix. But if you think it is better to have the name without Ex, I can change it and resubmit. Thank you, Igor -Original Message- From: Chang, Abner Sent: Wednesday, August 17,

[edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName

Per the UEFI specification, a device driver implementation should return EFI_UNSUPPORTED if the ChildHandle argument in EFI_COMPONENT_NAME2_PROTOCOL.GetControllerName() is not NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer

Re: [edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config

Hi Kun, I plan to get this series merged when the merge window opens. If you agree, I will drop this patch before merging. Please let me know if that is ok. Regards, Sami Mujawar On 17/08/2022 09:53 am, Pierre Gondois wrote: On 8/17/22 02:17, Kun Qin wrote: Hi Pierre, You are correct

Re: [edk2-devel] [PATCH v4 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space

Hi Kun, Thank you for the updated patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/08/2022 11:28 pm, Kun Qin via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 Certain OSes will complain if the ECAM config space is not

[edk2-devel] CcProbeLib not working for runtime calls

Hi, https://bugzilla.redhat.com/show_bug.cgi?id=2114858 I think the call chain is: -> linux does efi runtime call -> some debug message printed -> OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c -> MdePkg/Library/BaseIoLibIntrinsic (IoWriteFifo8) ->

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

Thanks Sami. Regards, Rohit From: Sami Mujawar Sent: 17 August 2022 10:46 To: Rohit Mathew ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi Rohit, Apologies for the delay. I will pick this up once the merge window opens.

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: Add support to build _DSD

Hello Jeff, Thanks for the v2. I only have small NITs. With the above: Reviewed-by: Pierre Gondois On 8/16/22 20:37, Jeff Brasen wrote: Add APIs needed to build _DSD with different UUIDs. This is per ACPI specification 6.4 s6.2.5. Adds support for building data packages with format Package

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

Hi Rohit, Apologies for the delay. I will pick this up once the merge window opens. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92512): https://edk2.groups.io/g/devel/message/92512

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Introduce NULL class library to inhibit driver load

On 08/17/22 10:39, Ard Biesheuvel wrote: > Agree with all of the above. At this point, I think the only way to do > this properly is to create an alternative UefiDriverEntrypoint library > with the fw_cfg check folded into it. This is easy to do and addresses > all the concerns raised here (as it

Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT

Gentle reminder for this patch series. Regards, Rohit From: Rohit Mathew Sent: 02 August 2022 14:51 To: devel@edk2.groups.io; Sami Mujawar Cc: Thanu Rangarajan ; Thomas Abraham ; nd Subject: RE: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Hi Sami, Gentle

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg:Improved Smbios Type9 table and Smbios 3.5.0 spec changes

Also attaching the patch files here for reference. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92509): https://edk2.groups.io/g/devel/message/92509 Mute This Topic: https://groups.io/mt/92829976/21656 Group Owner:

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg:Improved Smbios Type9 table and Smbios 3.5.0 spec changes

Hi Liming, Created edk2 Pull Request with Patches, Please help to check. https://github.com/tianocore/edk2/pull/3214 Thanks, Sainadh. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92508): https://edk2.groups.io/g/devel/message/92508

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Introduce NULL class library to inhibit driver load

On 08/16/22 23:08, Brian J. Johnson wrote: > On 8/16/22 07:30, Laszlo Ersek wrote: >> On physical machines, I've seen firmware options for disabling the IP >> stack entirely; I wonder how those firmwares do it... > > I don't know how any physical machine handles that particular option. > But one

Re: [edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config

On 8/17/22 02:17, Kun Qin wrote: Hi Pierre, You are correct that if CM_ARM_PCI_ADDRESS_MAP_INFO.PCI_SS_CONFIG is no longer being used, this patch is not needed. Thanks for catching this. On the other hand, just for my learning purpose, could you please let me know what the use case for

Re: [edk2-devel] [PATCH 1/2] OvmfPkg: Introduce NULL class library to inhibit driver load

On Tue, 16 Aug 2022 at 23:10, Brian J. Johnson wrote: > > On 8/16/22 07:30, Laszlo Ersek wrote: > > On 08/15/22 11:40, Ard Biesheuvel wrote: > >> Add a new library that can be incorporated into any driver built from > >> source, and which permits loading of the driver to be inhibited based on >

Re: [edk2-devel] [PATCH EDK2 v2 1/1] MdeModulePkg/PiSmmCore:Avoid overflow risk

On 2022/8/16 9:49, Ni, Ray wrote: >> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c >> @@ -621,6 +621,9 @@ InternalIsBufferOverlapped ( >>IN UINTN Size2 >>) >> { >> + if (((UINTN)Buff1 > MAX_UINTN - Size1) || ((UINTN)Buff2 > MAX_UINTN -

回复: [edk2-devel] 回复: [PATCH EDK2 v1 1/1] MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue

Weiyi: This patch doesn't pass CI. Please check https://github.com/tianocore/edk2/pull/3208 > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2022年8月12日 12:53 > 收件人: 'Wenyi Xie' ; devel@edk2.groups.io; > jian.j.w...@intel.com; zhichao@intel.com;

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Correct cluster index

On Tue, 16 Aug 2022 at 22:46, Jeff Brasen wrote: > > Current code will generate duplicate UID if there are nested clusters > in the topology. > What is a nested cluster? > Signed-off-by: Jeff Brasen > --- > .../SsdtCpuTopologyGenerator.c| 22 --- > 1 file

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Add DMAR SIDP Table dumpping

VT-d spec 4.0 has added a new structure called SIDP which is more generic to describe special properties of integrated devices. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 72