[edk2-devel] [edk2-platforms][PATCH V2 13/16] Platform/Loongson: Add Reset System Lib.

This library provides interfaces related to restart and shutdown. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../BaseResetSystemAcpiGed.c | 155 ++ .../BaseResetSystemAcpiGedLib.inf | 42 +++

[edk2-devel] [edk2-platforms][PATCH V2 09/16] Platform/Loongson: Add PciCpuIoDxe driver.

Add PCI CpuIo protocol.there is no fix translation offset between I/O port accesses and MMIO accesses. Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL to add the translation for IO access. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li ---

[edk2-devel] [edk2-platforms][PATCH V2 16/16] Platform/Loongson: Support for saving variables to flash.

Added the function of saving non-volatile variables. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dec| 6 ++ Platform/Loongson/LoongArchQemuPkg/Loongson.dsc| 2 +-

[edk2-devel] [edk2-platforms][PATCH V2 01/16] Platform/Loongson: Add Serial Port library

Serial Port library for LoongarchQemuPkg REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/Cpu.h| 387 +++ .../Include/LoongArchQemuPlatform.h | 97 +++ .../Library/SerialPortLib/SerialPortLib.c

[edk2-devel] [edk2-platforms][PATCH V2 14/16] Platform/Loongson: Support Dxe

Support Dxe for LoogArch. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Loongson/LoongArchQemuPkg/Loongson.dec| 14 +- .../Loongson/LoongArchQemuPkg/Loongson.dsc| 420 +- .../Loongson/LoongArchQemuPkg/Loongson.fdf| 243

[edk2-devel] [edk2-platforms][PATCH V2 06/16] Platform/Loongson: Add StableTimerLib.

This library provides a delay interface and a timing interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Include/Library/StableTimer.h | 43 .../Library/StableTimerLib/Count.S| 35 +++

[edk2-devel] [edk2-platforms][PATCH V2 11/16] Platform/Loongson: Add RealTime Clock lib.

This library provides interfaces such as real-time clock initialization to get time and setting time. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LsRealTimeClockLib/LsRealTimeClock.h | 41 +++ .../LsRealTimeClockLib/LsRealTimeClockLib.c |

[edk2-devel] [edk2-platforms][PATCH V2 15/16] Platform/Loongson: Add QemuFlashFvbServicesRuntimeDxe driver.

This library provides flash read and write functionality and supports writing variables to flash. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../QemuFlashFvbServicesRuntimeDxe/FvbInfo.c | 115 ++ .../FvbServicesRuntimeDxe.inf |

[edk2-devel] [edk2-platforms][PATCH V2 12/16] Platform/Loongson: Add Platform Boot Manager Lib.

The Library provides Boot Manager interfaces. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../PlatformBootManagerLib/PlatformBm.c | 760 ++ .../PlatformBootManagerLib/PlatformBm.h | 112 +++ .../PlatformBootManagerLib.inf

[edk2-devel] [edk2-platforms][PATCH V2 03/16] Platform/Loongson: Add PeiServicesTablePointerLib.

Use a register to save PeiServicesTable pointer, This lib Provides PeiServicesTable pointer saving and retrieval services. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../PeiServicesTablePointer.c | 78 +++

[edk2-devel] [edk2-platforms][PATCH V2 02/16] Platform/Loongson: Support SEC And Add Readme.md

Add SEC Code And Readme.md for LoongArchQemu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li Signed-off-by: xianglai li --- Maintainers.txt | 4 + .../Include/LoongArchAsmMacro.h | 23 +

[edk2-devel] [edk2-platforms][PATCH V2 05/16] Platform/Loongson: Add MmuLib.

Read the memory map information through the QemuFwCfg interface, then build the page table through the memory map information, and finally enable Mmu. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Include/Library/MmuLib.h | 85 ++

[edk2-devel] [edk2-platforms][PATCH V2 10/16] Platform/Loongson: Add timer Dxe driver.

This driver produces Timer Architectural Protocol, Registers a timer interrupt and initializes the timer. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Drivers/StableTimerDxe/Timer.c| 405 ++

[edk2-devel] [edk2-platforms][PATCH V2 07/16] Platform/Loongson: Support PEI phase.

Platform PEI module for LoongArch platform initialization. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../Library/StableTimerLib/TimerLib.c | 6 +- .../Loongson/LoongArchQemuPkg/Loongson.dec| 22 ++

[edk2-devel] [edk2-platforms][PATCH V2 08/16] Platform/Loongson: Add CPU DXE driver.

The driver produces EFI_CPU_ARCH_PROTOCOL, Initialize the exception entry address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.c | 382 ++ .../LoongArchQemuPkg/Drivers/CpuDxe/CpuDxe.h | 153

[edk2-devel] [edk2-platforms][PATCH V2 04/16] Platform/Loongson: Add QemuFwCfgLib.

QemuFwCfgLib for PEI phase. This library obtains the QemuFWCfg base address by directly parsing the fdt, and reads and writes the data in the QemuFWCfg by operating on the QemuFWCfg base address. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 Signed-off-by: xianglai li ---

[edk2-devel] [edk2-platforms][PATCH V2 00/16] Platform: Add Loongson support.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4054 The uploaded code generates firmware to support Linux launching on the LoongArch platform under qemu, So it will run in a virtual machine. LoongArch is the general processor architecture of Loongson. You can get the latest LoongArch

[edk2-devel] [PATCH 3/3] CloudHv:arm: add kernel load driver into dsc/fdf

As CloudHv kernel load fs driver is implemented, add it into dsc/fdf. Signed-off-by: Jianyong Wu --- ArmVirtPkg/ArmVirtCloudHv.dsc | 8 +++- ArmVirtPkg/ArmVirtCloudHv.fdf | 1 + .../CloudHvKernelLoaderFsDxe/CloudHvKernelLoaderFsDxe.inf

[edk2-devel] [PATCH 2/3] CloudHv:arm: build hob for kernel image memory as read-only

As we use memory to pass kernel image, the memory region where kernel image locates should be added into hob as read-only. Signed-off-by: Jianyong Wu --- .../CloudHvVirtMemInfoLib.c | 66 +-- 1 file changed, 62 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [PATCH 1/3] CloudHv:arm: add kernel load fs driver

This is used for supporting direct kernel boot in CloudHv. CloudHv will store kernel image in system ram and pass kernel info through DT. It's firmware's responsibility to fetch the kernel data and create a file device to feed for loadImage Signed-off-by: Jianyong Wu ---

[edk2-devel] [PATCH 0/3] CloudHv:arm: Enable direct kernel boot

Direct kernel boot removes the dependency of retrieving kernel image from block device. For Cloud Hypervisor, we use the following way to support it. 1. Cloud Hypervisor store kernel image into memory and put kernel info, including the memory base and size, into DT; 2. When init memory in

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 09/15/2022 #cal-reminder

*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* 09/15/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] [PATCH 2/2] BaseTools/FMMT: Add Shrink Fv function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938 This function is used to remove the useless FV free space. Usage: FMMT -s Inputfile Outputfile Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/Python/FMMT/FMMT.py | 7 +

[edk2-devel] [PATCH 1/2] BaseTools/FMMT: Add Extract FV function

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938 With this patch "-e" parameter supports extract FV function. Usage: FMMT -e Inputfile TargetFv Outputfile Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- BaseTools/Source/Python/FMMT/FMMT.py | 3 +-

Re: [edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000

Pushed as 76fc44fecb..801d003703 Note I fixed two nearby comments and my editor cleaned up trailing whitespace automatically. - // [F2]/[F7] + // [F2] And - // Register F7 only when the mBootMenuOptionNumber is valid + // Register [F7] only when the mBootMenuOptionNumber is valid Regards,

Re: [edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000

Reviewed-by: Isaac Oram James, I cannot apply the patch. I can fix it up to push though, so I don't need you to resolve. But for a bigger patch, I would need help resolving. I note that you have special characters in your name. I doubt that matters, but I would probably try to keep it

Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds

Reviewed-by: Rebecca Cran On 9/15/22 17:06, Pedro Falcato wrote: As reported by Rebecca Cran, there was some build breakage when compiling with stack-protector-on-by-default toolchains. Adding the proper library to the DSC should fix it. Cc: Rebecca Cran Cc: Marvin Häuser Signed-off-by:

[edk2-devel] [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds

As reported by Rebecca Cran, there was some build breakage when compiling with stack-protector-on-by-default toolchains. Adding the proper library to the DSC should fix it. Cc: Rebecca Cran Cc: Marvin Häuser Signed-off-by: Pedro Falcato --- Features/Ext4Pkg/Ext4Pkg.dsc | 5 + 1 file

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

Hi Ard, If there is content you do not think needs to follow the min quality criteria, perhaps it can be moved out of edk2 repo? Maybe to edk2-staging or edk2-archive? Thanks, Mike > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, September 15, 2022 2:03 PM > To:

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D wrote: > > Ard, > > Why would you want to do that? The whole point of CI is to establish a > minimum quality level for all code in the project. > > They can be disabled with updates to the YAML file. Checks can be disabled > completely and may

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

Pushed as e81432f and 76fc44f. Thanks! On Thu, Sep 15, 2022 at 10:00 PM Pedro Falcato wrote: > Series-Reviewed-by: Pedro Falcato > > On Wed, Sep 7, 2022 at 3:02 PM Savva Mitrofanov > wrote: > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 >> >> Hi all, >> >> In the fifth version I

Re: [edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

Series-Reviewed-by: Pedro Falcato On Wed, Sep 7, 2022 at 3:02 PM Savva Mitrofanov wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 > > Hi all, > > In the fifth version I corrected remarks from Pedro Falcato and Marvin > Häuser. > I moved symlink procedures into independent C

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

Ard, Why would you want to do that? The whole point of CI is to establish a minimum quality level for all code in the project. They can be disabled with updates to the YAML file. Checks can be disabled completely and may of the checks support exception lists. Mike > -Original

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

On Thu, 15 Sept 2022 at 21:46, Michael Kubacki wrote: > > Hi Ard, > > I haven't seen any action items for the v1 series. > > Can you please check the series again and let me know if you have any > further concerns? > The only thing I'd like to know is how I can override the CI and merge a PR

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

Hi Ard, I haven't seen any action items for the v1 series. Can you please check the series again and let me know if you have any further concerns? Thanks, Michael On 9/7/2022 11:16 AM, Ard Biesheuvel wrote: On Wed, 7 Sept 2022 at 17:00, Michael Kubacki wrote: When would you like to have

Re: [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file

Hi Chasel, Your CI YAML file feedback in v1 is addressed now in v2. Can you please provide your review on this patch and [PATCH v2 5/6]? Note that I updated the commit message for this patch to remove the info about the build being broken since that was recently fixed. That update is in the

Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file

Hi Jian, Can you please provide a review for this patch? Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series will be ready once this patch is reviewed. Thanks, Michael On 9/7/2022 1:05 AM, Michael Kubacki wrote: From: Michael Kubacki

[edk2-devel] [PATCH v2 6/6] .azurepipelines: Add IntelFsp2Pkg and IntelFsp2WrapperPkg to CI

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 Adds these packages to a new edk2 matrix job so they can be validated in edk2 CI. Cc: Bret Barkelew Cc: Chasel Chiu Cc: Liming Gao Cc: Michael D Kinney Cc: Nate DeSimone Cc: Sean Brogan Cc: Star Zeng

[edk2-devel] [PATCH v2 4/6] IntelFsp2WrapperPkg: Fix code formatting errors

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng

[edk2-devel] [PATCH v2 5/6] IntelFsp2WrapperPkg: Add CI YAML file

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 Adds IntelFsp2WrapperPkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. Adds a special case for the Library Class check CI plugin to ignore

[edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 Adds IntelFsp2Pkg to the list of supported build packages for edk2 CI and defines an initial set of CI configuration options. The compiler plugin is disabled as the package currently does not build due to some

[edk2-devel] [PATCH v2 2/6] IntelFsp2Pkg/BaseFspMultiPhaseLib: Replace duplicate GUID

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 The FILE_GUID for this library instance file is a duplicate of Library/SecFspSecPlatformLibNull/SecFspSecPlatformLibNull.inf. This change replaces the duplicated GUID value with a unique GUID. Cc: Chasel Chiu Cc:

[edk2-devel] [PATCH v2 1/6] IntelFsp2Pkg: Fix code formatting errors

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng

[edk2-devel] [PATCH v2 0/6] Enable CI in Intel FSP Packages

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 - Enables CI in IntelFsp2Pkg and IntelFsp2WrapperPkg. - Fixes several pre-existing issues that impact common CI checks. You can find the CI results for the packages with this change in the following edk2 PR:

Re: [edk2-devel] [PATCH v3 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib

Thanks Leif. I will fix as your suggestion. -Nhi On 9/15/2022 5:54 PM, Leif Lindholm wrote: On Tue, Sep 13, 2022 at 13:19:47 +0700, Nhi Pham wrote: From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Pushed as 8d8bb28d2c..17a682058c -Original Message- From: Kinney, Michael D Sent: Thursday, September 15, 2022 9:57 AM To: Oram, Isaac W ; devel@edk2.groups.io; Kinney, Michael D Cc: Leif Lindholm ; Pedro Falcato ; Theo Jehl Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Thanks for this. On Thu, Sep 15, 2022 at 08:47:34 -0700, Isaac Oram wrote: > Enable maintainers for Platform/Qemu/QemuOpenBoardPkg MinPlatformPkg > based board port. > https://edk2-docs.gitbook.io/edk-ii-minimum-platform-specification/ > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Pedro

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.

Patch merged: https://github.com/tianocore/edk2/commit/f46c7d1e36c901e72cc0daee8429275bcb319eb9 Thanks, Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Wednesday, September 7, 2022 12:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ;

Re: [edk2-devel] [PATCH] Maintainers.txt: Update email address

Reviewed-by: Andrew Fish > On Sep 15, 2022, at 9:58 AM, Michael D Kinney > wrote: > > Reviewed-by: Michael D Kinney > > > >> -Original Message- >> From: Nickle Wang mailto:nick...@nvidia.com>> >> Sent: Wednesday, September 14, 2022 7:20 PM >> To:

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage

Apologies for the delay. Merged as f4679715a40d..8d8bb28d2c4b Regards, Sami Mujawar On 04/07/2022 05:59 pm, Rohit Mathew wrote: Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of consoles") setup the routing of console messages to a different set of UART ports. Following up

Re: [edk2-devel] [PATCH] Maintainers.txt: Update email address

Reviewed-by: Michael D Kinney > -Original Message- > From: Nickle Wang > Sent: Wednesday, September 14, 2022 7:20 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; > Kinney, Michael D ; > Abner Chang > Subject: [PATCH] Maintainers.txt: Update email address > > Update

Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm

Patch merged: https://github.com/tianocore/edk2/commit/981bf66d5a7b1a31be5ffccc15fe13b97300e124 Thanks, Chasel > -Original Message- > From: Kuo, Ted > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S,

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.

Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Wednesday, September 7, 2022 12:43 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure. REF:

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Reviewed-by: Michael D Kinney > -Original Message- > From: Oram, Isaac W > Sent: Thursday, September 15, 2022 8:48 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Leif Lindholm > ; Kinney, Michael D > ; Pedro Falcato ; Theo > Jehl > Subject: [edk2-devel][edk2-platforms][PATCH V1

Re: [edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

Merged as 45297e6c9bd1..8c92a9508e16 Thanks. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93848): https://edk2.groups.io/g/devel/message/93848 Mute This Topic: https://groups.io/mt/93510745/21656 Group Owner:

Re: [edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm

Thanks Ted! Reviewed-by: Chasel Chiu > -Original Message- > From: Kuo, Ted > Sent: Thursday, September 15, 2022 6:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star ; S, Ashraf > Ali ; Duggapu, Chinni B > Subject: [edk2-devel][PATCH v2]

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update maintainers/reviewers for CI and Test

Reviewed-by: Michael Kubacki On 9/2/2022 8:23 PM, mikub...@linux.microsoft.com wrote: From: "brbar...@microsoft.com" Remove Bret Barkelew from: - .azurepipelines - .mergify - .pytool - UnitTestFrameworkPkg Add Michael Kubacki to: - .azurepipelines - .pytool Signed-off-by: Bret Barkelew

Re: [edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as UID

Hi Jeff, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 06/09/2022 09:33 pm, Jeff Brasen wrote: Add support for selecting to use index or segment number as UID and name. This allows the path of the nodes to be well known. For example, if the PCIe node needs

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Reviewed-by: Theo Jehl Le jeu. 15 sept. 2022 à 17:48, Isaac Oram a écrit : > Enable maintainers for Platform/Qemu/QemuOpenBoardPkg MinPlatformPkg > based board port. > https://edk2-docs.gitbook.io/edk-ii-minimum-platform-specification/ > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Pedro

Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

Done, https://edk2.groups.io/g/devel/message/93841 to cross-reference. Regards, Isaac -Original Message- From: Leif Lindholm Sent: Thursday, September 15, 2022 3:16 AM To: Oram, Isaac W Cc: Kinney, Michael D ; Theo Jehl ; devel@edk2.groups.io; Pedro Falcato ; Gerd Hoffmann ; Stefan

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Acked-by: Pedro Falcato On Thu, Sep 15, 2022 at 4:47 PM Isaac Oram wrote: > Enable maintainers for Platform/Qemu/QemuOpenBoardPkg MinPlatformPkg > based board port. > https://edk2-docs.gitbook.io/edk-ii-minimum-platform-specification/ > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Pedro

[edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainers.txt: Add QemuOpenBoardPkg maintainers

Enable maintainers for Platform/Qemu/QemuOpenBoardPkg MinPlatformPkg based board port. https://edk2-docs.gitbook.io/edk-ii-minimum-platform-specification/ Cc: Leif Lindholm Cc: Michael D Kinney Cc: Pedro Falcato Cc: Theo Jehl Signed-off-by: Isaac Oram --- Maintainers.txt | 6 ++ 1 file

Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: Add Smbios Type17 Table generator

[AMD Official Use Only - General] > -Original Message- > From: Sami Mujawar > Sent: Wednesday, September 14, 2022 11:35 PM > To: Chang, Abner ; devel@edk2.groups.io; Girish > Mahadevan ; Alexei Fedorov > > Cc: Samer El-Haj-Mahmoud ; Jeff Brasen > (jbra...@nvidia.com) ; Ashish Singhal

Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Hi Jeff, Please find my inputs inline marked [SAMI]. Regards, Sami Mujawar On 15/09/2022 02:10 pm, Jeff Brasen wrote: Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223

Re: [edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

Hi Jeff, Please find my feedback inline marked [SAMI]. Most of my suggestions are with respect to reducing the number of parameters in the AmlCreateCpcNod(). Regards, Sami Mujawar On 15/09/2022 02:10 pm, Jeff Brasen wrote: _CPC entries can describe CPU performance information. The object

Re: [edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Hi Jeff, Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 15/09/2022 02:10 pm, Jeff Brasen wrote: Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance

[edk2-devel] Now: TianoCore Community Meeting - EMEA / NAMO - 09/15/2022 #cal-notice

*TianoCore Community Meeting - EMEA / NAMO* *When:* 09/15/2022 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:*

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 09/15/2022 #cal-reminder

*Reminder: TianoCore Community Meeting - EMEA / NAMO* *When:* 09/15/2022 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Hi Jeff, Apologies for the delay in providing feedback. I was half way through your patch series when you sent the v3. For this patch please fine my feedbakc inline marked [SAMI].  I believe some of these still apply for v3. I will provide review feedback for the v3 series shortly.

[edk2-devel][PATCH v2] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063 Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm to align with FSP 2.4 SPEC. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Chinni B Duggapu Signed-off-by: Ted Kuo ---

[edk2-devel] [PATCH 1/1] BaseTools: Fix RISC-V build failure with binutils 2.38+

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4061 >From version 2.38, binutils adheres to RISC-V ISA spec version 20191213. This means that the csr read/write (csrr*/csrw*) instructions and fence.i instruction are separated from the `I` extension, become two standalone extensions: Zicsr and

[edk2-devel][PATCH v1] IntelFsp2Pkg: NvsBufferPtr is missing in Fsp24ApiEntryM.nasm

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4063 Added NvsBufferPtr to FSPM_UPD_COMMON_FSP24 in Fsp24ApiEntryM.nasm to align with FSP 2.4 SPEC. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Cc: Chinni B Duggapu Signed-off-by: Ted Kuo ---

[edk2-devel] [PATCH v3 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen ---

[edk2-devel] [PATCH v3 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 -

[edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6 deletions(-) diff --git

[edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 148 --

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewers for IntelSiliconPkg

Reviewed-by: Ray Ni > -Original Message- > From: S, Ashraf Ali > Sent: Tuesday, August 23, 2022 3:25 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; > Chaganty, Rangasai V > ; Oram, Isaac W > Subject: [PATCH] Maintainers.txt: Update reviewers for IntelSiliconPkg > > Add

Re: [edk2-devel] [PATCH v2 10/34] ShellPkg: Add LOONGARCH64 architecture for EDK2 CI.

Zhichao, Ok, I will add all of R-B information in the V3. Thanks for reminding. :) Thanks, Chao On 9月 15 2022, at 4:56 下午, "Gao, Zhichao" wrote: > Reviewed-by: Zhichao Gao > > Please add Mike's R-B. If the patches are not changed, you can keep the > received R-B so the

Re: [edk2-devel] [edk2-platforms][PATCH 1/2] SbsaQemu/OemMiscLib: Update for new OemMiscLib APIs

On Tue, Sep 13, 2022 at 13:17:34 +0700, Nhi Pham wrote: > This is to reflect the new APIs added to edk2/OemMiscLib library. > > Signed-off-by: Nhi Pham Matching my comment on OemMiscLibNull - could you use PcdSystemBiosRelease and PcdEmbeddedControllerFirmwareRelease here? / Leif > --- >

Re: [edk2-devel] [edk2-platforms][PATCH 2/2] SbsaQemu/OemMiscLib: Fix typo of "AssetTagType02"

On Tue, Sep 13, 2022 at 13:17:35 +0700, Nhi Pham wrote: > This fixes the typo of AssetTagType02 according to the recent changes > from OemMiscLib.h in the edk2. > > Signed-off-by: Nhi Pham Reviewed-by: Leif Lindholm > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 2 +- > 1 file

Re: [edk2-devel] [PATCH v3 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib

On Tue, Sep 13, 2022 at 13:19:47 +0700, Nhi Pham wrote: > From: Minh Nguyen > > In some scenarios, the information of Bios Version, Bios Release > and Embedded Controller Firmware Release are fetched during UEFI > booting. This patch supports updating those fields dynamically > when the PCDs are

Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

We appear to be missing a Maintainers.txt entry for this new package. Could someone cook one up? / Leif On Wed, Sep 14, 2022 at 20:14:27 +, Oram, Isaac W wrote: > Series pushed as 9a7234827f..f4679715a4 > > -Original Message- > From: Kinney, Michael D > Sent: Tuesday,

Re: [edk2-devel] [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

Reviewed-by: Xiaoyu Lu -Original Message- From: Wenyi Xie Sent: Thursday, September 15, 2022 5:26 PM To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian J ; Lu, Xiaoyu1 ; Jiang, Guomin Cc: songdongku...@huawei.com; xiewen...@huawei.com Subject: [PATCH EDK2 v1 1/1]

[edk2-devel] [PATCH EDK2 v1 0/1] CryptoPkg/BaseCryptLib:Remove redundant init

Main Changes : 1.Remove redundant memory init. Wenyi Xie (1): CryptoPkg/BaseCryptLib:Remove redundant init CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 -- 1 file changed, 2 deletions(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

[edk2-devel] [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

CertCtx is used to be defined as a struct and ZeroMem is called to init this struct. But now CertCtx is defined as a point, so use ZeroMem (, sizeof (CertCtx)) is not correct any more. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Wenyi Xie ---

Re: [edk2-devel] [PATCH v2 30/34] MdeModulePkg/Logo: Add LoongArch64 architecture.

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Chao Li > Sent: Wednesday, September 14, 2022 5:42 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray > Subject: [PATCH v2 30/34] MdeModulePkg/Logo: Add LoongArch64 > architecture. > > REF:

Re: [edk2-devel] [PATCH v2 10/34] ShellPkg: Add LOONGARCH64 architecture for EDK2 CI.

Reviewed-by: Zhichao Gao Please add Mike's R-B. If the patches are not changed, you can keep the received R-B so the maintainers/reviewers can avoid review the same content again. Thanks, Zhichao > -Original Message- > From: Chao Li > Sent: Wednesday, September 14, 2022 5:36 PM >

[edk2-devel] [PATCH] Maintainers.txt: Update email address

Update Nickle's email address from csie.io to nvidia.com for those packages which are reviewed by Nickle. Per suggestion from Abner, change Nickle from reviewer to maintainer for RedfishPkg. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Abner Chang Signed-off-by: Nickle Wang ---

Re: [edk2-devel] [PATCH v2 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

Hello Jeff, This patch looks good to me: Reviewed-by: Pierre Gondois On 9/14/22 23:34, Jeff Brasen wrote: _CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add

Re: [edk2-devel] [PATCH v2 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Hello Jeff, Just one remark: On 9/14/22 23:34, Jeff Brasen wrote: Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 223 +- 1 file changed, 217 insertions(+), 6

Re: [edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Hello Jeff, Just one remark: On 9/14/22 23:34, Jeff Brasen wrote: Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen ---

Re: [edk2-devel] 回复: edk2-devel] [PATCH v2 34/34] BaseTools: Add LoongArch64 binding.

Liming, Ok, in V3, I will put this patch together with BaseTools changes. Thanks, Chao On 9月 15 2022, at 2:34 下午, "gaoliming" wrote: > Chao: > This change should be placed together with other changes in BaseTools. I > mean their commits can be placed together. > > The code change is

Re: [edk2-devel] 回复: PATCH v2 17/34] BaseTools: BaseTools changes for LoongArch platform.

Liming, Ok, I will change the commit title in the V3. Thanks, Chao On 9月 15 2022, at 2:30 下午, "gaoliming" wrote: > Chao: > This change is to update BaseTools build tool to support new LoongArch. > Please update commit message title. > > The code change is good to me. Reviewed-by:

Re: [edk2-devel] 回复: PATCH v2 16/34] BaseTools: BaseTools changes for LoongArch platform.

Liming, Ok, I will change the commit message in the V3. Thanks, Chao On 9月 15 2022, at 2:28 下午, "gaoliming" wrote: > Chao: > This change is to update GCC5 tool chain to support LoongArch. So, the > commit message title should be updated for GCC5 tool chain. > > The code change is good

Re: [edk2-devel] 回复: PATCH v2 15/34] BaseTools: BaseTools changes for LoongArch platform.

Liming, Ok, I will change the commit message in the V3. Thanks, Chao On 9月 15 2022, at 2:27 下午, "gaoliming via groups.io" wrote: > Chao: > This change is for BaseTools C tools . The commit message can be > BaseTools: Update GenFw/GenFv to support LoongArch platform. > > The code

回复: [edk2-devel] [PATCH v2 34/34] BaseTools: Add LoongArch64 binding.

Chao: This change should be placed together with other changes in BaseTools. I mean their commits can be placed together. The code change is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chao Li > 发送时间: 2022年9月14日 17:43 > 收件人:

[edk2-devel] 回复: [PATCH v2 17/34] BaseTools: BaseTools changes for LoongArch platform.

Chao: This change is to update BaseTools build tool to support new LoongArch. Please update commit message title. The code change is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Chao Li > 发送时间: 2022年9月14日 17:41 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming

[edk2-devel] 回复: [PATCH v2 16/34] BaseTools: BaseTools changes for LoongArch platform.

Chao: This change is to update GCC5 tool chain to support LoongArch. So, the commit message title should be updated for GCC5 tool chain. The code change is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Chao Li > 发送时间: 2022年9月14日 17:40 > 收件人:

[edk2-devel] 回复: [PATCH v2 15/34] BaseTools: BaseTools changes for LoongArch platform.

Chao: This change is for BaseTools C tools . The commit message can be BaseTools: Update GenFw/GenFv to support LoongArch platform. The code change is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Chao Li > 发送时间: 2022年9月14日 17:40 > 收件人: devel@edk2.groups.io >