Patch merged:
https://github.com/tianocore/edk2/commit/b84f32ae5b475ce657ea1c9db29d4e4ec7711948
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chiu,
> Chasel
> Sent: Tuesday, November 1, 2022 10:46 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Michael D Kinney
---
.../GoogleTestBaseSafeIntLib.inf | 37 +
.../GoogleTestBaseSafeIntLib.uni | 13 +
.../SafeIntLibUintnIntnUnitTests32.cpp| 425 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.pytool/CISettings.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Add submodule for googletest and add GoogleTestLib that is
required for GoogleTest based unit tests. Add GoogleTest
documentation to Readme.md along with a port of the sample
unit test to the GoogleTest style.
Cc: Michael Kubacki
Cc: Sean
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Set environment variable GTEST_OUTPUT to specify the output
format of XML and the output file name. Both CMOCKA_XML_FILE
and GTEST_OUTPUT are set for each host based unit test to
support both cmocka unit tests and gtest unit tests.
Cc:
Cc: Michael Kubacki
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Michael D Kinney
---
UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
PR: https://github.com/tianocore/edk2/pull/3566
Branch: https://github.com/mdkinney/edk2/tree/Bug_4134_AddGoogleTest
Add GoogleTest support to UnitTestFrameworkPkg to provide an
additional host-based unit test framework to developers.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
* Map NULL to nullptr or __null when c++ compiler is used.
* Map STATIC_ASSERT to static_assert when a c++ compiler is used.
* Typecast RETURN_SUCCESS to type RETURN_STATUS to match type used
by all return error/warning status codes. C++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
When unit testing is enabled, make sure _ASSERT() is not already
defined by the host environment before defining _ASSERT(). This
avoids conflicts with VS20xx builds of GoogleTest based unit tests.
Cc: Liming Gao
Cc: Zhiguang Liu
For the series, reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Friday, November 4, 2022 7:20 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Dong, Eric ;
> Ni, Ray ; Brijesh Singh ; Aktas,
> Erdem ; Gerd Hoffmann ;
> James Bottomley ; Yao, Jiewen
> ; Tom Lendacky
Reviewed-by: Ted Kuo
-Original Message-
From: Chiu, Chasel
Sent: Friday, November 4, 2022 1:02 AM
To: Kuo, Ted ; devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: RE: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP should support input UPD
as NULL.
Hi Ted,
Please see
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Pedro Falcato
> 发送时间: 2022年11月3日 9:12
> 收件人: devel@edk2.groups.io
> 抄送: Pedro Falcato ; Vitaly Cheptsov
> ; Marvin Häuser ;
> Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Jiewen
> Yao
> 主题: [PATCH v3 1/1] MdePkg/BaseLib: Fix out-of-bounds
Sami, Leif, Ard:
Can you give your Reviewed-by for this patch set this week? If so, this
feature can catch stable tag 202211.
Stable202211 tag soft feature freeze will start on next Monday Nov 7th.
Thanks
Liming
> -邮件原件-
> 发件人: Yao, Jiewen
> 发送时间: 2022年11月1日 16:56
> 收件人:
Sainadh:
The change is good. Can you create pull request for this change in Edk2
project?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sainadh
> Nagolu via groups.io
> 发送时间: 2022年11月2日 12:30
> 收件人: devel@edk2.groups.io; Sainadh Nagolu
> 抄送: Vasudevan S ; Sundaresan S
>
> 主题:
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, November 3, 2022 5:25 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Sean Brogan
>
> Subject: [PATCH v1 0/2] UnitTestFrameworkPkg: Add
> UnitTestUefiBootServicesTableLib
Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, November 3, 2022 5:33 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ; Kinney, Michael D
> ; Gao, Liming
>
> Subject: [PATCH v3 2/2] .github: Add initial CodeQL config and
Hi Mike,
Node.js and cspell are not needed. I confirmed the GitHub workflow with them
removed here:
Enable CodeQL · tianocore/edk2@ad62416 (github.com) (
https://github.com/tianocore/edk2/actions/runs/3390100498 )
v3 has been sent with that change:
[PATCH v3 0/2] Enable Initial CodeQL Support
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4115
Adds initial support for enabling CodeQL Code Scanning in this
repository per the RFC:
https://github.com/tianocore/edk2/discussions/3258
Adds the following new files:
- .github/workflows/codql-analysis.yml -
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4115
This patch series enables initial CodeQL support within the edk2
repository.
After this patch, a CodeQL Analyze step will run on a subset of
edk2 packages in Pull Requests. The plan to scale additional CodeQL
queries
From: Michael Kubacki
Updates PrmPkg to use UnitTestUefiBootServicesTableLib from
UnitTestFrameworkPkg instead of UefiBootServicesTableLibUnitTest
in PrmPkg.
Cc: Michael D Kinney
Cc: Sean Brogan
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
This library supports a Boot Services table library implementation
that allows code dependent upon UefiBootServicesTableLib to operate
in an isolated execution environment such as within
the context of a host-based unit test framework.
The unit test should initialize the
From: Michael Kubacki
This patch series moves a library that is useful for stubbing UEFI
Boot Services from PrmPkg to UnitTestFrameworkPkg.
An example of library usage that makes use of mocked protocol
interfaces to retain protocol state is here:
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
Delete VmgExitLib because it is replaced by CcExitLib.
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Signed-off-by: Min Xu
---
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is renamed as CcExitLib. The related section in
Maintainers.txt should be updated as well.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is replaced by CcExitLib. So it is deleted from UefiCpuPkg.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Min Xu
---
UefiCpuPkg/Include/Library/VmgExitLib.h | 173 --
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is renamed as CcExitLib. See the description in BZ4123.
So OvmfPkg should be updated to this rename.
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib is renamed as CcExitLib. So UefiPayloadPkg.dsc should be
updated as well.
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Reviewed-by: James Lu
Reviewed-by: Gua Guo
Signed-off-by: Min Xu
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of
From: Min M Xu
https://bugzilla.tianocore.org/show_bug.cgi?id=4123
The base CcExitLib library provides a default limited interface. As it
does not provide full support, create an OVMF version of this library to
begin the process of providing full support of Cc guest (such as SEV-ES,
TDX) within
From: Min M Xu
https://bugzilla.tianocore.org/show_bug.cgi?id=4123
CcExitLib is designed to replace VmgExitLib. This patch adds CcExitLib in
*.dsc which import VmgExitLib. VmgExitLib in these *.dsc will be deleted
in the follwing patch so that the build will not be broken.
Cc: Brijesh Singh
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
CcExitLib is designed to support handling #VC/#VE exceptions and issuing
VMGEXIT instructions. It can be used to perform these:
- Handling #VC exceptions
- Handling #VE exceptions
- Preparing for and issuing a VMGEXIT
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
VmgExitLib once was designed to provide interfaces to support #VC handler
and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
introduced, this library is updated to support #VE as well. Now the name
of VmgExitLib cannot
I might be using the wrong term, I'm still in the beginning of learning this
field so I apologise if I am out of my depth.
Maybe I just meant ROM memory... I thought that ROM memory was stored in flash
memory.
The program is currently shipped in a manner that changing or formatting the
hard
On Thu, Nov 3, 2022 at 10:02 PM d.meneses via groups.io wrote:
> It needs to run from FLASH and not an EFI partition.
>
Why flash?
> It needs to run at startup before the boot loader and OS.
> This is in order to make it non-removable and unskippable, unlike apps in
> /EFI/BOOT.
> I am aware of
It needs to run from FLASH and not an EFI partition.
It needs to run at startup before the boot loader and OS.
This is in order to make it non-removable and unskippable, unlike apps in
/EFI/BOOT.
I am aware of the other options you've mentioned, I've even done it on a real
machine.
Glad to see this works on Windows agents. I know it will be good to switch
back to Linux agents when stable.
See comments below.
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Thursday, November 3, 2022 2:41 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan ;
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Thursday, November 3, 2022 2:40 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm ;
> Kinney, Michael D ;
> Sean Brogan
> Subject: [edk2-devel] [PATCH v2
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4115
Adds initial support for enabling CodeQL Code Scanning in this
repository per the RFC:
https://github.com/tianocore/edk2/discussions/3258
Adds the following new files:
- .github/workflows/codql-analysis.yml -
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4115
This patch series enables initial CodeQL support within the edk2
repository.
After this patch, a CodeQL Analyze step will run on a subset of
edk2 packages in Pull Requests. The plan to scale additional CodeQL
queries
> On Nov 3, 2022, at 12:11 PM, d.meneses via groups.io
> wrote:
>
> Yes I also believe I'm threading a XY problem.
>
> Let's simplify my learning and set the goal to: add an UEFI application to
> OVMF so that it runs natively on startup.
>
> Does this make more sense?
>
> I followed the
Also...would it be a simpler policy to fail the capsule update all together if
any of the
3 allocations fail? That way, there is no case where is "may fail".
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, November 3, 2022 2:21 PM
> To: Desimone, Nathaniel L ;
>
Hi Nate,
The "may fail" messages look a bit odd. Is this due to the fact that
CapsuleRuntimeDxe is in X64 mode,
but this module does not know if PEI Phase will process the capsule in IA32 or
X64 execution mode?
We have a PCD that is set if the DXE IPL needs to switch modes. Can we use
that
Yes I also believe I'm threading a XY problem.
Let's simplify my learning and set the goal to: add an UEFI application to OVMF
so that it runs natively on startup.
Does this make more sense?
I followed the same process and I can use UEFITool to confirm there's an
UefiApplication inside the
On Thu, Nov 3, 2022 at 3:53 PM zhoucheng wrote:
> Description according to Chapter 7.5.2 of USB 3.2 spec protocol.
> When the Usb state machine is in Inactive, the software is required
> to perform a warm reset operation.
>
> Cc: Liming Gao
> Cc: Hao A Wu
> Cc: Ray Ni
> Signed-off-by: Cheng
Hi Ted,
Please see my reply below inline.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Wednesday, November 2, 2022 7:32 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Desimone, Nathaniel L ; Zeng, Star
>
> Subject: RE: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP
Hi,
DEPEX (AIUI, I might be playing loose with language here) is essentially a
bunch of conditions you can package with your .efi that explain how your
.efi depends on protocols.
If you set it to TRUE, it will *always* run. If you set it to FALSE, it
will *never* run (because it will always
Hi Laszlo,
I think we should consider expending the meaning of PCD to allow
multiple algos and update lib implementation to support multiple.
This should not have a size impact for platforms that only want one
algo. And should also be backwards compatible to expand meaning to
support multiple.
Description according to Chapter 7.5.2 of USB 3.2 spec protocol.
When the Usb state machine is in Inactive, the software is required
to perform a warm reset operation.
Cc: Ray Ni
Cc: Liming Gao
Cc: Wang Jian J
Reviewed-by: Wu Hao A
Signed-off-by: Cheng Zhou
zhoucheng (1):
Description according to Chapter 7.5.2 of USB 3.2 spec protocol.
When the Usb state machine is in Inactive, the software is required
to perform a warm reset operation.
Cc: Liming Gao
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Cheng Zhou
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 14 ++
Thank you Andrew for this information.
I set it to *true* cause the builder was asking for a *Depex section*.
Setting it to *false allows QEMU* to boot properly.
Nonetheless, the driver *doesn't seem to be called*... yet.
Concerning Pedro's suggestion (Olá!!!), thank you for pointing me to the
Hi Mike,
On 11/02/22 17:48, Kinney, Michael D wrote:
> Hi Laszlo,
>
> Thank you for all the updates. One comment below.
>
> Mike
>
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Wednesday, November 2, 2022 2:37 AM
>> To: devel@edk2.groups.io; ler...@redhat.com
>> Cc: Zurcher,
Reviewed-by: Guo Dong
-Original Message-
From: Liu, Zhiguang
Sent: Tuesday, November 1, 2022 12:59 AM
To: devel@edk2.groups.io
Cc: Yu Pu ; Dong, Guo ; Ni, Ray
; Maurice Ma ; You, Benjamin
; Rhodes, Sean
Subject: [PATCH v3 8/9] UefiPayloadPkg: Remove UefiCpuLib from module INFs.
Reviewed-by: Guo Dong
-Original Message-
From: Hsu, VictorX
Sent: Thursday, November 3, 2022 2:11 AM
To: devel@edk2.groups.io
Cc: Hsu, VictorX ; Dong, Guo ; Ni,
Ray ; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
From: VictorX Hsu
Reviewed-by: Guo Dong
-Original Message-
From: Xu, Min M
Sent: Tuesday, November 1, 2022 10:11 PM
To: devel@edk2.groups.io
Cc: Xu, Min M ; Dong, Guo ; Ni, Ray
; Rhodes, Sean ; Lu, James
; Guo, Gua
Subject: [PATCH 4/8] UefiPayloadPkg: Use CcExitLib instead of VmgExitLib
From: Min M
*TianoCore edk2-test Bug Triage Meeting*
*When:*
11/03/2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
11/03/2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
From: VictorX Hsu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4136
System will depend on Boot Mode value to do different behavior
Update during Capsule Update process. So UPL need to support
update boot mode.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: VictorX
Reviewed-by: James Lu
-Original Message-
From: Hsu, VictorX
Sent: Thursday, November 3, 2022 5:11 PM
To: devel@edk2.groups.io
Cc: Hsu, VictorX ; Dong, Guo ; Ni,
Ray ; Lu, James ; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
From: VictorX Hsu
Give + 1, it can help to unlock Capsule Update through have correct Boot Mode
value.
Reviewed-by: Gua Guo
-Original Message-
From: Hsu, VictorX
Sent: Thursday, November 3, 2022 5:11 PM
To: devel@edk2.groups.io
Cc: Hsu, VictorX ; Dong, Guo ; Ni,
Ray ; Lu, James ; Guo, Gua
Subject:
59 matches
Mail list logo
