Series Reviewed-by: Michael D Kinney
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, November 8, 2022 4:22 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ; Sean
> Brogan ; Kinney, Michael D
>
> Subject: [PATCH v2 0/2]
Hi Mike,
I made those updates in the v2 series just sent:
[PATCH v2 0/2] Enable CodeQL Failures and Add New Queries (groups.io) (
https://edk2.groups.io/g/devel/message/96124 )
Thanks,
Michael
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
From: Michael Kubacki
The query cpp/conditionallyuninitializedvariable was initially
enabled with the CodeQL code because work was in progress on those
changes. The results were filtered out so CodeQL passed so we could
verify the CodeQL workflow without impacting CI results.
This change allows
From: Michael Kubacki
Fixes issues found with the cpp/wrong-type-format-argument CodeQL
rule in BaseTools.
Reference:
https://cwe.mitre.org/data/definitions/686.html
The following CodeQL errors are resolved:
1. Check failure on line 1115 in
BaseTools/Source/C/EfiRom/EfiRom.c
- This
From: Michael Kubacki
When CodeQL was enabled, the goal was to enable the flow and not
impact build results. cpp/conditionallyuninitializedvariable was
the first and only query enabled with all CodeQL results filtered
out from affecting CI results.
This achieved the goal to enable CodeQL for
Hi Liming,
Thank you for the review and adding the new BZ. I updated the new BZ with a
few more details.
Merged PR: https://github.com/tianocore/edk2/pull/3598
Mike
> -Original Message-
> From: gaoliming
> Sent: Monday, November 7, 2022 11:16 PM
> To: devel@edk2.groups.io; Kinney,
>
> This code signals the Before Exit Boot Services event at the beginning
> of the ExitBootServices() function. This gives all the rest of the
> code to prepare for the ExitBootServices event.
>
Hi Robert, I think we're both trying to do this at the same time. See
the patch series "SEV-SNP
Hi Michael,
2 comments below.
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Tuesday, November 8, 2022 11:52 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine ; Sean
> Brogan ; Kinney, Michael D
>
> Subject: [PATCH v1 1/2]
For the codeql series
Reviewed-by: Sean Brogan
On 11/8/2022 11:51 AM, Michael Kubacki wrote:
From: Michael Kubacki
When CodeQL was enabled, the goal was to enable the flow and not
impact build results. cpp/conditionallyuninitializedvariable was
the first and only query enabled with all
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Michael D Kinney
Reviewed-by: Liming Gao
---
.../GoogleTestBaseSafeIntLib.inf | 37 +
.../GoogleTestBaseSafeIntLib.uni | 13 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Liming Gao
Signed-off-by: Michael D Kinney
Reviewed-by: Michael Kubacki
---
.pytool/CISettings.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.pytool/CISettings.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
When unit testing is enabled, make sure _ASSERT() is not already
defined by the host environment before defining _ASSERT(). This
avoids conflicts with VS20xx builds of GoogleTest based unit tests.
Cc: Liming Gao
Cc: Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Set environment variable GTEST_OUTPUT to specify the output
format of XML and the output file name. Both CMOCKA_XML_FILE
and GTEST_OUTPUT are set for each host based unit test to
support both cmocka unit tests and gtest unit tests.
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Add submodule for googletest and add GoogleTestLib that is
required for GoogleTest based unit tests. Add GoogleTest
documentation to Readme.md along with a port of the sample
unit test to the GoogleTest style.
Cc: Michael Kubacki
Cc: Sean
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
* Map NULL to nullptr or __null when c++ compiler is used.
* Map STATIC_ASSERT to static_assert when a c++ compiler is used.
* Typecast RETURN_SUCCESS to type RETURN_STATUS to match type used
by all return error/warning status codes. C++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134
Add GoogleTest support to UnitTestFrameworkPkg to provide an
additional host-based unit test framework to developers.
Code: https://github.com/google/googletest
Docs: https://google.github.io/googletest
GoogleTest is implemented in C++,
Add /Zi to CC_FLAGS in CmockaLib.inf to enable symbol information
Cc: Michael Kubacki
Cc: Sean Brogan
Signed-off-by: Michael D Kinney
Reviewed-by: Michael Kubacki
---
UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi Liming,
Thank you for the reminder. I will update Readme.rst
Mike
> -Original Message-
> From: gaoliming
> Sent: Monday, November 7, 2022 11:47 PM
> To: devel@edk2.groups.io; Kinney, Michael D
> Cc: 'Michael Kubacki' ; 'Sean Brogan'
>
> Subject: 回复: [edk2-devel] [Patch V2 3/7]
Hi Robert,
I do not see the signal of the after exit boot services event.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Robert Phelps
> via groups.io
> Sent: Tuesday, November 8, 2022 12:28 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao,
On 11/8/22 10:09, Yao, Jiewen wrote:
Hi Tom/Dionna
I think this patch is addressing
https://bugzilla.tianocore.org/show_bug.cgi?id=3987.
For patch 1~3, I am OK for the API which we already agreed, such as
EfiMemoryAcceptProtocol and EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES.
I have given
The Uefi v2.9 specification adds this event group in section 3.1.7,
with its GUID defined in the Related Definitions section of
EFI_BOOT_SERVICES.CreateEventEx() in chapter 7.
Cc: "Michael D Kinney"
Cc: Ard Biesheuvel
Cc: Gerd Hoffman
Cc: Jiewen Yao
Signed-off-by: Dionna Glaze
---
Location of notification is has been specified in UEFI v2.9.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ard Biesheuvel
Cc: "Min M. Xu"
Cc: Andrew Fish
Cc: "Michael D. Kinney"
Cc: Ray Ni
Acked-by: Jiewen Yao
Signed-off-by: Dionna Glaze
---
Add EFI_EVENT_BEFORE_EXIT_BOOT_SERVICES_GUID
Add EFI_EVENT_GROUP_AFTER_READY_TO_BOOT
Both defined in UEFI standard v2.9.
Cc: Ard Biescheuvel
Cc: "Min M. Xu"
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Tom Lendacky
Cc: Jiewen Yao
Cc: Erdem Aktas
Signed-off-by: Dionna Glaze
---
From: Sophia Wolf
When a guest OS does not support unaccepted memory, the unaccepted
memory must be accepted before returning a memory map to the caller.
EfiMemoryAcceptProtocol is defined in MdePkg and is implemented /
Installed in AmdSevDxe for AMD SEV-SNP memory acceptance.
Cc: Gerd
This is the first half of the patch series
[PATCH v8 0/7] Add safe unaccepted memory behavior
These patches add SEV-SNP support for the MemoryAccept protocol, and
implement an already standardized mechanism for performing any actions
just before terminating the memory map.
We implement a
This code signals the Before Exit Boot Services event at the beginning
of the ExitBootServices() function. This gives all the rest of the
code to prepare for the ExitBootServices event.
Cc: Dandan Bi [dandanbi]
Cc: Liming Gao [lgao4]
Signed-off-by: Robert Phelps
---
The following patches contain the new definitions for new events that
were added in UEFI 2.9: Before Exit Boot Services and After Ready to
Boot. The second patch adds the call to signal the Before Exit Boot
Services Event in DxeMain.c and the addition of the GUID in the INF
file DxeMain.inf.
Add Before Exit Boot Services Event and After Ready To Boot Event Definitions
Cc: Michael D Kinney [mdkinney]
Cc: Liming Gao [lgao4]
Cc: Zhiguang Liu [LiuZhiguang001]
Signed-off-by: Robert Phelps
---
MdePkg/Include/Guid/EventGroup.h | 10 ++
MdePkg/MdePkg.dec
The UEFI 2.9 specification added a new FORM_BROWSER_ACTION_REQUEST. This
adds FORM_BROWSER_ACTION_REQUEST_QUESTION_APPLY.
Signed-off-by: Robert Phelps
---
MdePkg/Include/Protocol/FormBrowser2.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdePkg/Include/Protocol/FormBrowser2.h
Hi Rebecca Cran,
in addition to my former email:
We have the same issue with on a LINUX Buildmachine (latest UBUNTU, GNU5
toolchain)
fopen() always fail.
Any suggestions on opening files in C.
Is there a special trick on UEFI???
Thanks in advance for your time and advice,
JC En lunes, 7
From: Michael Kubacki
The query cpp/conditionallyuninitializedvariable was initially
enabled with the CodeQL code because work was in progress on those
changes. The results were filtered out so CodeQL passed so we could
verify the CodeQL workflow without impacting CI results.
This change allows
From: Michael Kubacki
Fixes issues found with the cpp/wrong-type-format-argument CodeQL
rule in BaseTools.
Reference:
https://cwe.mitre.org/data/definitions/686.html
The following CodeQL errors are resolved:
1. Check failure on line 1115 in
BaseTools/Source/C/EfiRom/EfiRom.c
- This
From: Michael Kubacki
When CodeQL was enabled, the goal was to enable the flow and not
impact build results. cpp/conditionallyuninitializedvariable was
the first and only query enabled with all CodeQL results filtered
out from affecting CI results.
This achieved the goal to enable CodeQL for
> The total time for memory accept is 4 part:
>1) vBIOS early phase, single thread accept
>2) vBIOS runtime phase, multi thread accept
>3) OS early phase, single thread accept
>4) OS runtime phase, multi thread accept
>
>We hope 1) is zero.
>And we are trying to balance between 2) and 3).
Do you
Hi Dionna,
For the feature you are working on, it looks like you only require the before
exit boot services event.
However, the UEFI 2.9 Spec added the before and after events at the same time.
I recommend these patches be updated to add both events and signal both events.
Thanks,
Mike
>
Pushed 6032b46dce1dea705f95ecfdb68656281f0822f7
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96093): https://edk2.groups.io/g/devel/message/96093
Mute This Topic: https://groups.io/mt/94864133/21656
Group Owner:
Acked-by: Jiewen Yao
> -Original Message-
> From: Dionna Glaze
> Sent: Wednesday, November 9, 2022 12:46 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Gerd Hoffmann
> ; James Bottomley ; Yao,
> Jiewen ; Tom Lendacky
>
> Subject: [PATCH 1/3] OvmfPkg: Realize EfiMemoryAcceptProtocol
Location of notification is has been specified in UEFI v2.9.
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Ard Biesheuvel
Cc: "Min M. Xu"
Cc: Andrew Fish
Cc: "Michael D. Kinney"
Cc: Ray Ni
Acked-by: Jiewen Yao
Signed-off-by: Dionna Glaze
---
Event group as defined in UEFI standard v2.9.
Cc: Ard Biescheuvel
Cc: "Min M. Xu"
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Tom Lendacky
Cc: Jiewen Yao
Cc: Erdem Aktas
Acked-by: Jiewen Yao
Signed-off-by: Dionna Glaze
---
MdePkg/Include/Guid/EventGroup.h | 5 +
MdePkg/MdePkg.dec
From: Sophia Wolf
When a guest OS does not support unaccepted memory, the unaccepted
memory must be accepted before returning a memory map to the caller.
EfiMemoryAcceptProtocol is defined in MdePkg and is implemented /
Installed in AmdSevDxe for AMD SEV-SNP memory acceptance.
Cc: Gerd
This is the first half of the patch series
[PATCH v8 0/7] Add safe unaccepted memory behavior
These patches add SEV-SNP support for the MemoryAccept protocol, and
implement an already standardized mechanism for performing any actions
just before terminating the memory map.
We implement a
>
> BTW: Is there any data for AMD-SEV?
>
Earlier this year, I tried to make the lazy accept patches work for
SEV-SNP, but the boot would always crash in the Qemu try boot kernel
step IIRC:
https://github.com/AMDESE/ovmf/pull/4
Tom suggested accepting the first 4GiB and I didn't go back to try
Right, Dionna. In intel, we are doing POC to see what is the best size the BIOS
should accept.
The total time for memory accept is 4 part:
1) vBIOS early phase, single thread accept
2) vBIOS runtime phase, multi thread accept
3) OS early phase, single thread accept
4) OS runtime phase, multi
On 10/24/22 15:41, Dionna Glaze wrote:
From: Sophia Wolf
When a guest OS does not support unaccepted memory, the unaccepted
memory must be accepted before returning a memory map to the caller.
EfiMemoryAcceptProtocol is defined in MdePkg and is implemented /
Installed in AmdSevDxe for AMD
On Tue, Nov 8, 2022 at 8:09 AM Yao, Jiewen wrote:
>
> Hi Tom/Dionna
> I think this patch is addressing
> https://bugzilla.tianocore.org/show_bug.cgi?id=3987.
>
> For patch 1~3, I am OK for the API which we already agreed, such as
> EfiMemoryAcceptProtocol and
Hi Tom/Dionna
I think this patch is addressing
https://bugzilla.tianocore.org/show_bug.cgi?id=3987.
For patch 1~3, I am OK for the API which we already agreed, such as
EfiMemoryAcceptProtocol and EFI_EVENT_GROUP_BEFORE_EXIT_BOOT_SERVICES.
I have given Acked by: Jiewen Yao
For patch 4, it
Acked-by: Jiewen Yao
> -Original Message-
> From: Dionna Glaze
> Sent: Tuesday, October 25, 2022 4:41 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Ard Biescheuvel
> ; Xu, Min M ; Gerd Hoffmann
> ; James Bottomley ; Tom
> Lendacky ; Yao, Jiewen
> ; Aktas, Erdem
> Subject: [PATCH
Acked-by: Jiewen Yao
Need AMD-SEV people to give Reviewed-by.
Thank you
Yao, Jiewen
> -Original Message-
> From: Dionna Glaze
> Sent: Tuesday, October 25, 2022 4:41 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Gerd Hoffmann
> ; James Bottomley ; Yao,
> Jiewen ; Tom Lendacky
>
>
Acked-by: Jiewen Yao
> -Original Message-
> From: Dionna Glaze
> Sent: Tuesday, October 25, 2022 4:41 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze ; Gerd Hoffmann
> ; James Bottomley ; Yao,
> Jiewen ; Tom Lendacky
> ; Ard Biesheuvel ; Xu,
> Min M ; Andrew Fish ; Kinney,
> Michael D
On Wed, Oct 19, 2022 at 11:22:07AM +0200, Ard Biesheuvel wrote:
> Now that we have all the pieces in place, switch the AArch64 version of
> ArmVirtQemu to a mode where the first thing it does out of reset is
> enable a preliminary ID map that covers the NOR flash and sufficient
> DRAM to create
On 10/24/22 15:41, Dionna Glaze wrote:
These seven patches build on the lazy-accept patch series
"Introduce Lazy-accept for Tdx guest"
Since the above series was accepted into the EDK2 tree, can this series
also be pulled in so that both TDX and SNP can support unaccepted memory
in the same
From: Anthony PERARD
The PcdFSBClock can be a dynamic PCD. This can be an issue when
InternalX86GetTimerFrequency() tries to get the value while been
called with TPL been set to TPL_HIGH_LEVEL.
When the PCD is dynamic, PcdGet*() calls a function that try to grab a
lock which set TPL to
Could I get some reviews on this please?
Thanks.
Rebecca Cran
On 10/27/22 12:51, Rebecca Cran wrote:
There currently isn't a way to differentiate the different
levels of DEBUG output: DEBUG_ERROR, DEBUG_WARN, DEBUG_INFO
etc.
To improve this, wrap DEBUG_ERROR and DEBUG_WARN level
messages in
53 matches
Mail list logo
