One more comment:
For all header files, no need to remove the opening '_' of include guard macro.
Protected variable code are now in different folder than original variable
driver.
They won't reference code from each other. Please add the opening '_' for those
macros to confirm to edk2 coding
Jiewen:
This patch set has passed code review before soft feature freeze phase.
And, there is no code change recently. So, I agree to merge this patch set
for the stable tag.
I will help merge it.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Yao, Jiewen
> 发送时间:
Ping for reviewing, Any comments is welcome.
>From edk2 mailing list, Soft Feature Freeze start on 2022-11-07 for
>edk2-stable202211,
is edk2-platform is affected also?
And there are series of submition for Riscv ovmf supports recently, we will
adopt
the new multi-arch schemes on Loongarch
Hi Judah,
See my comments (starting with [JianJW]) inline below.
> -Original Message-
> From: Vang, Judah
> Sent: Sunday, November 06, 2022 3:35 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Mistry,
> Nishant C
> Subject: [PATCH v5 07/19] MdeModulePkg:
Sorry, please ignore this one. I should reply the one from v5.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian
> J
> Sent: Monday, November 14, 2022 1:39 AM
> To: Vang, Judah ; devel@edk2.groups.io
> Cc: Gao, Liming ; Wu, Hao A
> ; Mistry, Nishant
[AMD Official Use Only - General]
For this case, we don't have to take another global reformatting. These two
formats can coexisting without the conflict. We just allow the condense argus
format in CSS. Also, update Uncrustify to not forcing each argument at its own
line.
The current
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, November 14, 2022
4:30pm to 5:30pm
(UTC-08:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623294 )
*Description:*
Hi Judah,
See my comments (starting with [JianJW]) inline below.
Regards,
Jian
> -Original Message-
> From: Vang, Judah
> Sent: Thursday, August 11, 2022 2:53 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Mistry,
> Nishant C
> Subject: [PATCH v4 07/28]
We do not want another global format change because that make git blame
difficult to use.
Are any clarifications required to describe the current Uncrustify behavior?
Or is the description correct?
If the current description matches Uncristify behavior, then I recommend we
close this issue
Abner,
I recommend we do not make this change for CCS v2.3 and either defer or close
as will not fix.
Please add notes that Uncrustify is not configured to use 80 columns and we do
not want to make another global change to format.
These global format changes make it difficult to use git blame
[AMD Official Use Only - General]
> -Original Message-
> From: Kinney, Michael D
> Sent: Sunday, November 13, 2022 10:01 AM
> To: Chang, Abner ; devel@edk2.groups.io; Michael
> Kubacki ; Kinney, Michael D
>
> Cc: Wee, Sing ; Rebecca Cran
> ; ler...@redhat.com; heyi@linaro.org
>
[AMD Official Use Only - General]
No, I don't think so. Need to update Uncrstify/PatchCheck tool if we have this
patch merged to CCS.
Abner
From: Kinney, Michael D
Sent: Sunday, November 13, 2022 9:59 AM
To: devel@edk2.groups.io; Chang, Abner ; Laszlo Ersek
; Kinney, Michael D
Subject: RE:
[AMD Official Use Only - General]
Uncrustify can fix the first argument that is not at the indent with two space.
It also can fix the first argument that is not at the new line.
But it also makes each argument a new line if multiple args are condensed in
one line. That is what we have to update
13 matches
Mail list logo
