Hello,
I saw there are several CI check failures for this 4 patches:
https://github.com/tianocore/edk2/pull/3702
Could you help to resolve them? Thanks.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> Sent: Friday, December 2, 2022 4:
Remove HOST_APPLICATION limitation for UnitTestHostBaseLib, so that
this library can be used as BaseLib by Emulator.
Also, add some missing files
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Ray Ni
---
MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 6 --
1 file changed, 4 insertion
For different compilers, both IA32 and X64 can use
Ia32/CpuFlushTlbGcc.c, which is C code (no inline assembly code).
To simplify, remove other assemly file for CpuFlushTlb,
and rename Ia32/CpuFlushTlbGcc.c to Ia32/CpuFlushTlb.c.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Ray Ni
Signed-o
Main Changes since v1 :
1.fix code format
Zihong Yi (1):
CryptoPkg/BaseCryptLib:time overflow
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
CryptoPkg/Library/BaseCryptLib/SysCall/TimerWrapper.c | 51 ++--
2 files changed, 38 insertions(+), 15 deletions(-)
--
From: Zihong Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4167
In CrtLibSupport.h, time_t is defined as INT32, and its maximum value
is 2147483647. That is, the corresponding maximum timestamp is
2038-01-19 11:14:07. Therefore, overflow occurs when the test time
exceeds 2038-01-19 11:1
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: Chang, Abner
Sent: Friday, December 2, 2022 7:36 AM
To: Rebecca Cran ; devel@edk2.groups.io; Nickle Wang
Cc: Igor Kulchytskyy
Subject: RE: [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames
External email: Use c
Fixes: CVE-2019-14560
GetEfiGlobalVariable2() is used in some instances when looking up the
SecureBoot UEFI variable. The API can fail in certain circumstances,
for example, if AllocatePool() fails or if gRT->GetVariable() fails.
In the case of secure boot checks, it is critical that this return v
Merged https://github.com/tianocore/edk2/pull/3694
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Thursday, December 1, 2022 2:27 PM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Aktas, Erdem ; James Bottomley
> ; Gerd Hoffmann ; Tom
> Lendacky
> Subj
Sorry for a question.
For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it feasible
to distinguish timeout cases with other error cases and only adjust
timeout related messages to VERBOSE level?
Best Regards,
Hao Wu
> -Original Message-
> From: Rebecca Cran
> Sent: Friday,
Improve the formatting of the documentation for functions in
ArmExceptionLib/ArmExceptionLib.c.
Signed-off-by: Rebecca Cran
---
ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 115 +++-
1 file changed, 64 insertions(+), 51 deletions(-)
diff --git a/ArmPkg/Library/ArmException
Fix the doxygen comments for CopyExceptionHandlers by removing the
nonexistant "VectorInfo" parameter and replacing it with "BaseAddress".
Fix the doxygen comments for RegisterCpuInterruptHandler by removing
the nonexistant parameter "This".
Signed-off-by: Rebecca Cran
---
ArmPkg/Library/ArmExc
Fix incorrect parameters and improve formatting of doxygen comments in
ArmExceptionLib.
Rebecca Cran (2):
ArmPkg: Fix incorrect parameter list in doxygen comments
ArmPkg: Improve formatting of docs in
ArmExceptionLib/ArmExceptionLib.c
ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 11
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, December 2, 2022 12:04 AM
> To: devel@edk2.groups.io; Chang, Abner ; Nickle
> Wang
> Cc: Rebecca Cran
> Subject: [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames
Improve the grammar of the comment in PxeReceive about ensuring that
MediaPresent is set to the correct value.
Signed-off-by: Rebecca Cran
---
NetworkPkg/SnpDxe/Receive.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/NetworkPkg/SnpDxe/Receive.c b/NetworkPkg/SnpDxe/R
The output of the "ping" command shows the time without a space between
the label and the value. e.g.:
20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time1~2ms
Improve the readability and consistency by adding an equals sign for the
time value:
20 bytes from 192.168.0.1 : icmp_seq=1 ttl=1 time=1~2
With the pending commit of UsbNetworkPkg, it will become common for
UsbBulkTransfer calls to timeout, given that the drivers are called from
MnpSystemPoll every MNP_SYS_POLL_INTERVAL milliseconds: the drivers
check for network packets by calling UsbBulkTransfer with a timeout of
1ms.
Avoid console
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Use the same vm_image as the other Linux CIs in
ArmVirtPkg, EmulatorPkg, and OvmfPkg.
Switch over to ubuntu-22.04 form ubuntu-latest.
Signed-off-by: Oliver Steffen
---
.azurepipelines/Ubuntu-GCC5.yml | 2 +-
1 file ch
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Remove BaseTools/Bin/gcc_*_ext_dep.yaml to stop
downloading gcc from external locations; use the
gcc provided by the container image instead.
The container image sets the variable GCC5_*_PREFIX accordingly.
Signed-off-by:
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and n
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and n
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and n
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number,
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number,
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number,
Reviewed-by: Michael Kubacki
On 12/1/2022 3:28 PM, Oliver Steffen wrote:
Add a new parameter "usePythonVersion" to the CI job templates.
This makes it possible to specify the version of Python to use.
The default value is '', in which case Python will not be downloaded
at runtime and the one pr
Modify all *.dsc files to make sure all parts of the CI actually run.
This is only needed to trigger the CI in the PR and shall not be merged.
Signed-off-by: Oliver Steffen
---
ArmPkg/ArmPkg.dsc | 1 +
ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc
Use the same vm_image as the other Linux CIs in
ArmVirtPkg, EmulatorPkg, and OvmfPkg.
Switch over to ubuntu-22.04 form ubuntu-latest.
Signed-off-by: Oliver Steffen
---
.azurepipelines/Ubuntu-GCC5.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/Ubuntu-GCC5.
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The
previously used ubuntu-18.04 which is not available anymore since
Dec 1st 2022.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
1 file changed, 1 inserti
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and nasm are pinned to avoid
unintended upgrades during image rebuild.
Do not run
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The
previously used ubuntu-18.04 which is not available anymore since
Dec 1st 2022.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
1 file changed, 1 ins
Switch over to ubuntu-22.04 as the vm_image for Linux CI jobs. The
previously used ubuntu-18.04 which is not available anymore since
Dec 1st 2022.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +-
1 file changed, 1 inse
Remove BaseTools/Bin/gcc_*_ext_dep.yaml to stop
downloading gcc from external locations; use the
gcc provided by the container image instead.
The container image sets the variable GCC5_*_PREFIX accordingly.
Signed-off-by: Oliver Steffen
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21
All ext_dep.yml files for gcc have been removed and gcc
is expected to be installed on the system (GCC5_*_PREFIX
may indicate the location).
No need to adjust the toolchain scopes for Linux builds
anymore.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
.pytool/CISettings.py | 9
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and nasm are pinned to avoid
unintended upgrades during image rebuild.
Use Python
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and nasm are pinned to avoid
unintended upgrades during image rebuild.
Do not run
Run all Linux based jobs in a container, using a custom Fedora 35 image
(gcc 11). The image is hosted on ghcr.io and the Dockerfiles are
here: https://github.com/tianocore/containers
The version numbers of gcc, iasl, and nasm are pinned to avoid
unintended upgrades during image rebuild.
Do not run
Add a parameter of the pr-gate-build-job template to specify a
container image URL. If the value is not '' (default), then the
jobs will be run inside a container based on that image.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
.azurepipelines/templates/pr-gate-build-job.yml
Without adding ~/.local/bin to PATH, `pip install` will throw
an error when running inside a container.
Containers will be introduced to the CI in the following commits.
Signed-off-by: Oliver Steffen
Reviewed-by: Michael Kubacki
---
.azurepipelines/templates/platform-build-run-steps.yml | 6 +++
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number, if Python shall be pulled
at CI runtime.
Signed-off-by: Oliver Steffen
---
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number, if Python shall be pulled
at CI runtime.
Signed-off-by: Oliver Steffen
---
Use the default Python version from the defaults template
(.azurepipelines/templates/defaults.yml) in the Windows and
Linux CI jobs.
Previous changes to the CI job templates make it necessary
to specify a version number, if Python shall be pulled
at CI runtime.
Signed-off-by: Oliver Steffen
---
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom
containers. This decouples the CI environment from the virtual machine
images that Azure DevOps provides. The currently used ubuntu-18.04 image
has been deprecated for a while now and will finally be removed on
Dec 1st 2022.
The con
Add a new parameter "usePythonVersion" to the CI job templates.
This makes it possible to specify the version of Python to use.
The default value is '', in which case Python will not be downloaded
at runtime and the one provided by the VM/container image will be used.
Additionally, add a template
Adjusts the requirements for the MaxPacketLength to match what is seen on
real world devices that do not follow the USB specification.
This fixes enumeration on the multiple USB 3 devices made by SanDisk,
Integral, Kingston and other generic brands.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean R
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Sign
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +
1 file changed, 9 inse
From: Matt DeVillier
On some platforms, including Sky Lake and Kaby Lake, the PSIV (Protocol
Speed ID Value) indicesare shared between Protocol Speed ID DWORD' in
the extended capabilities registers for both USB2 (Full Speed) and USB3
(Super Speed).
An example can be found below:
XhcCheckUs
Hi Mike,
Thank you for the fast response.
I will be waiting for your guidance on this topic.
Btw - I am too new in the EDK2 world to witness this Itanium
deprecation back in 2019. How such process looks like?
If it starts with update in documentation followed by the changes
in the code? How long
Reviewed the patch with Stuart and Edhaya in edk2-test monthly meeting. The
patch looks good to me. Thanks, Dimitrije.
Reviewed-by: Sunny Wang
-Original Message-
From: Dimitrije Pavlov
Sent: 10 October 2022 03:06
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Jeff Booher-Kaeding
; S
Hi Pawel,
Thank you for the patch. I agree this fixes the size issue.
However, this structure and the associated PPI are defined in the PI Spec
and other modules may depend on the structure layout and would have to be
rebuilt after this structure change.
It would be better to have a backwards
OK. Doesn't look like a big impact.
Thanks,
Brian J. Johnson
Original Message
From: Gerd Hoffmann [mailto:kra...@redhat.com]
Sent: Thursday, December 1, 2022 at 2:38 AM
To: Brian J. Johnson
Cc: devel@edk2.groups.io, Alexey Kardashevskiy , Liming
Gao , Erdem Aktas ,
Pawel Pol
Fix a typo of "RedfishLibs.dsc.inc" in RedfishLibs.dsc.inc, and correct
the name of the .fdf.inc filename in Redfish.fdf.inc.
Signed-off-by: Rebecca Cran
---
RedfishPkg/RedfishLibs.dsc.inc | 2 +-
RedfishPkg/Redfish.fdf.inc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On 10/3/22 03:26, RichardHo [何明忠] via groups.io wrote:
diff --git a/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
new file mode 100644
index 00..5db95b284c
--- /dev/null
+++ b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
+/**
+ This function is c
Due to allocation type used in HOB responsible for vCPU data allocation
EDK2 is limited to only 1024 vCPU when running with Qemu.
After some research and feedback from edk-devel mailing list it looks
like solution for this may be quie easy. Instead of changing allocation
type we can save the data b
Itanium support has been removed from EDK2 aroun 2019.
ITANIUM_HANDOFF_STATUS data structure looks to be
some leftover from that process.
There is also positive sidefect of this data structure removal.
Due to HOB allocation type used in PEI stage there is a limit
how much data about virtual CPU ca
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nickle Wang
> via groups.io
> Sent: Thursday, December 1, 2022 4:42 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Kinney, Michael D
> ; Nick Ramirez
> Subject: [edk2-devel
Reviewed-by: G Edhaya Chandran
Refactoring suggestion: Can the code for checking of the UsableMemoryBelow4G
moved to a function? Since it is used in two places.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96831): https://edk2.groups
Added the subject as somehow it didn't get set.
On 11/30/22 20:35, Alexey Kardashevskiy wrote:
Date: Tue, 22 Nov 2022 16:12:55 +1100
Subject: [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to
PcdConfidentialComputingGuestAttr
PcdConfidentialComputingGuestAttr so far only contained an SEV mode
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Chang, Abner
Sent: Wednesday, November 30, 2022 10:30 PM
To: devel@edk2.groups.io; nick...@nvidia.com
Cc: Igor Kulchytskyy ; Nick Ramirez
Subject: [EXTERNAL] RE: [edk2-devel] [edk2-staging][PATCH V2]
edk2-staging/RedfishClientPkg:
Hey
The patch caused CI failure - https://github.com/tianocore/edk2/pull/3691
Please always run Tiano CI before submit the patch.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Thursday, December 1, 2022 9:37 PM
> To: xiewenyi (A) ; devel@edk2.group
*TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, December 1, 2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?s
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, December 1, 2022
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...
Thank you!
Reviewed-by: Jiewen Yao
> -Original Message-
> From: xiewenyi (A)
> Sent: Thursday, December 1, 2022 8:34 PM
> To: Yao, Jiewen ; devel@edk2.groups.io; Wang, Jian
> J ; Lu, Xiaoyu1 ; Jiang,
> Guomin
> Cc: songdongku...@huawei.com; yizih...@huawei.com
> Subject: Re: [edk2-deve
Fix GCC build error on AARCH64 system.
Signed-off-by: Nickle Wang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Nick Ramirez
---
.../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Univer
Fix GCC build error on AARCH64 system.
Signed-off-by: Nickle Wang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Nick Ramirez
---
.../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/RegularExpressionD
On 2022/12/1 16:34, Yao, Jiewen wrote:
> Thank you!
>
> Would you please share what test you have run for this patch, such as UEFI
> secure boot? HTTPS boot?
>
Hi, Jiewen
We found this problem when importing certification and verifying the expiration
date(the verifying code is customed), so
Merged https://github.com/tianocore/edk2/pull/3690
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Friday, November 18, 2022 4:11 PM
> To: Chen, Gang C ; devel@edk2.groups.io
> Cc: Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib:
On Wed, Nov 30, 2022 at 01:28:42PM -0600, Brian J. Johnson wrote:
> Gerd,
>
> Sorry, gotta ask: does this make much difference in the size of the
> compiled code? That's a constraint on many real-hardware X64 platforms,
> especially for 32-bit code.
Quick test with OvmfPkg/OvmfPkgIa32X64.dsc (s
Thanks.
Would you please share what test you have run for this?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Li,
> Zhihao
> Sent: Wednesday, November 30, 2022 10:21 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J
>
> Subject: [edk2-devel] [PATCH v1 1/
Thank you!
Would you please share what test you have run for this patch, such as UEFI
secure boot? HTTPS boot?
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> wenyi,xie via groups.io
> Sent: Friday, November 25, 2022 5:12 PM
> To: devel@edk2.groups.io; Yao, Jiewen ; W
Reviewed-by: Jiewen Yao
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 30, 2022 1:33 AM
> To: devel@edk2.groups.io
> Cc: Erich McMillan ; Jiang, Guomin
> ; Wang, Jian J ; Yao,
> Jiewen ; Michael Kubacki
> ; Lu, Xiaoyu1
> Subject: [PATCH v2 04/12] C
71 matches
Mail list logo
