Re: [edk2-devel] [PATCH] SecurityPkg: check return value of GetEfiGlobalVariable2() in DxeImageVerificationHandler()

Thanks for the patch. Would you please share the info that, how this patch is tested? Have you created a situation to cause GetEfiGlobalVariable2() returns failure here? > -Original Message- > From: Jon Maloy > Sent: Friday, December 2, 2022 11:05 AM > To: devel@edk2.groups.io > Cc: k

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/PciHotPlugInitDxe: fix io window size

Uhmm. I assume this should be done in PciBus driver. It will be a burden to let each PciHotPlugInitDxe to fix the smallest IO window. + PciBus maintainer: Ray Ni and Hao A Wu What's your opinion? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Mo

Re: [edk2-devel] [PATCH] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb

Hi Mike Thanks for the comment. I also think the history is confusing. Yes, I used "git mv" to rename and remove, as below: git mv MdePkg/Library/BaseCpuLib/Ia32/CpuFlushTlbGcc.c MdePkg/Library/BaseCpuLib/Ia32/CpuFlushTlb.c -f But in the patch, it shows delete and modified. (I expect it shows d

Re: [edk2-devel] [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE handler

Merged https://github.com/tianocore/edk2/pull/3741 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, December 9, 2022 2:50 PM > To: Ryan Afranji ; devel@edk2.groups.io > Cc: Nakajima, Jun ; Xu, Min M > ; Aktas, Erdem ; > vannapu...@google.com > S

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: move include files to inc subdir

Hi Gerd I like the idea to put *.dsc and *.fdf to a subdirectory. I recommend to follow what we did in MinPlatformPkg. https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatformPkg/Include/Dsc https://github.com/tianocore/edk2-platforms/tree/master/Platform/Intel/MinPlatfor

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformCI: Expand Ovmf PlatformCI for Shell UnitTest

Thanks. I think this is good addition. Acked-by: Jiewen Yao Need CI expert to give reviewed-by. > -Original Message- > From: Tan, Dun > Sent: Monday, December 5, 2022 11:57 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; > Gerd Hoffmann ; Ni, Ray

Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest

Hi Sean, Thank you for creating this discussion. Looking forward to more feedback from community. Thanks, Dun From: Sean Brogan Sent: Friday, December 9, 2022 6:37 AM To: Tan, Dun ; Michael Kubacki ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH v1 5/5] OvmfPkg: Add reference to new build instructions

Good work. Thanks. Reviewed-by: Jiewen Yao > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Tuesday, December 6, 2022 1:29 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; > Gerd Hoffmann ; Sean Brogan > ; Kinney, Michael D > ; Gao

Re: [edk2-devel] [V1 PATCH 1/1] OvmfPkg: Add INVD case in #VE handler

Reviewed-by: Jiewen Yao > -Original Message- > From: Ryan Afranji > Sent: Thursday, December 8, 2022 8:51 AM > To: devel@edk2.groups.io > Cc: Nakajima, Jun ; Xu, Min M > ; Yao, Jiewen ; Aktas, Erdem > ; vannapu...@google.com; Ryan Afranji > > Subject: [V1 PATCH 1/1] OvmfPkg: Add INVD ca

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev/SecretDxe: Allocate CC secret location as runtime memory

Thanks Ard for reviewing this patch. On 09/12/2022 1:02, Ard Biesheuvel wrote: > On Thu, 8 Dec 2022 at 09:08, Dov Murik wrote: >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4186 >> >> Commit 079a58276b98 ("OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret >> area as reserved") marked th

Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest

Dun, I created this discussion on github hoping that others might have ideas/feedback. Integrate target-based testing into Platform CI for Edk2 using OVMF · Discussion #3739 · tianocore/edk2 (github.com) Lets use that to discuss and then on m

[edk2-devel] [PATCH] OvmfPkg/PlatformPei: Validate SEC's GHCB page

When running under SEV-ES, a page of shared memory is allocated for the GHCB during the SEC phase at address 0x809000. This page of memory is eventually passed to the OS as EfiConventionalMemory. When running SEV-SNP, this page is not PVALIDATE'd in the RMP table, meaning that if the guest OS tries

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Add Redfish.Settings support

BIOS feature driver cannot recognize "@Redfish.Settings", decode it and get pending setting URI. So BIOS feature driver can consume pending setting from correct place. Signed-off-by: Simon Wang Cc: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0

Re: [edk2-devel] [PATCH] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb

Did you use git mv to rename CpuFlushTlbGcc,c to CpuFlushTlb.c to preserve history? The log here shows a delete and new. Mike > -Original Message- > From: Liu, Zhiguang > Sent: Thursday, December 8, 2022 5:42 PM > To: devel@edk2.groups.io; Liu, Zhiguang > Cc: Kinney, Michael D ; Gao, L

Re: [edk2-devel] [PATCH] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb

Hi Liming and Mike, Could you help review this patch? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Friday, December 2, 2022 2:25 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Kinney, Michael D > ; Gao, Liming ; > Ni, Ray > S

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev/SecretDxe: Allocate CC secret location as runtime memory

On Thu, 8 Dec 2022 at 09:08, Dov Murik wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4186 > > Commit 079a58276b98 ("OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret > area as reserved") marked the launch secret area itself (1 page) as > reserved so it the guest OS can use it during

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 23:35, Ard Biesheuvel wrote: > > On Thu, 8 Dec 2022 at 22:57, Kinney, Michael D > wrote: > > > > Ard, > > > > Thank you for the correction. > > > > If we add that CONST, then the ShellPkg build breaks with an error > > > > c:\work\github\tianocore\edk2\ShellPkg\Application\S

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 22:57, Kinney, Michael D wrote: > > Ard, > > Thank you for the correction. > > If we add that CONST, then the ShellPkg build breaks with an error > > c:\work\github\tianocore\edk2\ShellPkg\Application\Shell\ShellProtocol.c(297): > error C2220: the following warning is treate

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

BTW...if the only fix we need is to prevent a write to a read-only page that contains a device path, then there may be a simpler fix. Given that the shell mappings are for file systems and not consoles, we never expect a multi-instance device path. This means the that the loop that is looking fo

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

Ard, Thank you for the correction. If we add that CONST, then the ShellPkg build breaks with an error c:\work\github\tianocore\edk2\ShellPkg\Application\Shell\ShellProtocol.c(297): error C2220: the following warning is treated as an error c:\work\github\tianocore\edk2\ShellPkg\Application\Shell

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 22:15, Michael D Kinney wrote: > > Hi Ard, > > There is a difference between returning a pointer to a device path > and modifying the device path contents. > > If you add CONST to the argument, then an updated pointer to a device > path can not be returned. > No, this is inc

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

Hi Ard, There is a difference between returning a pointer to a device path and modifying the device path contents. If you add CONST to the argument, then an updated pointer to a device path can not be returned. The API clear describes returning an updated device path pointer, so the API is decl

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 20:20, Kinney, Michael D wrote: > > Hi Ard, > > Much of this code has not been updated since initially added in 2010. > > Looks like a bug to me that has been there the whole time. > > I agree it is a behavior change in the implementation. But unless > new code use of this A

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

Hi Ard, Much of this code has not been updated since initially added in 2010. Looks like a bug to me that has been there the whole time. I agree it is a behavior change in the implementation. But unless new code use of this API looks at the implementation, they would not know it is destructive

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 19:28, Kinney, Michael D wrote: > > Hi Ard, > > From this description, it does not look like it should be modifying the > contents of the device path. Just point to the device path end node that > follows the match found. > > /** > Gets the mapping that most closely matche

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

Hi Ard, From this description, it does not look like it should be modifying the contents of the device path. Just point to the device path end node that follows the match found. /** Gets the mapping that most closely matches the device path. This function gets the mapping which corresponds

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Use correct type for alignment mask

On Thu, 8 Dec 2022 at 00:13, Kinney, Michael D wrote: > > Reviewed-by: Michael D Kinney > Thanks Merged as #3738 > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ard > > Biesheuvel > > Sent: Wednesday, December 7, 2022 10:01 AM > > To: devel@edk2.groups.io > > Cc:

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

On Thu, 8 Dec 2022 at 17:51, Michael D Kinney wrote: > > Hi Ard, > > Are you saying that ConvertEfiFileProtocolToShellHandle() modifies the device > path passed in? > > Is that a bug in this API? > No, the issue is in EfiShellGetMapFromDevicePath(), which calls SetDevicePathEndNode() (on line 29

Re: [edk2-devel] [PATCH] ShellPkg: Avoid corrupting installed device path protocols

Hi Ard, Are you saying that ConvertEfiFileProtocolToShellHandle() modifies the device path passed in? Is that a bug in this API? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel > Sent: Wednesday, December 7, 2022 8:13 AM > To: devel@edk2.groups.io >

[edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets

Prior to this change, deps were not generated for Arm and AARCH64 libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That resulted in bad incremental builds. Signed-off-by: Jake Garver Reviewed-by: Jeff Brasen --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(

Re: [edk2-devel] [edk2-wiki][PATCH v3 1/4] Add initial How to Build with Stuart Document

Ah, thanks for the explanation! On 12/8/22 07:21, Michael Kubacki wrote: I write it by hand. HTML comes in because I'm using collapsing content via sections. Once in those sections, normal markdown formatting does not apply. I've limited HTML usage in those sections to very simple tags that m

Re: [edk2-devel] [edk2-wiki][PATCH v3 1/4] Add initial How to Build with Stuart Document

I write it by hand. HTML comes in because I'm using collapsing content via sections. Once in those sections, normal markdown formatting does not apply. I've limited HTML usage in those sections to very simple tags that mostly map directly to features allowed in markdown formatting as well ( ->

[edk2-devel][PATCH V2 1/1] Platform/Sgi: Add memory map entry for debug uart controller

The UART0 controller connected in the AXI expansion space is used as the debug UART controller. Add platform memory map descriptor for this UART controller. Signed-off-by: Tony K Nadackal --- Changes since v1: - Enabled support for this change on RD-N2 platform as well. Platform/ARM/SgiPkg/Driv

Re: [edk2-devel] [edk2-platforms][PATCH V3 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

HI Sahil, Thank you for the updated patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 08/12/2022, 12:07, "sahil" wrote: The PNP ID 0x0A09 used for CCIX host bridge in the current code is not defined in any specification and is therefore incorr

[edk2-devel][PATCH V2 1/1] Platform/Sgi: Add support for RD-N2-Cfg3 platform

From: Vijayenthiran Subramaniam The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. A new PCD named PcdGicItsCount is introduced to speci

[edk2-devel] [edk2-platforms][PATCH V3 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

The PNP ID 0x0A09 used for CCIX host bridge in the current code is not defined in any specification and is therefore incorrect. Also, there is no need for a separate ID for CCIX host bridge, for the following reasons: 1. CCIX doesn't have any host specific requirements/ingredients as such. 2. CCI

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

Hi Sahil, Than you for this patch. Can you add some explanation to the commit message, on why this change is required and what does this patch fix, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97133): h

Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib

Yes. I am not sure if the preference for modules in other packages. But for code in UefiCpuPkg, I don't prefer this way. Thanks, Ray > -Original Message- > From: Sunil V L > Sent: Thursday, December 8, 2022 12:58 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Wang, Jian J ; Gao, Liming >

Re: [edk2-devel] [PATCH 3/3] .azurepipelines: Expand PlatformCI template for Shell UnitTest

Thank you and Sean a lot! I'll attend the CI meeting if there is any open. Thanks, Dun -Original Message- From: Michael Kubacki Sent: Thursday, December 8, 2022 10:57 AM To: devel@edk2.groups.io; Tan, Dun Cc: Sean Brogan ; Kinney, Michael D ; Gao, Liming ; Ni, Ray Subject: Re: [edk2-

[edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev/SecretDxe: Allocate CC secret location as runtime memory

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4186 Commit 079a58276b98 ("OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved") marked the launch secret area itself (1 page) as reserved so it the guest OS can use it during the lifetime of the OS. However, the address and size of