Re: [edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-11 Thread Zhiguang Liu
Hi Liming and Mike, Could you help review this patch? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Wednesday, December 7, 2022 9:37 AM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Kinney, Michael D > ; Gao, Liming ; > Ni, Ray

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Modify APIs in UnitTestPersistenceLib

2022-12-11 Thread Zhiguang Liu
Hi UnitTestFrameworkPkg Maintainers and reviewers, Could you help review this patch? Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Tuesday, December 6, 2022 1:26 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Kinney, Michael

Re: [edk2-devel] [PATCH] MdeModulePkg: Add new reviewer for Device and Peripheral modules

2022-12-11 Thread Ni, Ray
Hao, Foster, any comments? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, September 21, 2022 11:16 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Nong, Foster > Subject: [edk2-devel] [PATCH] MdeModulePkg: Add new reviewer for Device and >

[edk2-devel] [PATCH v2] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb

2022-12-11 Thread Zhiguang Liu
For different compilers, both IA32 and X64 can use Ia32/CpuFlushTlbGcc.c, which is C code (no inline assembly code). To simplify, remove other assemly file for CpuFlushTlb, and rename Ia32/CpuFlushTlbGcc.c to X86CpuFlushTlb.c. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Ray Ni

Re: [edk2-devel] [Patch 1/1] ShellPkg/Shell: Do not set end device path if already end

2022-12-11 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Ard Biesheuvel > Sent: Saturday, December 10, 2022 1:44 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > Subject: Re: [Patch 1/1] ShellPkg/Shell: Do not set end device path if

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformPei: Validate SEC's GHCB page

2022-12-11 Thread Gerd Hoffmann
Hi, > > + Status = MemEncryptSevSetPageEncMask ( > > +0, // Cr3 -- use system Cr3 > > +FixedPcdGet32 (PcdOvmfSecGhcbBase), > > +1 // Number of pages > > +); > > These arguments need to be aligned under the

Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] HI Ard, attach the patch review for the 'static'. Please check it and provide your feedback on it if you think the phrase is not strong enough. Thanks Abner > -Original Message- > From: Kinney, Michael D > Sent: Monday, November 28, 2022 11:41 PM >

Re: [edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Add Redfish.Settings support

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Simon, comments in line. > -Original Message- > From: Simon Wang (SW-GPU) > Sent: Friday, December 9, 2022 2:40 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Nick Ramirez > ; Chang, Abner ; Igor > Miroshnichenko > Subject: [edk2-staging][PATCH]

Re: [edk2-devel] [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

2022-12-11 Thread Wu, Hao A
For the 3 patches: [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block [PATCH V2] MdeModulePkg/Usb: Read a large number of blocks [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value I found that they will cause CI failures: https://github.com/tianocore/edk2/pull/3749

Re: [edk2-devel] [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2022-12-11 Thread Wu, Hao A
Sorry for a question, may I know what issue was met that leads to the proposed patch? Could you help to check if it is related with the topic discussed in https://edk2.groups.io/g/devel/topic/92833071#92165? Thanks in advance. Best Regards, Hao Wu > -Original Message- > From:

Re: [edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Library

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:41 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 2/3] edk2-staging/RedfishClientPkg: Add > Redfish

Re: [edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Protocol

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:41 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 1/3]

Re: [edk2-devel] [edk2-platform][PATCH V3 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized

2022-12-11 Thread Wu, Hao A
Pushed via: PR - https://github.com/tianocore/edk2/pull/3748 Commit - https://github.com/tianocore/edk2/commit/5890a18409a0e67a491c600b930e6c904ad3b3fd Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Thursday, December 8, 2022

Re: [edk2-devel] [edk2-staging][PATCH 3/3] edk2-staging/RedfishPkg: Add new interfaces to Redfish library

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:10 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 3/3]

Re: [edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishPkg: Introduce new interfaces to Redfish protocol

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:10 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 2/3] edk2-staging/RedfishPkg: Introduce new >

Re: [edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishPkg: Add interface to get question default value

2022-12-11 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Nickle, comments in line. > -Original Message- > From: Nickle Wang > Sent: Wednesday, December 7, 2022 10:09 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH 1/3]

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Ata: Fix command status reporting

2022-12-11 Thread Wu, Hao A
Pushed via: PR - https://github.com/tianocore/edk2/pull/3746 Commit - https://github.com/tianocore/edk2/commit/a6542894391bae58b7704b2624b541a2b8b9ed93 Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Wu, Hao A Sent: Thursday, December 8, 2022 12:21 PM To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH] MdePkg/BaseCpuLib: Remove assembly for CpuFlushTlb

2022-12-11 Thread Zhiguang Liu
Hi Mike, Good comment. I will modify and send a new version. Thanks Zhiguang > -Original Message- > From: Kinney, Michael D > Sent: Saturday, December 10, 2022 2:18 AM > To: Liu, Zhiguang ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Gao, Liming ; Ni, Ray > Subject: RE:

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, December 12, 2022 #cal-reminder

2022-12-11 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, December 12, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650222 ) *Description:*