Hi Ray,
I have updated the series as per your suggestion
(https://edk2.groups.io/g/devel/message/97440). Patches 5/23 - 9/23 are
for UefiCpuPkg. Please review and let me know if this is acceptable
approach.
Thanks
Sunil
On Wed, Dec 14, 2022 at 12:37:04PM +, Ni, Ray wrote:
> No.
> I agree tha
On Thu, Dec 15, 2022 at 09:48:59AM -0800, Tuan Phan wrote:
> The RiscV toolchain doesn't provide __ctzdi2 implementation when
> compiled with -nostdlib that needed by openssl library when EC
> enabled. So adding the simple implementation of __ctzdi2.
>
> Forcing to use CopyMem of EDK2 as builtin
Merged: https://github.com/tianocore/edk2/pull/3778
> -Original Message-
> From: Boeuf, Sebastien
> Sent: Thursday, December 15, 2022 11:10 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Xu, Min M ;
> kra...@redhat.com; Boeuf, Sebastien
> Subject: [PATCH v2 0/3] OvmfPkg: Make IntelTdx
Simplify the code to set memory used by smm page table as RO.
Since memory used by smm page table are in PageTablePool list,
we only need to set all PageTablePool as ReadOnly in smm page
table itself. Also, we only need to flush tlb once after
setting all page table pool as Read Only.
Signed-off-b
Remove SmmCpuFeaturesAllocatePageTableMemory in this headfile.
This API is not used by PiSmmCpuDxeSmm driver any more. Also
no other files use this API.
Signed-off-by: Dun Tan
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
---
UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 25
Introduce page table pool mechanism for smm page table to simplify
page table memory management and protection. This mechanism has been
used in DxeIpl. The basic idea is to allocate a bunch of continuous
pages of memory in advance, and all future page tables consumption
will happen in those pool in
1.Introduce page table pool mechanism in SMM page table
2.Remove unused API in SmmCpuFeaturesLib.h
3.Simplify the code to set smm page table as RO
Dun Tan (3):
UefiCpuPkg/PiSmmCpuDxeSmm: Introduce page table pool mechanism
UefiCpuPkg: Remove unused API in SmmCpuFeaturesLib.h
UefiCpuPkg: Simp
Hi Michael,
Thanks for your reminder.
Dongdong
> -原始邮件-发件人:"Michael Kubacki"
> 发送时间:2022-12-16 00:40:44
> (星期五)收件人:devel@edk2.groups.io抄送:"Alexei Fedorov" ,
> "Ankit Sinha" , "Ard Biesheuvel"
> , "Dongdong Zhang"
> , "Gerd Hoffmann" ,
> "Guomin Jiang" , "Jiewen Yao" ,
> "Leif Lind
Hi Sean,
Yes, that is the correct section. Hard to tell from patch email alone.
There is a git config that can always include the name of the section of the
INF/DEC/DSC/FDF file where a change is made.
Can make it a bit easier to review.
https://github.com/tianocore/tianocore.github.io/wiki/La
Hi Mike
Thank you; changed to PcdGetBool.
It's in `[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
PcdsDynamicEx]` - is that not right?
Thanks
Sean
On Thu, 15 Dec 2022 at 22:09, Kinney, Michael D
wrote:
> Hi Sean,
>
> A couple comments related to the PCD type below.
>
> Mike
>
> > ---
Hi Sean,
A couple comments related to the PCD type below.
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Thursday, December 15, 2022 1:12 PM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean ; Gao, Zhichao
> ; Ni, Ray ; Wang, Jian J
> ; Gao, Liming
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
MdeModuleP
Hey All,
Anyone able to review the EDK2 Network Pkg patch I've submitted?
The patch is below in the original email. Let me know if you'd like a fresh
patch file.
Thanks,
Zack
-Original Message-
From: Clark-williams, Zachary
Sent: Tuesday, December 6, 2022 10:42 AM
To: devel@edk2.group
Acked-by: Michael D Kinney
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, December 14, 2022 7:11 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Mistry, Nishant C
> ; Vang, Judah
>
> Subject: RE: [PATCH] SecurityPkg: deprecate RpmcLib and Varia
On Thu, 15 Dec 2022 at 14:12, Dov Murik wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4186
>
> Commit 079a58276b98 ("OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret
> area as reserved") marked the launch secret area itself (1 page) as
> reserved so the guest OS can use it during t
Michael,
I appreciate your efforts to improve code quality in all aspects.
I think this is the only part of the change that is being asked
to be adjusted (specifically for the ArmPkg and ArmVirtPkg) is
the following.
>> -"AuditOnly": True,
>> +"AuditOnly": False,
Differe
Hi Jiewen,
Thanks to Min, I've been able to fix the remaining issues.
I've just sent a v2 after I've verified the CI was passing correctly.
Thanks,
Sebastien
From: Yao, Jiewen
Sent: Thursday, December 15, 2022 3:02 AM
To: Boeuf, Sebastien ; devel@edk2.groups.io
From: Sebastien Boeuf
This is required for passing the ACPI tables from the VMM up to the
guest OS. They are transferred through this GUID extension.
Signed-off-by: Jiaqi Gao
Signed-off-by: Sebastien Boeuf
---
OvmfPkg/Library/PlatformInitLib/IntelTdx.c | 5 +
1 file changed, 5 insertions(
From: Sebastien Boeuf
Rely on CcProbe() to identify when running on TDX so that ACPI tables
can be retrieved differently for Cloud Hypervisor. Instead of relying on
the PVH structure to find the RSDP pointer, the tables are individually
passed through the HOB.
Signed-off-by: Jiaqi Gao
Signed-of
From: Sebastien Boeuf
Rely on the CcProbe() function to identify when running on TDX. This
allows the firmware to follow a different codepath for Cloud Hypervisor,
which means it doesn't rely on PVH to find out about memory below 4GiB.
instead it falls back onto the CMOS to retrieve that informat
From: Sebastien Boeuf
The IntelTdxX64 OVMF target wasn't working with Cloud Hypervisor on TDX
platform. This was due to the way the OVMF code expects Cloud Hypervisor
to rely on PVH to retrieve information like memory below 4GiB as well as
the ACPI tables.
This is why this series takes care of i
https://bugzilla.tianocore.org/show_bug.cgi?id=4195
Transfer from DXE to OS waking vector by calling SwitchStack() when
both are in the same execution mode.
Cc: Ray Ni
Cc: Zhiguang Liu
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Cc: Chinni B Duggapu
Signed-off-by: Ted K
https://bugzilla.tianocore.org/show_bug.cgi?id=4195
1.Updated the GDT table in VTF0 to align with the one in S3Resume2Pei.
By doing so can simplify the changes to enable S3 in 64bit PEI.
2.Use SwitchStack() between PEI and SMM in S3 resume path when both
are in the same execution mode.
3.Transf
This patch set enables S3 in 64bit PEI.
Ted Kuo (2):
UefiCpuPkg: Supporting S3 in 64bit PEI
MdeModulePkg: Supporting S3 in 64bit PEI
.../BootScriptExecutorDxe/ScriptExecute.c | 21 ++--
.../BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 +-
.../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c |
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4186
Commit 079a58276b98 ("OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret
area as reserved") marked the launch secret area itself (1 page) as
reserved so the guest OS can use it during the lifetime of the OS.
However, the address and size of the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add infrastructure files to build edk2 for RISC-V qemu virt machine.
- It follows PEI less design.
- Leveraged from ArmVirtQemu
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: A
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RiscVVirt is created to support EDK2 for RISC-V qemu
virt machine platform. Add maintainer entries.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Sunil V L
---
Maintainers.txt | 4
1 file changed, 4 inserti
This is mostly copied from ArmVirtPkg since RISC-V follows
similar model.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
---
OvmfPkg/Library/PlatformBootManagerLib/DxeRiscV64PlatformBootManagerLib.inf |
75 ++
OvmfPkg/Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add the SEC module for RISC-V. It uses the PEI less design.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Min Xu
Cc: Tom Lendacky
Cc: Daniel Schaefer
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is mostly copied from
edk2-platforms/Platform/RISC-V/PlatformPkg/Library/ResetSystemLib
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
Cc: Daniel Schaefer
Signed-off-by: S
Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL
to add the translation for IO access. This is copied from
ArmPciCpuIo2Dxe driver since this is required by others
like RISC-V.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
---
OvmfPkg/
This library is required to use the PEI less design for
RISC-V qemu virt support.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
---
OvmfPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf| 23
+++
OvmfPk
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is copied from
edk2-platforms/Platform/RISC-V/PlatformPkg/Universal/FdtPeim
but added as part of library instead of a separate module.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Daniel Schaefer
Signe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This module is required by other architectures like RISC-V.
Hence, move this to OvmfPkg.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
---
ArmVirtPkg/ArmVirtPkg.dec
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add the VirtNorFlashPlatformLib library for qemu virt machines.
Add two instances of the library. One which uses DT information
and the other which is static. They are copied from
ArmVirtPkg and SbsaQemu. Two PCD variables used by the libra
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
PlatformHasAcpiDtDxe is required by other architectures also.
Hence, it is moved to OvmfPkg. So, update the consumers of this
module with the new location.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-o
The NvVarStoreFormattedLib library is moved to MdeModulePkg.
So, updates its users with the new location.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
---
ArmVirtPkg/ArmVirtKvmTool.dsc| 2 +-
ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
Arm
This library is required by NorFlashDxe. Since it will be used by
both virtual and real platforms, migrate this library to
MdeModulePkg.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel Schaefer
Cc: Jian J Wang
Cc: Liming Gao
Cc: Andrew Fish
Cc: Michael D Kinney
Signed-off-b
This PCD is required to be enabled so that PrePiLib
can be used in RISC-V.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
---
EmbeddedPkg/EmbeddedPkg.dec | 3 +++
1 file changed, 3 insertions(+)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/Em
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/UefiCpuPkg.dsc | 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RISC-V register names do not follow the EDK2 formatting.
So, add it to ignore list for now.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 +
1 file change
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is mostly copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVTimerLib
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Abner Chang
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/U
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add Cpu Exception Handler library for RISC-V. This is copied
from edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVExceptionLib
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Abner Chang
Signed-off-by: Sunil V
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This DXE module initializes the timer interrupt handler
and installs the Arch Timer protocol.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/UefiCpuPkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This library is required to make SBI ecalls from the S-mode EDK2.
This is mostly copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Sunil V L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Few of the basic helper functions required for any
RISC-V CPU were added in edk2-platforms. To support
qemu virt, they need to be added in BaseLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Daniel Schaefer
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL.
Add this protocol GUID definition and the header file required.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abner Chang
Signed-off-by: Sunil V L
Acked-by
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add register definitions and access routines for RISC-V. These
headers are leveraged from opensbi repo.
Cc: Daniel Schaefer
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
MdePk
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add support for RISC-V qemu virt machine. Most of the changes are migrated from
edk2-platforms repo and followed the latest guidelines for EDK2 code
structuring.
The series has passed all CI tests (https://github.com/tianocore/edk2/pull/34
On Thu, 15 Dec 2022 at 04:26, Xu, Min M wrote:
>
> Hi, Leif/Ard/Abner/Daniel
> Since you're the maintainer/reviewer of EmbeddedPkg, would you please help to
> review this patch? Any comments is welcome.
>
I have no objections to this
Acked-by: Ard Biesheuvel
>
> > -Original Message-
>
Thanks Jiaxin.
Reviewed-by: Eric Dong
-Original Message-
From: Wu, Jiaxin
Sent: Thursday, December 15, 2022 5:41 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Ni, Ray ; Maciej Rabeda
Subject: [PATCH v1] Maintainers.txt: Update NetworkPkg & MM modules Reviewer
This is to change Networ
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, December 15, 2022 5:41 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Maciej
> Rabeda
> Subject: [PATCH v1] Maintainers.txt: Update NetworkPkg & MM modules Reviewer
>
> This is to change NetworkP
On Wed, Dec 14, 2022 at 19:04:06 -0500, Michael Kubacki wrote:
> I'm just trying to understand your position.
>
> Are you saying you would rather people check in typos and then later have
> patches come into the package to fix them?
>
> For example, like these:
>
> - ArmVirtPkg: https://edk2.gro
On Thu, 15 Dec 2022 at 09:35, wrote:
>
> From: Pierre Gondois
>
> Building the RdV1 platform fails when only providing the
> '-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
> There is only one MmUnblockMemoryLib implementation used,
> so unconditionally use this implementation.
>
This is to change NetworkPkg & MM modules Reviewer.
Cc: Eric Dong
Cc: Ray Ni
Cc: Maciej Rabeda
Signed-off-by: Jiaxin Wu
---
Maintainers.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 6a92922258..e2beafbaa6 100644
--- a/Maintai
On Thu, 15 Dec 2022 at 01:04, Michael Kubacki
wrote:
>
> I'm just trying to understand your position.
>
> Are you saying you would rather people check in typos and then later
> have patches come into the package to fix them?
>
> For example, like these:
>
> - ArmVirtPkg: https://edk2.groups.io/g/d
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF once accepts memory only by BSP. To improve the boot performance
this patch introduce the multi-core accpet memory. Multi-core means
BSP and APs work together to accept memory.
TDVF leverages mailbox to wake up APs. It
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
In the following patches TdxMailboxLib will be included in
PlatformInitLib. While PlatformInitLib is imported by some IA32/X64
platforms (for example AmdSevX64.dsc). So TdxMailboxLibNull is added in
those platforms which don'
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
This patch moves the TDX APs nasm code from SecEntry.nasm to
IntelTdxAPs.nasm. IntelTdxX64 and OvmfPkgX64 use the same nasm so that
it can be easier to be managed. In the following patch there will be
AcceptMemory related cha
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF APs once did nothing but spin around to wait for the Wakeup command.
This patch enables APs to handle the AcceptPages command. Once APs find
the AcceptPages command, it set its stack and jump to the function of
ApAcceptM
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TdxMailboxLib is designed only for TDX guest which arch is X64. This
patch set the VALID_ARCHITECTURES of TdxMailboxLib as X64.
Because in the following patches TdxMailboxLib will be included in
PlatformInitLib. While Platfo
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TdxMailboxLib once was designed to be used in DXE phase. But now it is
going to be used in SEC/PEI phase (in the following patches). Global
variables are not allowed. The library is refactored after those global
variables are
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4172
TDVF once accepts memory only by BSP. To improve the boot performance
this patch-set introduce the multi-core accpet memory. Multi-core means
BSP and APs work together to accept memory.
TDVF leverages mailbox to wake up APs. It is not enable
From: Pierre Gondois
Building the RdV1 platform fails when only providing the
'-D SECURE_BOOT_ENABLE' flag due to MmUnblockMemoryLib missing.
There is only one MmUnblockMemoryLib implementation used,
so unconditionally use this implementation.
Signed-off-by: Pierre Gondois
---
Notes:
v2:
Merged https://github.com/tianocore/edk2/pull/3774
> -Original Message-
> From: Tom Lendacky
> Sent: Tuesday, December 13, 2022 3:30 AM
> To: Adam Dunlap ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Yao, Jiewen
> ; Justen, Jordan L ; Gerd
> Hoffmann ; Brijesh Singh ;
> Aktas, Erdem ; Jam
65 matches
Mail list logo
