Thanks for the fix.
Reviewed-by: Jiewen Yao
Question: Have you run tiano CI by yourself, before submit the patch?
> -Original Message-
> From: Lee, Chun-Yi
> Sent: Thursday, December 15, 2022 10:27 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Gerd Hoffmann
> ; Yao, Jiewen ; Tom Len
Sorry, fix typo:
2. With reason above, I feel that adding comment in the code might not be the
best idea, because it is so simple that it will easily introduce
misunderstanding and confusing.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao,
> Jiewen
> Sent: Saturda
Hi Tom
Any further discussion?
I would like to merge if no other feedback.
> -Original Message-
> From: Xu, Min M
> Sent: Thursday, December 15, 2022 1:18 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Gerd Hoffmann ;
> Kinney, Michael
Hi Gerd
I would like to clarify a couple of things:
1) "Using these builds with writable flash is not secure."
Whenever we say "secure" or "not secure", we need align the threat model at
first.
What component is trusted? Which is not trusted? Who is adversary? With which
capability? Under which
On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney <
michael.d.kin...@intel.com> wrote:
> If that intrinsic is specific to RISCV, then should CompilerHelper.c go
> into a RiscV64 subdir?
Mike and Tuan,
Two comments:
1) __ctzdi2 is not riscv specific and is a part of the standard functions
provid
If that intrinsic is specific to RISCV, then should CompilerHelper.c go into a
RiscV64 subdir?
Mike
> -Original Message-
> From: Tuan Phan
> Sent: Friday, December 16, 2022 10:48 AM
> Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Kinney, Michael D
> ; Yao, Jiewen
> ; Wang, Jian J
Hi Pedro,
This is great feature. We may have some other big changes
in our git history that we may want to have an option to ignore
when using git blame.
There is a git configuration script in BaseTools/Scripts.
We can also consider adding this git config command there.
Reviewed-by: Michael D
Thank you for highlighting the issue. Makes a lot of sense with same flag used
for GCC IA32.
Mike
From: Marvin Häuser
Sent: Friday, December 16, 2022 12:08 PM
To: Pedro Falcato
Cc: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming
; Chen, Christine ; Kinney,
Michael D ; Leif Lindholm
; Andre
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Friday, December 16, 2022 11:50 AM
> To: devel@edk2.groups.io
> Cc: Pedro Falcato ; Marvin Häuser
> ; Feng, Bob C ; Gao,
> Liming ; Chen, Christine
> Subject: [edk2-
Add a .git-blame-ignore-revs file containing the hashes of every
uncrustify format commit as retrieved in:
git log --oneline --no-abbrev-commit | grep "uncrustify"
This file can be used by tools (such as GitHub[1]) to ignore
certain revisions when git blame-ing a file.
It can also be tri
PS: it's worth noting that at this moment in time, due to this, the CLANG
toolchains are very broken as they break the UEFI spec and are silently
incompatible with modules compiled in both GCC and MSVC.
Fixing this should be top priority.
Pedro
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You recei
Currently, UINT64 is not 8-byte aligned for CLANG* toolchains on IA32,
which causes ABI differences between IA32 and X64 in such simple examples as:
struct S {UINT32 A; UINT64 B;};
Pass -malign-double to align it to 8 bytes, as is done for GCC already.
Signed-off-by: Pedro Falcato
Cc: Marvin Hä
Hi Mike,
Thanks for the suggestion but I think I'm just going to avoid making
these changes in edk2, at least for now.
If package maintainers don't appreciate the work and we have to figure
out who wants what every time a patch is submitted it truly does consume
more of my time than it shoul
I haven’t tried it, but farther down on the page steps 9 and 10 look like
they’re related to the option Mike suggested, so they might be required for it
to work?
From: devel@edk2.groups.io On Behalf Of Sean Rhodes via
groups.io
Sent: Friday, December 16, 2022 1:58 AM
To: devel@edk2.groups.io;
It looks like that function call takes a double as a parameter, which is a type
of floating point number. I’m guessing that’s why the compiler is complaining
that the ‘+nofp’ feature can’t be used with that function.
From: devel@edk2.groups.io On Behalf Of Sami Mujawar via
groups.io
Sent: Frid
Only S3Resume.c is updated in patch v2 for the failure in UncrustifyCheck.
Thanks,
Ted
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kuo, Ted
Sent: Friday, December 16, 2022 8:46 PM
To: devel@edk2.groups.io
Subject: [edk2-devel][PATCH v2 0/2] Supporting S3 in 64bit PEI
This
https://bugzilla.tianocore.org/show_bug.cgi?id=4195
Transfer from DXE to OS waking vector by calling SwitchStack() when
both are in the same execution mode.
Cc: Ray Ni
Cc: Zhiguang Liu
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Cc: Chinni B Duggapu
Signed-off-by: Ted K
https://bugzilla.tianocore.org/show_bug.cgi?id=4195
1.Updated the GDT table in VTF0 to align with the one in S3Resume2Pei.
By doing so can simplify the changes to enable S3 in 64bit PEI.
2.Use SwitchStack() between PEI and SMM in S3 resume path when both
are in the same execution mode.
3.Transf
This patch set enables S3 in 64bit PEI.
Ted Kuo (2):
UefiCpuPkg: Supporting S3 in 64bit PEI
MdeModulePkg: Supporting S3 in 64bit PEI
.../BootScriptExecutorDxe/ScriptExecute.c | 21 ++--
.../BootScriptExecutorDxe/X64/SetIdtEntry.c | 4 +-
.../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c |
Ted,
Can you fix the GCC failures? Refer https://github.com/tianocore/edk2/pull/3781
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Friday, December 16, 2022 4:55 PM
> To: devel@edk2.groups.io; Kuo, Ted
> Subject: Re: [edk2-devel][PATCH v1 0/2] Supporting
Hi Vijay,
Thank you for this patch.
This patch as such looks ok to me but I am getting a build the following
failure when openssl library is being built.
build -a AARCH64 -p Platform\ARM\SgiPkg\PlatformStandaloneMm2.dsc -t GCC5 -b
DEBUG -n 1 -D EDK2_OUT_DIR=Build\ArmSgiPlatStmm2 -D SECURE_STOR
OVMF builds in stateless secure boot configuration
(SECURE_BOOT_ENABLE=TRUE + SMM_REQUIRE=FALSE) are expected to use the
emulated variable store (EmuVariableFvbRuntimeDxe) with the store being
re-initialized on each reset (see PlatformInitEmuVariableNvStore())
Using these builds with writable flas
Main Changes since v1 :
1.fix format issue found by Uncrustify
Wenyi Xie (1):
MdeModulePkg/BaseBmpSupportLib: Fix ColorMap issue
MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c | 6 ++
1 file changed, 6 insertions(+)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
When BitPerPixel is 1,4,8, there should be a color map in bmp file. But if
the format of bmp file is error, it maybe has no color map when BitPerPixel
is 1,4,8. The condition checking now can not catch this issue.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Wenyi X
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Friday, December 16, 2022 4:58 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier ; Wu, Hao A
> ; Wang, Jian J ;
> Gao, Liming ; Gao, Zhichao ;
> Ni, Ray ; Rhodes,
> Sean
> Subject:
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManager
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Sign
On some platforms, including Sky Lake and Kaby Lake, the PSIV (Protocol
Speed ID Value) indices are shared between Protocol Speed ID DWORD' in
the extended capabilities registers for both USB2 (Full Speed) and USB3
(Super Speed).
An example can be found below:
XhcCheckUsbPortSpeedUsedPsic: ch
Hi Mike
Thanks; didn't work but I'll have a play wth it!
Sean
On Thu, 15 Dec 2022 at 22:55, Michael D Kinney
wrote:
> Hi Sean,
>
>
>
> Yes, that is the correct section. Hard to tell from patch email alone.
>
>
>
> There is a git config that can always include the name of the section of
> the
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
MdeModuleP
Ted,
Thanks for your hard working on the final public patch that enables S3 in 64bit
PEI.
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo, Ted
> Sent: Thursday, December 15, 2022 10:47 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v1
Thank you Jiewen :)
From: Yao, Jiewen
Sent: Friday, December 16, 2022 4:03:00 AM
To: Boeuf, Sebastien ; devel@edk2.groups.io
Cc: Xu, Min M ; kra...@redhat.com
Subject: RE: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
Merged: https://github.c
For this patch serial
Reviewed-by: Zhiguang Liu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo, Ted
> Sent: Thursday, December 15, 2022 10:47 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v1 0/2] Supporting S3 in 64bit PEI
>
> This patch set enables S3
33 matches
Mail list logo
