Re: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload

Reviewed-by: James Lu -Original Message- From: Dong, Guo Sent: Thursday, December 22, 2022 5:25 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload From: Guo

回复: 回复: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

Create Pull Request https://github.com/tianocore/edk2/pull/3819 to merge them. Thanks Liming > -邮件原件- > 发件人: Gerd Hoffmann > 发送时间: 2022年12月21日 14:26 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: brian.john...@hpe.com; 'Alexey Kardashevskiy' ; > 'Erdem Aktas' ; 'Pawel Polaws

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewers for OVMF/Confidential Computing

Acked-by: Jiewen Yao > -Original Message- > From: Michael Roth > Sent: Thursday, December 22, 2022 1:24 AM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Xu, Min M > Subject: [PATCH] Maintainers.txt: Update reviewers for OVMF/Confident

Re: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload

Reviewed-by: -Original Message- From: Dong, Guo Sent: Thursday, December 22, 2022 5:25 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload From: Guo Dong B

Re: [edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload

LGTM but it still hangs on Qemu and real hardware. Debug build shows: Building ResourceDescriptorHobs for reserved memory: 0. - 0FFF [10] buildhob: base = 0x0, size = 0x1000, type = 0x5 1. 1000 - 0009 [01] 2. 000A - 000F

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

Thanks Mike for fixing this. On 21/12/2022 18:06, Michael Roth wrote: > The SEV-SNP Confidential Computing blob contains metadata that should > remain accessible for the life of the guest. Allocate it as > EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest > operating system

[edk2-devel][PATCH] UefiPayloadPkg: Fix boot issue for non-universal payload

From: Guo Dong BDS module was moved from DXEFV to newly created BDSFV recently. Non-universal UEFI payload doesn't support multiple FV, so it failed to boot since BDS module could not be found. This patch add BDS back to DXEFV when UNIVERSAL_PAYLOAD is not set. Cc: Ray Ni Cc: Sean Rhodes Cc: J

[edk2-devel] Error while compiling BOOT build

build.py... : error C0DE: Tools code failure Please send email to devel@edk2.groups.io for help, attaching following call stack trace! Traceback (most recent call last): File "/local/mnt/workspace/spotu/Palima/BOOT.MXF.2.0-00864-WAIPIO-1_tbu_dsbl/boot_image

Re: [edk2-devel] [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

On Wed, Dec 21, 2022 at 10:06:47AM -0600, Michael Roth wrote: > Here are a number of fixes related to OVMF handling of the SEV-SNP > Confidential Computing blob and CPUID table. > > Patch #1 is a fix for recently-reported issue that can cause > significant problems with some SEV-SNP guest operatin

[edk2-devel] [PATCH 3/4] OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation

CPUID leaf 0xD sub-leafs 0x0 and 0x1 contain cumulative sizes for the enabled XSave areas. Those sizes are calculated by tallying up all the other sub-leafs that contain per-area size information for XSave areas that are currently enabled in XCr0/XSS. The current check has the logic inverted. Fix t

Re: [edk2-devel] [PATCH v4 0/4] Fix AP Jump Table Handling for SEV-SNP

On Wed, Dec 21, 2022 at 09:50:43AM -0600, Michael Roth wrote: > A full-featured SEV-SNP guest will not rely on the AP jump table, and > will instead use the AP Creation interface defined by the GHCB. However, > a guest is still allowed to use the AP jump table if desired. > > However, unlike with

[edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

The SEV-SNP Confidential Computing blob contains metadata that should remain accessible for the life of the guest. Allocate it as EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest operating system later. Reported-by: Dov Murik Suggested-by: Dov Murik Signed-off-by: Michael

[edk2-devel] [PATCH 4/4] OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

Currently OVMF tries to rely on the base size advertised via the CPUID table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will generally work for KVM guests, but might not for other SEV-SNP hypervisor implementations. Make the handling more robust by simply using the base area size do

[edk2-devel] [PATCH v4 2/4] MdePkg: Add PcdSevSnpSecretsAddress to export SEV-SNP secrets page

OvmfPkg will initially use this to hand off the secrets page address to UefiCpuPkg, which will need this PCD to access the SEV-SNP secrets page address. Define this as an MdePkg PCD so it can be accessed by other packages alongside the secrets page struct defined in MdePkg/Include. Reviewed-by: To

[edk2-devel] [PATCH v4 1/4] MdePkg: Add header for SEV-SNP secrets page struct

This will be needed so that the AP Jump Table address can be stored for use by the operating system later, and possibly for other things in the future. Reviewed-by: Tom Lendacky Signed-off-by: Michael Roth --- MdePkg/Include/Register/Amd/SnpSecretsPage.h | 56 1 file change

[edk2-devel] [PATCH 2/4] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

The Confidential Computing blob defined here is intended to match the definition defined by linux guest kernel. Previously, both definitions relied on natural alignment, but that relies on both OVMF and kernel being compiled as 64-bit. While there aren't currently any plans to enable SNP support fo

[edk2-devel] [PATCH] Maintainers.txt: Update reviewers for OVMF/Confidential Computing

Add myself as a reviewer for OVMF/Confidential Computing patches. Remove Brijesh while at it, since he is no longer at AMD, and the email is no longer valid. Suggested-by: Tom Lendacky Signed-off-by: Michael Roth --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[edk2-devel] [PATCH v4 0/4] Fix AP Jump Table Handling for SEV-SNP

A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table a

[edk2-devel] 回覆: [PATCH v2] PcAtChipsetPkg: Move RTC PCD to dynamic PCD

Hi @Ni, Ray I've created the PR, could you help me add push label when you're available. https://github.com/tianocore/edk2/pull/3804 Thanks. [https://opengraph.githubassets.com/3850aa42841dc80e2908f3ef5866e2d1f35925baaf2b87c6c38d33bc42564239/tianocore/edk2/pull/3804]

[edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the PcdSevSnpSecretsAddress PCD during PEI phase

This needs to be set so that UefiCpuPkg can locate the SEV-SNP secrets page later to set the AP Jump Table address. Reviewed-by: Tom Lendacky Signed-off-by: Michael Roth --- OvmfPkg/AmdSev/AmdSevX64.dsc| 3 +++ OvmfPkg/CloudHv/CloudHvX64.dsc | 3 +++ OvmfPkg/IntelTdx/IntelTdxX64.ds

[edk2-devel] [PATCH 0/4] Fixes for SEV-SNP CC blob and CPUID table handling

Here are a number of fixes related to OVMF handling of the SEV-SNP Confidential Computing blob and CPUID table. Patch #1 is a fix for recently-reported issue that can cause significant problems with some SEV-SNP guest operating systems. Please consider applying this patch directly if the other pat

[edk2-devel] [PATCH v4 4/4] UefiCpuPkg: Store SEV-SNP AP jump table in the secrets page

A full-featured SEV-SNP guest will not rely on the AP jump table, and will instead use the AP Creation interface defined by the GHCB. However, a guest is still allowed to use the AP jump table if desired. However, unlike with SEV-ES guests, SEV-SNP guests should not store/retrieve the jump table a

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

On 12/21/22 10:06, Michael Roth wrote: Currently OVMF tries to rely on the base size advertised via the CPUID table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will generally work for KVM guests, but might not for other SEV-SNP hypervisor implementations. Make the handling more rob

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation

On 12/21/22 10:06, Michael Roth wrote: CPUID leaf 0xD sub-leafs 0x0 and 0x1 contain cumulative sizes for the enabled XSave areas. Those sizes are calculated by tallying up all the other sub-leafs that contain per-area size information for XSave areas that are currently enabled in XCr0/XSS. The cu

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

On 12/21/22 10:06, Michael Roth wrote: The SEV-SNP Confidential Computing blob contains metadata that should remain accessible for the life of the guest. Allocate it as EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest operating system later. Reported-by: Dov Murik Sugges

Re: [edk2-devel] [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

[AMD Official Use Only - General] Hi Hao, I just sent out three patches and below is PR which passed the CI. https://github.com/tianocore/edk2/pull/3794 Thanks Abner > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 20, 2022 11:03 AM > To: Chang, Abner ; devel@edk2.groups

[edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

From: Abner Chang Unlink the XhciPei memory block when it has been freed. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Pci/XhciPei/UsbHcMem.c | 29 - 1 file changed, 28 insertions(+

[edk2-devel] [PATCH 2/3] MdeModulePkg/Usb: Read a large number of blocks

From: Abner Chang Changes to allow reading blocks that greater than 65535 sectors. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Usb/UsbBotPei/PeiAtapi.c | 25 +++ 1 file changed, 12 ins

[edk2-devel] [PATCH 1/3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

From: Abner Chang Initialize XHCI DCI slot's context entries value. Signed-off-by: Jiangang He Cc: Hao A Wu Cc: Ray Ni Cc: Garrett Kirkendall Cc: Abner Chang Cc: Kuei-Hung Lin --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++ MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++ 2

Re: [edk2-devel] [PATCH v2 1/1] CryptoPkg: Need to enable crypto functions

Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3817 > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, December 21, 2022 11:20 AM > To: devel@edk2.groups.io; Vang, Judah ; Kinney, > Michael D > Cc: Yao, Jiewen ; Wang, Jian J > ; Xiaoyu Lu ; Jiang,

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei

Merged https://github.com/tianocore/edk2/pull/3814 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Wednesday, December 21, 2022 4:13 PM > To: Gerd Hoffmann ; devel@edk2.groups.io; > anthony.per...@citrix.com > Cc: Ard Biesheuvel ; Justen, Jordan L > >

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

Hi Joey You are welcome. Thanks to catch the issue and provide the patch. One thing to clarify: The patch submitter is expected to pass CI, *before* submit the patch. The benefit is that: If the patch passes the review, the maintainer may merge it directly. There is no need to trigger another

[edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

When set to true, the Logo is positioned according to the BGRT specification, 38.2% from the top of the screen. When set to false, no behaviour is changed and the logo is positioned centrally. Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModuleP

[edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Reset the port if status change returns an error

Force resetting the port by clearing the USB_PORT_STAT_C_RESET bit in PortChangeStatus when XhcPollPortStatusChange fails Signed-off-by: Sean Rhodes --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/XhciD

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei

Acked-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, December 20, 2022 3:26 PM > To: devel@edk2.groups.io; anthony.per...@citrix.com > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platfor

Re: [edk2-devel] [Patch V2 0/3] Introduce page table pool mechanism in SMM page table

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Wednesday, December 21, 2022 12:22 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V2 0/3] Introduce page table pool mechanism in > SMM page table > > 1.Introduce page table p

Re: [edk2-devel] [PATCH V2 0/6] Enable Multi-core based lazy-accept for TDVF

Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3813 > -Original Message- > From: Xu, Min M > Sent: Tuesday, December 20, 2022 4:43 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; Gerd Hoffmann ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky >

Re: [edk2-devel] [PATCH 2/3] OvmfPkg: Add library to handle TPL from within nested interrupt handlers

On 12/20/22 16:02, Michael Brown wrote: > On 09/12/2022 15:22, Michael Brown wrote: >> On 09/12/2022 15:02, Gerd Hoffmann wrote: Add the Nested Interrupt TPL Library (NestedInterruptTplLib) to provide helper functions that can be used by nested interrupt handlers in place of RaiseTPL

Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure

sure Mike. I will. > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, December 21, 2022 11:51 AM > To: devel@edk2.groups.io; ppola...@redhat.com; Ni, Ray ; > Zimmer, Vincent > ; Kinney, Michael D > Cc: Gao, Liming ; Liu, Zhiguang > ; Kinney, Michael D > > Subject: RE: [