Re: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested changes/additions

2022-12-29 Thread Rebecca Cran
Thanks! That was the step I was missing - I was still running edksetup.bat instead of Edk2ToolsBuild.py. -- Rebecca Cran On 12/30/22 00:07, Sean Brogan wrote: Rebecca, I don't see detailed instructions for how to build the base tools in the new wiki pages. But if you use the python /pytool

Re: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested changes/additions

2022-12-29 Thread Sean
Rebecca, I don't see detailed instructions for how to build the base tools in the new wiki pages. But if you use the python /pytool method then a path file is generated and Stuart will set the path correctly. This file should be used to build the base tools https://github.com/tianocore/edk2/blo

Re: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

2022-12-29 Thread Prakash K via groups.io
Hi Gaolimihg, The commit message title is starting with package name in PR3656. Please check the pull request and let us know PR3656 -> https://github.com/tianocore/edk2/pull/3656 Thanks, Prakash K -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

2022-12-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Sure, I am glad to provide the overview of edk2 Redfish feature. Abner > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 30, 2022 1:37 AM > To: devel@edk2.groups.io; Chang, Abner ; Kinney, > Michael D > Cc: Gao, Liming ; Liu, Zhig

Re: [edk2-devel] [PATCH 0/3] Add NULL IpmiCommandLib instance

2022-12-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Sure Mike, I had CC IPMI owners to review edk2 IPMI related patch sets. This change doesn't have a big impact on edk2-platforms because all the references of IpmiCommandLib under edk2-platfoms are in IpmiFeaturePkg itself. The old IpmiCommandLib.h will be still

Re: 回复: [edk2-devel] Reducing the size of the loongarch64 toolchain download

2022-12-29 Thread Rebecca Cran
The directory exists, that's not the problem. The issue is that it's far larger than it needs to be: we could save bandwidth and time. (.venv) bcran@cube:~/src/uefi/tmp/edk2/BaseTools/Bin/gcc_loongarch64_unknown_linux_extdep$ ldd bin/loongarch64-unknown-linux-gnu-* ... bin/loongarch64-unknown

Re: [edk2-devel] 回复: [PATCH 1/1] BaseTools: Fix IA32 UINT64 alignment for CLANG toolchains

2022-12-29 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Wednesday, December 21, 2022 9:25 AM To: 'Pedro Falcato' ; devel@edk2.groups.io Cc: 'Marvin Häuser' ; Feng, Bob C ; Chen, Christine Subject: [edk2-devel] 回复: [PATCH 1/1] Base

回复: [edk2-devel] Reducing the size of the loongarch64 toolchain download

2022-12-29 Thread gaoliming via groups.io
Rebecca: BaseTools/Bin/gcc_loongarch64_unknown_linux_extdep directory should be created after Stuart build. Please confirm it. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2022年12月28日 16:15 > 收件人: Chao Li ; Baoqi Zhang > ; Dongyan Qian > 抄送: devel@edk2.gr

[edk2-devel] 回复: [PATCH 1/1] MdePkg: Label CreateEvent NotifyFunction and NotifyContext optional

2022-12-29 Thread gaoliming via groups.io
Rebecca: CreateEvent implementation in DxeMain has followed this definition. So, only this change is required. Reviewed-by: Liming Gao for this patch. Thanks Liming > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2022年12月24日 7:48 > 收件人: devel@edk2.groups.io; Michael D Kinney > ; Liming Gao ;

回复: [edk2-devel] [PATCH] MdeModulePkg/Bus/Ata/AhciPei: Fix DEADCODE Coverity issue

2022-12-29 Thread gaoliming via groups.io
Ranbir: This change is good. Reviewed-by: Liming Gao Thanks Liming 发件人: devel@edk2.groups.io 代表 Ranbir Singh via groups.io 发送时间: 2022年12月22日 18:06 收件人: devel@edk2.groups.io 主题: [edk2-devel] [PATCH] MdeModulePkg/Bus/Ata/AhciPei: Fix DEADCODE Coverity issue Hi All, The attached patch

Re: [edk2-devel] [PATCH v3 12/16] ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot

2022-12-29 Thread dann frazier
On Mon, Sep 26, 2022 at 10:25:07AM +0200, Ard Biesheuvel wrote: > Now that we have all the pieces in place, switch the AArch64 version of > ArmVirtQemu to a mode where the first thing it does out of reset is > enable a preliminary ID map that covers the NOR flash and sufficient > DRAM to create the

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

2022-12-29 Thread dann frazier
On Mon, Nov 28, 2022 at 04:46:10PM +0100, Gerd Hoffmann wrote: > On Mon, Sep 26, 2022 at 10:24:58AM +0200, Ard Biesheuvel wrote: > > When the memory protections were implemented and enabled on ArmVirtQemu > > 5+ years ago, we had to work around the fact that GRUB at the time > > expected EFI_LOADER

Re: [edk2-devel] Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT]

2022-12-29 Thread Hsu, VictorX
Hi @Kinney, Michael D Please review https://github.com/tianocore/edk2/pull/3793 for below questions. 1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master * tianocore/edk2 * GitHub

[edk2-devel] [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD

2022-12-29 Thread kasimx . liu
From: KasimX Liu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193 In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx Cc: Guo Dong Cc: Ray Ni Cc: James Lu Cc: Gua Guo Signed-off-by: KasimX

[edk2-devel] Add compiled firmware binaries to CI build artifacts

2022-12-29 Thread Erich
Hi All, Maybe these are uploaded to a separate location, if so apologies hope you can point me in the right direction :) I am wondering if we can publish the .bin (.fd) files produced by builds into the pipeline artifacts so downstream consumers can download latest .bin files without having to wo

Re: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested changes/additions

2022-12-29 Thread Michael D Kinney
+ Michael Kubacki > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Saturday, December 24, 2022 9:38 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Subject: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested > changes/additions > > Mike

Re: [edk2-devel] [PATCH V2 0/3] IPMI changes for Redfish

2022-12-29 Thread Michael D Kinney
Hi Abner, Can you provide an overview of the RedFish features that are required to interact with HW interfaces such as USB and IPMI and network services? I am wondering if these can be abstracted through dynamic interfaces such as PPI/Protocol instead of static interfaces such as library classe

Re: [edk2-devel] [PATCH 0/3] Add NULL IpmiCommandLib instance

2022-12-29 Thread Michael D Kinney
Hi Abner, Since this is moving content from edk2-platforms to edk2, we need to make sure that migration is coordinated with the edk2-platforms owners for the IPMPI feature and we have a transition plan for all downstream platform DSC files to use the content from the new location. These types

Re: [edk2-devel] Unable to run the stuart tools on (Intel) macOS

2022-12-29 Thread Michael D Kinney
+Andrew Fish From: Rebecca Cran Sent: Wednesday, December 28, 2022 3:58 PM To: devel@edk2.groups.io; Sean Brogan ; Michael Kubacki ; Kinney, Michael D ; Gao, Liming Subject: Unable to run the stuart tools on (Intel) macOS I was wondering if anyone's looked into running the stuart tools on

Re: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested changes/additions

2022-12-29 Thread Michael D Kinney
+Michael Kubacki > -Original Message- > From: Rebecca Cran > Sent: Wednesday, December 28, 2022 7:47 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Subject: Re: [edk2-devel] edk2-wiki: "How to build with Stuart" - suggested > changes/additions > > I also found a problem on Windows.

Re: [edk2-devel] [PATCH] BaseTools: Use BUILD_CC when checking gcc version in DevicePath

2022-12-29 Thread Bob Feng
Thank you for fixing this issue. Reviewed-by: Bob Feng -Original Message- From: Jake Garver Sent: Tuesday, December 20, 2022 9:14 PM To: devel@edk2.groups.io Cc: jbra...@nvidia.com; ashishsin...@nvidia.com; Feng, Bob C ; Gao, Liming ; Chen, Christine ; Jake Garver Subject: [PATCH] B

Re: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets

2022-12-29 Thread Bob Feng
This patch is good to me. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Jake Garver via groups.io Sent: Friday, December 9, 2022 12:22 AM To: devel@edk2.groups.io; jbra...@nvidia.com; ashishsin...@nvidia.com Cc: Jake Garver Subject: [edk2-devel] [PAT

Re: [edk2-devel] [Patch V2 3/3] [edk2-staging]BaseTools: Add new build option for Variable default value generation

2022-12-29 Thread Bob Feng
Hi Christine, Could you send out the entire patch series together? Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Tuesday, November 15, 2022 4:47 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch V2 3/3] [edk

devel@edk2.groups.io

2022-12-29 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Chiang, Dakota Sent: Tuesday, December 27, 2022 5:23 PM To: devel@edk2.groups.io Cc: Chiang, Dakota ; Feng, Bob C ; Gao, Liming ; Lin, Jason1 ; Kumar, Rahul R Subject: [PATCH] S-ACM entry ver 0x200 does not contain requested FMS&mask Fr

Re: [edk2-devel] [PATCH V1 0/2] Refactor TDX MmioExit

2022-12-29 Thread Min Xu
Code: https://github.com/mxu9/edk2/tree/TdxMmioExit.v1 > -Original Message- > From: Xu, Min M > Sent: Thursday, December 29, 2022 4:56 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Gerd Hoffmann ; > Tom Lendacky ; Ryan Afranji > > Subj

[edk2-devel] [PATCH V1 2/2] OvmfPkg/CcExitLib: Refactor TDX MmioExit

2022-12-29 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169 The previous TDX MmioExit doesn't handle the Mmio instructions correctly in some scenarios. This patch refactors the implementation to fix the issues. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann

[edk2-devel] [PATCH V1 1/2] OvmfPkg/CcExitLib: Move common X86 instruction code to separate file

2022-12-29 Thread Min Xu
From: Min M Xu https://bugzilla.tianocore.org/show_bug.cgi?id=4169 Move common X86 instruction codes from CcExitVcHandler.c to separate files (CcInstruction.h / CcInstruction.c) so that these codes can be re-used in TDX. Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao C

[edk2-devel] [PATCH V1 0/2] Refactor TDX MmioExit

2022-12-29 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169 The previous TDX MmioExit doesn't handle the Mmio instructions correctly in some scenarios. This patch-set refactors the implementation to fix the issues. Before the refactoring, common X86 instruction codes in CcExitVcHandler.c are moved to