Re: [edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

Hi Dov/Ard Please allow me to clarify: EfiACPIReclaimMemory in UEFI spec means: OS may use the memory, after it copies the ACPI table to its own location. It is also called "AddressRangeACPI" in ACPI spec. [2] https://uefi.org/specs/ACPI/6.5/15_System_Address_Map_Interfaces.html, search Addres

[edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3845 Enables KVM and One Click Recovery WLAN capability with WiFi Profile Sync feature and protocol. Adding WiFiProfileSyncProtocol, which supports the profilesync driver operations for transferring WiFi profiles fr

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

Thank you Jiaxin, Find my responses inline. An updated patch with requested changes is in route today. Thanks, Zack -Original Message- From: Wu, Jiaxin Sent: Thursday, January 5, 2023 9:09 PM To: Clark-williams, Zachary ; devel@edk2.groups.io; Kinney, Michael D Cc: Zachary C

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

Hi Rebecca, Thanks for sharing this patch. I found a few minor issues when running this test app. Please see comments with [KQ] below. Regards, Kun On 1/4/2023 7:37 AM, Rebecca Cran wrote: The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL. usage: MpServicesTest -A [-O

Re: [edk2-devel] [PATCH v4 2/3] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Sorry, hit the send button too soon... One more comment under [KQ-2]. Thanks, Kun On 1/6/2023 2:11 PM, Kun Qin via groups.io wrote: Hi Rebecca, I have tried to use this for a few different scenarios and below is a few minor issues I have found and potential changes (marked with [KQ]). Please

Re: [edk2-devel] [PATCH v4 2/3] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Hi Rebecca, I have tried to use this for a few different scenarios and below is a few minor issues I have found and potential changes (marked with [KQ]). Please let me know if I have any misunderstanding on the protocol itself. Thanks, Kun On 1/4/2023 7:37 AM, Rebecca Cran wrote: Add suppor

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/PlatformInitLib: check 64bit mmio window for resource conflicts

On Fri, Jan 6, 2023 at 2:04 PM Gerd Hoffmann wrote: > Add new operation mode to PlatformScanOrAdd64BitE820Ram() which checks > whenever any reservations from the qemu e820 table overlap with the mmio > window. Should that be the case move it to avoid the conflict. > Hi, In what case could this

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

Hi Jiewen, On 06/01/2023 11:18, Yao, Jiewen wrote: > Are you sure you want to use EfiACPIReclaimMemory ? > > Usually EfiACPIReclaimMemory is only for ACPI table, which can be reclaimed > and used by OS, after copy ACPI table. > > If you want to claim the memory owned by firmware (not owned by O

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

On 1/6/23 04:02, Laszlo Ersek wrote: The ShellLib dependency was incorrectly used for bringing in "gEfiShellParametersProtocolGuid". But "gEfiShellParametersProtocolGuid" is a standard protocol GUID, it is declared in "MdePkg/MdePkg.dec". So you just need to spell it out in the [Protocols] secti

Re: [edk2-devel] [PATCH edk2-platforms] Platform/RPi4: Add EFI_MP_SERVICES_PROTOCOL support

Reviewed-by: Rebecca Cran -- Rebecca Cran On 1/5/23 10:01, Ard Biesheuvel wrote: Fix the ARM_MPCORE_INFO table and incorporate the DXE driver and test app to the build so that EFI_MP_SERVICES_PROTOCOL can be used and tested on Raspberry Pi 4. Note that the test app is not added to the image -

Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

The patches aren't attached to the cover letter, but are separate emails. You should be able to find them by looking for "PATCH v4 1/3", "PATCH v4 2/3" etc. I've made several changes to the WaitEvent handling in the latest patch: could you check if the problem has been fixed please? -- Rebec

Re: [edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

Hi Rebecca, Thanks for the information. Somehow these patches (i.e. https://edk2.groups.io/g/devel/message/98106) just landed on groups.io last night. I will test the latest version of your patches and reply back here. Regards, Kun On 1/6/2023 10:42 AM, Rebecca Cran wrote: The patches aren'

Re: [edk2-devel] PING [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

Le Thu, Jan 05, 2023 at 11:40:43PM +, Pedro Falcato a écrit : > On Thu, Jan 5, 2023 at 11:50 AM wrote: > > > Hello, > > > > Ping'ing for this patch sent on November 2022. > > > > The patch is trivial. Can someone review it or eventually merge it if OK? > > > > TIA, > > -- > > Thierry

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 02:03, Gerd Hoffmann wrote: On Fri, Jan 06, 2023 at 07:42:20AM +0100, Laszlo Ersek wrote: On 1/6/23 05:12, Ni, Ray wrote: Ard, Only AMD X64 (including SEV and without SEV) runs the code that switches to 32bit paging disabled mode. Intel X64 runs the code that stays at 64bit paging m

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

I recommend also add detailed information in the code as comment. That can help people who only reads the code directly. Thank you Yao, Jiewen > -Original Message- > From: Gerd Hoffmann > Sent: Friday, January 6, 2023 11:32 PM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Ard Bieshe

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

On Fri, Jan 06, 2023 at 03:14:53PM +0100, Ard Biesheuvel wrote: > Hi Gerd, > > On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann wrote: > > > > > > > > Gerd Hoffmann (2): > > OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram > > documentation > > OvmfPkg/PlatformInitLib: check 64bit

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

> The developers of CryptoConsumer always build binary based on latest platform > code. If so, how you guarantee the compatibility between CryptoConsumer and old other platform code? The saftest way is always to build CryptoConsumer with old platform, then replace it with the one in the old pl

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

>However, I am still not sure why the CryptoConsumer need link a higher version >CryptoLib wrapper, if it wants to work with old CryptoBin. The developers of CryptoConsumer always build binary based on latest platform code. They prefer to keep the integrity of the platform code instead of changi

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Hi Gerd, On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram > documentation > OvmfPkg/PlatformInitLib: check 64bit mmio window for resource > conflicts > > OvmfPkg/Library/PlatformInitLib/MemDet

[edk2-devel] [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts

Gerd Hoffmann (2): OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation OvmfPkg/PlatformInitLib: check 64bit mmio window for resource conflicts OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63 + 1 file changed, 51 insertions(+), 12 deleti

[edk2-devel] [PATCH 2/2] OvmfPkg/PlatformInitLib: check 64bit mmio window for resource conflicts

Add new operation mode to PlatformScanOrAdd64BitE820Ram() which checks whenever any reservations from the qemu e820 table overlap with the mmio window. Should that be the case move it to avoid the conflict. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 47 ++

[edk2-devel] [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation

Documentation of PlatformScanOrAdd64BitE820Ram() ran out of sync with the implementation. Fix that. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/Library/PlatformInitLib/

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 12:14, Gerd Hoffmann wrote: > Hi, > >> Now, there *is* one benefit I can imagine. For Intel maintainers, it may >> be difficult to maintain and to "route around" the SEV-related stuff in >> "X64/MpFuncs.nasm", in the long term. I can wholly accept that. So >> splitting and duplicating

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

Hi Yi I believe I have some misunderstanding, after I read the definition again. According to https://github.com/tianocore/edk2/blob/master/CryptoPkg/Private/Protocol/Crypto.h#L24, the version means "The version of the EDK II Crypto Protocol." It is not the version of the implementation. As such

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewers for OVMF/Confidential Computing

Merged https://github.com/tianocore/edk2/pull/3864 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, January 6, 2023 5:01 PM > To: Michael Roth ; devel@edk2.groups.io > Cc: Tom Lendacky ; Aktas, Erdem > ; James Bottomley ; Xu, > Min M > Subject:

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

Perhaps we can ask developers to update the minimum version of CyptoAPI after bug or security fixes. [Jiewen] First, this is a new requirement. Hard to enforce. Second, if you do this, then you *may* need update the CryptoBin, if CryptoConsumer is updated. Third, it is hard to determine *when* t

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

Hi, > Now, there *is* one benefit I can imagine. For Intel maintainers, it may > be difficult to maintain and to "route around" the SEV-related stuff in > "X64/MpFuncs.nasm", in the long term. I can wholly accept that. So > splitting and duplicating the assembly code for that purpose is > justif

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

Hi Jiewen, Thanks for feedback. >If you can upgrade the CryptoConsumer, why not upgrade the CryptoBin at the >same time? 1. CryptoConsumer and CryptoBin are usually delivered by different people. For example, some features that require CryptoBin are responsible for by an independent team, but

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

On 1/6/23 10:40, Ard Biesheuvel wrote: > On Wed, 4 Jan 2023 at 16:37, Rebecca Cran wrote: >> >> The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL. >> >> usage: >> MpServicesTest -A [-O] >> MpServicesTest -T >> MpServicesTest -S >> MpServicesTest -P >> MpServicesTest

Re: [edk2-devel] [PATCH V1 1/1] SecurityPkg: Move TdTcg2Dxe from OvmfPkg to SecurityPkg

Merged https://github.com/tianocore/edk2/pull/3862 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Friday, January 6, 2023 4:05 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Wang, Jian J ; Arti Gupta > Subject: Re: [edk2-devel] [PATCH V1 1/1] Securi

[edk2-devel] 回覆: [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD

Hi @Dong, Guo I've created the PR, could you help me add push label when you're available. https://github.com/tianocore/edk2/pull/3856 Thanks. 寄件者: Dong, Guo 寄件日期: 2023年1月5日 上午 07:16 收件者: Liu, KasimX ; devel@edk2.groups.io 副本: Ni, R

[edk2-devel] edk2 BUILD error issue on Win 11

Hi,  I am attempting EDK2  build on Win 11 but I get Key error "WORKSPACE"  (see end of followin trace:)Please assist.Thanks,Avijit Note: VS2019 Professional installed, iasl and nasm installed, python 3.10. (.venv) PS C:\edk2> stuart_UPDATE -c OvmfPkg/PlatformCI/PlatformBuild.py TOOL_CHAIN_TAG=VS

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

Thanks for the review -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98112): https://edk2.groups.io/g/devel/message/98112 Mute This Topic: https://groups.io/mt/96046622/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://ed

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

Thanks for the review! -Original Message- From: Ni, Ray Sent: Friday, January 6, 2023 9:01 AM To: Oram, Isaac W ; Chang, Hunter ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; S, Ashraf Ali Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionIn

[edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

From: Hunter Chang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242 Define a macro for SmbiosFeaturePkg usage which named INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in IndustryStandard/FirmwareVersionInfo.h Signed-off-by: Hunter Chang Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac

Re: [edk2-devel] [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h

It is from Sipkg.dec gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are available for system- and OEM-specific information I think there is no spec define 0xDD. -Original Message- From: Ni, Ray Sent: Thursday, January 5, 2023

[edk2-devel] [PATCH v4 2/3] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under AArch64. PSCI_CPU_ON is called to power on the core, the supplied procedure is executed and PSCI_CPU_OFF is called to power off the core. Fixes contributed by Ard Biesheuvel. Signed-off-by: Rebecca Cran --- ArmPkg/ArmPkg.dsc

[edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL. usage: MpServicesTest -A [-O] MpServicesTest -T MpServicesTest -S MpServicesTest -P MpServicesTest -U MpServicesTest -W MpServicesTest -E MpServicesTest -D MpServicesTest -h Parameter: -A: Run all APs.

[edk2-devel] [PATCH v3 2/3] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under AArch64. PSCI_CPU_ON is called to power on the core, the supplied procedure is executed and PSCI_CPU_OFF is called to power off the core. Fixes contributed by Ard Biesheuvel. Signed-off-by: Rebecca Cran Reviewed-by: Ard Biesheu

[edk2-devel] [PATCH v4 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add an MpServicesTest application to exercise it

Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64, and add an MpServicesTest application to exercise it. Changes from v3: Removed Ard's 'Reviewed-by' line from the commits since the code has changed sufficiently that it's no longer valid. Rebecca Cran (3): ArmPkg: Add GET_MPID

[edk2-devel] [PATCH v3 3/3] MdeModulePkg: Add new Application/MpServicesTest application

The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL. usage: MpServicesTest -A [-O] MpServicesTest -T MpServicesTest -S MpServicesTest -P MpServicesTest -U MpServicesTest -W MpServicesTest -E MpServicesTest -D MpServicesTest -h Parameter: -A: Run all APs.

[edk2-devel] [PATCH v4 1/3] ArmPkg: Add GET_MPIDR_AFFINITY_BITS and MPIDR_MT_BIT to ArmLib.h

Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/ArmLib.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h index 6566deebdde2..fa605f128bfd 100644 --- a/ArmPkg/Include/Library/ArmLib.h +++

[edk2-devel] [PATCH v3 0/3] ArmPkg,MdeModulePkg: Implement EFI_MP_SERVICES_PROTOCOL for AArch64 and add MpServicesTest application

Implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls for AArch64, and add an MpServicesTest application to exercise it. Changes from v2: - Moved definition of MT bit and macro to get affinity bits into ArmLib.h. - Fixed issues noted during review. - Fixed various issues in non-blocking mode.

[edk2-devel] [PATCH v3 1/3] ArmPkg: Add GET_MPIDR_AFFINITY_BITS and MPIDR_MT_BIT to ArmLib.h

Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/ArmLib.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h index 6566deebdde2..fa605f128bfd 100644 --- a/ArmPkg/Include/Library/ArmLib.h +++

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 10:45, Ni, Ray wrote: >> This makes sense, but, again, even disregarding the problem that the >> code forgot to switch to the new page table, the idea should be spelled >> out in the commit message and/or in code comments. Preferably: both. >> >> (In fact if the idea had been documented,

Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

Hi Moritz, Apologies for typing your name incorrectly in my previous email. Regards, Sami Mujawar On 06/01/2023 09:55 am, Sami Mujawar via groups.io wrote: Hi Ard, Mortiz, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 06/01/2023 09:15 am, Ard Biesheuvel wrote: (c

[edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

fix debug print error level hob not save correct debugprinterrorlevel should cover the case: Header.Lenth ==UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD () Change-Id: Ibebe29fe8057e24448b31a8caa7ab6eb8054c39b BugZilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4264 Signed-off-by: Ning Feng ---

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

On 1/6/23 10:55, Laszlo Ersek wrote: > On 1/4/23 12:11, Gerd Hoffmann wrote: > >> The versions are not that ancient. The problem is more that upstream >> grub is really slow on integrating patches so every distro does carry >> a huge pile of downstream patches. And they seem to re-introduce the

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Make Protocol Service API backward compatible

Thanks Yi. You raised a very interesting question. + Mike Kinney, to comment from the requirement perspective. The original design is very simple: CryptoBin.Version >= CryptoConsumer.Version. Now you want to handle the case that: CryptoConsumer.Version > CryptoBin.Version, but the CryptoConsume

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

On 1/4/23 12:11, Gerd Hoffmann wrote: > The versions are not that ancient. The problem is more that upstream > grub is really slow on integrating patches so every distro does carry > a huge pile of downstream patches. And they seem to re-introduce the > bug ... See also: commit d20b06a3afdf ("O

Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

Hi Ard, Mortiz, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 06/01/2023 09:15 am, Ard Biesheuvel wrote: (cc Sami) On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io wrote: Linux' cpu DT bindings call out

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

> This makes sense, but, again, even disregarding the problem that the > code forgot to switch to the new page table, the idea should be spelled > out in the commit message and/or in code comments. Preferably: both. > > (In fact if the idea had been documented, Yuanhao might not have > forgotten t

Re: [edk2-devel] [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl

Would you please file a Bugzilla to describe the issue? > -Original Message- > From: Chen, Gang C > Sent: Thursday, January 5, 2023 11:20 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Chen, Gang C > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable

Re: [edk2-devel] [PATCH 1/1] SecurityPkg/AuthVariableLib: Check SHA-256 OID with ContentInfo present

Hi That is good catch! My apology to miss it before. 1) Please file a bugzilla (https://bugzilla.tianocore.org/) to record the issue and associate to the patch. 2) Would you please share with us that how you discover the issue? For example, any real use case to include ContentInfo? If yes, pleas

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

On Wed, 4 Jan 2023 at 16:37, Rebecca Cran wrote: > > The MpServicesTest application exercises the EFI_MP_SERVICES_PROTOCOL. > > usage: > MpServicesTest -A [-O] > MpServicesTest -T > MpServicesTest -S > MpServicesTest -P > MpServicesTest -U > MpServicesTest -W > MpServicesTest -E >

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 09:39, Ni, Ray wrote: > > >> -Original Message- >> From: Laszlo Ersek >> Sent: Friday, January 6, 2023 4:31 PM >> To: Gerd Hoffmann >> Cc: devel@edk2.groups.io; Ni, Ray ; a...@kernel.org; Xie, >> Yuanhao ; >> thomas.lenda...@amd.com >> Subject: Re: [edk2-devel] [PATCH] UefiCp

Re: [edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the PcdSevSnpSecretsAddress PCD during PEI phase

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Roth, > Michael via groups.io > Sent: Wednesday, December 21, 2022 11:51 PM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Ni, Ray > Subject: [edk2-devel] [PATCH v4 3/4] OvmfPkg: Initialize the > PcdSev

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/AmdSevDxe: Allocate SEV-SNP CC blob as EfiACPIReclaimMemory

Are you sure you want to use EfiACPIReclaimMemory ? Usually EfiACPIReclaimMemory is only for ACPI table, which can be reclaimed and used by OS, after copy ACPI table. If you want to claim the memory owned by firmware (not owned by OS), you need use ACPINvs or reserved. Although I don't fully

Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

(cc Sami) On Fri, 6 Jan 2023 at 10:14, Ard Biesheuvel wrote: > > On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io > wrote: > > > > Linux' cpu DT bindings call out arm,armv8 while the code previously > > used arm,arm-v8. > > > > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add

Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

On Fri, 6 Jan 2023 at 00:07, Moritz Fischer via groups.io wrote: > > Linux' cpu DT bindings call out arm,armv8 while the code previously > used arm,arm-v8. > > Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") > Signed-off-by: Moritz Fischer > --- > DynamicTablesPkg/Librar

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/AmdSevDxe: Update ConfidentialComputing blob struct definition

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Roth, > Michael via groups.io > Sent: Thursday, December 22, 2022 12:07 AM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Ni, Ray > Subject: [edk2-devel] [PATCH 2/4] OvmfPkg/AmdSevDxe: Update > Confiden

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 09:43, Xie, Yuanhao wrote: > Hi all, > > Thanks for feedbacks. I will revert the original ones, and send the > new version. OK, thanks. Please pay attention the ordering of the reverts. The original series was merged in the following order: (a) 1 7bda8c648192 UefiCpuPkg: Duplicated A

Re: [edk2-devel] [PATCH] Maintainers.txt: Update reviewers for OVMF/Confidential Computing

Acked-by: Jiewen Yao > -Original Message- > From: Michael Roth > Sent: Thursday, December 22, 2022 1:24 AM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Xu, Min M > Subject: [PATCH] Maintainers.txt: Update reviewers for OVMF/Confident

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/CcExitLib: Use documented XSave area base size for SEV-SNP

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Roth, > Michael via groups.io > Sent: Thursday, December 22, 2022 12:07 AM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Ni, Ray > Subject: [edk2-devel] [PATCH 4/4] OvmfPkg/CcExitLib: Use documented >

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/CcExitLib: Fix SEV-SNP XSave area size calculation

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Roth, > Michael via groups.io > Sent: Thursday, December 22, 2022 12:07 AM > To: devel@edk2.groups.io > Cc: Tom Lendacky ; Ni, Ray > ; Pavan Kumar Paluri > Subject: [edk2-devel] [PATCH 3/4] OvmfPkg/CcExi

Re: [edk2-devel] [PATCH V1 2/2] OvmfPkg/CcExitLib: Refactor TDX MmioExit

Thanks for the cleanup. Comments inline. In general, we need ensure CpuDeadLoop() for *any* parsing error in VE handler. Just ASSERT or VmCall(HALT) is not enough, because ASSERT == nothing in release, while VmCall(HALT) is not trusted. ASSERT can only be used to handle internal impossible logi

Re: [edk2-devel] [PATCH v3 03/16] ArmVirtPkg: make EFI_LOADER_DATA non-executable

Hi, > Hopefully sometime in the next few weeks we can prepare a comprehensive set > of patches and changes needed in edk2 to implement this strict environment.  > One of the relevant changes to this discussion and patch series is we > switched the configuration from PCD to hob > (mu_basecore/Dxe

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

Hi all, Thanks for feedbacks. I will revert the original ones, and send the new version. Yuanhao -Original Message- From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann Sent: Friday, January 6, 2023 4:03 PM To: Laszlo Ersek Cc: devel@edk2.groups.io; Ni, Ray ; a...@kernel.org; Xie, Yu

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

> -Original Message- > From: Laszlo Ersek > Sent: Friday, January 6, 2023 4:31 PM > To: Gerd Hoffmann > Cc: devel@edk2.groups.io; Ni, Ray ; a...@kernel.org; Xie, > Yuanhao ; > thomas.lenda...@amd.com > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and > ens

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On 1/6/23 09:03, Gerd Hoffmann wrote: > On Fri, Jan 06, 2023 at 07:42:20AM +0100, Laszlo Ersek wrote: >> On 1/6/23 05:12, Ni, Ray wrote: >>> >>> Ard, >>> >>> Only AMD X64 (including SEV and without SEV) runs the code that >>> switches to 32bit paging disabled mode. >>> Intel X64 runs the code that

Re: [edk2-devel] [PATCH V1 1/2] OvmfPkg/CcExitLib: Move common X86 instruction code to separate file

Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Thursday, December 29, 2022 4:56 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Gerd Hoffmann > ; Aktas, Erdem ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky > Subject: [PATCH V1 1/2] OvmfPkg/CcExitLib: Move com

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: designate Gerd Hoffmann as UefiCpuPkg reviewer

On 1/4/23 15:06, Ni, Ray wrote: > Reviewed-by: Ray Ni Thanks; PR#3861 / commit 0aca5901e344. Laszlo > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, January 4, 2023 12:06 AM >> To: devel@edk2.groups.io >> Cc: Andrew Fish ; Dong, Eric ; Gerd >> Hoffmann ; Leif >> Lind

Re: [edk2-devel] [PATCH V1 1/1] SecurityPkg: Move TdTcg2Dxe from OvmfPkg to SecurityPkg

Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Wednesday, January 4, 2023 9:14 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J ; Arti Gupta > Subject: [PATCH V1 1/1] SecurityPkg: Move TdTcg2Dxe from OvmfPkg to > SecurityPkg > > From:

Re: [edk2-devel] [PATCH] UefiCpuPkg:Fixed AsmRelocateApLoopStart and ensure allocated memory <4GB

On Fri, Jan 06, 2023 at 07:42:20AM +0100, Laszlo Ersek wrote: > On 1/6/23 05:12, Ni, Ray wrote: > > > > Ard, > > > > Only AMD X64 (including SEV and without SEV) runs the code that > > switches to 32bit paging disabled mode. > > Intel X64 runs the code that stays at 64bit paging mode. So no need >