Re: [edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/Loongson: Support pflash for loongarch.

2023-01-09 Thread Chao Li
I suggest to splitting this patch into two, one for adding new driver, and one for adjusting the code. Thanks, Chao 在 2023/1/10 09:16, xianglai 写道: Add pflash driver for loongarch. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by:

Re: [edk2-devel] [PATCH V2 5/6] OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol

2023-01-09 Thread Min Xu
On January 10, 2023 1:51 PM, Laszlo Ersek wrote: > > So, I think this patch is good. I do have small request though. Please bear > with > me: > > - in patch #3, can you move the "QemuAcpiHandle = NULL" assignment right > above the gBS->InstallProtocolInterface() call? > > - and in patch #5 (i.e

Re: [edk2-devel] [PATCH V2 5/6] OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol

2023-01-09 Thread Laszlo Ersek
Hi Min, On 1/9/23 14:59, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 install the QemuAcpiTableNotifyProtocol at a > wrong positioin. It should be called before TransferS3ContextToBootScript > because TransferS3ContextToBootS

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-09 Thread Michael D Kinney
Acked-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin > Sent: Monday, January 9, 2023 7:03 PM > To: Clark-williams, Zachary ; > devel@edk2.groups.io > Cc: Zachary Clark-Williams ; Maciej Rabeda > ; Otcheretianski, Andrei > > Subject

Re: [edk2-devel] [PATCH V2 4/6] OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables

2023-01-09 Thread Laszlo Ersek
On 1/9/23 14:59, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > Commit 9fdc70af6ba8 wrongly removed the log from InstallQemuFwCfgTables > after ACPI tables are successfully installed. This patch add the log > back after all operations succeed. > >

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-09 Thread Rebecca Cran
You might still be using the Metronome driver from EmbeddedPkg instead of MdeModulePkg. That will for example cause gBS->Stall to take much longer than it should. -- Rebecca Cran On 1/8/23 03:41, tinhnguyen via groups.io wrote: Hi RichardHo, This driver has interested me. I've ported your dr

Re: [edk2-devel] [PATCH V2 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c

2023-01-09 Thread Laszlo Ersek
On 1/9/23 14:59, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > The handle of mQemuAcpiHandle is not needed for anything, beyond the > scope of the InstallQemuFwCfgTables(). So a local variable will > suffice for storing the handle. > > Cc: Laszlo

Re: [edk2-devel] [PATCH V2 1/6] OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL

2023-01-09 Thread Laszlo Ersek
On 1/9/23 14:59, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 > > The QEMU_ACPI_TABLE_NOTIFY_PROTOCOL structure is superfluous because NULL > protocol interfaces have been used in edk2 repeatedly. A protocol instance > can exist in the protocol datab

Re: [edk2-devel] 回复: [edk2-devel] 回复: 回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

2023-01-09 Thread Prakash K via groups.io
Hi Gaoliming, Pull Request #3656 has been closed without merging the changes. Link -> https://github.com/tianocore/edk2/pull/3656 ( https://github.com/tianocore/edk2/pull/3656 ) May I know the reason for closing the pull request ? Should I create another pull request ? Thanks, Prakash K -=-=-

Re: [edk2-devel] MinPlatformPkg question

2023-01-09 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Garret, Thanks for bringing this discussion. We agree with this and want (also help) to see the common modules in this package were moved out of MinPlatform, as AMD server platform also leverage it. Regards, Abner From: Kirkendall, Garrett Sent: Tuesday, J

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-09 Thread Wu, Jiaxin
One comment as below, Others good to me. Reviewed-by: Wu Jiaxin > + @param[in, out] WcmProfile WiFi Connection Manager profile > structure > + @param[in, out] MacAddress MAC address from AMT saved to NiC > MAC address > + > + @retval EFI_SUCCESS Stored WiFi profi

Re: [edk2-devel] [PATCH] UefiPayloadPkg/DebugPrintErrorLevelLibHob

2023-01-09 Thread Ning Feng
Hi, @Lu, James will you please check if the code change make sense then merge the pr? I have already fix the commit message, and create the PR. UefiPayloadPkg: Fix debug print error level hob not save correct by NingFengGit · Pull Request #3868 · tianocore/edk2 (githu

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, January 10, 2023 #cal-reminder

2023-01-09 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, January 10, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-

[edk2-devel] [edk2-platforms][PATCH V2 7/7] Platform/Loongson: Enable zero address protection.

2023-01-09 Thread xianglai
Set the 0 page property to unreadable, non-writable, non-executable Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- .../LoongArchQemuPkg/Library/MmuLib/MmuBaseLibPei.inf | 2 ++ .../Loongson/LoongArchQemuP

[edk2-devel] [edk2-platforms][PATCH V2 5/7] Platform/Loongson: Optimize page table entry null determination.

2023-01-09 Thread xianglai
Modify the null judgment condition of page table entries. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Library/MmuLib/page.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

[edk2-devel] [edk2-platforms][PATCH V2 6/7] Platform/Loongson: Optimize the huge page and page entry conversion.

2023-01-09 Thread xianglai
Optimize the process of converting huge pages to page table entries. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- .../Library/MmuLib/MmuLibCore.c | 109 +- .../LoongArchQemuPk

[edk2-devel] [edk2-platforms][PATCH V2 4/7] Platform/Loongson: Modify the page table entry access priority.

2023-01-09 Thread xianglai
Modify the page table entry access priority When the Page table properties are set. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Library/MmuLib/MmuLibCore.c | 2 +- 1 fil

[edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/Loongson: Support pflash for loongarch.

2023-01-09 Thread xianglai
Add pflash driver for loongarch. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: xianglai li --- .../Library/NorFlashQemuLib/NorFlashQemuLib.c | 141 ++ .../NorFlashQemuLib/NorFlashQemuLib.inf | 43

[edk2-devel] [edk2-platforms][PATCH V2 2/7] Platform/Loongson:add nvme device driver for loongarch.

2023-01-09 Thread xianglai
From: Bibo Mao add nvme device driver support loongarch qemu virt machine. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Bibo Mao Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/Loongson.dsc | 5 +

[edk2-devel] [edk2-platforms][PATCH V2 1/7] Platform/Loongson: add bootmode support.

2023-01-09 Thread xianglai
From: Bibo Mao add bootmode support in PEI phase. Cc: Ard Biesheuvel Cc: Bibo Mao Cc: Chao Li Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Bibo Mao Signed-off-by: xianglai li --- Platform/Loongson/LoongArchQemuPkg/PlatformPei/Platform.c | 5 + 1 file changed,

[edk2-devel] [edk2-platforms][PATCH V2 0/7] loongarch add flash device.

2023-01-09 Thread xianglai
This is a patch series that contains: 1.loongarch add flash device driver. 2.loongarch add nvme device driver. 3.Optimize the mmu lib of loongarch. 4.Enable zero address protection. v2 changes: - Split the MMU lib-related patches further. - Remove the for loop of flash information lookup in Virt

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

2023-01-09 Thread Ni, Ray
UefiCpuPkg\Test\UnitTest\EfiMpServicesPpiProtocol\EfiMpServiceProtocolShellUnitTest.inf can be used to build the shell app. > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, January 10, 2023 1:13 AM > To: devel@edk2.groups.io; quic_rc...@quicinc.com > Cc: Ni, Ray ; Kun Qin ; Sa

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, January 9, 2023 #cal-notice

2023-01-09 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, January 9, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650234 ) *Description:* TianoCore commu

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

2023-01-09 Thread Isaac Oram
I think that there shouldn’t be any difficulty to build QemuOpenBoardPkg and most of the Platforms/Intel packages (Simics and Purley are “special” and should be considered a waste of time at this time). I know how stuart works but I assume at some point it is capable of running normal edk2 buil

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiTables: Fix EFI_ACPI_GPE0_BLK_LEN calculation

2023-01-09 Thread Isaac Oram
Pushed as a57865b571..3e0f5b21c9 -Original Message- From: Chiu, Chasel Sent: Wednesday, January 4, 2023 7:09 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Ponnusamy, Suresh Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoar

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

2023-01-09 Thread dann frazier
On Thu, Jan 05, 2023 at 05:25:28PM +0100, Ard Biesheuvel wrote: > The early ID map used by ArmVirtQemu uses ASID scoped non-global > mappings, as this allows us to switch to the permanent ID map seamlessly > without the need for explicit TLB maintenance. > > However, this triggers a known erratum

[edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI

2023-01-09 Thread Isaac Oram
Fix some build issues with GCC5 targets Add a Readme.md for AdvancedFeaturePkg Add VS2019, CLANGPDB, and GCC5 build targets to Readme.md for each feature Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Dandan Bi Signed-off-by: Isaac Oram --- .../AdvancedFeaturePkg/Advanc

[edk2-devel] [PATCH V2 2/2] OvmfPkg/CcExitLib: Refactor TDX MmioExit

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169 The previous TDX MmioExit doesn't handle the Mmio instructions correctly in some scenarios. This patch refactors the implementation to fix the issues. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann

[edk2-devel] [PATCH V2 1/2] OvmfPkg/CcExitLib: Move common X86 instruction code to separate file

2023-01-09 Thread Min Xu
From: Min M Xu https://bugzilla.tianocore.org/show_bug.cgi?id=4169 Move common X86 instruction codes from CcExitVcHandler.c to separate files (CcInstruction.h / CcInstruction.c) so that these codes can be re-used in TDX. Cc: Gerd Hoffmann Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao C

[edk2-devel] [PATCH V2 0/2] [PATCH V1 0/2] Refactor TDX MmioExit

2023-01-09 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4169 The previous TDX MmioExit doesn't handle the Mmio instructions correctly in some scenarios. This patch-set refactors the implementation to fix the issues. Before the refactoring, common X86 instruction codes in CcExitVcHandler.c are moved to

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-09 Thread Michael Brown
On 08/01/2023 10:41, tinhnguyen via groups.io wrote: The root cause is that we spend a long time waiting for USB UsbBulkTransfer to complete, but if there is no data to communicate -> it will always time out. Coincidentally, I have just implemented a fix for this. It works by implementing a

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-09 Thread tinhnguyen via groups.io
Hi RichardHo, This driver has interested me. I've ported your driver to tinh_ampere_edk2 ( https://github.com/tinhnampere/edk2/tree/support_usbnet ) and tinh_ampere_edk2_platform ( https://github.com/tinhnampere/edk2-platforms/tree/support_usbnet ). I'm having the same issue with our USB CDC EC

[edk2-devel] It told me to send you this..

2023-01-09 Thread MAAYAN
[image: image.png] -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98204): https://edk2.groups.io/g/devel/message/98204 Mute This Topic: https://groups.io/mt/96166305/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, January 9, 2023 #cal-reminder

2023-01-09 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, January 9, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1650234 ) *Description:* Tiano

Re: [edk2-devel] [PATCH 0/4] Revert the series of the patches which put APs in

2023-01-09 Thread Ard Biesheuvel
On Mon, 9 Jan 2023 at 09:15, Laszlo Ersek wrote: > > On 1/9/23 04:37, Yuanhao Xie wrote: > > This series of original patches requiring revert, redo and further cleanup. > > > > 4GB limitation of memory allocation will be kept for the case APs > > still need to be transferred to 32-bit mode before

Re: [edk2-devel] [PATCH] NetworkPkg: Add WiFi profile sync protocol support

2023-01-09 Thread Clark-williams, Zachary
Hey Jiaxin, Please rind my updated patch below. Let me know when you get this reviewed so I can get it merged as soon as possible. Thank you, Zack -Original Message- From: Clark-williams, Zachary Sent: Friday, January 6, 2023 5:31 PM To: devel@edk2.groups.io Cc: Zachary Clark-William

[edk2-devel] MinPlatformPkg question

2023-01-09 Thread Kirkendall, Garrett via groups.io
[AMD Official Use Only - General] Start the conversation: Some time back there were posts about promoting MinPlatformPkg up to a more generic level. Is there still a desire to implement this and possibly even to promote this more generic MinPlatformPkg to the edk2 repository. Would it be expa

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

2023-01-09 Thread Ard Biesheuvel
On Mon, 9 Jan 2023 at 15:25, Rebecca Cran wrote: > > Thanks, I hadn't seen that. Unless people want the additional control > this application provides via the command-line options, I can drop this > patch. > > -- > Rebecca Cran > > On 1/8/23 18:32, Ni, Ray wrote: > > Rebecca, > > Have you reviewed

[edk2-devel] [PATCH 1/1 v3] EmulatorPkg: fixes for NetBSD compilation

2023-01-09 Thread tlaronde
EmulatorPkg: fixes for NetBSD compilation. Note: generated against today (2023-01-09) master. v3: - Macro __NetBSD__ used instead of lower level _NETBSD_SOURCE; - The required fd value (-1) for mmap(3) under *BSD is given as is with a comment indicating why this particular value for MAP_ANON; -

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

2023-01-09 Thread Sami Mujawar
Hi Morit, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/01/2023 04:42 pm, Moritz Fischer wrote: Linux's cpu DT bindings call out arm,armv8 while the code previously used arm,arm-v8, add second entry to support the arm,arm-v8 c

[edk2-devel] [PATCH v2] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

2023-01-09 Thread Moritz Fischer via groups.io
Linux's cpu DT bindings call out arm,armv8 while the code previously used arm,arm-v8, add second entry to support the arm,arm-v8 case. Cc: Sami Mujawar Fixes: e366a41ef0 ("DynamicTablesPkg: FdtHwInfoParser: Add GICC parser") Signed-off-by: Moritz Fischer --- DynamicTablesPkg/Library/FdtHwInfoPa

Re: [edk2-devel] [PATCH 0/4] BaseTools - various cleanups

2023-01-09 Thread Ard Biesheuvel
On Thu, 5 Jan 2023 at 17:05, Ard Biesheuvel wrote: > > Some cleanups for the tools_def template, mostly related to ARM but with > some CLANG38 and RISCV changes as well. > Bob, Liming: any concerns regarding this series? > Ard Biesheuvel (4): > BaseTools/tools_def RISCV: Make OpenSBI referenc

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/XhciPei: Unlinked XhciPei memory block

2023-01-09 Thread He, Jiangang via groups.io
[AMD Official Use Only - General] Hi Hao, Yes UsbHcUnlinkMemBlock() call should be uncommented. -- for (Block = Pool->Head->Next; Block != NULL; Block = Pool->Head->Next) { UsbHcUnlinkMemBlock (Pool->Head, Block); UsbHcFreeMemBlock (Pool, Block); } -

Re: [edk2-devel] [PATCH v4 3/3] MdeModulePkg: Add new Application/MpServicesTest application

2023-01-09 Thread Rebecca Cran
Thanks, I hadn't seen that. Unless people want the additional control this application provides via the command-line options, I can drop this patch. -- Rebecca Cran On 1/8/23 18:32, Ni, Ray wrote: Rebecca, Have you reviewed UefiCpuPkg\Test\UnitTest\EfiMpServicesPpiProtocol? It's based on Uni

[edk2-devel] [edk2-staging][PATCH 2/3] RedfishPkg: Update Redfish DSC

2023-01-09 Thread Chang, Abner via groups.io
From: Abner Chang Update Redfish DSC for PlatformHostInterfaceBmcUsbNicLib. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc index 161

[edk2-devel] [edk2-staging][PATCH 1/3] RedfishPkg/Library: Redfish BMC USBNIC Host Interface

2023-01-09 Thread Chang, Abner via groups.io
From: Abner Chang BMC exposed USB NIC platform Redfish Host Interface library implementation. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 44 + .../PlatformHostInterfaceBmcUsbNicLib.h | 83 ++ .../PlatformHostI

[edk2-devel] [edk2-staging][PATCH 0/3] BMC USBNIC Platform HI Lib

2023-01-09 Thread Chang, Abner via groups.io
From: Abner Chang BZ #: 4282 Implement the platform Redfish host interface library that uses IPMI commands to get the network information of BMC-exposed USB NIC for building up the SMBIOS type 42 record. The prerequisites: BZ #4213, 4214 and 4231 Signed-off-by: Abner Chang Cc: Michael D Kinney

[edk2-devel] [PATCH V2 3/6] OvmfPkg/AcpiPlatformDxe: Use local variable in QemuFwCfgAcpi.c

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The handle of mQemuAcpiHandle is not needed for anything, beyond the scope of the InstallQemuFwCfgTables(). So a local variable will suffice for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottomley Cc:

[edk2-devel] [PATCH V2 2/6] OvmfPkg/AcpiPlatformDxe: Use local variable in CloudHvAcpi.c

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The handle of mChAcpiHandle is not needed for anything, beyond the scope of the InstallCloudHvTablesTdx (). A local variable (ChAcpiHandle) suffices for storing the handle. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bottom

[edk2-devel] [PATCH V2 5/6] OvmfPkg/AcpiPlatformDxe: Refactor QemuAcpiTableNotifyProtocol

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 install the QemuAcpiTableNotifyProtocol at a wrong positioin. It should be called before TransferS3ContextToBootScript because TransferS3ContextToBootScript is the last operation in InstallQemuFwCfgTables(

[edk2-devel] [PATCH V2 6/6] OvmfPkg/AcpiPlatformDxe: Return error if installing NotifyProtocol failed

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Installation of gQemuAcpiTableNotifyProtocol may fail. The error code should be returned so that the caller can handle it. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc: Sebast

[edk2-devel] [PATCH V2 4/6] OvmfPkg/AcpiPlatformDxe: Add log to show the installed tables

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 wrongly removed the log from InstallQemuFwCfgTables after ACPI tables are successfully installed. This patch add the log back after all operations succeed. Cc: Laszlo Ersek Cc: Erdem Aktas Cc: James Bot

[edk2-devel] [PATCH V2 0/6] Refactor installation of gQemuAcpiTableNotifyProtocol

2023-01-09 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 Commit 9fdc70af6ba8 breaks log analysis and code cohesion in AcpiPlatformDxe. See the detailed information in BZ#4237. This patch-set contains below patches to fix above issues. #1: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL and delete Qemu

[edk2-devel] [PATCH V2 1/6] OvmfPkg/AcpiPlatformDxe: Remove QEMU_ACPI_TABLE_NOTIFY_PROTOCOL

2023-01-09 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 The QEMU_ACPI_TABLE_NOTIFY_PROTOCOL structure is superfluous because NULL protocol interfaces have been used in edk2 repeatedly. A protocol instance can exist in the protocol database with a NULL associated interface. Therefo

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

2023-01-09 Thread PierreGondois
Hello, I was wondering if I should re-arrange the patch in any way/there was any concern with the patch set. The first patch of serie was taken, but the other ones are pending, Regards, Pierre On 11/28/22 14:34, PierreGondois via groups.io wrote: Hello Ard, On 11/26/22 15:33, Ard Biesheuvel wr

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation

2023-01-09 Thread Laszlo Ersek
On 1/9/23 11:15, Gerd Hoffmann wrote: >>> + @param[out] MaxAddress If MaxAddress is not NULL, then MaxAddress holds >>> + the highest exclusive >=4GB RAM address on >>> output. >>> + If QEMU's fw_cfg E820 RAM map contains no RAM >>> entry >>> +

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation

2023-01-09 Thread Gerd Hoffmann
> > + @param[out] MaxAddress If MaxAddress is not NULL, then MaxAddress holds > > + the highest exclusive >=4GB RAM address on > > output. > > + If QEMU's fw_cfg E820 RAM map contains no RAM > > entry > > + that starts o

Re: [edk2-devel] [PATCH 0/1] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-09 Thread Oliver Steffen
On Thu, Jan 5, 2023 at 4:19 PM Oliver Steffen wrote: > Quoting Laszlo Ersek (2023-01-05 16:12:36) > > On 1/5/23 14:52, Gerd Hoffmann wrote: > > > On Thu, Jan 05, 2023 at 02:43:32PM +0100, Oliver Steffen wrote: > > >> Quoting Gerd Hoffmann (2023-01-05 14:12:22) > > >>> Not sure this is an option.

Re: [edk2-devel] [PATCH] DynamicTablesPkg: FdtHwInfoParserLib: Fix compatible string

2023-01-09 Thread Sami Mujawar
Hi Moritz, Please see my response inline marked [SAMI]. Regards, Sami Mujawar On 08/01/2023, 04:08, "Moritz Fischer" wrote: Sami, On Fri, Jan 6, 2023 at 1:55 AM Sami Mujawar wrote: > > Hi Ard, Mortiz, > > Please find my response inline marked [SAMI]. > > Reg

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion

2023-01-09 Thread Min Xu
Hi, Laszlo I do appreciate the detailed and accurate explanation of how AcpiPlatformDxe downloads ACPI tables from QEMU and then install them. I will submit a new patch-set soon. Thanks Min > -Original Message- > From: Laszlo Ersek > Sent: Thursday, January 5, 2023 5:09 PM > To: devel@

Re: [edk2-devel] [PATCH 0/4] Revert the series of the patches which put APs in

2023-01-09 Thread Laszlo Ersek
On 1/9/23 04:37, Yuanhao Xie wrote: > This series of original patches requiring revert, redo and further cleanup. > > 4GB limitation of memory allocation will be kept for the case APs > still need to be transferred to 32-bit mode before handoff to the OS. > > Stack offset for AsmRelocateApLoopSt

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram documentation

2023-01-09 Thread Laszlo Ersek
On 1/6/23 15:04, Gerd Hoffmann wrote: > Documentation of PlatformScanOrAdd64BitE820Ram() ran out of sync > with the implementation. Fix that. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletio