Re: [edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

2023-01-20 Thread Min Xu
On January 20, 2023 9:51 PM, Gerd Hoffmann wrote: > > > > > [Jiewen] No. We cannot move to MdePkg. > > > > TCG defines the field to be variable length. Something like below: > > > > > > > > typedef struct { > > > > UINT8 TableDescriptionSize; > > > > UINT8

[edk2-devel] [PATCH v1 4/4] SecurityPkg: don't require PK to be self-signed by default

2023-01-20 Thread Jan Bobek via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2506 Change the default value of PcdRequireSelfSignedPk to FALSE in accordance with UEFI spec, which states that PK need not be self-signed when enrolling in setup mode. Note that this relaxes the legacy behavior, which required the PK to be sel

[edk2-devel] [PATCH v1 1/4] SecurityPkg: limit verification of enrolled PK in setup mode

2023-01-20 Thread Jan Bobek via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2506 Per UEFI spec, enrolling a new PK in setup mode should not require a self-signature. Introduce a feature PCD called PcdRequireSelfSignedPk to control this requirement. Default to TRUE in order to preserve the legacy behavior. Cc: Jiewen Yao

[edk2-devel] [PATCH v1 2/4] OvmfPkg: require self-signed PK when secure boot is enabled

2023-01-20 Thread Jan Bobek via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2506 In all DSC files that define SECURE_BOOT_ENABLE, opt-in into requiring self-signed PK when SECURE_BOOT_ENABLE is TRUE. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan Cc: Sebasti

[edk2-devel] [PATCH v1 3/4] ArmVirtPkg: require self-signed PK when secure boot is enabled

2023-01-20 Thread Jan Bobek via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2506 In all DSC files that define SECURE_BOOT_ENABLE, opt-in into requiring self-signed PK when SECURE_BOOT_ENABLE is TRUE. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Jan Bobek --- ArmVirtPkg/Arm

[edk2-devel] [PATCH v1 0/4] Don't require self-signed PK in setup mode

2023-01-20 Thread Jan Bobek via groups.io
Hi all, I'm sending out v1 of my patch series that addresses a UEFI spec non-compliance when enrolling PK in setup mode. Additional info can be found in bugzilla [1]; the changes are split into 4 patches as suggested by Laszlo Ersek in comment #4. I've based my work on the patch by Matthew Carlso

Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support

2023-01-20 Thread Rebecca Cran
Hi Richard, I've continued working on my USB EEM support, and just pushed my changes to https://github.com/bcran/edk2/tree/usb-net . I was wondering when you think you might have the next set of patches ready for review? Thanks. Rebecca Cran On 1/12/23 01:36, RichardHo [何明忠] via groups

Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file

2023-01-20 Thread Rebecca Cran
Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? Also perhaps a .editorconfig file? -- Rebecca Cran On 1/20/23 13:51, Michael Kubacki wrote: From: Michael Kubacki Tianocore maintains container images in the tianocore/co

Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs

2023-01-20 Thread Michael D Kinney
Merged. PR: https://github.com/tianocore/edk2/pull/3938 Commit: https://github.com/tianocore/edk2/commit/7afef31b2b17d1a8d5248eb562352c6d3505ea14 I do not recall the meaning of LaffStd. My best guess is that it is Latin Fixed Font Standard. Mike > -Original Message- > From: Jan Engel

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg: Export default shell delay as PCD

2023-01-20 Thread Michael D Kinney
Merged PR: https://github.com/tianocore/edk2/pull/3937 Commit: https://github.com/tianocore/edk2/commit/e96a5734f6b1b1d38a60d9ecf77a453ae2fc8303 Mike > -Original Message- > From: Kinney, Michael D > Sent: Friday, January 20, 2023 7:56 AM > To: devel@edk2.groups.io; quic_tpi...@quicinc

Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs

2023-01-20 Thread Jan Engelhardt
On Friday 2023-01-20 16:57, Michael D Kinney wrote: > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Jan Engelhardt >> Sent: Saturday, January 7, 2023 7:16 AM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd >>

Re: [edk2-devel] Documentation errors

2023-01-20 Thread tlaro...@polynum.com
Woa! That was fast... Thanks! Le Fri, Jan 20, 2023 at 03:52:13PM +, Michael D Kinney a écrit : > Thank you for noticing this issue with the description of the DEC spec on the > wiki page. > > I have fixed it. > > In general, issues with the specs and the wiki page can be entered as BZ, but

Re: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd glyphs

2023-01-20 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Jan Engelhardt > Sent: Saturday, January 7, 2023 7:16 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] MdeModulePkg: remove garbage pixels in LaffStd > glyphs > > Signed-off-

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg: Export default shell delay as PCD

2023-01-20 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tomas Pilar > (tpilar) > Sent: Tuesday, January 3, 2023 9:02 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [edk2-devel] [PATCH v3 1/1] ShellPkg: Export default she

Re: [edk2-devel] Documentation errors

2023-01-20 Thread Michael D Kinney
Thank you for noticing this issue with the description of the DEC spec on the wiki page. I have fixed it. In general, issues with the specs and the wiki page can be entered as BZ, but this was a simple issue that could be resolved immediately. Thanks, Mike > -Original Message- > From

[edk2-devel] [PATCH v4 5/6] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

2023-01-20 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds initial defination for AMD's SmmCpuFeaturesLib library implementation. All function's body either empty or just returns value. Its initial skeleton of library implementation. Cc: Paul Grimes Cc: Garrett Kirke

[edk2-devel] [PATCH v4 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2023-01-20 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from SMM.

[edk2-devel] [PATCH v4 4/6] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

2023-01-20 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Garrett Kirkendall

[edk2-devel] [PATCH v4 3/6] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

2023-01-20 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements SmmSmramSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Latee

[edk2-devel] [PATCH v4 2/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

2023-01-20 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v4 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family

2023-01-20 Thread Abdul Lateef Attar via groups.io
V4 delta changes: rebase to master branch. added reviewed-by. V3 delta changes: Addressed review comments from Abner chang. Re-arranged patch order. PR: https://github.com/tianocore/edk2/pull/3936 Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rah

[edk2-devel] [PATCH v4 1/6] MdePkg: Adds AMD SMRAM save state map

2023-01-20 Thread Abdul Lateef Attar via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds an SMM SMRAM save-state map for AMD processors. SMRAM save state maps for the AMD processor family are now supported. Save state map structure is added based on AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2. The AMD le

Re: [edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-20 Thread Laszlo Ersek
On 1/20/23 10:54, Ard Biesheuvel wrote: > On Fri, 20 Jan 2023 at 10:25, Laszlo Ersek wrote: >> >> On 1/19/23 14:43, Ard Biesheuvel wrote: >>> QEMU for x86 has a nasty CPU hotplug bug of which the ramifications are >>> difficult to oversee, even though KVM acceleration seems to be >>> unaffected. T

[edk2-devel] Documentation errors

2023-01-20 Thread tlaronde
Context: I continue to explore the EDK II in order to allow NetBSD to be a more direct OS host for compilation and testing. Starting to review the documentation for building (low level: Build), I have spotted this: In: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Documentation i

Re: [edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

2023-01-20 Thread Gerd Hoffmann
> > > [Jiewen] No. We cannot move to MdePkg. > > > TCG defines the field to be variable length. Something like below: > > > > > > typedef struct { > > > UINT8 TableDescriptionSize; > > > UINT8 TableDescription[TableDescriptionSize]; > > > UINT64

Re: [edk2-devel] [PATCH v3 0/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Laszlo Ersek
On 1/19/23 12:01, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: cpuhp-reg-catch-4250-v3 > Test build: https://github.com/tianocore/edk2/pull/3930 > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4250 > > v2 was posted at: > - 20230112082845.128463-1-

Re: [edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-20 Thread Laszlo Ersek
On 1/19/23 14:43, Ard Biesheuvel wrote: > QEMU for x86 has a nasty CPU hotplug bug of which the ramifications are > difficult to oversee, even though KVM acceleration seems to be > unaffected. This has been addressed in QEMU mainline, and will percolate > through the ecosystem at its usual pace. In

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Laszlo Ersek
On 1/20/23 10:10, Ard Biesheuvel wrote: > On Fri, 20 Jan 2023 at 09:50, Laszlo Ersek wrote: >> >> a couple of requests to Oliver below: >> >> On 1/19/23 12:27, Ard Biesheuvel wrote: >>> On Thu, 19 Jan 2023 at 12:01, Laszlo Ersek wrote: In QEMU v5.1.0, the CPU hotplug register block misb

Re: [edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

2023-01-20 Thread Min Xu
On January 20, 2023 6:18 PM, Gerd Hoffmann wrote: > On Fri, Jan 20, 2023 at 08:10:45AM +, Yao, Jiewen wrote: > > > Can we define FV_HANDOFF_TABLE_POINTERS2 and > FV_HANDOFF_TABLE_POINTERS2 in > MdePkg/Include/IndustryStandard/UefiTcgPlatform.h? > > > > [Jiewen] No. We cannot move to MdePkg. > >

Re: [edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

2023-01-20 Thread Gerd Hoffmann
On Fri, Jan 20, 2023 at 08:10:45AM +, Yao, Jiewen wrote: > > Can we define FV_HANDOFF_TABLE_POINTERS2 and FV_HANDOFF_TABLE_POINTERS2 in > > MdePkg/Include/IndustryStandard/UefiTcgPlatform.h? > > [Jiewen] No. We cannot move to MdePkg. > TCG defines the field to be variable length. Something li

Re: [edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-20 Thread Ard Biesheuvel
On Fri, 20 Jan 2023 at 10:25, Laszlo Ersek wrote: > > On 1/19/23 14:43, Ard Biesheuvel wrote: > > QEMU for x86 has a nasty CPU hotplug bug of which the ramifications are > > difficult to oversee, even though KVM acceleration seems to be > > unaffected. This has been addressed in QEMU mainline, and

Re: [edk2-devel] [RFC PATCH] OvmfPkg/PlatformCI VS2019: Enable temporary workaround for cpuhp bugfix

2023-01-20 Thread Laszlo Ersek
On 1/19/23 14:43, Ard Biesheuvel wrote: > QEMU for x86 has a nasty CPU hotplug bug of which the ramifications are > difficult to oversee, even though KVM acceleration seems to be > unaffected. This has been addressed in QEMU mainline, and will percolate > through the ecosystem at its usual pace. In

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Laszlo Ersek
On 1/20/23 10:17, Laszlo Ersek wrote: > On 1/20/23 09:50, Laszlo Ersek wrote: > >> Oliver: >> >> (1) can you please post a patch for the Windows CI so that the >> following option be passed to QEMU: >> >> -fw_cfg name=opt/org.tianocore/X-Cpuhp-Bugcheck-Override,string=yes >> >> (This option is h

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Laszlo Ersek
On 1/20/23 09:50, Laszlo Ersek wrote: > Oliver: > > (1) can you please post a patch for the Windows CI so that the > following option be passed to QEMU: > > -fw_cfg name=opt/org.tianocore/X-Cpuhp-Bugcheck-Override,string=yes > > (This option is harmless when the firmware does not determine the Q

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Ard Biesheuvel
On Fri, 20 Jan 2023 at 09:50, Laszlo Ersek wrote: > > a couple of requests to Oliver below: > > On 1/19/23 12:27, Ard Biesheuvel wrote: > > On Thu, 19 Jan 2023 at 12:01, Laszlo Ersek wrote: > >> > >> In QEMU v5.1.0, the CPU hotplug register block misbehaves: the negotiation > >> protocol is (effe

Re: [edk2-devel] [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

2023-01-20 Thread Laszlo Ersek
a couple of requests to Oliver below: On 1/19/23 12:27, Ard Biesheuvel wrote: > On Thu, 19 Jan 2023 at 12:01, Laszlo Ersek wrote: >> >> In QEMU v5.1.0, the CPU hotplug register block misbehaves: the negotiation >> protocol is (effectively) broken such that it suggests that switching from >> the l

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

2023-01-20 Thread Laszlo Ersek
On 1/18/23 16:06, Ni, Ray wrote: > #pragma pack(1) > typedef struct { > UINT32CpuIndex; > UINT32NumberOfCpus; // align to > EFI_SEC_PLATFORM_INFORMATION_RECORD2.NumberOfCpus > UINT64SmBase[]; > } SMM_BASE_HOB_DATA; > #pragma pack() > > For system with less than 8K CPUs, one HO

Re: [edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

2023-01-20 Thread Yao, Jiewen
> Can we define FV_HANDOFF_TABLE_POINTERS2 and FV_HANDOFF_TABLE_POINTERS2 in > MdePkg/Include/IndustryStandard/UefiTcgPlatform.h? [Jiewen] No. We cannot move to MdePkg. TCG defines the field to be variable length. Something like below: typedef struct { UINT8 TableDescripti